From: Jason Gunthorpe <jgg@ziepe.ca>
To: John Hubbard <jhubbard@nvidia.com>
Cc: "Andrew Morton" <akpm@linux-foundation.org>,
"Al Viro" <viro@zeniv.linux.org.uk>,
"Alex Williamson" <alex.williamson@redhat.com>,
"Benjamin Herrenschmidt" <benh@kernel.crashing.org>,
"Björn Töpel" <bjorn.topel@intel.com>,
"Christoph Hellwig" <hch@infradead.org>,
"Dan Williams" <dan.j.williams@intel.com>,
"Daniel Vetter" <daniel@ffwll.ch>,
"Dave Chinner" <david@fromorbit.com>,
"David Airlie" <airlied@linux.ie>,
"David S . Miller" <davem@davemloft.net>,
"Ira Weiny" <ira.weiny@intel.com>, "Jan Kara" <jack@suse.cz>,
"Jens Axboe" <axboe@kernel.dk>,
"Jonathan Corbet" <corbet@lwn.net>,
"Jérôme Glisse" <jglisse@redhat.com>,
"Magnus Karlsson" <magnus.karlsson@intel.com>,
"Mauro Carvalho Chehab" <mchehab@kernel.org>,
"Michael Ellerman" <mpe@ellerman.id.au>,
"Michal Hocko" <mhocko@suse.com>,
"Mike Kravetz" <mike.kravetz@oracle.com>,
"Paul Mackerras" <paulus@samba.org>,
"Shuah Khan" <shuah@kernel.org>,
"Vlastimil Babka" <vbabka@suse.cz>,
bpf@vger.kernel.org, dri-devel@lists.freedesktop.org,
kvm@vger.kernel.org, linux-block@vger.kernel.org,
linux-doc@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-kselftest@vger.kernel.org, linux-media@vger.kernel.org,
linux-rdma@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
netdev@vger.kernel.org, linux-mm@kvack.org,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v5 12/24] IB/{core,hw,umem}: set FOLL_PIN via pin_user_pages*(), fix up ODP
Date: Fri, 15 Nov 2019 10:09:27 -0400 [thread overview]
Message-ID: <20191115140927.GB4055@ziepe.ca> (raw)
In-Reply-To: <20191115055340.1825745-13-jhubbard@nvidia.com>
On Thu, Nov 14, 2019 at 09:53:28PM -0800, John Hubbard wrote:
> Convert infiniband to use the new pin_user_pages*() calls.
>
> Also, revert earlier changes to Infiniband ODP that had it using
> put_user_page(). ODP is "Case 3" in
> Documentation/core-api/pin_user_pages.rst, which is to say, normal
> get_user_pages() and put_page() is the API to use there.
>
> The new pin_user_pages*() calls replace corresponding get_user_pages*()
> calls, and set the FOLL_PIN flag. The FOLL_PIN flag requires that the
> caller must return the pages via put_user_page*() calls, but infiniband
> was already doing that as part of an earlier commit.
>
> Signed-off-by: John Hubbard <jhubbard@nvidia.com>
> ---
> drivers/infiniband/core/umem.c | 2 +-
> drivers/infiniband/core/umem_odp.c | 13 ++++++-------
> drivers/infiniband/hw/hfi1/user_pages.c | 2 +-
> drivers/infiniband/hw/mthca/mthca_memfree.c | 2 +-
> drivers/infiniband/hw/qib/qib_user_pages.c | 2 +-
> drivers/infiniband/hw/qib/qib_user_sdma.c | 2 +-
> drivers/infiniband/hw/usnic/usnic_uiom.c | 2 +-
> drivers/infiniband/sw/siw/siw_mem.c | 2 +-
> 8 files changed, 13 insertions(+), 14 deletions(-)
Ok
Reviewed-by: Jason Gunthorpe <jgg@mellanox.com>
Jason
WARNING: multiple messages have this Message-ID (diff)
From: Jason Gunthorpe <jgg@ziepe.ca>
To: John Hubbard <jhubbard@nvidia.com>
Cc: "Michal Hocko" <mhocko@suse.com>, "Jan Kara" <jack@suse.cz>,
kvm@vger.kernel.org, linux-doc@vger.kernel.org,
"David Airlie" <airlied@linux.ie>,
"Dave Chinner" <david@fromorbit.com>,
dri-devel@lists.freedesktop.org,
LKML <linux-kernel@vger.kernel.org>,
linux-mm@kvack.org, "Paul Mackerras" <paulus@samba.org>,
linux-kselftest@vger.kernel.org,
"Ira Weiny" <ira.weiny@intel.com>,
"Jonathan Corbet" <corbet@lwn.net>,
linux-rdma@vger.kernel.org,
"Christoph Hellwig" <hch@infradead.org>,
"Vlastimil Babka" <vbabka@suse.cz>,
"Björn Töpel" <bjorn.topel@intel.com>,
linux-media@vger.kernel.org, "Shuah Khan" <shuah@kernel.org>,
linux-block@vger.kernel.org, "Jérôme Glisse" <jglisse@redhat.com>,
"Al Viro" <viro@zeniv.linux.org.uk>,
"Dan Williams" <dan.j.williams@intel.com>,
"Mauro Carvalho Chehab" <mchehab@kernel.org>,
bpf@vger.kernel.org,
"Magnus Karlsson" <magnus.karlsson@intel.com>,
"Jens Axboe" <axboe@kernel.dk>,
netdev@vger.kernel.org,
"Alex Williamson" <alex.williamson@redhat.com>,
"Daniel Vetter" <daniel@ffwll.ch>,
linux-fsdevel@vger.kernel.org,
"Andrew Morton" <akpm@linux-foundation.org>,
linuxppc-dev@lists.ozlabs.org,
"David S . Miller" <davem@davemloft.net>,
"Mike Kravetz" <mike.kravetz@oracle.com>
Subject: Re: [PATCH v5 12/24] IB/{core,hw,umem}: set FOLL_PIN via pin_user_pages*(), fix up ODP
Date: Fri, 15 Nov 2019 10:09:27 -0400 [thread overview]
Message-ID: <20191115140927.GB4055@ziepe.ca> (raw)
In-Reply-To: <20191115055340.1825745-13-jhubbard@nvidia.com>
On Thu, Nov 14, 2019 at 09:53:28PM -0800, John Hubbard wrote:
> Convert infiniband to use the new pin_user_pages*() calls.
>
> Also, revert earlier changes to Infiniband ODP that had it using
> put_user_page(). ODP is "Case 3" in
> Documentation/core-api/pin_user_pages.rst, which is to say, normal
> get_user_pages() and put_page() is the API to use there.
>
> The new pin_user_pages*() calls replace corresponding get_user_pages*()
> calls, and set the FOLL_PIN flag. The FOLL_PIN flag requires that the
> caller must return the pages via put_user_page*() calls, but infiniband
> was already doing that as part of an earlier commit.
>
> Signed-off-by: John Hubbard <jhubbard@nvidia.com>
> ---
> drivers/infiniband/core/umem.c | 2 +-
> drivers/infiniband/core/umem_odp.c | 13 ++++++-------
> drivers/infiniband/hw/hfi1/user_pages.c | 2 +-
> drivers/infiniband/hw/mthca/mthca_memfree.c | 2 +-
> drivers/infiniband/hw/qib/qib_user_pages.c | 2 +-
> drivers/infiniband/hw/qib/qib_user_sdma.c | 2 +-
> drivers/infiniband/hw/usnic/usnic_uiom.c | 2 +-
> drivers/infiniband/sw/siw/siw_mem.c | 2 +-
> 8 files changed, 13 insertions(+), 14 deletions(-)
Ok
Reviewed-by: Jason Gunthorpe <jgg@mellanox.com>
Jason
WARNING: multiple messages have this Message-ID (diff)
From: Jason Gunthorpe <jgg@ziepe.ca>
To: John Hubbard <jhubbard@nvidia.com>
Cc: "Andrew Morton" <akpm@linux-foundation.org>,
"Al Viro" <viro@zeniv.linux.org.uk>,
"Alex Williamson" <alex.williamson@redhat.com>,
"Benjamin Herrenschmidt" <benh@kernel.crashing.org>,
"Björn Töpel" <bjorn.topel@intel.com>,
"Christoph Hellwig" <hch@infradead.org>,
"Dan Williams" <dan.j.williams@intel.com>,
"Daniel Vetter" <daniel@ffwll.ch>,
"Dave Chinner" <david@fromorbit.com>,
"David Airlie" <airlied@linux.ie>,
"David S . Miller" <davem@davemloft.net>,
"Ira Weiny" <ira.weiny@intel.com>, "Jan Kara" <jack@suse.cz>,
"Jens Axboe" <axboe@kernel.dk>,
"Jonathan Corbet" <corbet@lwn.net>,
"Jérôme Glisse" <jglisse@redhat.com>,
"Magnus Karlsson" <magnus.karlsson@intel.com>,
"Mauro Carvalho Chehab" <mchehab@kernel.org>,
"Michael Ellerman" <mpe@ellerman.id.au>
Subject: Re: [PATCH v5 12/24] IB/{core,hw,umem}: set FOLL_PIN via pin_user_pages*(), fix up ODP
Date: Fri, 15 Nov 2019 10:09:27 -0400 [thread overview]
Message-ID: <20191115140927.GB4055@ziepe.ca> (raw)
In-Reply-To: <20191115055340.1825745-13-jhubbard@nvidia.com>
On Thu, Nov 14, 2019 at 09:53:28PM -0800, John Hubbard wrote:
> Convert infiniband to use the new pin_user_pages*() calls.
>
> Also, revert earlier changes to Infiniband ODP that had it using
> put_user_page(). ODP is "Case 3" in
> Documentation/core-api/pin_user_pages.rst, which is to say, normal
> get_user_pages() and put_page() is the API to use there.
>
> The new pin_user_pages*() calls replace corresponding get_user_pages*()
> calls, and set the FOLL_PIN flag. The FOLL_PIN flag requires that the
> caller must return the pages via put_user_page*() calls, but infiniband
> was already doing that as part of an earlier commit.
>
> Signed-off-by: John Hubbard <jhubbard@nvidia.com>
> ---
> drivers/infiniband/core/umem.c | 2 +-
> drivers/infiniband/core/umem_odp.c | 13 ++++++-------
> drivers/infiniband/hw/hfi1/user_pages.c | 2 +-
> drivers/infiniband/hw/mthca/mthca_memfree.c | 2 +-
> drivers/infiniband/hw/qib/qib_user_pages.c | 2 +-
> drivers/infiniband/hw/qib/qib_user_sdma.c | 2 +-
> drivers/infiniband/hw/usnic/usnic_uiom.c | 2 +-
> drivers/infiniband/sw/siw/siw_mem.c | 2 +-
> 8 files changed, 13 insertions(+), 14 deletions(-)
Ok
Reviewed-by: Jason Gunthorpe <jgg@mellanox.com>
Jason
next prev parent reply other threads:[~2019-11-15 14:09 UTC|newest]
Thread overview: 154+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-15 5:53 [PATCH v5 00/24] mm/gup: track dma-pinned pages: FOLL_PIN John Hubbard
2019-11-15 5:53 ` John Hubbard
2019-11-15 5:53 ` John Hubbard
2019-11-15 5:53 ` John Hubbard
2019-11-15 5:53 ` [PATCH v5 01/24] mm/gup: pass flags arg to __gup_device_* functions John Hubbard
2019-11-15 5:53 ` John Hubbard
2019-11-15 5:53 ` John Hubbard
2019-11-15 5:53 ` John Hubbard
2019-11-15 5:53 ` [PATCH v5 02/24] mm/gup: factor out duplicate code from four routines John Hubbard
2019-11-15 5:53 ` John Hubbard
2019-11-15 5:53 ` John Hubbard
2019-11-15 5:53 ` John Hubbard
2019-11-18 9:46 ` Jan Kara
2019-11-18 9:46 ` Jan Kara
2019-11-18 9:46 ` Jan Kara
2019-11-18 9:46 ` Jan Kara
2019-11-19 7:00 ` John Hubbard
2019-11-19 7:00 ` John Hubbard
2019-11-19 7:00 ` John Hubbard
2019-11-19 7:00 ` John Hubbard
2019-11-15 5:53 ` [PATCH v5 03/24] mm/gup: move try_get_compound_head() to top, fix minor issues John Hubbard
2019-11-15 5:53 ` John Hubbard
2019-11-15 5:53 ` John Hubbard
2019-11-15 5:53 ` John Hubbard
2019-11-15 5:53 ` [PATCH v5 04/24] mm: Cleanup __put_devmap_managed_page() vs ->page_free() John Hubbard
2019-11-15 5:53 ` John Hubbard
2019-11-15 5:53 ` John Hubbard
2019-11-15 5:53 ` John Hubbard
2019-11-15 5:53 ` [PATCH v5 05/24] mm: devmap: refactor 1-based refcounting for ZONE_DEVICE pages John Hubbard
2019-11-15 5:53 ` John Hubbard
2019-11-15 5:53 ` John Hubbard
2019-11-15 5:53 ` John Hubbard
2019-11-15 5:53 ` [PATCH v5 06/24] goldish_pipe: rename local pin_user_pages() routine John Hubbard
2019-11-15 5:53 ` John Hubbard
2019-11-15 5:53 ` John Hubbard
2019-11-15 5:53 ` John Hubbard
2019-11-18 9:47 ` Jan Kara
2019-11-18 9:47 ` Jan Kara
2019-11-18 9:47 ` Jan Kara
2019-11-18 9:47 ` Jan Kara
2019-11-15 5:53 ` [PATCH v5 07/24] IB/umem: use get_user_pages_fast() to pin DMA pages John Hubbard
2019-11-15 5:53 ` John Hubbard
2019-11-15 5:53 ` John Hubbard
2019-11-15 5:53 ` John Hubbard
2019-11-18 9:49 ` Jan Kara
2019-11-18 9:49 ` Jan Kara
2019-11-18 9:49 ` Jan Kara
2019-11-18 9:49 ` Jan Kara
2019-11-15 5:53 ` [PATCH v5 08/24] media/v4l2-core: set pages dirty upon releasing DMA buffers John Hubbard
2019-11-15 5:53 ` John Hubbard
2019-11-15 5:53 ` John Hubbard
2019-11-15 5:53 ` John Hubbard
2019-11-15 5:53 ` [PATCH v5 09/24] vfio, mm: fix get_user_pages_remote() and FOLL_LONGTERM John Hubbard
2019-11-15 5:53 ` John Hubbard
2019-11-15 5:53 ` John Hubbard
2019-11-15 5:53 ` John Hubbard
2019-11-15 14:08 ` Jason Gunthorpe
2019-11-15 14:08 ` Jason Gunthorpe
2019-11-15 14:08 ` Jason Gunthorpe
2019-11-15 18:06 ` Ira Weiny
2019-11-15 18:06 ` Ira Weiny
2019-11-15 18:06 ` Ira Weiny
2019-11-15 18:06 ` Ira Weiny
2019-11-15 5:53 ` [PATCH v5 10/24] mm/gup: introduce pin_user_pages*() and FOLL_PIN John Hubbard
2019-11-15 5:53 ` John Hubbard
2019-11-15 5:53 ` John Hubbard
2019-11-15 5:53 ` John Hubbard
2019-11-18 10:16 ` Jan Kara
2019-11-18 10:16 ` Jan Kara
2019-11-18 10:16 ` Jan Kara
2019-11-18 10:16 ` Jan Kara
2019-11-19 5:17 ` John Hubbard
2019-11-19 5:17 ` John Hubbard
2019-11-19 5:17 ` John Hubbard
2019-11-19 5:17 ` John Hubbard
2019-11-15 5:53 ` [PATCH v5 11/24] goldish_pipe: convert to pin_user_pages() and put_user_page() John Hubbard
2019-11-15 5:53 ` John Hubbard
2019-11-15 5:53 ` John Hubbard
2019-11-15 5:53 ` John Hubbard
2019-11-18 10:16 ` Jan Kara
2019-11-18 10:16 ` Jan Kara
2019-11-18 10:16 ` Jan Kara
2019-11-18 10:16 ` Jan Kara
2019-11-15 5:53 ` [PATCH v5 12/24] IB/{core,hw,umem}: set FOLL_PIN via pin_user_pages*(), fix up ODP John Hubbard
2019-11-15 5:53 ` [PATCH v5 12/24] IB/{core, hw, umem}: " John Hubbard
2019-11-15 5:53 ` John Hubbard
2019-11-15 5:53 ` John Hubbard
2019-11-15 14:09 ` Jason Gunthorpe [this message]
2019-11-15 14:09 ` [PATCH v5 12/24] IB/{core,hw,umem}: " Jason Gunthorpe
2019-11-15 14:09 ` Jason Gunthorpe
2019-11-15 5:53 ` [PATCH v5 13/24] mm/process_vm_access: set FOLL_PIN via pin_user_pages_remote() John Hubbard
2019-11-15 5:53 ` John Hubbard
2019-11-15 5:53 ` John Hubbard
2019-11-15 5:53 ` John Hubbard
2019-11-18 10:30 ` Jan Kara
2019-11-18 10:30 ` Jan Kara
2019-11-18 10:30 ` Jan Kara
2019-11-18 10:30 ` Jan Kara
2019-11-15 5:53 ` [PATCH v5 14/24] drm/via: set FOLL_PIN via pin_user_pages_fast() John Hubbard
2019-11-15 5:53 ` John Hubbard
2019-11-15 5:53 ` John Hubbard
2019-11-15 5:53 ` John Hubbard
2019-11-15 5:53 ` [PATCH v5 15/24] fs/io_uring: set FOLL_PIN via pin_user_pages() John Hubbard
2019-11-15 5:53 ` John Hubbard
2019-11-15 5:53 ` John Hubbard
2019-11-15 5:53 ` John Hubbard
2019-11-18 10:34 ` Jan Kara
2019-11-18 10:34 ` Jan Kara
2019-11-18 10:34 ` Jan Kara
2019-11-18 10:34 ` Jan Kara
2019-11-15 5:53 ` [PATCH v5 16/24] net/xdp: " John Hubbard
2019-11-15 5:53 ` John Hubbard
2019-11-15 5:53 ` John Hubbard
2019-11-15 5:53 ` John Hubbard
2019-11-15 5:53 ` [PATCH v5 17/24] mm/gup: track FOLL_PIN pages John Hubbard
2019-11-15 5:53 ` John Hubbard
2019-11-15 5:53 ` John Hubbard
2019-11-15 5:53 ` John Hubbard
2019-11-18 11:58 ` Jan Kara
2019-11-18 11:58 ` Jan Kara
2019-11-18 11:58 ` Jan Kara
2019-11-18 11:58 ` Jan Kara
2019-11-19 0:22 ` John Hubbard
2019-11-19 0:22 ` John Hubbard
2019-11-19 0:22 ` John Hubbard
2019-11-19 0:22 ` John Hubbard
2019-11-15 5:53 ` [PATCH v5 18/24] media/v4l2-core: pin_user_pages (FOLL_PIN) and put_user_page() conversion John Hubbard
2019-11-15 5:53 ` John Hubbard
2019-11-15 5:53 ` John Hubbard
2019-11-15 5:53 ` John Hubbard
2019-11-15 5:53 ` [PATCH v5 19/24] vfio, mm: " John Hubbard
2019-11-15 5:53 ` John Hubbard
2019-11-15 5:53 ` John Hubbard
2019-11-15 5:53 ` John Hubbard
2019-11-15 5:53 ` [PATCH v5 20/24] powerpc: book3s64: convert to pin_user_pages() and put_user_page() John Hubbard
2019-11-15 5:53 ` John Hubbard
2019-11-15 5:53 ` John Hubbard
2019-11-15 5:53 ` John Hubbard
2019-11-15 5:53 ` [PATCH v5 21/24] mm/gup_benchmark: use proper FOLL_WRITE flags instead of hard-coding "1" John Hubbard
2019-11-15 5:53 ` John Hubbard
2019-11-15 5:53 ` John Hubbard
2019-11-15 5:53 ` John Hubbard
2019-11-15 5:53 ` [PATCH v5 22/24] mm/gup_benchmark: support pin_user_pages() and related calls John Hubbard
2019-11-15 5:53 ` John Hubbard
2019-11-15 5:53 ` John Hubbard
2019-11-15 5:53 ` John Hubbard
2019-11-15 5:53 ` [PATCH v5 23/24] selftests/vm: run_vmtests: invoke gup_benchmark with basic FOLL_PIN coverage John Hubbard
2019-11-15 5:53 ` John Hubbard
2019-11-15 5:53 ` John Hubbard
2019-11-15 5:53 ` John Hubbard
2019-11-15 5:53 ` [PATCH v5 24/24] mm, tree-wide: rename put_user_page*() to unpin_user_page*() John Hubbard
2019-11-15 5:53 ` John Hubbard
2019-11-15 5:53 ` John Hubbard
2019-11-15 5:53 ` John Hubbard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191115140927.GB4055@ziepe.ca \
--to=jgg@ziepe.ca \
--cc=airlied@linux.ie \
--cc=akpm@linux-foundation.org \
--cc=alex.williamson@redhat.com \
--cc=axboe@kernel.dk \
--cc=benh@kernel.crashing.org \
--cc=bjorn.topel@intel.com \
--cc=bpf@vger.kernel.org \
--cc=corbet@lwn.net \
--cc=dan.j.williams@intel.com \
--cc=daniel@ffwll.ch \
--cc=davem@davemloft.net \
--cc=david@fromorbit.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=hch@infradead.org \
--cc=ira.weiny@intel.com \
--cc=jack@suse.cz \
--cc=jglisse@redhat.com \
--cc=jhubbard@nvidia.com \
--cc=kvm@vger.kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-rdma@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=magnus.karlsson@intel.com \
--cc=mchehab@kernel.org \
--cc=mhocko@suse.com \
--cc=mike.kravetz@oracle.com \
--cc=mpe@ellerman.id.au \
--cc=netdev@vger.kernel.org \
--cc=paulus@samba.org \
--cc=shuah@kernel.org \
--cc=vbabka@suse.cz \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.