From: Dan Carpenter <dan.carpenter@oracle.com> To: Ravulapati Vishnu vardhan rao <Vishnuvardhanrao.Ravulapati@amd.com> Cc: Alexander.Deucher@amd.com, djkurtz@google.com, Akshu.Agrawal@amd.com, Liam Girdwood <lgirdwood@gmail.com>, Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>, "moderated list:SOUND - SOC LAYER / DYNAMIC AUDIO POWER MANAGEM..." <alsa-devel@alsa-project.org>, open list <linux-kernel@vger.kernel.org> Subject: Re: [PATCH v10 1/6] ASoC: amd:Create multiple I2S platform device endpoint Date: Tue, 19 Nov 2019 17:16:28 +0300 [thread overview] Message-ID: <20191119141628.GD30789@kadam> (raw) In-Reply-To: <1574172508-26546-2-git-send-email-Vishnuvardhanrao.Ravulapati@amd.com> On Tue, Nov 19, 2019 at 07:38:23PM +0530, Ravulapati Vishnu vardhan rao wrote: > @@ -56,10 +56,11 @@ static int snd_acp3x_probe(struct pci_dev *pci, > irqflags = 0; > > addr = pci_resource_start(pci, 0); > - adata->acp3x_base = ioremap(addr, pci_resource_len(pci, 0)); > + adata->acp3x_base = devm_ioremap(&pci->dev, addr, > + pci_resource_len(pci, 0)); > if (!adata->acp3x_base) { > ret = -ENOMEM; > - goto release_regions; > + goto disable_msi; This is a bug fix. :) > } > pci_set_master(pci); > pci_set_drvdata(pci, adata); This patch is fine. Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com> regards, dan carpenter
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com> To: Ravulapati Vishnu vardhan rao <Vishnuvardhanrao.Ravulapati@amd.com> Cc: "moderated list:SOUND - SOC LAYER / DYNAMIC AUDIO POWER MANAGEM..." <alsa-devel@alsa-project.org>, open list <linux-kernel@vger.kernel.org>, Takashi Iwai <tiwai@suse.com>, Liam Girdwood <lgirdwood@gmail.com>, Mark Brown <broonie@kernel.org>, djkurtz@google.com, Alexander.Deucher@amd.com, Akshu.Agrawal@amd.com Subject: Re: [alsa-devel] [PATCH v10 1/6] ASoC: amd:Create multiple I2S platform device endpoint Date: Tue, 19 Nov 2019 17:16:28 +0300 [thread overview] Message-ID: <20191119141628.GD30789@kadam> (raw) In-Reply-To: <1574172508-26546-2-git-send-email-Vishnuvardhanrao.Ravulapati@amd.com> On Tue, Nov 19, 2019 at 07:38:23PM +0530, Ravulapati Vishnu vardhan rao wrote: > @@ -56,10 +56,11 @@ static int snd_acp3x_probe(struct pci_dev *pci, > irqflags = 0; > > addr = pci_resource_start(pci, 0); > - adata->acp3x_base = ioremap(addr, pci_resource_len(pci, 0)); > + adata->acp3x_base = devm_ioremap(&pci->dev, addr, > + pci_resource_len(pci, 0)); > if (!adata->acp3x_base) { > ret = -ENOMEM; > - goto release_regions; > + goto disable_msi; This is a bug fix. :) > } > pci_set_master(pci); > pci_set_drvdata(pci, adata); This patch is fine. Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com> regards, dan carpenter _______________________________________________ Alsa-devel mailing list Alsa-devel@alsa-project.org https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
next prev parent reply other threads:[~2019-11-19 14:18 UTC|newest] Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top [not found] <1574172508-26546-1-git-send-email-Vishnuvardhanrao.Ravulapati@amd.com> 2019-11-19 14:08 ` [PATCH v10 1/6] ASoC: amd:Create multiple I2S platform device endpoint Ravulapati Vishnu vardhan rao 2019-11-19 14:08 ` [alsa-devel] " Ravulapati Vishnu vardhan rao 2019-11-19 14:16 ` Dan Carpenter [this message] 2019-11-19 14:16 ` Dan Carpenter 2019-11-19 14:08 ` [PATCH v10 2/6] ASoC: amd: Refactoring of DAI from DMA driver Ravulapati Vishnu vardhan rao 2019-11-19 14:08 ` [alsa-devel] " Ravulapati Vishnu vardhan rao 2019-11-19 14:08 ` [PATCH v10 3/6] ASoC: amd: Enabling I2S instance in DMA and DAI Ravulapati Vishnu vardhan rao 2019-11-19 14:08 ` [alsa-devel] " Ravulapati Vishnu vardhan rao 2019-11-19 14:08 ` [PATCH v10 4/6] ASoC: amd: add ACP3x TDM mode support Ravulapati Vishnu vardhan rao 2019-11-19 14:08 ` [alsa-devel] " Ravulapati Vishnu vardhan rao 2019-11-19 14:08 ` [PATCH v10 5/6] ASoC: amd: Handle ACP3x I2S-SP Interrupts Ravulapati Vishnu vardhan rao 2019-11-19 14:08 ` [alsa-devel] " Ravulapati Vishnu vardhan rao 2019-11-19 14:08 ` [PATCH v10 6/6] ASoC: amd: Added ACP3x system resume and runtime pm Ravulapati Vishnu vardhan rao 2019-11-19 14:08 ` [alsa-devel] " Ravulapati Vishnu vardhan rao 2019-11-19 14:28 ` Dan Carpenter 2019-11-19 14:28 ` [alsa-devel] " Dan Carpenter
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20191119141628.GD30789@kadam \ --to=dan.carpenter@oracle.com \ --cc=Akshu.Agrawal@amd.com \ --cc=Alexander.Deucher@amd.com \ --cc=Vishnuvardhanrao.Ravulapati@amd.com \ --cc=alsa-devel@alsa-project.org \ --cc=broonie@kernel.org \ --cc=djkurtz@google.com \ --cc=lgirdwood@gmail.com \ --cc=linux-kernel@vger.kernel.org \ --cc=perex@perex.cz \ --cc=tiwai@suse.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.