From: Daniel Vetter <daniel@ffwll.ch>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: dri-devel <dri-devel@lists.freedesktop.org>,
Thomas Zimmermann <tzimmermann@suse.de>
Subject: Re: [PATCH v2] drm/gem: Fix mmap fake offset handling for drm_gem_object_funcs.mmap
Date: Wed, 20 Nov 2019 11:39:13 +0100 [thread overview]
Message-ID: <20191120103913.GH30416@phenom.ffwll.local> (raw)
In-Reply-To: <20191120080532.hjjjddxrsikozlpq@sirius.home.kraxel.org>
On Wed, Nov 20, 2019 at 09:05:32AM +0100, Gerd Hoffmann wrote:
> Hi,
>
> > > I can see now why you want a private address space for each object.
> > > Does that imply we need an anon_inode for each gem object? Or is
> > > there some more lightweight way to do this?
> >
> > I have no idea whether we can get a address_space struct without an inode
> > (and no disasters).
>
> Anything building on shmem helpers should be able to use
> obj->filp->f_mapping, right? So allocating an inode unconditionally
> doesn't look like a good plan.
Not sure the shmem helpers forward the mmap to the underlying shmem file,
so not sure this is the greatest way either.
> Guess I'll go look at ttm-local changes for starters and see how it
> goes.
I think for ttm just consistently using the one per-device mapping for
everything, with all the fake offsets, is probably the quickest route.
Maybe also for for shmem helpers.
I'm kinda leaning towards that we just restore the fake offset everywhere,
and document how it works. Until someone comes up with a really bright
idea.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2019-11-20 10:39 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-24 19:18 [PATCH v2] drm/gem: Fix mmap fake offset handling for drm_gem_object_funcs.mmap Rob Herring
2019-10-25 5:34 ` Gerd Hoffmann
2019-10-25 7:30 ` Daniel Vetter
2019-11-08 16:27 ` Daniel Vetter
2019-11-08 16:55 ` Daniel Vetter
2019-11-12 8:52 ` Gerd Hoffmann
2019-11-12 9:35 ` Daniel Vetter
2019-11-12 15:37 ` Rob Herring
2019-11-12 19:06 ` Daniel Vetter
2019-11-12 21:31 ` Rob Herring
2019-11-12 22:14 ` Daniel Vetter
2019-11-13 7:53 ` Gerd Hoffmann
2019-11-12 9:26 ` Thomas Zimmermann
2019-11-12 9:32 ` Daniel Vetter
2019-11-12 9:49 ` Thomas Zimmermann
2019-11-12 10:38 ` Gerd Hoffmann
2019-11-12 14:44 ` Daniel Vetter
2019-11-13 7:39 ` Gerd Hoffmann
2019-11-13 8:17 ` Daniel Vetter
2019-11-13 13:51 ` Gerd Hoffmann
2019-11-13 16:27 ` Daniel Vetter
2019-11-15 9:37 ` Gerd Hoffmann
2019-11-15 10:18 ` Daniel Vetter
2019-11-15 10:56 ` Gerd Hoffmann
2019-11-15 15:31 ` Daniel Vetter
2019-11-18 10:40 ` Gerd Hoffmann
2019-11-18 16:49 ` Daniel Vetter
2019-11-20 8:05 ` Gerd Hoffmann
2019-11-20 10:39 ` Daniel Vetter [this message]
2019-11-20 11:40 ` Gerd Hoffmann
2019-11-20 12:04 ` Daniel Vetter
2019-11-20 12:18 ` Gerd Hoffmann
2019-11-20 12:34 ` Daniel Vetter
2019-11-20 13:08 ` Gerd Hoffmann
2019-11-20 13:40 ` Daniel Vetter
2019-11-21 8:10 ` Gerd Hoffmann
2019-11-21 8:47 ` Daniel Vetter
2019-11-21 8:02 ` Gerd Hoffmann
2019-11-21 8:49 ` Daniel Vetter
2019-11-21 10:18 ` Gerd Hoffmann
2019-11-21 10:36 ` Daniel Vetter
2019-11-13 13:53 ` Rob Herring
2019-11-13 16:28 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191120103913.GH30416@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=kraxel@redhat.com \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.