From: Daniel Vetter <daniel@ffwll.ch>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: Thomas Zimmermann <tzimmermann@suse.de>,
dri-devel <dri-devel@lists.freedesktop.org>
Subject: Re: [PATCH v2] drm/gem: Fix mmap fake offset handling for drm_gem_object_funcs.mmap
Date: Thu, 21 Nov 2019 11:36:04 +0100 [thread overview]
Message-ID: <CAKMK7uG3gXWW_exta9=SLY_OhMTAZoGF9U_MkJ60co7s-MiCsQ@mail.gmail.com> (raw)
In-Reply-To: <20191121101823.2774x3htreifdjqf@sirius.home.kraxel.org>
On Thu, Nov 21, 2019 at 11:18 AM Gerd Hoffmann <kraxel@redhat.com> wrote:
>
> On Thu, Nov 21, 2019 at 09:49:53AM +0100, Daniel Vetter wrote:
> > On Thu, Nov 21, 2019 at 09:02:59AM +0100, Gerd Hoffmann wrote:
> > > Hi,
> > >
> > > > > update-object-after-move works fine.
> > > > >
> > > > > try zap mappings with madvise(dontneed) has no bad effects (after vram
> > > > > move, trying to force re-creating the ptes).
> > > >
> > > > Well if it's broken the zapping wouldn't work :-)
> > > >
> > > > > didn't try the memory pressure thing yet.
> > > >
> > > > I'm surprised ... and I have no idea how/why it keeps working.
> > > >
> > > > For my paranoia, can you instrument the ttm page fault handler, and double
> > > > check that we get new faults after the move, and set up new ptes for the
> > > > same old mapping, but now pointing at the new place in vram?
> > >
> > > Hmm, only the drm device mapping is faulted in after moving it,
> > > the dma-buf mapping is not. Fixed by:
> >
> > Ah yes, that's more what I'd expect to happen, and the below is what I'd
> > expect to fix things up. I think we should move it up ahead of the device
> > callback (so that drivers can overwrite) and then push as a fix. Separate
> > from a possible patch to undo the fake offset removal.
> > -Daniel
>
> Is there a more elegant way than copying the intel list on non-intel
> patches to kick intel ci?
Nope, not really.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2019-11-21 10:36 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-24 19:18 [PATCH v2] drm/gem: Fix mmap fake offset handling for drm_gem_object_funcs.mmap Rob Herring
2019-10-25 5:34 ` Gerd Hoffmann
2019-10-25 7:30 ` Daniel Vetter
2019-11-08 16:27 ` Daniel Vetter
2019-11-08 16:55 ` Daniel Vetter
2019-11-12 8:52 ` Gerd Hoffmann
2019-11-12 9:35 ` Daniel Vetter
2019-11-12 15:37 ` Rob Herring
2019-11-12 19:06 ` Daniel Vetter
2019-11-12 21:31 ` Rob Herring
2019-11-12 22:14 ` Daniel Vetter
2019-11-13 7:53 ` Gerd Hoffmann
2019-11-12 9:26 ` Thomas Zimmermann
2019-11-12 9:32 ` Daniel Vetter
2019-11-12 9:49 ` Thomas Zimmermann
2019-11-12 10:38 ` Gerd Hoffmann
2019-11-12 14:44 ` Daniel Vetter
2019-11-13 7:39 ` Gerd Hoffmann
2019-11-13 8:17 ` Daniel Vetter
2019-11-13 13:51 ` Gerd Hoffmann
2019-11-13 16:27 ` Daniel Vetter
2019-11-15 9:37 ` Gerd Hoffmann
2019-11-15 10:18 ` Daniel Vetter
2019-11-15 10:56 ` Gerd Hoffmann
2019-11-15 15:31 ` Daniel Vetter
2019-11-18 10:40 ` Gerd Hoffmann
2019-11-18 16:49 ` Daniel Vetter
2019-11-20 8:05 ` Gerd Hoffmann
2019-11-20 10:39 ` Daniel Vetter
2019-11-20 11:40 ` Gerd Hoffmann
2019-11-20 12:04 ` Daniel Vetter
2019-11-20 12:18 ` Gerd Hoffmann
2019-11-20 12:34 ` Daniel Vetter
2019-11-20 13:08 ` Gerd Hoffmann
2019-11-20 13:40 ` Daniel Vetter
2019-11-21 8:10 ` Gerd Hoffmann
2019-11-21 8:47 ` Daniel Vetter
2019-11-21 8:02 ` Gerd Hoffmann
2019-11-21 8:49 ` Daniel Vetter
2019-11-21 10:18 ` Gerd Hoffmann
2019-11-21 10:36 ` Daniel Vetter [this message]
2019-11-13 13:53 ` Rob Herring
2019-11-13 16:28 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAKMK7uG3gXWW_exta9=SLY_OhMTAZoGF9U_MkJ60co7s-MiCsQ@mail.gmail.com' \
--to=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=kraxel@redhat.com \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.