From: Bibby Hsieh <bibby.hsieh@mediatek.com>
To: Matthias Brugger <matthias.bgg@gmail.com>,
Rob Herring <robh+dt@kernel.org>, CK HU <ck.hu@mediatek.com>
Cc: <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-mediatek@lists.infradead.org>,
<srv_heupstream@mediatek.com>,
Nicolas Boichat <drinkcat@chromium.org>,
Dennis-YC Hsieh <dennis-yc.hsieh@mediatek.com>,
Bibby Hsieh <bibby.hsieh@mediatek.com>
Subject: [PATCH v17 1/6] soc: mediatek: cmdq: fixup wrong input order of write api
Date: Thu, 21 Nov 2019 09:54:05 +0800 [thread overview]
Message-ID: <20191121015410.18852-2-bibby.hsieh@mediatek.com> (raw)
In-Reply-To: <20191121015410.18852-1-bibby.hsieh@mediatek.com>
Fixup a issue was caused by the previous fixup patch.
Fixes: 1a92f989126e ("soc: mediatek: cmdq: reorder the parameter")
Signed-off-by: Bibby Hsieh <bibby.hsieh@mediatek.com>
---
drivers/soc/mediatek/mtk-cmdq-helper.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/soc/mediatek/mtk-cmdq-helper.c b/drivers/soc/mediatek/mtk-cmdq-helper.c
index 7aa0517ff2f3..3c82de5f9417 100644
--- a/drivers/soc/mediatek/mtk-cmdq-helper.c
+++ b/drivers/soc/mediatek/mtk-cmdq-helper.c
@@ -155,7 +155,7 @@ int cmdq_pkt_write_mask(struct cmdq_pkt *pkt, u8 subsys,
err = cmdq_pkt_append_command(pkt, CMDQ_CODE_MASK, 0, ~mask);
offset_mask |= CMDQ_WRITE_ENABLE_MASK;
}
- err |= cmdq_pkt_write(pkt, value, subsys, offset_mask);
+ err |= cmdq_pkt_write(pkt, subsys, offset_mask, value);
return err;
}
--
2.18.0
WARNING: multiple messages have this Message-ID (diff)
From: Bibby Hsieh <bibby.hsieh@mediatek.com>
To: Matthias Brugger <matthias.bgg@gmail.com>,
Rob Herring <robh+dt@kernel.org>, CK HU <ck.hu@mediatek.com>
Cc: devicetree@vger.kernel.org,
Nicolas Boichat <drinkcat@chromium.org>,
srv_heupstream@mediatek.com, linux-kernel@vger.kernel.org,
Dennis-YC Hsieh <dennis-yc.hsieh@mediatek.com>,
linux-mediatek@lists.infradead.org,
Bibby Hsieh <bibby.hsieh@mediatek.com>,
linux-arm-kernel@lists.infradead.org
Subject: [PATCH v17 1/6] soc: mediatek: cmdq: fixup wrong input order of write api
Date: Thu, 21 Nov 2019 09:54:05 +0800 [thread overview]
Message-ID: <20191121015410.18852-2-bibby.hsieh@mediatek.com> (raw)
In-Reply-To: <20191121015410.18852-1-bibby.hsieh@mediatek.com>
Fixup a issue was caused by the previous fixup patch.
Fixes: 1a92f989126e ("soc: mediatek: cmdq: reorder the parameter")
Signed-off-by: Bibby Hsieh <bibby.hsieh@mediatek.com>
---
drivers/soc/mediatek/mtk-cmdq-helper.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/soc/mediatek/mtk-cmdq-helper.c b/drivers/soc/mediatek/mtk-cmdq-helper.c
index 7aa0517ff2f3..3c82de5f9417 100644
--- a/drivers/soc/mediatek/mtk-cmdq-helper.c
+++ b/drivers/soc/mediatek/mtk-cmdq-helper.c
@@ -155,7 +155,7 @@ int cmdq_pkt_write_mask(struct cmdq_pkt *pkt, u8 subsys,
err = cmdq_pkt_append_command(pkt, CMDQ_CODE_MASK, 0, ~mask);
offset_mask |= CMDQ_WRITE_ENABLE_MASK;
}
- err |= cmdq_pkt_write(pkt, value, subsys, offset_mask);
+ err |= cmdq_pkt_write(pkt, subsys, offset_mask, value);
return err;
}
--
2.18.0
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
WARNING: multiple messages have this Message-ID (diff)
From: Bibby Hsieh <bibby.hsieh@mediatek.com>
To: Matthias Brugger <matthias.bgg@gmail.com>,
Rob Herring <robh+dt@kernel.org>, CK HU <ck.hu@mediatek.com>
Cc: devicetree@vger.kernel.org,
Nicolas Boichat <drinkcat@chromium.org>,
srv_heupstream@mediatek.com, linux-kernel@vger.kernel.org,
Dennis-YC Hsieh <dennis-yc.hsieh@mediatek.com>,
linux-mediatek@lists.infradead.org,
Bibby Hsieh <bibby.hsieh@mediatek.com>,
linux-arm-kernel@lists.infradead.org
Subject: [PATCH v17 1/6] soc: mediatek: cmdq: fixup wrong input order of write api
Date: Thu, 21 Nov 2019 09:54:05 +0800 [thread overview]
Message-ID: <20191121015410.18852-2-bibby.hsieh@mediatek.com> (raw)
In-Reply-To: <20191121015410.18852-1-bibby.hsieh@mediatek.com>
Fixup a issue was caused by the previous fixup patch.
Fixes: 1a92f989126e ("soc: mediatek: cmdq: reorder the parameter")
Signed-off-by: Bibby Hsieh <bibby.hsieh@mediatek.com>
---
drivers/soc/mediatek/mtk-cmdq-helper.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/soc/mediatek/mtk-cmdq-helper.c b/drivers/soc/mediatek/mtk-cmdq-helper.c
index 7aa0517ff2f3..3c82de5f9417 100644
--- a/drivers/soc/mediatek/mtk-cmdq-helper.c
+++ b/drivers/soc/mediatek/mtk-cmdq-helper.c
@@ -155,7 +155,7 @@ int cmdq_pkt_write_mask(struct cmdq_pkt *pkt, u8 subsys,
err = cmdq_pkt_append_command(pkt, CMDQ_CODE_MASK, 0, ~mask);
offset_mask |= CMDQ_WRITE_ENABLE_MASK;
}
- err |= cmdq_pkt_write(pkt, value, subsys, offset_mask);
+ err |= cmdq_pkt_write(pkt, subsys, offset_mask, value);
return err;
}
--
2.18.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-11-21 1:54 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-21 1:54 [PATCH v17 0/6] support gce on mt8183 platform Bibby Hsieh
2019-11-21 1:54 ` Bibby Hsieh
2019-11-21 1:54 ` Bibby Hsieh
2019-11-21 1:54 ` Bibby Hsieh [this message]
2019-11-21 1:54 ` [PATCH v17 1/6] soc: mediatek: cmdq: fixup wrong input order of write api Bibby Hsieh
2019-11-21 1:54 ` Bibby Hsieh
2019-11-22 8:05 ` CK Hu
2019-11-22 8:05 ` CK Hu
2019-11-22 8:05 ` CK Hu
2019-11-21 1:54 ` [PATCH v17 2/6] soc: mediatek: cmdq: remove OR opertaion from err return Bibby Hsieh
2019-11-21 1:54 ` Bibby Hsieh
2019-11-21 1:54 ` Bibby Hsieh
2019-12-11 18:26 ` Matthias Brugger
2019-12-11 18:26 ` Matthias Brugger
2019-12-11 18:26 ` Matthias Brugger
2019-11-21 1:54 ` [PATCH v17 3/6] soc: mediatek: cmdq: define the instruction struct Bibby Hsieh
2019-11-21 1:54 ` Bibby Hsieh
2019-11-21 1:54 ` Bibby Hsieh
2019-11-22 8:30 ` CK Hu
2019-11-22 8:30 ` CK Hu
2019-11-22 8:30 ` CK Hu
2019-12-11 18:39 ` Matthias Brugger
2019-12-11 18:39 ` Matthias Brugger
2019-12-11 18:39 ` Matthias Brugger
2019-11-21 1:54 ` [PATCH v17 4/6] soc: mediatek: cmdq: add polling function Bibby Hsieh
2019-11-21 1:54 ` Bibby Hsieh
2019-11-21 1:54 ` Bibby Hsieh
2019-11-22 8:36 ` CK Hu
2019-11-22 8:36 ` CK Hu
2019-11-22 8:36 ` CK Hu
2019-12-14 21:45 ` Matthias Brugger
2019-12-14 21:45 ` Matthias Brugger
2019-12-14 21:45 ` Matthias Brugger
2019-11-21 1:54 ` [PATCH v17 5/6] soc: mediatek: cmdq: add cmdq_dev_get_client_reg function Bibby Hsieh
2019-11-21 1:54 ` Bibby Hsieh
2019-11-21 1:54 ` Bibby Hsieh
2019-12-14 21:57 ` Matthias Brugger
2019-12-14 21:57 ` Matthias Brugger
2019-12-14 21:57 ` Matthias Brugger
2019-11-21 1:54 ` [PATCH v17 6/6] arm64: dts: add gce node for mt8183 Bibby Hsieh
2019-11-21 1:54 ` Bibby Hsieh
2019-11-21 1:54 ` Bibby Hsieh
2019-12-11 18:56 ` Matthias Brugger
2019-12-11 18:56 ` Matthias Brugger
2019-12-11 18:56 ` Matthias Brugger
2019-12-11 22:09 ` [PATCH v17 0/6] support gce on mt8183 platform Nicolas Boichat
2019-12-11 22:09 ` Nicolas Boichat
2019-12-11 22:09 ` Nicolas Boichat
2019-12-12 7:49 ` Matthias Brugger
2019-12-12 7:49 ` Matthias Brugger
2019-12-12 7:49 ` Matthias Brugger
2019-12-12 9:47 ` Bibby Hsieh
2019-12-12 9:47 ` Bibby Hsieh
2019-12-12 9:47 ` Bibby Hsieh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191121015410.18852-2-bibby.hsieh@mediatek.com \
--to=bibby.hsieh@mediatek.com \
--cc=ck.hu@mediatek.com \
--cc=dennis-yc.hsieh@mediatek.com \
--cc=devicetree@vger.kernel.org \
--cc=drinkcat@chromium.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=robh+dt@kernel.org \
--cc=srv_heupstream@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.