Re: [PATCH v3] msm:disp:dpu1: add support for display for SC7180 target

From: Rob Herring <robh@kernel.org>
To: Kalyan Thota <kalyan_t@codeaurora.org>
Cc: dri-devel@lists.freedesktop.org, linux-arm-msm@vger.kernel.org,
	freedreno@lists.freedesktop.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, robdclark@gmail.com,
	seanpaul@chromium.org, hoegsberg@chromium.org,
	dhar@codeaurora.org, jsanka@codeaurora.org,
	chandanu@codeaurora.org, travitej@codeaurora.org,
	nganji@codeaurora.org
Subject: Re: [PATCH v3] msm:disp:dpu1: add support for display for SC7180 target
Date: Fri, 22 Nov 2019 18:44:36 -0600	[thread overview]
Message-ID: <20191123004436.GA18110@bogus> (raw)
In-Reply-To: <1574252368-4645-1-git-send-email-kalyan_t@codeaurora.org>

On Wed, Nov 20, 2019 at 05:49:28PM +0530, Kalyan Thota wrote:
> Add display hw catalog changes for SC7180 target.
> 
> Changes in v1:
>  - Configure register offsets and capabilities for the
>    display hw blocks.
> 
> Changes in v2:
>  - mdss_irq data type has changed in the dependent
>    patch, accommodate the necessary changes.
>  - Add co-developed-by tags in the commit msg (Stephen Boyd).
> 
> Changes in v3:
>  - fix kernel checkpatch errors in v2

But not the one telling you to split bindings to separate patch?

> 
> This patch has dependency on the below series
> 
> https://patchwork.kernel.org/patch/11253647/
> 
> Co-developed-by: Shubhashree Dhar <dhar@codeaurora.org>
> Signed-off-by: Shubhashree Dhar <dhar@codeaurora.org>
> Co-developed-by: Raviteja Tamatam <travitej@codeaurora.org>
> Signed-off-by: Raviteja Tamatam <travitej@codeaurora.org>
> Signed-off-by: Kalyan Thota <kalyan_t@codeaurora.org>
> ---
>  .../devicetree/bindings/display/msm/dpu.txt        |   4 +-

Acked-by: Rob Herring <robh@kernel.org>

>  drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c     | 189 +++++++++++++++++++--
>  drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.h     |   4 +
>  drivers/gpu/drm/msm/disp/dpu1/dpu_hw_lm.c          |   3 +-
>  drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c            |   1 +
>  drivers/gpu/drm/msm/msm_drv.c                      |   4 +-
>  6 files changed, 190 insertions(+), 15 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/display/msm/dpu.txt b/Documentation/devicetree/bindings/display/msm/dpu.txt
> index a61dd40..512f022 100644
> --- a/Documentation/devicetree/bindings/display/msm/dpu.txt
> +++ b/Documentation/devicetree/bindings/display/msm/dpu.txt
> @@ -8,7 +8,7 @@ The DPU display controller is found in SDM845 SoC.
>  
>  MDSS:
>  Required properties:
> -- compatible: "qcom,sdm845-mdss"
> +- compatible: "qcom,sdm845-mdss", "qcom,sc7180-mdss"
>  - reg: physical base address and length of contoller's registers.
>  - reg-names: register region names. The following region is required:
>    * "mdss"
> @@ -41,7 +41,7 @@ Optional properties:
>  
>  MDP:
>  Required properties:
> -- compatible: "qcom,sdm845-dpu"
> +- compatible: "qcom,sdm845-dpu", "qcom,sc7180-dpu"
>  - reg: physical base address and length of controller's registers.
>  - reg-names : register region names. The following region is required:
>    * "mdp"