Re: [PATCH v2 4/4] ARM: dts: phycore-imx6: set buck regulator modes explicitly

From: Shawn Guo <shawnguo@kernel.org>
To: Christoph Fritz <chf.fritz@googlemail.com>
Cc: Adam Thomson <Adam.Thomson.Opensource@diasemi.com>,
	Mark Brown <broonie@kernel.org>,
	Fabio Estevam <festevam@gmail.com>,
	Rob Herring <robh+dt@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Lee Jones <lee.jones@linaro.org>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Support Opensource <Support.Opensource@diasemi.com>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v2 4/4] ARM: dts: phycore-imx6: set buck regulator modes explicitly
Date: Wed, 4 Dec 2019 20:53:37 +0800	[thread overview]
Message-ID: <20191204125336.GM3365@dragon> (raw)
In-Reply-To: <1574973044.2362.11.camel@googlemail.com>

On Thu, Nov 28, 2019 at 09:30:44PM +0100, Christoph Fritz wrote:
> Hi Shawn,
> 
>  any chance to get this patch queued for the upcoming kernel?

Sorry, no.  I need to wait for DA9063_BUCK_MODE_SYNC landing on 5.5-rc1,
and then apply this DTS patch.

Shawn

> 
> bye
>  -- Christoph
> 
> On Wed, 2019-11-13 at 16:26 +0000, Adam Thomson wrote:
> > On 13 November 2019 13:40, Christoph Fritz wrote:
> > 
> > > This patch sets initial buck regulator modes explicitly to a state this
> > > hardware needs. So a wrong initial mode set by bootloader or pmic itself
> > > does not interfere anymore.
> > > 
> > > Signed-off-by: Christoph Fritz <chf.fritz@googlemail.com>
> > 
> > Reviewed-by: Adam Thomson <Adam.Thomson.Opensource@diasemi.com>
> > 
> > > ---
> > >  arch/arm/boot/dts/imx6qdl-phytec-phycore-som.dtsi | 5 +++++
> > >  1 file changed, 5 insertions(+)
> > > 
> > > diff --git a/arch/arm/boot/dts/imx6qdl-phytec-phycore-som.dtsi
> > > b/arch/arm/boot/dts/imx6qdl-phytec-phycore-som.dtsi
> > > index 6486df3..644625d 100644
> > > --- a/arch/arm/boot/dts/imx6qdl-phytec-phycore-som.dtsi
> > > +++ b/arch/arm/boot/dts/imx6qdl-phytec-phycore-som.dtsi
> > > @@ -5,6 +5,7 @@
> > >   */
> > > 
> > >  #include <dt-bindings/gpio/gpio.h>
> > > +#include <dt-bindings/regulator/dlg,da9063-regulator.h>
> > > 
> > >  / {
> > >  	aliases {
> > > @@ -109,6 +110,7 @@
> > >  				regulator-name = "vdd_arm";
> > >  				regulator-min-microvolt = <730000>;
> > >  				regulator-max-microvolt = <1380000>;
> > > +				regulator-initial-mode =
> > > <DA9063_BUCK_MODE_SYNC>;
> > >  				regulator-always-on;
> > >  			};
> > > 
> > > @@ -116,6 +118,7 @@
> > >  				regulator-name = "vdd_soc";
> > >  				regulator-min-microvolt = <730000>;
> > >  				regulator-max-microvolt = <1380000>;
> > > +				regulator-initial-mode =
> > > <DA9063_BUCK_MODE_SYNC>;
> > >  				regulator-always-on;
> > >  			};
> > > 
> > > @@ -123,6 +126,7 @@
> > >  				regulator-name = "vdd_ddr3";
> > >  				regulator-min-microvolt = <1500000>;
> > >  				regulator-max-microvolt = <1500000>;
> > > +				regulator-initial-mode =
> > > <DA9063_BUCK_MODE_SYNC>;
> > >  				regulator-always-on;
> > >  			};
> > > 
> > > @@ -130,6 +134,7 @@
> > >  				regulator-name = "vdd_eth";
> > >  				regulator-min-microvolt = <1200000>;
> > >  				regulator-max-microvolt = <1200000>;
> > > +				regulator-initial-mode =
> > > <DA9063_BUCK_MODE_SYNC>;
> > >  				regulator-always-on;
> > >  			};
> > > 
> > > --
> > > 2.1.4
> > 
> 
> 
> 