From: Miquel Raynal <miquel.raynal@bootlin.com>
To: "Heiko Stübner" <heiko@sntech.de>
Cc: linux-rockchip@lists.infradead.org,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] arm64: dts: rockchip: Move xin32k fixed-clock out of PX30 DTSI
Date: Wed, 4 Dec 2019 18:36:46 +0100 [thread overview]
Message-ID: <20191204183646.2f7f6e7f@xps13> (raw)
In-Reply-To: <2665233.YyXs6BPQ7y@diego>
Hi Heiko,
Heiko Stübner <heiko@sntech.de> wrote on Wed, 04 Dec 2019 18:31:46
+0100:
> Hi Miquel,
>
> Am Mittwoch, 4. Dezember 2019, 18:15:37 CET schrieb Miquel Raynal:
> > This clock has nothing to do in the PX30 DTSI as it is supposed to be
> > an input of the SoC. Moving it to the EVB DTS (only board file using
> > this DTSI) makes more sense. Also, when this clock is not a fixed
> > clock and comes from eg. a PMIC the situation can be described cleanly
> > in the device tree (avoids having to delete the fixed-clock node
> > first).
> >
> > This clock is not mandatory to boot so it should not break existing
> > users.
> >
> > Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
>
> Sorry foo being the bearer of bad news again, but that issue got already
> fixed by:
He he, no problem :) I was not actually looking at the right branch
(v5.5-armsoc/dts64).
> arm64: dts: rockchip: remove static xin32k from px30
> https://git.kernel.org/pub/scm/linux/kernel/git/mmind/linux-rockchip.git/commit/?h=v5.5-armsoc/dts64&id=00519137f7d4fc19ff27f3d3f4fc45b5b222ae82
>
> arm64: dts: rockchip: fix the px30-evb power tree
> https://git.kernel.org/pub/scm/linux/kernel/git/mmind/linux-rockchip.git/commit/?h=v5.5-armsoc/dts64&id=915b6a8b54a6d436885a458867e59fb20fc6356d
>
>
> On most/all Rockchip the xin32k clock is actually provided by the boards
> pmic - the rk809 in this case.
Thanks for the confirmation!
Miquèl
WARNING: multiple messages have this Message-ID (diff)
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: "Heiko Stübner" <heiko@sntech.de>
Cc: Mark Rutland <mark.rutland@arm.com>,
linux-rockchip@lists.infradead.org,
Rob Herring <robh+dt@kernel.org>,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org
Subject: Re: [PATCH] arm64: dts: rockchip: Move xin32k fixed-clock out of PX30 DTSI
Date: Wed, 4 Dec 2019 18:36:46 +0100 [thread overview]
Message-ID: <20191204183646.2f7f6e7f@xps13> (raw)
In-Reply-To: <2665233.YyXs6BPQ7y@diego>
Hi Heiko,
Heiko Stübner <heiko@sntech.de> wrote on Wed, 04 Dec 2019 18:31:46
+0100:
> Hi Miquel,
>
> Am Mittwoch, 4. Dezember 2019, 18:15:37 CET schrieb Miquel Raynal:
> > This clock has nothing to do in the PX30 DTSI as it is supposed to be
> > an input of the SoC. Moving it to the EVB DTS (only board file using
> > this DTSI) makes more sense. Also, when this clock is not a fixed
> > clock and comes from eg. a PMIC the situation can be described cleanly
> > in the device tree (avoids having to delete the fixed-clock node
> > first).
> >
> > This clock is not mandatory to boot so it should not break existing
> > users.
> >
> > Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
>
> Sorry foo being the bearer of bad news again, but that issue got already
> fixed by:
He he, no problem :) I was not actually looking at the right branch
(v5.5-armsoc/dts64).
> arm64: dts: rockchip: remove static xin32k from px30
> https://git.kernel.org/pub/scm/linux/kernel/git/mmind/linux-rockchip.git/commit/?h=v5.5-armsoc/dts64&id=00519137f7d4fc19ff27f3d3f4fc45b5b222ae82
>
> arm64: dts: rockchip: fix the px30-evb power tree
> https://git.kernel.org/pub/scm/linux/kernel/git/mmind/linux-rockchip.git/commit/?h=v5.5-armsoc/dts64&id=915b6a8b54a6d436885a458867e59fb20fc6356d
>
>
> On most/all Rockchip the xin32k clock is actually provided by the boards
> pmic - the rk809 in this case.
Thanks for the confirmation!
Miquèl
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-12-04 17:36 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-04 17:15 [PATCH] arm64: dts: rockchip: Move xin32k fixed-clock out of PX30 DTSI Miquel Raynal
2019-12-04 17:15 ` Miquel Raynal
2019-12-04 17:15 ` Miquel Raynal
2019-12-04 17:31 ` Heiko Stübner
2019-12-04 17:31 ` Heiko Stübner
2019-12-04 17:31 ` Heiko Stübner
2019-12-04 17:36 ` Miquel Raynal [this message]
2019-12-04 17:36 ` Miquel Raynal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191204183646.2f7f6e7f@xps13 \
--to=miquel.raynal@bootlin.com \
--cc=devicetree@vger.kernel.org \
--cc=heiko@sntech.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.