From: Miquel Raynal <miquel.raynal@bootlin.com> To: Heiko Stuebner <heiko@sntech.de> Cc: Rob Herring <robh+dt@kernel.org>, Mark Rutland <mark.rutland@arm.com>, devicetree@vger.kernel.org, linux-rockchip@lists.infradead.org, Paul Kocialkowski <paul.kocialkowski@bootlin.com>, Maxime Chevallier <maxime.chevallier@bootlin.com>, Thomas Petazzoni <thomas.petazzoni@bootlin.com> Subject: Re: [PATCH] arm64: dts: rockchip: Change RK809 PMIC interrupt polarity Date: Fri, 6 Dec 2019 16:52:50 +0100 [thread overview] Message-ID: <20191206165250.5877dec8@xps13> (raw) In-Reply-To: <3285991.EbEXlA3CnX@phil> Hi Heiko, Heiko Stuebner <heiko@sntech.de> wrote on Fri, 06 Dec 2019 16:48:00 +0100: > Hi Miquel, > > Am Freitag, 6. Dezember 2019, 16:42:47 CET schrieb Miquel Raynal: > > PMIC interrupt can be active high or active low depending on BIT(1) of > > the GPIO_INT_CFG pin. The default is 0x1, which means active > > high. Change the polarity in the device tree to reflect the default > > state. > > > > Without this and with the current code base, the interrupt never stops > > triggering while the MFD driver does not see anything to > > check/clear/mask so after 100000 spurious IRQs, the kernel simply > > desactivates the interrupt: > > > > irq 36: nobody cared (try booting with the "irqpoll" option) > > [...] > > handlers: > > [<(____ptrval____)>] irq_default_primary_handler threaded > > [<(____ptrval____)>] regmap_irq_thread > > Disabling IRQ #36 > > > > Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com> > > *coughs slightly* > > mfd: rk808: Set RK817 interrupt polarity to low > https://git.kernel.org/pub/scm/linux/kernel/git/lee/mfd.git/commit/drivers/mfd/rk808.c?h=for-mfd-next&id=dbd16ef53487084816a20f662423ab543a75fc83 > > Should be in the current merge window already I guess ;-) This time I swear I checked your tree. But this time we did not ended with the same fix so I missed this one *again* :) > > Having this consistent over all rk8xx seemed nicer. I'm fine with this approach too. Thanks, Miquèl
WARNING: multiple messages have this Message-ID (diff)
From: Miquel Raynal <miquel.raynal-LDxbnhwyfcJBDgjK7y7TUQ@public.gmane.org> To: Heiko Stuebner <heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org> Cc: Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Maxime Chevallier <maxime.chevallier-LDxbnhwyfcJBDgjK7y7TUQ@public.gmane.org>, Paul Kocialkowski <paul.kocialkowski-LDxbnhwyfcJBDgjK7y7TUQ@public.gmane.org>, linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>, Thomas Petazzoni <thomas.petazzoni-LDxbnhwyfcJBDgjK7y7TUQ@public.gmane.org> Subject: Re: [PATCH] arm64: dts: rockchip: Change RK809 PMIC interrupt polarity Date: Fri, 6 Dec 2019 16:52:50 +0100 [thread overview] Message-ID: <20191206165250.5877dec8@xps13> (raw) In-Reply-To: <3285991.EbEXlA3CnX@phil> Hi Heiko, Heiko Stuebner <heiko@sntech.de> wrote on Fri, 06 Dec 2019 16:48:00 +0100: > Hi Miquel, > > Am Freitag, 6. Dezember 2019, 16:42:47 CET schrieb Miquel Raynal: > > PMIC interrupt can be active high or active low depending on BIT(1) of > > the GPIO_INT_CFG pin. The default is 0x1, which means active > > high. Change the polarity in the device tree to reflect the default > > state. > > > > Without this and with the current code base, the interrupt never stops > > triggering while the MFD driver does not see anything to > > check/clear/mask so after 100000 spurious IRQs, the kernel simply > > desactivates the interrupt: > > > > irq 36: nobody cared (try booting with the "irqpoll" option) > > [...] > > handlers: > > [<(____ptrval____)>] irq_default_primary_handler threaded > > [<(____ptrval____)>] regmap_irq_thread > > Disabling IRQ #36 > > > > Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com> > > *coughs slightly* > > mfd: rk808: Set RK817 interrupt polarity to low > https://git.kernel.org/pub/scm/linux/kernel/git/lee/mfd.git/commit/drivers/mfd/rk808.c?h=for-mfd-next&id=dbd16ef53487084816a20f662423ab543a75fc83 > > Should be in the current merge window already I guess ;-) This time I swear I checked your tree. But this time we did not ended with the same fix so I missed this one *again* :) > > Having this consistent over all rk8xx seemed nicer. I'm fine with this approach too. Thanks, Miquèl _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip
next prev parent reply other threads:[~2019-12-06 15:52 UTC|newest] Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-12-06 15:42 [PATCH] arm64: dts: rockchip: Change RK809 PMIC interrupt polarity Miquel Raynal 2019-12-06 15:42 ` Miquel Raynal 2019-12-06 15:48 ` Heiko Stuebner 2019-12-06 15:48 ` Heiko Stuebner 2019-12-06 15:52 ` Miquel Raynal [this message] 2019-12-06 15:52 ` Miquel Raynal 2019-12-06 16:01 ` Heiko Stuebner 2019-12-06 16:01 ` Heiko Stuebner 2019-12-06 16:34 ` Miquel Raynal 2019-12-06 16:34 ` Miquel Raynal 2019-12-06 17:09 ` Heiko Stuebner 2019-12-06 17:09 ` Heiko Stuebner 2019-12-06 17:16 ` Miquel Raynal 2019-12-06 17:16 ` Miquel Raynal
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20191206165250.5877dec8@xps13 \ --to=miquel.raynal@bootlin.com \ --cc=devicetree@vger.kernel.org \ --cc=heiko@sntech.de \ --cc=linux-rockchip@lists.infradead.org \ --cc=mark.rutland@arm.com \ --cc=maxime.chevallier@bootlin.com \ --cc=paul.kocialkowski@bootlin.com \ --cc=robh+dt@kernel.org \ --cc=thomas.petazzoni@bootlin.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.