From: Mark Brown <broonie@kernel.org>
To: Chuhong Yuan <hslester96@gmail.com>
Cc: Brian Austin <brian.austin@cirrus.com>,
Paul Handrigan <Paul.Handrigan@cirrus.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
James Schulman <james.schulman@cirrus.com>,
alsa-devel@alsa-project.org, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ASoC: cs42l42: add missed regulator_bulk_disable in remove and fix probe failure
Date: Mon, 9 Dec 2019 17:00:30 +0000 [thread overview]
Message-ID: <20191209170030.GH5483@sirena.org.uk> (raw)
In-Reply-To: <CANhBUQ0zwQG-=C12v02cf5kfvJba=5_=0JkZA45DDhxOzTBY6A@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 676 bytes --]
On Tue, Dec 10, 2019 at 12:52:30AM +0800, Chuhong Yuan wrote:
> I have a question that what if CONFIG_PM is not defined?
> Since I have met runtime PM before in the patch
> a31eda65ba21 ("net: fec: fix clock count mis-match").
> I learned there that in some cases CONFIG_PM is not defined so runtime PM
> cannot take effect.
> Therefore, undo operations should still exist in remove functions.
There's also the case where runtime PM is there and the device is active
at suspend - it's not that there isn't a problem, it's that we can't
unconditionally do a disable because we don't know if there was a
matching enable. It'll need to be conditional on the runtime PM state.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@kernel.org>
To: Chuhong Yuan <hslester96@gmail.com>
Cc: Brian Austin <brian.austin@cirrus.com>,
alsa-devel@alsa-project.org, Liam Girdwood <lgirdwood@gmail.com>,
LKML <linux-kernel@vger.kernel.org>,
Takashi Iwai <tiwai@suse.com>,
Paul Handrigan <Paul.Handrigan@cirrus.com>,
James Schulman <james.schulman@cirrus.com>
Subject: Re: [alsa-devel] [PATCH] ASoC: cs42l42: add missed regulator_bulk_disable in remove and fix probe failure
Date: Mon, 9 Dec 2019 17:00:30 +0000 [thread overview]
Message-ID: <20191209170030.GH5483@sirena.org.uk> (raw)
In-Reply-To: <CANhBUQ0zwQG-=C12v02cf5kfvJba=5_=0JkZA45DDhxOzTBY6A@mail.gmail.com>
[-- Attachment #1.1: Type: text/plain, Size: 676 bytes --]
On Tue, Dec 10, 2019 at 12:52:30AM +0800, Chuhong Yuan wrote:
> I have a question that what if CONFIG_PM is not defined?
> Since I have met runtime PM before in the patch
> a31eda65ba21 ("net: fec: fix clock count mis-match").
> I learned there that in some cases CONFIG_PM is not defined so runtime PM
> cannot take effect.
> Therefore, undo operations should still exist in remove functions.
There's also the case where runtime PM is there and the device is active
at suspend - it's not that there isn't a problem, it's that we can't
unconditionally do a disable because we don't know if there was a
matching enable. It'll need to be conditional on the runtime PM state.
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
[-- Attachment #2: Type: text/plain, Size: 161 bytes --]
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
next prev parent reply other threads:[~2019-12-09 17:00 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-06 7:52 [PATCH] ASoC: cs42l42: add missed regulator_bulk_disable in remove and fix probe failure Chuhong Yuan
2019-12-06 7:52 ` [alsa-devel] " Chuhong Yuan
2019-12-09 16:24 ` Mark Brown
2019-12-09 16:24 ` [alsa-devel] " Mark Brown
2019-12-09 16:52 ` Chuhong Yuan
2019-12-09 16:52 ` [alsa-devel] " Chuhong Yuan
2019-12-09 17:00 ` Mark Brown [this message]
2019-12-09 17:00 ` Mark Brown
2019-12-10 1:32 ` Chuhong Yuan
2019-12-10 1:32 ` [alsa-devel] " Chuhong Yuan
2019-12-10 12:17 ` Mark Brown
2019-12-10 12:17 ` [alsa-devel] " Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191209170030.GH5483@sirena.org.uk \
--to=broonie@kernel.org \
--cc=Paul.Handrigan@cirrus.com \
--cc=alsa-devel@alsa-project.org \
--cc=brian.austin@cirrus.com \
--cc=hslester96@gmail.com \
--cc=james.schulman@cirrus.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.