From: Luc Van Oostenryck <luc.vanoostenryck@gmail.com> To: Peter Zijlstra <peterz@infradead.org> Cc: Will Deacon <will@kernel.org>, Linus Torvalds <torvalds@linux-foundation.org>, Michael Ellerman <mpe@ellerman.id.au>, dja@axtens.net, Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, linuxppc-dev@lists.ozlabs.org, Christophe Leroy <christophe.leroy@c-s.fr>, linux-arch <linux-arch@vger.kernel.org>, Mark Rutland <mark.rutland@arm.com>, Segher Boessenkool <segher@kernel.crashing.org>, Arnd Bergmann <arnd@arndb.de>, Christian Borntraeger <borntraeger@de.ibm.com> Subject: Re: READ_ONCE() + STACKPROTECTOR_STRONG == :/ (was Re: [GIT PULL] Please pull powerpc/linux.git powerpc-5.5-2 tag (topic/kasan-bitops)) Date: Fri, 13 Dec 2019 15:28:46 +0100 [thread overview] Message-ID: <20191213142846.ki2t2fwljnql66lt@ltop.local> (raw) In-Reply-To: <20191213125618.GD2844@hirez.programming.kicks-ass.net> On Fri, Dec 13, 2019 at 01:56:18PM +0100, Peter Zijlstra wrote: > > Excellent! I had to change it to something like: > > #define unqual_typeof(x) typeof(({_Atomic typeof(x) ___x __maybe_unused; ___x; })) > > but that does indeed work! > > Now I suppose we should wrap that in a symbol that indicates our > compiler does indeed support _Atomic, otherwise things will come apart. > > That is, my gcc-4.6 doesn't seem to have it, while gcc-4.8 does, which > is exactly the range that needs the daft READ_ONCE() construct, how > convenient :/ > > Something a little like this perhaps? Yes, this looks good to me. Just a small nit here below. > --- > > diff --git a/arch/arm64/include/asm/barrier.h b/arch/arm64/include/asm/barrier.h > index 7d9cc5ec4971..c389af602da8 100644 > --- a/arch/arm64/include/asm/barrier.h > +++ b/arch/arm64/include/asm/barrier.h > @@ -75,9 +75,9 @@ static inline unsigned long array_index_mask_nospec(unsigned long idx, > > #define __smp_store_release(p, v) \ > do { \ > - typeof(p) __p = (p); \ > - union { typeof(*p) __val; char __c[1]; } __u = \ > - { .__val = (__force typeof(*p)) (v) }; \ > + unqual_typeof(p) __p = (p); \ > + union { unqual_typeof(*p) __val; char __c[1]; } __u = \ > + { .__val = (__force unqual_typeof(*p)) (v) }; \ The 2 two trailing backslashes are now off by one tab. -- Luc
WARNING: multiple messages have this Message-ID (diff)
From: Luc Van Oostenryck <luc.vanoostenryck@gmail.com> To: Peter Zijlstra <peterz@infradead.org> Cc: linux-arch <linux-arch@vger.kernel.org>, Will Deacon <will@kernel.org>, linuxppc-dev@lists.ozlabs.org, Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, Christian Borntraeger <borntraeger@de.ibm.com>, Arnd Bergmann <arnd@arndb.de>, Mark Rutland <mark.rutland@arm.com>, Linus Torvalds <torvalds@linux-foundation.org>, dja@axtens.net Subject: Re: READ_ONCE() + STACKPROTECTOR_STRONG == :/ (was Re: [GIT PULL] Please pull powerpc/linux.git powerpc-5.5-2 tag (topic/kasan-bitops)) Date: Fri, 13 Dec 2019 15:28:46 +0100 [thread overview] Message-ID: <20191213142846.ki2t2fwljnql66lt@ltop.local> (raw) In-Reply-To: <20191213125618.GD2844@hirez.programming.kicks-ass.net> On Fri, Dec 13, 2019 at 01:56:18PM +0100, Peter Zijlstra wrote: > > Excellent! I had to change it to something like: > > #define unqual_typeof(x) typeof(({_Atomic typeof(x) ___x __maybe_unused; ___x; })) > > but that does indeed work! > > Now I suppose we should wrap that in a symbol that indicates our > compiler does indeed support _Atomic, otherwise things will come apart. > > That is, my gcc-4.6 doesn't seem to have it, while gcc-4.8 does, which > is exactly the range that needs the daft READ_ONCE() construct, how > convenient :/ > > Something a little like this perhaps? Yes, this looks good to me. Just a small nit here below. > --- > > diff --git a/arch/arm64/include/asm/barrier.h b/arch/arm64/include/asm/barrier.h > index 7d9cc5ec4971..c389af602da8 100644 > --- a/arch/arm64/include/asm/barrier.h > +++ b/arch/arm64/include/asm/barrier.h > @@ -75,9 +75,9 @@ static inline unsigned long array_index_mask_nospec(unsigned long idx, > > #define __smp_store_release(p, v) \ > do { \ > - typeof(p) __p = (p); \ > - union { typeof(*p) __val; char __c[1]; } __u = \ > - { .__val = (__force typeof(*p)) (v) }; \ > + unqual_typeof(p) __p = (p); \ > + union { unqual_typeof(*p) __val; char __c[1]; } __u = \ > + { .__val = (__force unqual_typeof(*p)) (v) }; \ The 2 two trailing backslashes are now off by one tab. -- Luc
next prev parent reply other threads:[~2019-12-13 20:37 UTC|newest] Thread overview: 86+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-12-06 12:46 [GIT PULL] Please pull powerpc/linux.git powerpc-5.5-2 tag (topic/kasan-bitops) Michael Ellerman 2019-12-06 12:46 ` Michael Ellerman 2019-12-06 13:16 ` Peter Zijlstra 2019-12-06 13:16 ` Peter Zijlstra 2019-12-10 5:38 ` Michael Ellerman 2019-12-10 5:38 ` Michael Ellerman 2019-12-10 10:15 ` Peter Zijlstra 2019-12-10 10:15 ` Peter Zijlstra 2019-12-11 0:29 ` Michael Ellerman 2019-12-11 0:29 ` Michael Ellerman 2019-12-12 5:42 ` READ_ONCE() + STACKPROTECTOR_STRONG == :/ (was Re: [GIT PULL] Please pull powerpc/linux.git powerpc-5.5-2 tag (topic/kasan-bitops)) Michael Ellerman 2019-12-12 5:42 ` Michael Ellerman 2019-12-12 8:01 ` Peter Zijlstra 2019-12-12 8:01 ` Peter Zijlstra 2019-12-12 10:07 ` Will Deacon 2019-12-12 10:07 ` Will Deacon 2019-12-12 10:46 ` Peter Zijlstra 2019-12-12 10:46 ` Peter Zijlstra 2019-12-12 17:04 ` Will Deacon 2019-12-12 17:04 ` Will Deacon 2019-12-12 17:16 ` Will Deacon 2019-12-12 17:16 ` Will Deacon 2019-12-12 17:41 ` Linus Torvalds 2019-12-12 17:41 ` Linus Torvalds 2019-12-12 17:50 ` Segher Boessenkool 2019-12-12 17:50 ` Segher Boessenkool 2019-12-12 18:06 ` Will Deacon 2019-12-12 18:06 ` Will Deacon 2019-12-12 18:29 ` Christian Borntraeger 2019-12-12 18:29 ` Christian Borntraeger 2019-12-12 18:43 ` Linus Torvalds 2019-12-12 18:43 ` Linus Torvalds 2019-12-12 19:34 ` Will Deacon 2019-12-12 19:34 ` Will Deacon 2019-12-12 20:21 ` Peter Zijlstra 2019-12-12 20:21 ` Peter Zijlstra 2019-12-12 20:53 ` Peter Zijlstra 2019-12-12 20:53 ` Peter Zijlstra 2019-12-13 10:47 ` Luc Van Oostenryck 2019-12-13 10:47 ` Luc Van Oostenryck 2019-12-13 12:56 ` Peter Zijlstra 2019-12-13 12:56 ` Peter Zijlstra 2019-12-13 14:28 ` Luc Van Oostenryck [this message] 2019-12-13 14:28 ` Luc Van Oostenryck 2019-12-12 20:49 ` Linus Torvalds 2019-12-12 20:49 ` Linus Torvalds 2019-12-13 13:17 ` Arnd Bergmann 2019-12-13 13:17 ` Arnd Bergmann 2019-12-13 21:32 ` Arnd Bergmann 2019-12-13 21:32 ` Arnd Bergmann 2019-12-13 22:01 ` Linus Torvalds 2019-12-13 22:01 ` Linus Torvalds 2019-12-16 10:28 ` Will Deacon 2019-12-16 10:28 ` Will Deacon 2019-12-16 11:47 ` Peter Zijlstra 2019-12-16 11:47 ` Peter Zijlstra 2019-12-16 12:06 ` Arnd Bergmann 2019-12-16 12:06 ` Arnd Bergmann 2019-12-17 17:07 ` Will Deacon 2019-12-17 17:07 ` Will Deacon 2019-12-17 18:04 ` Linus Torvalds 2019-12-17 18:04 ` Linus Torvalds 2019-12-17 18:05 ` Linus Torvalds 2019-12-17 18:05 ` Linus Torvalds 2019-12-17 18:31 ` Will Deacon 2019-12-17 18:31 ` Will Deacon 2019-12-17 18:32 ` Linus Torvalds 2019-12-17 18:32 ` Linus Torvalds 2019-12-18 12:17 ` Michael Ellerman 2019-12-18 12:17 ` Michael Ellerman 2019-12-19 12:11 ` Will Deacon 2019-12-19 12:11 ` Will Deacon 2019-12-18 10:22 ` Christian Borntraeger 2019-12-18 10:22 ` Christian Borntraeger 2019-12-18 10:35 ` Will Deacon 2019-12-18 10:35 ` Will Deacon 2019-12-13 12:07 ` Michael Ellerman 2019-12-13 12:07 ` Michael Ellerman 2019-12-13 13:53 ` Segher Boessenkool 2019-12-13 13:53 ` Segher Boessenkool 2019-12-13 21:06 ` Michael Ellerman 2019-12-13 21:06 ` Michael Ellerman 2019-12-12 15:10 ` Segher Boessenkool 2019-12-12 15:10 ` Segher Boessenkool 2019-12-06 22:15 ` [GIT PULL] Please pull powerpc/linux.git powerpc-5.5-2 tag (topic/kasan-bitops) pr-tracker-bot 2019-12-06 22:15 ` pr-tracker-bot
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20191213142846.ki2t2fwljnql66lt@ltop.local \ --to=luc.vanoostenryck@gmail.com \ --cc=arnd@arndb.de \ --cc=borntraeger@de.ibm.com \ --cc=christophe.leroy@c-s.fr \ --cc=dja@axtens.net \ --cc=linux-arch@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linuxppc-dev@lists.ozlabs.org \ --cc=mark.rutland@arm.com \ --cc=mpe@ellerman.id.au \ --cc=peterz@infradead.org \ --cc=segher@kernel.crashing.org \ --cc=torvalds@linux-foundation.org \ --cc=will@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.