From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Jitao Shi <jitao.shi@mediatek.com>
Cc: Thierry Reding <thierry.reding@gmail.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
linux-pwm@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
CK Hu <ck.hu@mediatek.com>,
linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org,
sj.huang@mediatek.com
Subject: Re: [PATCH v2 1/2] pwm: fine tune pwm-mtk-disp clock control flow
Date: Mon, 16 Dec 2019 09:18:43 +0100 [thread overview]
Message-ID: <20191216081843.yxe3vm674jwurwri@pengutronix.de> (raw)
In-Reply-To: <20191216070123.114719-2-jitao.shi@mediatek.com>
Hello,
On Mon, Dec 16, 2019 at 03:01:22PM +0800, Jitao Shi wrote:
> Match pwm clock when suspend and resume.
> Prepare and enable disp_pwm clock when disp_pwm enable.
> Disable and unprepare disp_pwm clock when disp_pwm disable.
Assuming you catched all clock operations (I didn't check), the patch
looks fine. The commit log could however be improved. Additional to
describing what the patch does, some words about the motivation would be
good. Does this fix a bug? Is it to save some power while the PWM isn't
in use?
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | https://www.pengutronix.de/ |
WARNING: multiple messages have this Message-ID (diff)
From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Jitao Shi <jitao.shi@mediatek.com>
Cc: linux-pwm@vger.kernel.org, linux-kernel@vger.kernel.org,
CK Hu <ck.hu@mediatek.com>,
sj.huang@mediatek.com, Thierry Reding <thierry.reding@gmail.com>,
linux-mediatek@lists.infradead.org,
Matthias Brugger <matthias.bgg@gmail.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 1/2] pwm: fine tune pwm-mtk-disp clock control flow
Date: Mon, 16 Dec 2019 09:18:43 +0100 [thread overview]
Message-ID: <20191216081843.yxe3vm674jwurwri@pengutronix.de> (raw)
In-Reply-To: <20191216070123.114719-2-jitao.shi@mediatek.com>
Hello,
On Mon, Dec 16, 2019 at 03:01:22PM +0800, Jitao Shi wrote:
> Match pwm clock when suspend and resume.
> Prepare and enable disp_pwm clock when disp_pwm enable.
> Disable and unprepare disp_pwm clock when disp_pwm disable.
Assuming you catched all clock operations (I didn't check), the patch
looks fine. The commit log could however be improved. Additional to
describing what the patch does, some words about the motivation would be
good. Does this fix a bug? Is it to save some power while the PWM isn't
in use?
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | https://www.pengutronix.de/ |
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
WARNING: multiple messages have this Message-ID (diff)
From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Jitao Shi <jitao.shi@mediatek.com>
Cc: linux-pwm@vger.kernel.org, linux-kernel@vger.kernel.org,
CK Hu <ck.hu@mediatek.com>,
sj.huang@mediatek.com, Thierry Reding <thierry.reding@gmail.com>,
linux-mediatek@lists.infradead.org,
Matthias Brugger <matthias.bgg@gmail.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 1/2] pwm: fine tune pwm-mtk-disp clock control flow
Date: Mon, 16 Dec 2019 09:18:43 +0100 [thread overview]
Message-ID: <20191216081843.yxe3vm674jwurwri@pengutronix.de> (raw)
In-Reply-To: <20191216070123.114719-2-jitao.shi@mediatek.com>
Hello,
On Mon, Dec 16, 2019 at 03:01:22PM +0800, Jitao Shi wrote:
> Match pwm clock when suspend and resume.
> Prepare and enable disp_pwm clock when disp_pwm enable.
> Disable and unprepare disp_pwm clock when disp_pwm disable.
Assuming you catched all clock operations (I didn't check), the patch
looks fine. The commit log could however be improved. Additional to
describing what the patch does, some words about the motivation would be
good. Does this fix a bug? Is it to save some power while the PWM isn't
in use?
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | https://www.pengutronix.de/ |
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-12-16 8:18 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-16 7:01 [PATCH v2 0/2] pwm_mtk_disp suspend resume issue fix Jitao Shi
2019-12-16 7:01 ` Jitao Shi
2019-12-16 7:01 ` Jitao Shi
2019-12-16 7:01 ` Jitao Shi
2019-12-16 7:01 ` [PATCH v2 1/2] pwm: fine tune pwm-mtk-disp clock control flow Jitao Shi
2019-12-16 7:01 ` Jitao Shi
2019-12-16 7:01 ` Jitao Shi
2019-12-16 7:01 ` Jitao Shi
2019-12-16 8:18 ` Uwe Kleine-König [this message]
2019-12-16 8:18 ` Uwe Kleine-König
2019-12-16 8:18 ` Uwe Kleine-König
2019-12-17 2:42 ` Jitao Shi
2019-12-17 2:42 ` Jitao Shi
2019-12-17 2:42 ` Jitao Shi
2019-12-16 7:01 ` [PATCH v2 2/2] pwm/mtk_disp: move the reg enable trigger in config Jitao Shi
2019-12-16 7:01 ` Jitao Shi
2019-12-16 7:01 ` Jitao Shi
2019-12-16 7:01 ` Jitao Shi
2019-12-16 8:20 ` Uwe Kleine-König
2019-12-16 8:20 ` Uwe Kleine-König
2019-12-16 8:20 ` Uwe Kleine-König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191216081843.yxe3vm674jwurwri@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=ck.hu@mediatek.com \
--cc=jitao.shi@mediatek.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-pwm@vger.kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=sj.huang@mediatek.com \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.