From: Jitao Shi <jitao.shi@mediatek.com>
To: Thierry Reding <thierry.reding@gmail.com>,
Uwe Kleine-Koenig <u.kleine-koenig@pengutronix.de>,
Matthias Brugger <matthias.bgg@gmail.com>,
<linux-pwm@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>, CK Hu <ck.hu@mediatek.com>
Cc: <linux-mediatek@lists.infradead.org>, <sj.huang@mediatek.com>,
Jitao Shi <jitao.shi@mediatek.com>
Subject: [PATCH v3 2/2] pwm: keep the trigger register after pwm setting.
Date: Tue, 17 Dec 2019 11:04:38 +0800 [thread overview]
Message-ID: <20191217030438.26657-3-jitao.shi@mediatek.com> (raw)
In-Reply-To: <20191217030438.26657-1-jitao.shi@mediatek.com>
Move the trigger after pwm setting to avoid the pwm wrong signal
output.
Remove the regist enable trigger setting in probe.
Move the trigger to end of mtk_disp_pwm_config().
Signed-off-by: Jitao Shi <jitao.shi@mediatek.com>
---
drivers/pwm/pwm-mtk-disp.c | 20 +++++++-------------
1 file changed, 7 insertions(+), 13 deletions(-)
diff --git a/drivers/pwm/pwm-mtk-disp.c b/drivers/pwm/pwm-mtk-disp.c
index c7b14acc9316..c1aae5b5693b 100644
--- a/drivers/pwm/pwm-mtk-disp.c
+++ b/drivers/pwm/pwm-mtk-disp.c
@@ -122,6 +122,13 @@ static int mtk_disp_pwm_config(struct pwm_chip *chip, struct pwm_device *pwm,
mtk_disp_pwm_update_bits(mdp, mdp->data->commit,
mdp->data->commit_mask,
0x0);
+ } else {
+ mtk_disp_pwm_update_bits(mdp, mdp->data->bls_debug,
+ mdp->data->bls_debug_mask,
+ mdp->data->bls_debug_mask);
+ mtk_disp_pwm_update_bits(mdp, mdp->data->con0,
+ mdp->data->con0_sel,
+ mdp->data->con0_sel);
}
clk_disable_unprepare(mdp->clk_mm);
@@ -207,19 +214,6 @@ static int mtk_disp_pwm_probe(struct platform_device *pdev)
platform_set_drvdata(pdev, mdp);
- /*
- * For MT2701, disable double buffer before writing register
- * and select manual mode and use PWM_PERIOD/PWM_HIGH_WIDTH.
- */
- if (!mdp->data->has_commit) {
- mtk_disp_pwm_update_bits(mdp, mdp->data->bls_debug,
- mdp->data->bls_debug_mask,
- mdp->data->bls_debug_mask);
- mtk_disp_pwm_update_bits(mdp, mdp->data->con0,
- mdp->data->con0_sel,
- mdp->data->con0_sel);
- }
-
return 0;
}
--
2.21.0
WARNING: multiple messages have this Message-ID (diff)
From: Jitao Shi <jitao.shi@mediatek.com>
To: Thierry Reding <thierry.reding@gmail.com>,
Uwe Kleine-Koenig <u.kleine-koenig@pengutronix.de>,
Matthias Brugger <matthias.bgg@gmail.com>,
linux-pwm@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, CK Hu <ck.hu@mediatek.com>
Cc: linux-mediatek@lists.infradead.org, sj.huang@mediatek.com,
Jitao Shi <jitao.shi@mediatek.com>
Subject: [PATCH v3 2/2] pwm: keep the trigger register after pwm setting.
Date: Tue, 17 Dec 2019 11:04:38 +0800 [thread overview]
Message-ID: <20191217030438.26657-3-jitao.shi@mediatek.com> (raw)
In-Reply-To: <20191217030438.26657-1-jitao.shi@mediatek.com>
Move the trigger after pwm setting to avoid the pwm wrong signal
output.
Remove the regist enable trigger setting in probe.
Move the trigger to end of mtk_disp_pwm_config().
Signed-off-by: Jitao Shi <jitao.shi@mediatek.com>
---
drivers/pwm/pwm-mtk-disp.c | 20 +++++++-------------
1 file changed, 7 insertions(+), 13 deletions(-)
diff --git a/drivers/pwm/pwm-mtk-disp.c b/drivers/pwm/pwm-mtk-disp.c
index c7b14acc9316..c1aae5b5693b 100644
--- a/drivers/pwm/pwm-mtk-disp.c
+++ b/drivers/pwm/pwm-mtk-disp.c
@@ -122,6 +122,13 @@ static int mtk_disp_pwm_config(struct pwm_chip *chip, struct pwm_device *pwm,
mtk_disp_pwm_update_bits(mdp, mdp->data->commit,
mdp->data->commit_mask,
0x0);
+ } else {
+ mtk_disp_pwm_update_bits(mdp, mdp->data->bls_debug,
+ mdp->data->bls_debug_mask,
+ mdp->data->bls_debug_mask);
+ mtk_disp_pwm_update_bits(mdp, mdp->data->con0,
+ mdp->data->con0_sel,
+ mdp->data->con0_sel);
}
clk_disable_unprepare(mdp->clk_mm);
@@ -207,19 +214,6 @@ static int mtk_disp_pwm_probe(struct platform_device *pdev)
platform_set_drvdata(pdev, mdp);
- /*
- * For MT2701, disable double buffer before writing register
- * and select manual mode and use PWM_PERIOD/PWM_HIGH_WIDTH.
- */
- if (!mdp->data->has_commit) {
- mtk_disp_pwm_update_bits(mdp, mdp->data->bls_debug,
- mdp->data->bls_debug_mask,
- mdp->data->bls_debug_mask);
- mtk_disp_pwm_update_bits(mdp, mdp->data->con0,
- mdp->data->con0_sel,
- mdp->data->con0_sel);
- }
-
return 0;
}
--
2.21.0
WARNING: multiple messages have this Message-ID (diff)
From: Jitao Shi <jitao.shi@mediatek.com>
To: Thierry Reding <thierry.reding@gmail.com>,
Uwe Kleine-Koenig <u.kleine-koenig@pengutronix.de>,
Matthias Brugger <matthias.bgg@gmail.com>,
<linux-pwm@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>, CK Hu <ck.hu@mediatek.com>
Cc: Jitao Shi <jitao.shi@mediatek.com>,
sj.huang@mediatek.com, linux-mediatek@lists.infradead.org
Subject: [PATCH v3 2/2] pwm: keep the trigger register after pwm setting.
Date: Tue, 17 Dec 2019 11:04:38 +0800 [thread overview]
Message-ID: <20191217030438.26657-3-jitao.shi@mediatek.com> (raw)
In-Reply-To: <20191217030438.26657-1-jitao.shi@mediatek.com>
Move the trigger after pwm setting to avoid the pwm wrong signal
output.
Remove the regist enable trigger setting in probe.
Move the trigger to end of mtk_disp_pwm_config().
Signed-off-by: Jitao Shi <jitao.shi@mediatek.com>
---
drivers/pwm/pwm-mtk-disp.c | 20 +++++++-------------
1 file changed, 7 insertions(+), 13 deletions(-)
diff --git a/drivers/pwm/pwm-mtk-disp.c b/drivers/pwm/pwm-mtk-disp.c
index c7b14acc9316..c1aae5b5693b 100644
--- a/drivers/pwm/pwm-mtk-disp.c
+++ b/drivers/pwm/pwm-mtk-disp.c
@@ -122,6 +122,13 @@ static int mtk_disp_pwm_config(struct pwm_chip *chip, struct pwm_device *pwm,
mtk_disp_pwm_update_bits(mdp, mdp->data->commit,
mdp->data->commit_mask,
0x0);
+ } else {
+ mtk_disp_pwm_update_bits(mdp, mdp->data->bls_debug,
+ mdp->data->bls_debug_mask,
+ mdp->data->bls_debug_mask);
+ mtk_disp_pwm_update_bits(mdp, mdp->data->con0,
+ mdp->data->con0_sel,
+ mdp->data->con0_sel);
}
clk_disable_unprepare(mdp->clk_mm);
@@ -207,19 +214,6 @@ static int mtk_disp_pwm_probe(struct platform_device *pdev)
platform_set_drvdata(pdev, mdp);
- /*
- * For MT2701, disable double buffer before writing register
- * and select manual mode and use PWM_PERIOD/PWM_HIGH_WIDTH.
- */
- if (!mdp->data->has_commit) {
- mtk_disp_pwm_update_bits(mdp, mdp->data->bls_debug,
- mdp->data->bls_debug_mask,
- mdp->data->bls_debug_mask);
- mtk_disp_pwm_update_bits(mdp, mdp->data->con0,
- mdp->data->con0_sel,
- mdp->data->con0_sel);
- }
-
return 0;
}
--
2.21.0
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
WARNING: multiple messages have this Message-ID (diff)
From: Jitao Shi <jitao.shi@mediatek.com>
To: Thierry Reding <thierry.reding@gmail.com>,
Uwe Kleine-Koenig <u.kleine-koenig@pengutronix.de>,
Matthias Brugger <matthias.bgg@gmail.com>,
<linux-pwm@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>, CK Hu <ck.hu@mediatek.com>
Cc: Jitao Shi <jitao.shi@mediatek.com>,
sj.huang@mediatek.com, linux-mediatek@lists.infradead.org
Subject: [PATCH v3 2/2] pwm: keep the trigger register after pwm setting.
Date: Tue, 17 Dec 2019 11:04:38 +0800 [thread overview]
Message-ID: <20191217030438.26657-3-jitao.shi@mediatek.com> (raw)
In-Reply-To: <20191217030438.26657-1-jitao.shi@mediatek.com>
Move the trigger after pwm setting to avoid the pwm wrong signal
output.
Remove the regist enable trigger setting in probe.
Move the trigger to end of mtk_disp_pwm_config().
Signed-off-by: Jitao Shi <jitao.shi@mediatek.com>
---
drivers/pwm/pwm-mtk-disp.c | 20 +++++++-------------
1 file changed, 7 insertions(+), 13 deletions(-)
diff --git a/drivers/pwm/pwm-mtk-disp.c b/drivers/pwm/pwm-mtk-disp.c
index c7b14acc9316..c1aae5b5693b 100644
--- a/drivers/pwm/pwm-mtk-disp.c
+++ b/drivers/pwm/pwm-mtk-disp.c
@@ -122,6 +122,13 @@ static int mtk_disp_pwm_config(struct pwm_chip *chip, struct pwm_device *pwm,
mtk_disp_pwm_update_bits(mdp, mdp->data->commit,
mdp->data->commit_mask,
0x0);
+ } else {
+ mtk_disp_pwm_update_bits(mdp, mdp->data->bls_debug,
+ mdp->data->bls_debug_mask,
+ mdp->data->bls_debug_mask);
+ mtk_disp_pwm_update_bits(mdp, mdp->data->con0,
+ mdp->data->con0_sel,
+ mdp->data->con0_sel);
}
clk_disable_unprepare(mdp->clk_mm);
@@ -207,19 +214,6 @@ static int mtk_disp_pwm_probe(struct platform_device *pdev)
platform_set_drvdata(pdev, mdp);
- /*
- * For MT2701, disable double buffer before writing register
- * and select manual mode and use PWM_PERIOD/PWM_HIGH_WIDTH.
- */
- if (!mdp->data->has_commit) {
- mtk_disp_pwm_update_bits(mdp, mdp->data->bls_debug,
- mdp->data->bls_debug_mask,
- mdp->data->bls_debug_mask);
- mtk_disp_pwm_update_bits(mdp, mdp->data->con0,
- mdp->data->con0_sel,
- mdp->data->con0_sel);
- }
-
return 0;
}
--
2.21.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-12-17 3:04 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-17 3:04 [PATCH v3 0/2] clocks don't disable when pwm_mtk_disp suspend Jitao Shi
2019-12-17 3:04 ` Jitao Shi
2019-12-17 3:04 ` Jitao Shi
2019-12-17 3:04 ` Jitao Shi
2019-12-17 3:04 ` [PATCH v3 1/2] pwm: fix pwm clocks not poweroff when disable pwm Jitao Shi
2019-12-17 3:04 ` Jitao Shi
2019-12-17 3:04 ` Jitao Shi
2019-12-17 3:04 ` Jitao Shi
2019-12-17 3:04 ` Jitao Shi [this message]
2019-12-17 3:04 ` [PATCH v3 2/2] pwm: keep the trigger register after pwm setting Jitao Shi
2019-12-17 3:04 ` Jitao Shi
2019-12-17 3:04 ` Jitao Shi
2019-12-17 3:26 ` [PATCH v3 0/2] clocks don't disable when pwm_mtk_disp suspend Chen-Yu Tsai
2019-12-17 3:26 ` Chen-Yu Tsai
2019-12-17 3:26 ` Chen-Yu Tsai
2019-12-17 3:26 ` Chen-Yu Tsai
2019-12-17 3:56 ` Jitao Shi
2019-12-17 3:56 ` Jitao Shi
2019-12-17 3:56 ` Jitao Shi
2019-12-17 3:56 ` Jitao Shi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191217030438.26657-3-jitao.shi@mediatek.com \
--to=jitao.shi@mediatek.com \
--cc=ck.hu@mediatek.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-pwm@vger.kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=sj.huang@mediatek.com \
--cc=thierry.reding@gmail.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.