From: Mike Rapoport <rppt@kernel.org> To: Geert Uytterhoeven <geert@linux-m68k.org> Cc: Linux-sh list <linux-sh@vger.kernel.org>, Yoshinori Sato <ysato@users.sourceforge.jp>, Rich Felker <dalias@libc.org>, Linux MM <linux-mm@kvack.org>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, Mike Rapoport <rppt@linux.ibm.com> Subject: Re: [PATCH 2/2] sh: add support for folded p4d page tables Date: Tue, 17 Dec 2019 18:32:14 +0000 [thread overview] Message-ID: <20191217183213.GA29446@rapoport-lnx> (raw) In-Reply-To: <CAMuHMdXYp7EBK446EsDt_HLDvc96TPP9oPZmsLtFL5VvhSejjw@mail.gmail.com> On Tue, Dec 17, 2019 at 06:59:43PM +0100, Geert Uytterhoeven wrote: > Hi Mike, > > On Tue, Dec 17, 2019 at 3:23 PM Mike Rapoport <rppt@kernel.org> wrote: > > From: Mike Rapoport <rppt@linux.ibm.com> > > > > Implement primitives necessary for the 4th level folding, add walks of p4d > > level where appropriate and remove usage of __ARCH_USE_5LEVEL_HACK. > > > > Signed-off-by: Mike Rapoport <rppt@linux.ibm.com> > > Thanks for your patch! > > > --- a/arch/sh/mm/fault.c > > +++ b/arch/sh/mm/fault.c > > @@ -65,7 +66,20 @@ static void show_pte(struct mm_struct *mm, unsigned long addr) > > break; > > } > > > > - pud = pud_offset(pgd, addr); > > + p4d = p4d_offset(pgd, addr); > > + if (PTRS_PER_P4D != 1) > > + printk(", *p4d=%0*Lx", (u32)(sizeof(*p4d) * 2), > > + (u64)p4d_val(*p4d)); > > This (and the prints below) is gonna cause lots of broken output lines. > You should use pr_cont() instead, and probably rebase on top of my > "[PATCH 7/7] sh: fault: Modernize printing of kernel messages" > (https://lore.kernel.org/lkml/20191203162645.19950-8-geert+renesas@glider.be/). Ok, will fix. > > + > > + if (p4d_none(*p4d)) > > + break; > > + > > + if (p4d_bad(*p4d)) { > > + printk("(bad)"); > > + break; > > + } > > + > > + pud = pud_offset(p4d, addr); > > if (PTRS_PER_PUD != 1) > > printk(", *pud=%0*Lx", (u32)(sizeof(*pud) * 2), > > (u64)pud_val(*pud)); > > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds -- Sincerely yours, Mike.
WARNING: multiple messages have this Message-ID (diff)
From: Mike Rapoport <rppt@kernel.org> To: Geert Uytterhoeven <geert@linux-m68k.org> Cc: Linux-sh list <linux-sh@vger.kernel.org>, Yoshinori Sato <ysato@users.sourceforge.jp>, Rich Felker <dalias@libc.org>, Linux MM <linux-mm@kvack.org>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, Mike Rapoport <rppt@linux.ibm.com> Subject: Re: [PATCH 2/2] sh: add support for folded p4d page tables Date: Tue, 17 Dec 2019 20:32:14 +0200 [thread overview] Message-ID: <20191217183213.GA29446@rapoport-lnx> (raw) In-Reply-To: <CAMuHMdXYp7EBK446EsDt_HLDvc96TPP9oPZmsLtFL5VvhSejjw@mail.gmail.com> On Tue, Dec 17, 2019 at 06:59:43PM +0100, Geert Uytterhoeven wrote: > Hi Mike, > > On Tue, Dec 17, 2019 at 3:23 PM Mike Rapoport <rppt@kernel.org> wrote: > > From: Mike Rapoport <rppt@linux.ibm.com> > > > > Implement primitives necessary for the 4th level folding, add walks of p4d > > level where appropriate and remove usage of __ARCH_USE_5LEVEL_HACK. > > > > Signed-off-by: Mike Rapoport <rppt@linux.ibm.com> > > Thanks for your patch! > > > --- a/arch/sh/mm/fault.c > > +++ b/arch/sh/mm/fault.c > > @@ -65,7 +66,20 @@ static void show_pte(struct mm_struct *mm, unsigned long addr) > > break; > > } > > > > - pud = pud_offset(pgd, addr); > > + p4d = p4d_offset(pgd, addr); > > + if (PTRS_PER_P4D != 1) > > + printk(", *p4d=%0*Lx", (u32)(sizeof(*p4d) * 2), > > + (u64)p4d_val(*p4d)); > > This (and the prints below) is gonna cause lots of broken output lines. > You should use pr_cont() instead, and probably rebase on top of my > "[PATCH 7/7] sh: fault: Modernize printing of kernel messages" > (https://lore.kernel.org/lkml/20191203162645.19950-8-geert+renesas@glider.be/). Ok, will fix. > > + > > + if (p4d_none(*p4d)) > > + break; > > + > > + if (p4d_bad(*p4d)) { > > + printk("(bad)"); > > + break; > > + } > > + > > + pud = pud_offset(p4d, addr); > > if (PTRS_PER_PUD != 1) > > printk(", *pud=%0*Lx", (u32)(sizeof(*pud) * 2), > > (u64)pud_val(*pud)); > > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds -- Sincerely yours, Mike.
next prev parent reply other threads:[~2019-12-17 18:32 UTC|newest] Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-12-17 14:21 [PATCH 0/2] sh: get rid of __ARCH_USE_5LEVEL_HACK Mike Rapoport 2019-12-17 14:21 ` Mike Rapoport 2019-12-17 14:21 ` [PATCH 1/2] sh: drop __pXd_offset() macros that duplicate pXd_index() ones Mike Rapoport 2019-12-17 14:21 ` Mike Rapoport 2019-12-17 14:21 ` [PATCH 2/2] sh: add support for folded p4d page tables Mike Rapoport 2019-12-17 14:21 ` Mike Rapoport 2019-12-17 17:59 ` Geert Uytterhoeven 2019-12-17 17:59 ` Geert Uytterhoeven 2019-12-17 17:59 ` Geert Uytterhoeven 2019-12-17 18:32 ` Mike Rapoport [this message] 2019-12-17 18:32 ` Mike Rapoport 2019-12-17 15:15 ` [PATCH 0/2] sh: get rid of __ARCH_USE_5LEVEL_HACK Rich Felker 2019-12-17 15:15 ` Rich Felker 2019-12-17 15:36 ` Mike Rapoport 2019-12-17 15:36 ` Mike Rapoport
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20191217183213.GA29446@rapoport-lnx \ --to=rppt@kernel.org \ --cc=dalias@libc.org \ --cc=geert@linux-m68k.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mm@kvack.org \ --cc=linux-sh@vger.kernel.org \ --cc=rppt@linux.ibm.com \ --cc=ysato@users.sourceforge.jp \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.