All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Xu <peterx@redhat.com>
To: Sean Christopherson <sean.j.christopherson@intel.com>
Cc: "James Hogan" <jhogan@kernel.org>,
	"Paul Mackerras" <paulus@ozlabs.org>,
	"Christian Borntraeger" <borntraeger@de.ibm.com>,
	"Janosch Frank" <frankja@linux.ibm.com>,
	"Paolo Bonzini" <pbonzini@redhat.com>,
	"Marc Zyngier" <maz@kernel.org>,
	linux-arm-kernel@lists.infradead.org,
	"Wanpeng Li" <wanpengli@tencent.com>,
	"Philippe Mathieu-Daudé" <f4bug@amsat.org>,
	kvm@vger.kernel.org, "David Hildenbrand" <david@redhat.com>,
	"Joerg Roedel" <joro@8bytes.org>,
	"Cornelia Huck" <cohuck@redhat.com>,
	linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org,
	kvm-ppc@vger.kernel.org, "Vitaly Kuznetsov" <vkuznets@redhat.com>,
	kvmarm@lists.cs.columbia.edu, "Jim Mattson" <jmattson@google.com>
Subject: Re: [PATCH v4 05/19] KVM: x86: Allocate memslot resources during prepare_memory_region()
Date: Tue, 17 Dec 2019 17:07:18 -0500	[thread overview]
Message-ID: <20191217220718.GJ7258@xz-x1> (raw)
In-Reply-To: <20191217204041.10815-6-sean.j.christopherson@intel.com>

On Tue, Dec 17, 2019 at 12:40:27PM -0800, Sean Christopherson wrote:
> Allocate the various metadata structures associated with a new memslot
> during kvm_arch_prepare_memory_region(), which paves the way for
> removing kvm_arch_create_memslot() altogether.  Moving x86's memory
> allocation only changes the order of kernel memory allocations between
> x86 and common KVM code.
> 
> No functional change intended.

(I still think it's a functional change, though...)

> 
> Signed-off-by: Sean Christopherson <sean.j.christopherson@intel.com>

Reviewed-by: Peter Xu <peterx@redhat.com>

-- 
Peter Xu


WARNING: multiple messages have this Message-ID (diff)
From: Peter Xu <peterx@redhat.com>
To: Sean Christopherson <sean.j.christopherson@intel.com>
Cc: "Wanpeng Li" <wanpengli@tencent.com>,
	"Janosch Frank" <frankja@linux.ibm.com>,
	kvm@vger.kernel.org, "David Hildenbrand" <david@redhat.com>,
	"James Hogan" <jhogan@kernel.org>,
	"Joerg Roedel" <joro@8bytes.org>,
	"Cornelia Huck" <cohuck@redhat.com>,
	linux-kernel@vger.kernel.org,
	"Philippe Mathieu-Daudé" <f4bug@amsat.org>,
	kvm-ppc@vger.kernel.org, linux-mips@vger.kernel.org,
	"Paul Mackerras" <paulus@ozlabs.org>,
	"Christian Borntraeger" <borntraeger@de.ibm.com>,
	"Marc Zyngier" <maz@kernel.org>,
	"Paolo Bonzini" <pbonzini@redhat.com>,
	"Vitaly Kuznetsov" <vkuznets@redhat.com>,
	kvmarm@lists.cs.columbia.edu,
	linux-arm-kernel@lists.infradead.org,
	"Jim Mattson" <jmattson@google.com>
Subject: Re: [PATCH v4 05/19] KVM: x86: Allocate memslot resources during prepare_memory_region()
Date: Tue, 17 Dec 2019 17:07:18 -0500	[thread overview]
Message-ID: <20191217220718.GJ7258@xz-x1> (raw)
In-Reply-To: <20191217204041.10815-6-sean.j.christopherson@intel.com>

On Tue, Dec 17, 2019 at 12:40:27PM -0800, Sean Christopherson wrote:
> Allocate the various metadata structures associated with a new memslot
> during kvm_arch_prepare_memory_region(), which paves the way for
> removing kvm_arch_create_memslot() altogether.  Moving x86's memory
> allocation only changes the order of kernel memory allocations between
> x86 and common KVM code.
> 
> No functional change intended.

(I still think it's a functional change, though...)

> 
> Signed-off-by: Sean Christopherson <sean.j.christopherson@intel.com>

Reviewed-by: Peter Xu <peterx@redhat.com>

-- 
Peter Xu

_______________________________________________
kvmarm mailing list
kvmarm@lists.cs.columbia.edu
https://lists.cs.columbia.edu/mailman/listinfo/kvmarm

WARNING: multiple messages have this Message-ID (diff)
From: Peter Xu <peterx@redhat.com>
To: Sean Christopherson <sean.j.christopherson@intel.com>
Cc: "Wanpeng Li" <wanpengli@tencent.com>,
	"Janosch Frank" <frankja@linux.ibm.com>,
	kvm@vger.kernel.org, "David Hildenbrand" <david@redhat.com>,
	"James Hogan" <jhogan@kernel.org>,
	"Joerg Roedel" <joro@8bytes.org>,
	"Cornelia Huck" <cohuck@redhat.com>,
	linux-kernel@vger.kernel.org,
	"Philippe Mathieu-Daudé" <f4bug@amsat.org>,
	kvm-ppc@vger.kernel.org, linux-mips@vger.kernel.org,
	"Paul Mackerras" <paulus@ozlabs.org>,
	"Christian Borntraeger" <borntraeger@de.ibm.com>,
	"Marc Zyngier" <maz@kernel.org>,
	"Paolo Bonzini" <pbonzini@redhat.com>,
	"Vitaly Kuznetsov" <vkuznets@redhat.com>,
	kvmarm@lists.cs.columbia.edu,
	linux-arm-kernel@lists.infradead.org,
	"Jim Mattson" <jmattson@google.com>
Subject: Re: [PATCH v4 05/19] KVM: x86: Allocate memslot resources during prepare_memory_region()
Date: Tue, 17 Dec 2019 17:07:18 -0500	[thread overview]
Message-ID: <20191217220718.GJ7258@xz-x1> (raw)
In-Reply-To: <20191217204041.10815-6-sean.j.christopherson@intel.com>

On Tue, Dec 17, 2019 at 12:40:27PM -0800, Sean Christopherson wrote:
> Allocate the various metadata structures associated with a new memslot
> during kvm_arch_prepare_memory_region(), which paves the way for
> removing kvm_arch_create_memslot() altogether.  Moving x86's memory
> allocation only changes the order of kernel memory allocations between
> x86 and common KVM code.
> 
> No functional change intended.

(I still think it's a functional change, though...)

> 
> Signed-off-by: Sean Christopherson <sean.j.christopherson@intel.com>

Reviewed-by: Peter Xu <peterx@redhat.com>

-- 
Peter Xu


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Peter Xu <peterx@redhat.com>
To: Sean Christopherson <sean.j.christopherson@intel.com>
Cc: "James Hogan" <jhogan@kernel.org>,
	"Paul Mackerras" <paulus@ozlabs.org>,
	"Christian Borntraeger" <borntraeger@de.ibm.com>,
	"Janosch Frank" <frankja@linux.ibm.com>,
	"Paolo Bonzini" <pbonzini@redhat.com>,
	"Marc Zyngier" <maz@kernel.org>,
	linux-arm-kernel@lists.infradead.org,
	"Wanpeng Li" <wanpengli@tencent.com>,
	"Philippe Mathieu-Daudé" <f4bug@amsat.org>,
	kvm@vger.kernel.org, "David Hildenbrand" <david@redhat.com>,
	"Joerg Roedel" <joro@8bytes.org>,
	"Cornelia Huck" <cohuck@redhat.com>,
	linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org,
	kvm-ppc@vger.kernel.org, "Vitaly Kuznetsov" <vkuznets@redhat.com>,
	kvmarm@lists.cs.columbia.edu, "Jim Mattson" <jmattson@google.com>
Subject: Re: [PATCH v4 05/19] KVM: x86: Allocate memslot resources during prepare_memory_region()
Date: Tue, 17 Dec 2019 22:07:18 +0000	[thread overview]
Message-ID: <20191217220718.GJ7258@xz-x1> (raw)
In-Reply-To: <20191217204041.10815-6-sean.j.christopherson@intel.com>

On Tue, Dec 17, 2019 at 12:40:27PM -0800, Sean Christopherson wrote:
> Allocate the various metadata structures associated with a new memslot
> during kvm_arch_prepare_memory_region(), which paves the way for
> removing kvm_arch_create_memslot() altogether.  Moving x86's memory
> allocation only changes the order of kernel memory allocations between
> x86 and common KVM code.
> 
> No functional change intended.

(I still think it's a functional change, though...)

> 
> Signed-off-by: Sean Christopherson <sean.j.christopherson@intel.com>

Reviewed-by: Peter Xu <peterx@redhat.com>

-- 
Peter Xu

  reply	other threads:[~2019-12-17 22:07 UTC|newest]

Thread overview: 160+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-17 20:40 [PATCH v4 00/19] KVM: Dynamically size memslot arrays Sean Christopherson
2019-12-17 20:40 ` Sean Christopherson
2019-12-17 20:40 ` Sean Christopherson
2019-12-17 20:40 ` Sean Christopherson
2019-12-17 20:40 ` [PATCH v4 01/19] KVM: x86: Allocate new rmap and large page tracking when moving memslot Sean Christopherson
2019-12-17 20:40   ` Sean Christopherson
2019-12-17 20:40   ` Sean Christopherson
2019-12-17 20:40   ` Sean Christopherson
2019-12-17 20:48   ` Sean Christopherson
2019-12-17 20:48     ` Sean Christopherson
2019-12-17 20:48     ` Sean Christopherson
2019-12-17 20:48     ` Sean Christopherson
2019-12-17 20:50     ` Sean Christopherson
2019-12-17 21:56   ` Peter Xu
2019-12-17 21:56     ` Peter Xu
2019-12-17 21:56     ` Peter Xu
2019-12-17 21:56     ` Peter Xu
2019-12-17 22:20     ` Sean Christopherson
2019-12-17 22:20       ` Sean Christopherson
2019-12-17 22:20       ` Sean Christopherson
2019-12-17 22:20       ` Sean Christopherson
2019-12-17 22:37       ` Peter Xu
2019-12-17 22:37         ` Peter Xu
2019-12-17 22:37         ` Peter Xu
2019-12-17 22:37         ` Peter Xu
2019-12-17 20:40 ` [PATCH v4 02/19] KVM: Reinstall old memslots if arch preparation fails Sean Christopherson
2019-12-17 20:40   ` Sean Christopherson
2019-12-17 20:40   ` Sean Christopherson
2019-12-17 20:40   ` Sean Christopherson
2019-12-17 20:40 ` [PATCH v4 03/19] KVM: Don't free new memslot if allocation of said memslot fails Sean Christopherson
2019-12-17 20:40   ` Sean Christopherson
2019-12-17 20:40   ` Sean Christopherson
2019-12-17 20:40   ` Sean Christopherson
2019-12-17 20:40 ` [PATCH v4 04/19] KVM: PPC: Move memslot memory allocation into prepare_memory_region() Sean Christopherson
2019-12-17 20:40   ` Sean Christopherson
2019-12-17 20:40   ` Sean Christopherson
2019-12-17 20:40   ` Sean Christopherson
2019-12-17 20:40 ` [PATCH v4 05/19] KVM: x86: Allocate memslot resources during prepare_memory_region() Sean Christopherson
2019-12-17 20:40   ` Sean Christopherson
2019-12-17 20:40   ` Sean Christopherson
2019-12-17 20:40   ` Sean Christopherson
2019-12-17 22:07   ` Peter Xu [this message]
2019-12-17 22:07     ` Peter Xu
2019-12-17 22:07     ` Peter Xu
2019-12-17 22:07     ` Peter Xu
2019-12-17 20:40 ` [PATCH v4 06/19] KVM: Drop kvm_arch_create_memslot() Sean Christopherson
2019-12-17 20:40   ` Sean Christopherson
2019-12-17 20:40   ` Sean Christopherson
2019-12-17 20:40   ` Sean Christopherson
2019-12-17 20:40 ` [PATCH v4 07/19] KVM: Explicitly free allocated-but-unused dirty bitmap Sean Christopherson
2019-12-17 20:40   ` Sean Christopherson
2019-12-17 20:40   ` Sean Christopherson
2019-12-17 20:40   ` Sean Christopherson
2019-12-17 22:24   ` Peter Xu
2019-12-17 22:24     ` Peter Xu
2019-12-17 22:24     ` Peter Xu
2019-12-17 22:24     ` Peter Xu
2019-12-17 22:51     ` Sean Christopherson
2019-12-17 22:51       ` Sean Christopherson
2019-12-17 22:51       ` Sean Christopherson
2019-12-17 22:51       ` Sean Christopherson
2019-12-18 16:17       ` Peter Xu
2019-12-18 16:17         ` Peter Xu
2019-12-18 16:17         ` Peter Xu
2019-12-18 16:17         ` Peter Xu
2019-12-17 20:40 ` [PATCH v4 08/19] KVM: Refactor error handling for setting memory region Sean Christopherson
2019-12-17 20:40   ` Sean Christopherson
2019-12-17 20:40   ` Sean Christopherson
2019-12-17 20:40   ` Sean Christopherson
2019-12-17 20:40 ` [PATCH v4 09/19] KVM: Move setting of memslot into helper routine Sean Christopherson
2019-12-17 20:40   ` Sean Christopherson
2019-12-17 20:40   ` Sean Christopherson
2019-12-17 20:40   ` Sean Christopherson
2019-12-17 20:40 ` [PATCH v4 10/19] KVM: Drop "const" attribute from old memslot in commit_memory_region() Sean Christopherson
2019-12-17 20:40   ` Sean Christopherson
2019-12-17 20:40   ` Sean Christopherson
2019-12-17 20:40   ` Sean Christopherson
2019-12-17 20:40 ` [PATCH v4 11/19] KVM: x86: Free arrays for old memslot when moving memslot's base gfn Sean Christopherson
2019-12-17 20:40   ` Sean Christopherson
2019-12-17 20:40   ` Sean Christopherson
2019-12-17 20:40   ` Sean Christopherson
2019-12-17 22:48   ` Peter Xu
2019-12-17 22:48     ` Peter Xu
2019-12-17 22:48     ` Peter Xu
2019-12-17 22:48     ` Peter Xu
2019-12-17 20:40 ` [PATCH v4 12/19] KVM: Move memslot deletion to helper function Sean Christopherson
2019-12-17 20:40   ` Sean Christopherson
2019-12-17 20:40   ` Sean Christopherson
2019-12-17 20:40   ` Sean Christopherson
2019-12-17 20:40 ` [PATCH v4 13/19] KVM: Simplify kvm_free_memslot() and all its descendents Sean Christopherson
2019-12-17 20:40   ` Sean Christopherson
2019-12-17 20:40   ` Sean Christopherson
2019-12-17 20:40   ` Sean Christopherson
2019-12-17 20:40 ` [PATCH v4 14/19] KVM: Clean up local variable usage in __kvm_set_memory_region() Sean Christopherson
2019-12-17 20:40   ` Sean Christopherson
2019-12-17 20:40   ` Sean Christopherson
2019-12-17 20:40   ` Sean Christopherson
2019-12-17 20:40 ` [PATCH v4 15/19] KVM: Provide common implementation for generic dirty log functions Sean Christopherson
2019-12-17 20:40   ` Sean Christopherson
2019-12-17 20:40   ` Sean Christopherson
2019-12-17 20:40   ` Sean Christopherson
2019-12-17 20:40 ` [PATCH v4 16/19] KVM: Ensure validity of memslot with respect to kvm_get_dirty_log() Sean Christopherson
2019-12-17 20:40   ` Sean Christopherson
2019-12-17 20:40   ` Sean Christopherson
2019-12-17 20:40   ` Sean Christopherson
2019-12-24 18:19   ` Peter Xu
2019-12-24 18:19     ` Peter Xu
2019-12-24 18:19     ` Peter Xu
2019-12-24 18:19     ` Peter Xu
2020-01-14 18:25     ` Sean Christopherson
2020-01-14 18:25       ` Sean Christopherson
2020-01-14 18:25       ` Sean Christopherson
2020-01-14 18:25       ` Sean Christopherson
2020-02-06 22:03       ` Peter Xu
2020-02-06 22:03         ` Peter Xu
2020-02-06 22:03         ` Peter Xu
2020-02-06 22:03         ` Peter Xu
2020-02-07 18:52         ` Sean Christopherson
2020-02-07 18:52           ` Sean Christopherson
2020-02-07 18:52           ` Sean Christopherson
2020-02-07 18:52           ` Sean Christopherson
2019-12-17 20:40 ` [PATCH v4 17/19] KVM: Terminate memslot walks via used_slots Sean Christopherson
2019-12-17 20:40   ` Sean Christopherson
2019-12-17 20:40   ` Sean Christopherson
2019-12-17 20:40   ` Sean Christopherson
2019-12-17 20:40 ` [PATCH v4 18/19] KVM: Dynamically size memslot array based on number of used slots Sean Christopherson
2019-12-17 20:40   ` Sean Christopherson
2019-12-17 20:40   ` Sean Christopherson
2019-12-17 20:40   ` Sean Christopherson
2019-12-17 20:40 ` [PATCH v4 19/19] KVM: selftests: Add test for KVM_SET_USER_MEMORY_REGION Sean Christopherson
2019-12-17 20:40   ` Sean Christopherson
2019-12-17 20:40   ` Sean Christopherson
2019-12-17 20:40   ` Sean Christopherson
2019-12-18 11:29   ` Christian Borntraeger
2019-12-18 11:29     ` Christian Borntraeger
2019-12-18 11:29     ` Christian Borntraeger
2019-12-18 11:29     ` Christian Borntraeger
2019-12-18 11:39   ` Christian Borntraeger
2019-12-18 11:39     ` Christian Borntraeger
2019-12-18 11:39     ` Christian Borntraeger
2019-12-18 11:39     ` Christian Borntraeger
2019-12-18 16:39     ` Sean Christopherson
2019-12-18 16:39       ` Sean Christopherson
2019-12-18 16:39       ` Sean Christopherson
2019-12-18 16:39       ` Sean Christopherson
2020-03-24  9:43       ` Christian Borntraeger
2020-03-24  9:43         ` Christian Borntraeger
2020-03-24  9:43         ` Christian Borntraeger
2020-03-24  9:43         ` Christian Borntraeger
2020-03-24 18:20         ` Sean Christopherson
2020-03-24 18:20           ` Sean Christopherson
2020-03-24 18:20           ` Sean Christopherson
2020-03-24 18:20           ` Sean Christopherson
2019-12-18 11:40 ` [PATCH v4 00/19] KVM: Dynamically size memslot arrays Christian Borntraeger
2019-12-18 11:40   ` Christian Borntraeger
2019-12-18 11:40   ` Christian Borntraeger
2019-12-18 11:40   ` Christian Borntraeger
2019-12-18 18:10 ` Marc Zyngier
2019-12-18 18:10   ` Marc Zyngier
2019-12-18 18:10   ` Marc Zyngier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191217220718.GJ7258@xz-x1 \
    --to=peterx@redhat.com \
    --cc=borntraeger@de.ibm.com \
    --cc=cohuck@redhat.com \
    --cc=david@redhat.com \
    --cc=f4bug@amsat.org \
    --cc=frankja@linux.ibm.com \
    --cc=jhogan@kernel.org \
    --cc=jmattson@google.com \
    --cc=joro@8bytes.org \
    --cc=kvm-ppc@vger.kernel.org \
    --cc=kvm@vger.kernel.org \
    --cc=kvmarm@lists.cs.columbia.edu \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mips@vger.kernel.org \
    --cc=maz@kernel.org \
    --cc=paulus@ozlabs.org \
    --cc=pbonzini@redhat.com \
    --cc=sean.j.christopherson@intel.com \
    --cc=vkuznets@redhat.com \
    --cc=wanpengli@tencent.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.