From: Arvind Sankar <nivedita@alum.mit.edu>
To: Tom Murphy <murphyt7@tcd.ie>
Cc: iommu@lists.linux-foundation.org,
Jani Nikula <jani.nikula@linux.intel.com>,
Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
Rodrigo Vivi <rodrigo.vivi@intel.com>,
David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
Joerg Roedel <joro@8bytes.org>, Will Deacon <will@kernel.org>,
Robin Murphy <robin.murphy@arm.com>,
Marek Szyprowski <m.szyprowski@samsung.com>,
Kukjin Kim <kgene@kernel.org>,
Krzysztof Kozlowski <krzk@kernel.org>,
David Woodhouse <dwmw2@infradead.org>,
Lu Baolu <baolu.lu@linux.intel.com>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
Rob Clark <robdclark@gmail.com>, Heiko Stuebner <heiko@sntech.de>,
Gerald Schaefer <gerald.schaefer@de.ibm.>
Subject: Re: [PATCH 1/8] iommu/vt-d: clean up 32bit si_domain assignment
Date: Sat, 21 Dec 2019 18:46:37 -0500 [thread overview]
Message-ID: <20191221234635.GA99623@rani.riverdale.lan> (raw)
In-Reply-To: <20191221150402.13868-2-murphyt7@tcd.ie>
On Sat, Dec 21, 2019 at 03:03:53PM +0000, Tom Murphy wrote:
> In the intel iommu driver devices which only support 32bit DMA can't be
> direct mapped. The implementation of this is weird. Currently we assign
> it a direct mapped domain and then remove the domain later and replace
> it with a domain of type IOMMU_DOMAIN_IDENTITY. We should just assign it
> a domain of type IOMMU_DOMAIN_IDENTITY from the begging rather than
> needlessly swapping domains.
>
> Signed-off-by: Tom Murphy <murphyt7@tcd.ie>
> ---
> drivers/iommu/intel-iommu.c | 88 +++++++++++++------------------------
> 1 file changed, 31 insertions(+), 57 deletions(-)
>
> diff --git a/drivers/iommu/intel-iommu.c b/drivers/iommu/intel-iommu.c
> index 0c8d81f56a30..c1ea66467918 100644
> --- a/drivers/iommu/intel-iommu.c
> +++ b/drivers/iommu/intel-iommu.c
> @@ -5640,7 +5609,12 @@ static int intel_iommu_add_device(struct device *dev)
> domain = iommu_get_domain_for_dev(dev);
> dmar_domain = to_dmar_domain(domain);
> if (domain->type == IOMMU_DOMAIN_DMA) {
> - if (device_def_domain_type(dev) == IOMMU_DOMAIN_IDENTITY) {
> + /*
> + * We check dma_mask >= dma_get_required_mask(dev) because
> + * 32 bit DMA falls back to non-identity mapping.
> + */
> + if (device_def_domain_type(dev) == IOMMU_DOMAIN_IDENTITY &&
> + dma_mask >= dma_get_required_mask(dev)) {
> ret = iommu_request_dm_for_dev(dev);
> if (ret) {
> dmar_remove_one_dev_info(dev);
> --
> 2.20.1
>
Should this be dma_direct_get_required_mask? dma_get_required_mask may
return DMA_BIT_MASK(32) -- it callbacks into intel_get_required_mask,
but I'm not sure what iommu_no_mapping(dev) will do at this point?
WARNING: multiple messages have this Message-ID (diff)
From: Arvind Sankar <nivedita@alum.mit.edu>
To: Tom Murphy <murphyt7@tcd.ie>
Cc: iommu@lists.linux-foundation.org,
Jani Nikula <jani.nikula@linux.intel.com>,
Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
Rodrigo Vivi <rodrigo.vivi@intel.com>,
David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
Joerg Roedel <joro@8bytes.org>, Will Deacon <will@kernel.org>,
Robin Murphy <robin.murphy@arm.com>,
Marek Szyprowski <m.szyprowski@samsung.com>,
Kukjin Kim <kgene@kernel.org>,
Krzysztof Kozlowski <krzk@kernel.org>,
David Woodhouse <dwmw2@infradead.org>,
Lu Baolu <baolu.lu@linux.intel.com>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
Rob Clark <robdclark@gmail.com>, Heiko Stuebner <heiko@sntech.de>,
Gerald Schaefer <gerald.schaefer@de.ibm.com>,
Thierry Reding <thierry.reding@gmail.com>,
Jonathan Hunter <jonathanh@nvidia.com>,
Jean-Philippe Brucker <jean-philippe@linaro.org>,
Alex Williamson <alex.williamson@redhat.com>,
Cornelia Huck <cohuck@redhat.com>,
Eric Auger <eric.auger@redhat.com>,
Julien Grall <julien.grall@arm.com>,
Marc Zyngier <maz@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-mediatek@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-s390@vger.kernel.org,
linux-tegra@vger.kernel.org,
virtualization@lists.linux-foundation.org, kvm@vger.kernel.org
Subject: Re: [PATCH 1/8] iommu/vt-d: clean up 32bit si_domain assignment
Date: Sat, 21 Dec 2019 18:46:37 -0500 [thread overview]
Message-ID: <20191221234635.GA99623@rani.riverdale.lan> (raw)
In-Reply-To: <20191221150402.13868-2-murphyt7@tcd.ie>
On Sat, Dec 21, 2019 at 03:03:53PM +0000, Tom Murphy wrote:
> In the intel iommu driver devices which only support 32bit DMA can't be
> direct mapped. The implementation of this is weird. Currently we assign
> it a direct mapped domain and then remove the domain later and replace
> it with a domain of type IOMMU_DOMAIN_IDENTITY. We should just assign it
> a domain of type IOMMU_DOMAIN_IDENTITY from the begging rather than
> needlessly swapping domains.
>
> Signed-off-by: Tom Murphy <murphyt7@tcd.ie>
> ---
> drivers/iommu/intel-iommu.c | 88 +++++++++++++------------------------
> 1 file changed, 31 insertions(+), 57 deletions(-)
>
> diff --git a/drivers/iommu/intel-iommu.c b/drivers/iommu/intel-iommu.c
> index 0c8d81f56a30..c1ea66467918 100644
> --- a/drivers/iommu/intel-iommu.c
> +++ b/drivers/iommu/intel-iommu.c
> @@ -5640,7 +5609,12 @@ static int intel_iommu_add_device(struct device *dev)
> domain = iommu_get_domain_for_dev(dev);
> dmar_domain = to_dmar_domain(domain);
> if (domain->type == IOMMU_DOMAIN_DMA) {
> - if (device_def_domain_type(dev) == IOMMU_DOMAIN_IDENTITY) {
> + /*
> + * We check dma_mask >= dma_get_required_mask(dev) because
> + * 32 bit DMA falls back to non-identity mapping.
> + */
> + if (device_def_domain_type(dev) == IOMMU_DOMAIN_IDENTITY &&
> + dma_mask >= dma_get_required_mask(dev)) {
> ret = iommu_request_dm_for_dev(dev);
> if (ret) {
> dmar_remove_one_dev_info(dev);
> --
> 2.20.1
>
Should this be dma_direct_get_required_mask? dma_get_required_mask may
return DMA_BIT_MASK(32) -- it callbacks into intel_get_required_mask,
but I'm not sure what iommu_no_mapping(dev) will do at this point?
WARNING: multiple messages have this Message-ID (diff)
From: Arvind Sankar <nivedita@alum.mit.edu>
To: Tom Murphy <murphyt7@tcd.ie>
Cc: Heiko Stuebner <heiko@sntech.de>,
kvm@vger.kernel.org, David Airlie <airlied@linux.ie>,
Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
dri-devel@lists.freedesktop.org,
Bjorn Andersson <bjorn.andersson@linaro.org>,
linux-tegra@vger.kernel.org, Julien Grall <julien.grall@arm.com>,
Thierry Reding <thierry.reding@gmail.com>,
Will Deacon <will@kernel.org>,
Jean-Philippe Brucker <jean-philippe@linaro.org>,
linux-samsung-soc@vger.kernel.org, Marc Zyngier <maz@kernel.org>,
iommu@lists.linux-foundation.org,
Krzysztof Kozlowski <krzk@kernel.org>,
Jonathan Hunter <jonathanh@nvidia.com>,
linux-rockchip@lists.infradead.org,
Andy Gross <agross@kernel.org>,
linux-arm-kernel@lists.infradead.org, linux-s390@vger.kernel.org,
linux-arm-msm@vger.kernel.org, intel-gfx@lists.freedesktop.org,
Jani Nikula <jani.nikula@linux.intel.com>,
Alex Williamson <alex.williamson@redhat.com>,
linux-mediatek@lists.infradead.org,
Rodrigo Vivi <rodrigo.vivi@intel.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
Thomas Gleixner <tglx@linutronix.de>,
virtualization@lists.linux-foundation.org,
Gerald Schaefer <gerald.schaefer@de.ibm.com>,
David Woodhouse <dwmw2@infradead.org>,
Cornelia Huck <cohuck@redhat.com>,
linux-kernel@vger.kernel.org, Kukjin Kim <kgene@kernel.org>,
Daniel Vetter <daniel@ffwll.ch>,
Robin Murphy <robin.murphy@arm.com>
Subject: Re: [PATCH 1/8] iommu/vt-d: clean up 32bit si_domain assignment
Date: Sat, 21 Dec 2019 18:46:37 -0500 [thread overview]
Message-ID: <20191221234635.GA99623@rani.riverdale.lan> (raw)
In-Reply-To: <20191221150402.13868-2-murphyt7@tcd.ie>
On Sat, Dec 21, 2019 at 03:03:53PM +0000, Tom Murphy wrote:
> In the intel iommu driver devices which only support 32bit DMA can't be
> direct mapped. The implementation of this is weird. Currently we assign
> it a direct mapped domain and then remove the domain later and replace
> it with a domain of type IOMMU_DOMAIN_IDENTITY. We should just assign it
> a domain of type IOMMU_DOMAIN_IDENTITY from the begging rather than
> needlessly swapping domains.
>
> Signed-off-by: Tom Murphy <murphyt7@tcd.ie>
> ---
> drivers/iommu/intel-iommu.c | 88 +++++++++++++------------------------
> 1 file changed, 31 insertions(+), 57 deletions(-)
>
> diff --git a/drivers/iommu/intel-iommu.c b/drivers/iommu/intel-iommu.c
> index 0c8d81f56a30..c1ea66467918 100644
> --- a/drivers/iommu/intel-iommu.c
> +++ b/drivers/iommu/intel-iommu.c
> @@ -5640,7 +5609,12 @@ static int intel_iommu_add_device(struct device *dev)
> domain = iommu_get_domain_for_dev(dev);
> dmar_domain = to_dmar_domain(domain);
> if (domain->type == IOMMU_DOMAIN_DMA) {
> - if (device_def_domain_type(dev) == IOMMU_DOMAIN_IDENTITY) {
> + /*
> + * We check dma_mask >= dma_get_required_mask(dev) because
> + * 32 bit DMA falls back to non-identity mapping.
> + */
> + if (device_def_domain_type(dev) == IOMMU_DOMAIN_IDENTITY &&
> + dma_mask >= dma_get_required_mask(dev)) {
> ret = iommu_request_dm_for_dev(dev);
> if (ret) {
> dmar_remove_one_dev_info(dev);
> --
> 2.20.1
>
Should this be dma_direct_get_required_mask? dma_get_required_mask may
return DMA_BIT_MASK(32) -- it callbacks into intel_get_required_mask,
but I'm not sure what iommu_no_mapping(dev) will do at this point?
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
WARNING: multiple messages have this Message-ID (diff)
From: Arvind Sankar <nivedita@alum.mit.edu>
To: Tom Murphy <murphyt7@tcd.ie>
Cc: Heiko Stuebner <heiko@sntech.de>,
kvm@vger.kernel.org, David Airlie <airlied@linux.ie>,
Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
dri-devel@lists.freedesktop.org,
Bjorn Andersson <bjorn.andersson@linaro.org>,
linux-tegra@vger.kernel.org, Julien Grall <julien.grall@arm.com>,
Thierry Reding <thierry.reding@gmail.com>,
Will Deacon <will@kernel.org>,
Marek Szyprowski <m.szyprowski@samsung.com>,
Jean-Philippe Brucker <jean-philippe@linaro.org>,
linux-samsung-soc@vger.kernel.org, Marc Zyngier <maz@kernel.org>,
Joerg Roedel <joro@8bytes.org>,
iommu@lists.linux-foundation.org,
Krzysztof Kozlowski <krzk@kernel.org>,
Jonathan Hunter <jonathanh@nvidia.com>,
linux-rockchip@lists.infradead.org,
Andy Gross <agross@kernel.org>,
linux-arm-kernel@lists.infradead.org, linux-s390@vger.kernel.org,
linux-arm-msm@vger.kernel.org, intel-gfx@lists.freedesktop.org,
Jani Nikula <jani.nikula@linux.intel.com>,
Eric Auger <eric.auger@redhat.com>,
Alex Williamson <alex.williamson@redhat.com>,
linux-mediatek@lists.infradead.org,
Rodrigo Vivi <rodrigo.vivi@intel.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
Thomas Gleixner <tglx@linutronix.de>,
virtualization@lists.linux-foundation.org,
Gerald Schaefer <gerald.schaefer@de.ibm.com>,
David Woodhouse <dwmw2@infradead.org>,
Cornelia Huck <cohuck@redhat.com>,
linux-kernel@vger.kernel.org, Rob Clark <robdclark@gmail.com>,
Kukjin Kim <kgene@kernel.org>, Daniel Vetter <daniel@ffwll.ch>,
Robin Murphy <robin.murphy@arm.com>,
Lu Baolu <baolu.lu@linux.intel.com>
Subject: Re: [PATCH 1/8] iommu/vt-d: clean up 32bit si_domain assignment
Date: Sat, 21 Dec 2019 18:46:37 -0500 [thread overview]
Message-ID: <20191221234635.GA99623@rani.riverdale.lan> (raw)
In-Reply-To: <20191221150402.13868-2-murphyt7@tcd.ie>
On Sat, Dec 21, 2019 at 03:03:53PM +0000, Tom Murphy wrote:
> In the intel iommu driver devices which only support 32bit DMA can't be
> direct mapped. The implementation of this is weird. Currently we assign
> it a direct mapped domain and then remove the domain later and replace
> it with a domain of type IOMMU_DOMAIN_IDENTITY. We should just assign it
> a domain of type IOMMU_DOMAIN_IDENTITY from the begging rather than
> needlessly swapping domains.
>
> Signed-off-by: Tom Murphy <murphyt7@tcd.ie>
> ---
> drivers/iommu/intel-iommu.c | 88 +++++++++++++------------------------
> 1 file changed, 31 insertions(+), 57 deletions(-)
>
> diff --git a/drivers/iommu/intel-iommu.c b/drivers/iommu/intel-iommu.c
> index 0c8d81f56a30..c1ea66467918 100644
> --- a/drivers/iommu/intel-iommu.c
> +++ b/drivers/iommu/intel-iommu.c
> @@ -5640,7 +5609,12 @@ static int intel_iommu_add_device(struct device *dev)
> domain = iommu_get_domain_for_dev(dev);
> dmar_domain = to_dmar_domain(domain);
> if (domain->type == IOMMU_DOMAIN_DMA) {
> - if (device_def_domain_type(dev) == IOMMU_DOMAIN_IDENTITY) {
> + /*
> + * We check dma_mask >= dma_get_required_mask(dev) because
> + * 32 bit DMA falls back to non-identity mapping.
> + */
> + if (device_def_domain_type(dev) == IOMMU_DOMAIN_IDENTITY &&
> + dma_mask >= dma_get_required_mask(dev)) {
> ret = iommu_request_dm_for_dev(dev);
> if (ret) {
> dmar_remove_one_dev_info(dev);
> --
> 2.20.1
>
Should this be dma_direct_get_required_mask? dma_get_required_mask may
return DMA_BIT_MASK(32) -- it callbacks into intel_get_required_mask,
but I'm not sure what iommu_no_mapping(dev) will do at this point?
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
WARNING: multiple messages have this Message-ID (diff)
From: Arvind Sankar <nivedita@alum.mit.edu>
To: Tom Murphy <murphyt7@tcd.ie>
Cc: Heiko Stuebner <heiko@sntech.de>,
kvm@vger.kernel.org, David Airlie <airlied@linux.ie>,
Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
dri-devel@lists.freedesktop.org,
Bjorn Andersson <bjorn.andersson@linaro.org>,
linux-tegra@vger.kernel.org, Julien Grall <julien.grall@arm.com>,
Thierry Reding <thierry.reding@gmail.com>,
Will Deacon <will@kernel.org>,
Marek Szyprowski <m.szyprowski@samsung.com>,
Jean-Philippe Brucker <jean-philippe@linaro.org>,
linux-samsung-soc@vger.kernel.org, Marc Zyngier <maz@kernel.org>,
Joerg Roedel <joro@8bytes.org>,
iommu@lists.linux-foundation.org,
Krzysztof Kozlowski <krzk@kernel.org>,
Jonathan Hunter <jonathanh@nvidia.com>,
linux-rockchip@lists.infradead.org,
Andy Gross <agross@kernel.org>,
linux-arm-kernel@lists.infradead.org, linux-s390@vger.kernel.org,
linux-arm-msm@vger.kernel.org, intel-gfx@lists.freedesktop.org,
Jani Nikula <jani.nikula@linux.intel.com>,
Eric Auger <eric.auger@redhat.com>,
Alex Williamson <alex.williamson@redhat.com>,
linux-mediatek@lists.infradead.org,
Rodrigo Vivi <rodrigo.vivi@intel.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
Thomas Gleixner <tglx@linutronix.de>,
virtualization@lists.linux-foundation.org,
Gerald Schaefer <gerald.schaefer@de.ibm.com>,
David Woodhouse <dwmw2@infradead.org>,
Cornelia Huck <cohuck@redhat.com>,
linux-kernel@vger.kernel.org, Rob Clark <robdclark@gmail.com>,
Kukjin Kim <kgene@kernel.org>, Daniel Vetter <daniel@ffwll.ch>,
Robin Murphy <robin.murphy@arm.com>,
Lu Baolu <baolu.lu@linux.intel.com>
Subject: Re: [PATCH 1/8] iommu/vt-d: clean up 32bit si_domain assignment
Date: Sat, 21 Dec 2019 18:46:37 -0500 [thread overview]
Message-ID: <20191221234635.GA99623@rani.riverdale.lan> (raw)
In-Reply-To: <20191221150402.13868-2-murphyt7@tcd.ie>
On Sat, Dec 21, 2019 at 03:03:53PM +0000, Tom Murphy wrote:
> In the intel iommu driver devices which only support 32bit DMA can't be
> direct mapped. The implementation of this is weird. Currently we assign
> it a direct mapped domain and then remove the domain later and replace
> it with a domain of type IOMMU_DOMAIN_IDENTITY. We should just assign it
> a domain of type IOMMU_DOMAIN_IDENTITY from the begging rather than
> needlessly swapping domains.
>
> Signed-off-by: Tom Murphy <murphyt7@tcd.ie>
> ---
> drivers/iommu/intel-iommu.c | 88 +++++++++++++------------------------
> 1 file changed, 31 insertions(+), 57 deletions(-)
>
> diff --git a/drivers/iommu/intel-iommu.c b/drivers/iommu/intel-iommu.c
> index 0c8d81f56a30..c1ea66467918 100644
> --- a/drivers/iommu/intel-iommu.c
> +++ b/drivers/iommu/intel-iommu.c
> @@ -5640,7 +5609,12 @@ static int intel_iommu_add_device(struct device *dev)
> domain = iommu_get_domain_for_dev(dev);
> dmar_domain = to_dmar_domain(domain);
> if (domain->type == IOMMU_DOMAIN_DMA) {
> - if (device_def_domain_type(dev) == IOMMU_DOMAIN_IDENTITY) {
> + /*
> + * We check dma_mask >= dma_get_required_mask(dev) because
> + * 32 bit DMA falls back to non-identity mapping.
> + */
> + if (device_def_domain_type(dev) == IOMMU_DOMAIN_IDENTITY &&
> + dma_mask >= dma_get_required_mask(dev)) {
> ret = iommu_request_dm_for_dev(dev);
> if (ret) {
> dmar_remove_one_dev_info(dev);
> --
> 2.20.1
>
Should this be dma_direct_get_required_mask? dma_get_required_mask may
return DMA_BIT_MASK(32) -- it callbacks into intel_get_required_mask,
but I'm not sure what iommu_no_mapping(dev) will do at this point?
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Arvind Sankar <nivedita@alum.mit.edu>
To: Tom Murphy <murphyt7@tcd.ie>
Cc: kvm@vger.kernel.org, David Airlie <airlied@linux.ie>,
dri-devel@lists.freedesktop.org,
Bjorn Andersson <bjorn.andersson@linaro.org>,
linux-tegra@vger.kernel.org, Julien Grall <julien.grall@arm.com>,
Thierry Reding <thierry.reding@gmail.com>,
Will Deacon <will@kernel.org>,
Marek Szyprowski <m.szyprowski@samsung.com>,
Jean-Philippe Brucker <jean-philippe@linaro.org>,
linux-samsung-soc@vger.kernel.org, Marc Zyngier <maz@kernel.org>,
iommu@lists.linux-foundation.org,
Krzysztof Kozlowski <krzk@kernel.org>,
Jonathan Hunter <jonathanh@nvidia.com>,
linux-rockchip@lists.infradead.org,
Andy Gross <agross@kernel.org>,
linux-arm-kernel@lists.infradead.org, linux-s390@vger.kernel.org,
linux-arm-msm@vger.kernel.org, intel-gfx@lists.freedesktop.org,
Eric Auger <eric.auger@redhat.com>,
Alex Williamson <alex.williamson@redhat.com>,
linux-mediatek@lists.infradead.org,
Rodrigo Vivi <rodrigo.vivi@intel.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
Thomas Gleixner <tglx@linutronix.de>,
virtualization@lists.linux-foundation.org,
Gerald Schaefer <gerald.schaefer@de.ibm.com>,
David Woodhouse <dwmw2@infradead.org>,
Cornelia Huck <cohuck@redhat.com>,
linux-kernel@vger.kernel.org, Kukjin Kim <kgene@kernel.org>,
Robin Murphy <robin.murphy@arm.com>,
Lu Baolu <baolu.lu@linux.intel.com>
Subject: Re: [PATCH 1/8] iommu/vt-d: clean up 32bit si_domain assignment
Date: Sat, 21 Dec 2019 18:46:37 -0500 [thread overview]
Message-ID: <20191221234635.GA99623@rani.riverdale.lan> (raw)
In-Reply-To: <20191221150402.13868-2-murphyt7@tcd.ie>
On Sat, Dec 21, 2019 at 03:03:53PM +0000, Tom Murphy wrote:
> In the intel iommu driver devices which only support 32bit DMA can't be
> direct mapped. The implementation of this is weird. Currently we assign
> it a direct mapped domain and then remove the domain later and replace
> it with a domain of type IOMMU_DOMAIN_IDENTITY. We should just assign it
> a domain of type IOMMU_DOMAIN_IDENTITY from the begging rather than
> needlessly swapping domains.
>
> Signed-off-by: Tom Murphy <murphyt7@tcd.ie>
> ---
> drivers/iommu/intel-iommu.c | 88 +++++++++++++------------------------
> 1 file changed, 31 insertions(+), 57 deletions(-)
>
> diff --git a/drivers/iommu/intel-iommu.c b/drivers/iommu/intel-iommu.c
> index 0c8d81f56a30..c1ea66467918 100644
> --- a/drivers/iommu/intel-iommu.c
> +++ b/drivers/iommu/intel-iommu.c
> @@ -5640,7 +5609,12 @@ static int intel_iommu_add_device(struct device *dev)
> domain = iommu_get_domain_for_dev(dev);
> dmar_domain = to_dmar_domain(domain);
> if (domain->type == IOMMU_DOMAIN_DMA) {
> - if (device_def_domain_type(dev) == IOMMU_DOMAIN_IDENTITY) {
> + /*
> + * We check dma_mask >= dma_get_required_mask(dev) because
> + * 32 bit DMA falls back to non-identity mapping.
> + */
> + if (device_def_domain_type(dev) == IOMMU_DOMAIN_IDENTITY &&
> + dma_mask >= dma_get_required_mask(dev)) {
> ret = iommu_request_dm_for_dev(dev);
> if (ret) {
> dmar_remove_one_dev_info(dev);
> --
> 2.20.1
>
Should this be dma_direct_get_required_mask? dma_get_required_mask may
return DMA_BIT_MASK(32) -- it callbacks into intel_get_required_mask,
but I'm not sure what iommu_no_mapping(dev) will do at this point?
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
WARNING: multiple messages have this Message-ID (diff)
From: Arvind Sankar <nivedita@alum.mit.edu>
To: Tom Murphy <murphyt7@tcd.ie>
Cc: Heiko Stuebner <heiko@sntech.de>,
kvm@vger.kernel.org, David Airlie <airlied@linux.ie>,
dri-devel@lists.freedesktop.org,
Bjorn Andersson <bjorn.andersson@linaro.org>,
linux-tegra@vger.kernel.org, Julien Grall <julien.grall@arm.com>,
Will Deacon <will@kernel.org>,
Marek Szyprowski <m.szyprowski@samsung.com>,
Jean-Philippe Brucker <jean-philippe@linaro.org>,
linux-samsung-soc@vger.kernel.org, Marc Zyngier <maz@kernel.org>,
Joerg Roedel <joro@8bytes.org>,
iommu@lists.linux-foundation.org,
Krzysztof Kozlowski <krzk@kernel.org>,
Jonathan Hunter <jonathanh@nvidia.com>,
linux-rockchip@lists.infradead.org,
Andy Gross <agross@kernel.org>,
linux-arm-kernel@lists.infradead.org, linux-s390@vger.kernel.org,
linux-arm-msm@vger.kernel.org, intel-gfx@lists.freedesktop.org,
Eric Auger <eric.auger@redhat.com>,
linux-mediatek@lists.infradead.org,
Matthias Brugger <matthias.bgg@gmail.com>,
Thomas Gleixner <tglx@linutronix.de>,
virtualization@lists.linux-foundation.org,
Gerald Schaefer <gerald.schaefer@de.ibm.com>,
David Woodhouse <dwmw2@infradead.org>,
Cornelia Huck <cohuck@redhat.com>,
linux-kernel@vger.kernel.org, Kukjin Kim <kgene@kernel.org>,
Robin Murphy <robin.murphy@arm.com>,
Lu Baolu <baolu.lu@linux.intel.com>
Subject: Re: [Intel-gfx] [PATCH 1/8] iommu/vt-d: clean up 32bit si_domain assignment
Date: Sat, 21 Dec 2019 18:46:37 -0500 [thread overview]
Message-ID: <20191221234635.GA99623@rani.riverdale.lan> (raw)
In-Reply-To: <20191221150402.13868-2-murphyt7@tcd.ie>
On Sat, Dec 21, 2019 at 03:03:53PM +0000, Tom Murphy wrote:
> In the intel iommu driver devices which only support 32bit DMA can't be
> direct mapped. The implementation of this is weird. Currently we assign
> it a direct mapped domain and then remove the domain later and replace
> it with a domain of type IOMMU_DOMAIN_IDENTITY. We should just assign it
> a domain of type IOMMU_DOMAIN_IDENTITY from the begging rather than
> needlessly swapping domains.
>
> Signed-off-by: Tom Murphy <murphyt7@tcd.ie>
> ---
> drivers/iommu/intel-iommu.c | 88 +++++++++++++------------------------
> 1 file changed, 31 insertions(+), 57 deletions(-)
>
> diff --git a/drivers/iommu/intel-iommu.c b/drivers/iommu/intel-iommu.c
> index 0c8d81f56a30..c1ea66467918 100644
> --- a/drivers/iommu/intel-iommu.c
> +++ b/drivers/iommu/intel-iommu.c
> @@ -5640,7 +5609,12 @@ static int intel_iommu_add_device(struct device *dev)
> domain = iommu_get_domain_for_dev(dev);
> dmar_domain = to_dmar_domain(domain);
> if (domain->type == IOMMU_DOMAIN_DMA) {
> - if (device_def_domain_type(dev) == IOMMU_DOMAIN_IDENTITY) {
> + /*
> + * We check dma_mask >= dma_get_required_mask(dev) because
> + * 32 bit DMA falls back to non-identity mapping.
> + */
> + if (device_def_domain_type(dev) == IOMMU_DOMAIN_IDENTITY &&
> + dma_mask >= dma_get_required_mask(dev)) {
> ret = iommu_request_dm_for_dev(dev);
> if (ret) {
> dmar_remove_one_dev_info(dev);
> --
> 2.20.1
>
Should this be dma_direct_get_required_mask? dma_get_required_mask may
return DMA_BIT_MASK(32) -- it callbacks into intel_get_required_mask,
but I'm not sure what iommu_no_mapping(dev) will do at this point?
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2019-12-21 23:46 UTC|newest]
Thread overview: 286+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-21 15:03 [PATCH 0/8] Convert the intel iommu driver to the dma-iommu api Tom Murphy
2019-12-21 15:03 ` [Intel-gfx] " Tom Murphy
2019-12-21 15:03 ` Tom Murphy
2019-12-21 15:03 ` Tom Murphy
2019-12-21 15:03 ` Tom Murphy
2019-12-21 15:03 ` Tom Murphy
2019-12-21 15:03 ` Tom Murphy
2019-12-21 15:03 ` [PATCH 1/8] iommu/vt-d: clean up 32bit si_domain assignment Tom Murphy
2019-12-21 15:03 ` [Intel-gfx] " Tom Murphy
2019-12-21 15:03 ` Tom Murphy
2019-12-21 15:03 ` Tom Murphy
2019-12-21 15:03 ` Tom Murphy
2019-12-21 15:03 ` Tom Murphy
2019-12-21 15:03 ` Tom Murphy
2019-12-21 23:46 ` Arvind Sankar [this message]
2019-12-21 23:46 ` [Intel-gfx] " Arvind Sankar
2019-12-21 23:46 ` Arvind Sankar
2019-12-21 23:46 ` Arvind Sankar
2019-12-21 23:46 ` Arvind Sankar
2019-12-21 23:46 ` Arvind Sankar
2019-12-21 23:46 ` Arvind Sankar
2019-12-23 3:00 ` Lu Baolu
2019-12-23 3:00 ` [Intel-gfx] " Lu Baolu
2019-12-23 3:00 ` Lu Baolu
2019-12-23 3:00 ` Lu Baolu
2019-12-23 3:00 ` Lu Baolu
2019-12-23 3:00 ` Lu Baolu
2019-12-23 3:00 ` Lu Baolu
2019-12-21 15:03 ` Tom Murphy
2019-12-21 15:03 ` [PATCH 2/8] iommu/vt-d: Use default dma_direct_* mapping functions for direct mapped devices Tom Murphy
2019-12-21 15:03 ` Tom Murphy
2019-12-21 15:03 ` [Intel-gfx] " Tom Murphy
2019-12-21 15:03 ` Tom Murphy
2019-12-21 15:03 ` Tom Murphy
2019-12-21 15:03 ` Tom Murphy
2019-12-21 15:03 ` Tom Murphy
2019-12-21 15:03 ` Tom Murphy
2019-12-21 15:03 ` [PATCH 3/8] iommu/vt-d: Remove IOVA handling code from non-dma_ops path Tom Murphy
2019-12-21 15:03 ` Tom Murphy
2019-12-21 15:03 ` [Intel-gfx] " Tom Murphy
2019-12-21 15:03 ` Tom Murphy
2019-12-21 15:03 ` Tom Murphy
2019-12-21 15:03 ` Tom Murphy
2019-12-21 15:03 ` Tom Murphy
2019-12-21 15:03 ` Tom Murphy
2020-03-20 6:30 ` Tom Murphy
2020-03-20 6:30 ` [Intel-gfx] " Tom Murphy
2020-03-20 6:30 ` Tom Murphy
2020-03-20 6:30 ` Tom Murphy
2020-03-20 6:30 ` Tom Murphy
2020-03-20 6:30 ` Tom Murphy
2020-03-20 6:30 ` Tom Murphy
2020-03-20 7:06 ` Lu Baolu
2020-03-20 7:06 ` [Intel-gfx] " Lu Baolu
2020-03-20 7:06 ` Lu Baolu
2020-03-20 7:06 ` Lu Baolu
2020-03-20 7:06 ` Lu Baolu
2020-03-20 7:06 ` Lu Baolu
2020-03-20 7:06 ` Lu Baolu
2019-12-21 15:03 ` [PATCH 4/8] iommu: Handle freelists when using deferred flushing in iommu drivers Tom Murphy
2019-12-21 15:03 ` Tom Murphy
2019-12-21 15:03 ` [Intel-gfx] " Tom Murphy
2019-12-21 15:03 ` Tom Murphy
2019-12-21 15:03 ` Tom Murphy
2019-12-21 15:03 ` Tom Murphy
2019-12-21 15:03 ` Tom Murphy
2019-12-21 15:03 ` Tom Murphy
2019-12-21 15:03 ` [PATCH 5/8] iommu: Add iommu_dma_free_cpu_cached_iovas function Tom Murphy
2019-12-21 15:03 ` Tom Murphy
2019-12-21 15:03 ` [Intel-gfx] " Tom Murphy
2019-12-21 15:03 ` Tom Murphy
2019-12-21 15:03 ` Tom Murphy
2019-12-21 15:03 ` Tom Murphy
2019-12-21 15:03 ` Tom Murphy
2019-12-21 15:03 ` Tom Murphy
2019-12-21 15:03 ` [PATCH 6/8] iommu: allow the dma-iommu api to use bounce buffers Tom Murphy
2019-12-21 15:03 ` Tom Murphy
2019-12-21 15:03 ` [Intel-gfx] " Tom Murphy
2019-12-21 15:03 ` Tom Murphy
2019-12-21 15:03 ` Tom Murphy
2019-12-21 15:03 ` Tom Murphy
2019-12-21 15:03 ` Tom Murphy
2019-12-21 15:03 ` Tom Murphy
2019-12-24 10:20 ` kbuild test robot
2019-12-24 10:20 ` kbuild test robot
2019-12-24 10:20 ` [Intel-gfx] " kbuild test robot
2019-12-24 10:20 ` kbuild test robot
2019-12-24 10:20 ` kbuild test robot
2019-12-24 10:20 ` kbuild test robot
2019-12-24 10:20 ` kbuild test robot
2019-12-24 10:20 ` kbuild test robot
2019-12-24 10:20 ` kbuild test robot
2019-12-24 10:20 ` kbuild test robot
2019-12-21 15:03 ` [PATCH 7/8] iommu/vt-d: Convert intel iommu driver to the iommu ops Tom Murphy
2019-12-21 15:03 ` Tom Murphy
2019-12-21 15:03 ` [Intel-gfx] " Tom Murphy
2019-12-21 15:03 ` Tom Murphy
2019-12-21 15:03 ` Tom Murphy
2019-12-21 15:03 ` Tom Murphy
2019-12-21 15:03 ` Tom Murphy
2019-12-21 15:03 ` Tom Murphy
2019-12-21 15:04 ` [PATCH 8/8] DO NOT MERGE: iommu: disable list appending in dma-iommu Tom Murphy
2019-12-21 15:04 ` Tom Murphy
2019-12-21 15:04 ` [Intel-gfx] " Tom Murphy
2019-12-21 15:04 ` Tom Murphy
2019-12-21 15:04 ` Tom Murphy
2019-12-21 15:04 ` Tom Murphy
2019-12-21 15:04 ` Tom Murphy
2019-12-21 15:04 ` Tom Murphy
2019-12-22 2:43 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Convert the intel iommu driver to the dma-iommu api Patchwork
2019-12-22 3:12 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
2019-12-23 10:37 ` [PATCH 0/8] " Jani Nikula
2019-12-23 10:37 ` [Intel-gfx] " Jani Nikula
2019-12-23 10:37 ` Jani Nikula
2019-12-23 10:37 ` Jani Nikula
2019-12-23 10:37 ` Jani Nikula
2019-12-23 10:37 ` Jani Nikula
2019-12-23 10:37 ` Jani Nikula
2019-12-23 10:37 ` Jani Nikula
2019-12-23 11:29 ` Robin Murphy
2019-12-23 11:29 ` Robin Murphy
2019-12-23 11:29 ` [Intel-gfx] " Robin Murphy
2019-12-23 11:29 ` Robin Murphy
2019-12-23 11:29 ` Robin Murphy
2019-12-23 11:29 ` Robin Murphy
2019-12-23 11:29 ` Robin Murphy
2019-12-23 11:29 ` Robin Murphy
2019-12-23 11:41 ` Jani Nikula
2019-12-23 11:41 ` [Intel-gfx] " Jani Nikula
2019-12-23 11:41 ` Jani Nikula
2019-12-23 11:41 ` Jani Nikula
2019-12-23 11:41 ` Jani Nikula
2019-12-23 11:41 ` Jani Nikula
2019-12-23 11:41 ` Jani Nikula
[not found] ` <87o8vzuv4i.fsf-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2020-03-20 6:28 ` Tom Murphy
2020-03-20 6:28 ` [Intel-gfx] " Tom Murphy
2020-03-20 6:28 ` Tom Murphy
2020-03-20 6:28 ` Tom Murphy
2020-03-20 6:28 ` Tom Murphy
2020-03-20 6:28 ` Tom Murphy
2020-03-20 6:28 ` Tom Murphy
2019-12-23 11:41 ` Jani Nikula
2019-12-23 10:37 ` Jani Nikula
2020-05-29 0:00 ` Logan Gunthorpe
2020-05-29 0:00 ` [Intel-gfx] " Logan Gunthorpe
2020-05-29 0:00 ` Logan Gunthorpe
2020-05-29 0:00 ` Logan Gunthorpe
2020-05-29 0:00 ` Logan Gunthorpe
2020-05-29 0:00 ` Logan Gunthorpe
2020-05-29 0:00 ` Logan Gunthorpe
2020-05-29 12:45 ` Christoph Hellwig
2020-05-29 12:45 ` [Intel-gfx] " Christoph Hellwig
2020-05-29 12:45 ` Christoph Hellwig
2020-05-29 12:45 ` Christoph Hellwig
2020-05-29 12:45 ` Christoph Hellwig
2020-05-29 12:45 ` Christoph Hellwig
2020-05-29 19:05 ` Logan Gunthorpe
2020-05-29 19:05 ` [Intel-gfx] " Logan Gunthorpe
2020-05-29 19:05 ` Logan Gunthorpe
2020-05-29 19:05 ` Logan Gunthorpe
2020-05-29 19:05 ` Logan Gunthorpe
2020-05-29 19:05 ` Logan Gunthorpe
2020-05-29 19:05 ` Logan Gunthorpe
[not found] ` <33137cfb-603c-86e8-1091-f36117ecfaf3-OTvnGxWRz7hWk0Htik3J/w@public.gmane.org>
2020-05-29 21:11 ` Marek Szyprowski
2020-05-29 21:11 ` [Intel-gfx] " Marek Szyprowski
2020-05-29 21:11 ` Marek Szyprowski
2020-05-29 21:11 ` Marek Szyprowski
2020-05-29 21:11 ` Marek Szyprowski
2020-05-29 21:11 ` Marek Szyprowski
2020-05-29 21:11 ` Marek Szyprowski
2020-05-29 21:21 ` Logan Gunthorpe
2020-05-29 21:21 ` [Intel-gfx] " Logan Gunthorpe
2020-05-29 21:21 ` Logan Gunthorpe
2020-05-29 21:21 ` Logan Gunthorpe
2020-05-29 21:21 ` Logan Gunthorpe
2020-05-29 21:21 ` Logan Gunthorpe
2020-05-29 21:21 ` Logan Gunthorpe
2020-08-24 0:04 ` Tom Murphy
2020-08-24 0:04 ` [Intel-gfx] " Tom Murphy
2020-08-24 0:04 ` Tom Murphy
2020-08-24 0:04 ` Tom Murphy
2020-08-24 0:04 ` Tom Murphy
2020-08-24 0:04 ` Tom Murphy
2020-08-24 0:04 ` Tom Murphy
2020-08-24 0:04 ` Tom Murphy
2020-08-26 18:26 ` Alex Deucher
2020-08-26 18:26 ` [Intel-gfx] " Alex Deucher
2020-08-26 18:26 ` Alex Deucher
2020-08-26 18:26 ` Alex Deucher
2020-08-26 18:26 ` Alex Deucher
2020-08-26 18:26 ` Alex Deucher
2020-08-26 18:26 ` Alex Deucher
2020-08-26 18:26 ` Alex Deucher
2020-08-26 18:26 ` Alex Deucher
2020-08-27 21:36 ` Logan Gunthorpe
2020-08-27 21:36 ` [Intel-gfx] " Logan Gunthorpe
2020-08-27 21:36 ` Logan Gunthorpe
2020-08-27 21:36 ` Logan Gunthorpe
2020-08-27 21:36 ` Logan Gunthorpe
2020-08-27 21:36 ` Logan Gunthorpe
2020-08-27 21:36 ` Logan Gunthorpe
2020-08-27 23:34 ` Tom Murphy
2020-08-27 23:34 ` [Intel-gfx] " Tom Murphy
2020-08-27 23:34 ` Tom Murphy
2020-08-27 23:34 ` Tom Murphy
2020-08-27 23:34 ` Tom Murphy
2020-08-27 23:34 ` Tom Murphy
2020-08-27 23:34 ` Tom Murphy
2020-08-27 23:34 ` Tom Murphy
2020-09-03 20:26 ` Tom Murphy
2020-09-03 20:26 ` [Intel-gfx] " Tom Murphy
2020-09-03 20:26 ` Tom Murphy
2020-09-03 20:26 ` Tom Murphy
2020-09-03 20:26 ` Tom Murphy
2020-09-03 20:26 ` Tom Murphy
2020-09-03 20:26 ` Tom Murphy
2020-09-03 20:26 ` Tom Murphy
2020-09-08 15:28 ` [Intel-gfx] " Tvrtko Ursulin
2020-09-08 15:28 ` Tvrtko Ursulin
2020-09-08 15:28 ` Tvrtko Ursulin
2020-09-08 15:28 ` Tvrtko Ursulin
2020-09-08 15:28 ` Tvrtko Ursulin
2020-09-08 15:28 ` Tvrtko Ursulin
2020-09-08 15:28 ` Tvrtko Ursulin
2020-09-08 15:44 ` Logan Gunthorpe
2020-09-08 15:44 ` Logan Gunthorpe
2020-09-08 15:44 ` Logan Gunthorpe
2020-09-08 15:44 ` Logan Gunthorpe
2020-09-08 15:44 ` Logan Gunthorpe
2020-09-08 15:44 ` Logan Gunthorpe
2020-09-08 15:44 ` Logan Gunthorpe
2020-09-08 15:56 ` Tvrtko Ursulin
2020-09-08 15:56 ` Tvrtko Ursulin
2020-09-08 15:56 ` Tvrtko Ursulin
2020-09-08 15:56 ` Tvrtko Ursulin
2020-09-08 15:56 ` Tvrtko Ursulin
2020-09-08 15:56 ` Tvrtko Ursulin
2020-09-08 22:43 ` Tom Murphy
2020-09-08 22:43 ` Tom Murphy
2020-09-08 22:43 ` Tom Murphy
2020-09-08 22:43 ` Tom Murphy
2020-09-08 22:43 ` Tom Murphy
2020-09-08 22:43 ` Tom Murphy
2020-09-08 22:43 ` Tom Murphy
2020-09-08 22:43 ` Tom Murphy
2020-09-09 9:16 ` Tvrtko Ursulin
2020-09-09 9:16 ` Tvrtko Ursulin
2020-09-09 9:16 ` Tvrtko Ursulin
2020-09-09 9:16 ` Tvrtko Ursulin
2020-09-09 9:16 ` Tvrtko Ursulin
2020-09-09 9:16 ` Tvrtko Ursulin
2020-09-09 9:16 ` Tvrtko Ursulin
2020-09-09 12:55 ` Tvrtko Ursulin
2020-09-09 12:55 ` Tvrtko Ursulin
2020-09-09 12:55 ` Tvrtko Ursulin
2020-09-09 12:55 ` Tvrtko Ursulin
2020-09-09 12:55 ` Tvrtko Ursulin
2020-09-09 12:55 ` Tvrtko Ursulin
2020-09-10 13:33 ` Tom Murphy
2020-09-10 13:33 ` Tom Murphy
2020-09-10 13:33 ` Tom Murphy
2020-09-10 13:33 ` Tom Murphy
2020-09-10 13:33 ` Tom Murphy
2020-09-10 13:33 ` Tom Murphy
2020-09-10 13:33 ` Tom Murphy
2020-09-10 13:33 ` Tom Murphy
2020-09-10 13:34 ` Tom Murphy
2020-09-10 13:34 ` Tom Murphy
2020-09-10 13:34 ` Tom Murphy
2020-09-10 13:34 ` Tom Murphy
2020-09-10 13:34 ` Tom Murphy
2020-09-10 13:34 ` Tom Murphy
2020-09-10 13:34 ` Tom Murphy
2020-09-10 13:34 ` Tom Murphy
2020-08-26 18:14 ` Robin Murphy
2020-08-26 18:14 ` [Intel-gfx] " Robin Murphy
2020-08-26 18:14 ` Robin Murphy
2020-08-26 18:14 ` Robin Murphy
2020-08-26 18:14 ` Robin Murphy
2020-08-26 18:14 ` Robin Murphy
2020-08-26 18:14 ` Robin Murphy
2020-08-26 18:14 ` Robin Murphy
2020-08-26 18:23 ` Tom Murphy
2020-08-26 18:23 ` [Intel-gfx] " Tom Murphy
2020-08-26 18:23 ` Tom Murphy
2020-08-26 18:23 ` Tom Murphy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191221234635.GA99623@rani.riverdale.lan \
--to=nivedita@alum.mit.edu \
--cc=agross@kernel.org \
--cc=airlied@linux.ie \
--cc=baolu.lu@linux.intel.com \
--cc=bjorn.andersson@linaro.org \
--cc=daniel@ffwll.ch \
--cc=dwmw2@infradead.org \
--cc=gerald.schaefer@de.ibm. \
--cc=heiko@sntech.de \
--cc=iommu@lists.linux-foundation.org \
--cc=jani.nikula@linux.intel.com \
--cc=joonas.lahtinen@linux.intel.com \
--cc=joro@8bytes.org \
--cc=kgene@kernel.org \
--cc=krzk@kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=matthias.bgg@gmail.com \
--cc=murphyt7@tcd.ie \
--cc=robdclark@gmail.com \
--cc=robin.murphy@arm.com \
--cc=rodrigo.vivi@intel.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.