Re: [PATCH 6/6] media: dvb_dummy_frontend: remove 'extern' keyword from declaration

From: Sean Young <sean@mess.org>
To: "Daniel W. S. Almeida" <dwlsalmeida@gmail.com>
Cc: mchehab@kernel.org, gregkh@linuxfoundation.org,
	rfontana@redhat.com, kstewart@linuxfoundation.org,
	tglx@linutronix.de, skhan@linuxfoundation.org,
	linux-kernel-mentees@lists.linuxfoundation.org,
	linux-media@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 6/6] media: dvb_dummy_frontend: remove 'extern' keyword from declaration
Date: Tue, 31 Dec 2019 10:12:31 +0000	[thread overview]
Message-ID: <20191231101230.GF24469@gofer.mess.org> (raw)
In-Reply-To: <20191201161542.69535-7-dwlsalmeida@gmail.com>

Hi Daniel,

On Sun, Dec 01, 2019 at 01:15:42PM -0300, Daniel W. S. Almeida wrote:
> From: "Daniel W. S. Almeida" <dwlsalmeida@gmail.com>
> 
> Fix CHECK:AVOID_EXTERNS: extern prototypes should be avoided in .h files
> by removing it.
> 
> Signed-off-by: Daniel W. S. Almeida <dwlsalmeida@gmail.com>
> ---
>  drivers/media/dvb-frontends/dvb_dummy_fe.h | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/media/dvb-frontends/dvb_dummy_fe.h b/drivers/media/dvb-frontends/dvb_dummy_fe.h
> index 35efe2ce1a88..1c82338e0c8a 100644
> --- a/drivers/media/dvb-frontends/dvb_dummy_fe.h
> +++ b/drivers/media/dvb-frontends/dvb_dummy_fe.h
> @@ -12,9 +12,9 @@
>  #include <media/dvb_frontend.h>
>  
>  #if IS_REACHABLE(CONFIG_DVB_DUMMY_FE)
> -extern struct dvb_frontend *dvb_dummy_fe_ofdm_attach(void);
> -extern struct dvb_frontend *dvb_dummy_fe_qpsk_attach(void);
> -extern struct dvb_frontend *dvb_dummy_fe_qam_attach(void);
> +struct dvb_frontend *dvb_dummy_fe_ofdm_attach(void);
> +struct dvb_frontend *dvb_dummy_fe_qpsk_attach(void);
> +struct dvb_frontend *dvb_dummy_fe_qam_attach(void);

Please add these changes to your patch:
"media: dvb_dummy_fe: Fix ERROR: POINTER_LOCATION"

Every patch should pass the checkpatch --strict test by itself; you
cannot fix checkpatch errors in a patch in a subsequent patch.

Thanks,
Sean

>  #else
>  static inline struct dvb_frontend *dvb_dummy_fe_ofdm_attach(void)
>  {
> -- 
> 2.24.0