From: Rob Herring <robh@kernel.org>
To: Yongqiang Niu <yongqiang.niu@mediatek.com>
Cc: CK Hu <ck.hu@mediatek.com>,
Philipp Zabel <p.zabel@pengutronix.de>,
Matthias Brugger <matthias.bgg@gmail.com>,
David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
Mark Rutland <mark.rutland@arm.com>,
dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org
Subject: Re: [RESEND PATCH v6 01/17] dt-bindings: mediatek: add rdma_fifo_size description for mt8183 display
Date: Fri, 3 Jan 2020 15:26:45 -0700 [thread overview]
Message-ID: <20200103222645.GA24430@bogus> (raw)
In-Reply-To: <1578021148-32413-2-git-send-email-yongqiang.niu@mediatek.com>
On Fri, Jan 03, 2020 at 11:12:12AM +0800, Yongqiang Niu wrote:
> Update device tree binding documention for rdma_fifo_size
Typo. And write complete sentences.
>
> Signed-off-by: Yongqiang Niu <yongqiang.niu@mediatek.com>
> ---
> .../devicetree/bindings/display/mediatek/mediatek,disp.txt | 13 +++++++++++++
> 1 file changed, 13 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,disp.txt b/Documentation/devicetree/bindings/display/mediatek/mediatek,disp.txt
> index 681502e..34bef44 100644
> --- a/Documentation/devicetree/bindings/display/mediatek/mediatek,disp.txt
> +++ b/Documentation/devicetree/bindings/display/mediatek/mediatek,disp.txt
> @@ -70,6 +70,10 @@ Required properties (DMA function blocks):
> argument, see Documentation/devicetree/bindings/iommu/mediatek,iommu.txt
> for details.
>
> +Required properties (DMA function blocks):
> +- mediatek,rdma_fifo_size: rdma fifo size may be different even in same SOC, add this
> + property to the corresponding rdma
s/_/-/
Valid values? Max value?
> +
> Examples:
>
> mmsys: clock-controller@14000000 {
> @@ -211,3 +215,12 @@ od@14023000 {
> power-domains = <&scpsys MT8173_POWER_DOMAIN_MM>;
> clocks = <&mmsys CLK_MM_DISP_OD>;
> };
> +
> +rdma1: rdma@1400c000 {
> + compatible = "mediatek,mt8183-disp-rdma";
> + reg = <0 0x1400c000 0 0x1000>;
> + interrupts = <GIC_SPI 229 IRQ_TYPE_LEVEL_LOW>;
> + power-domains = <&scpsys MT8183_POWER_DOMAIN_DISP>;
> + clocks = <&mmsys CLK_MM_DISP_RDMA1>;
> + mediatek,rdma_fifo_size = <2048>;
> +};
A new property doesn't really warrant a whole new example.
> \ No newline at end of file
^^^
> --
> 1.8.1.1.dirty
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Yongqiang Niu <yongqiang.niu@mediatek.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org,
Philipp Zabel <p.zabel@pengutronix.de>,
David Airlie <airlied@linux.ie>,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
Matthias Brugger <matthias.bgg@gmail.com>,
linux-mediatek@lists.infradead.org,
Daniel Vetter <daniel@ffwll.ch>, CK Hu <ck.hu@mediatek.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [RESEND PATCH v6 01/17] dt-bindings: mediatek: add rdma_fifo_size description for mt8183 display
Date: Fri, 3 Jan 2020 15:26:45 -0700 [thread overview]
Message-ID: <20200103222645.GA24430@bogus> (raw)
In-Reply-To: <1578021148-32413-2-git-send-email-yongqiang.niu@mediatek.com>
On Fri, Jan 03, 2020 at 11:12:12AM +0800, Yongqiang Niu wrote:
> Update device tree binding documention for rdma_fifo_size
Typo. And write complete sentences.
>
> Signed-off-by: Yongqiang Niu <yongqiang.niu@mediatek.com>
> ---
> .../devicetree/bindings/display/mediatek/mediatek,disp.txt | 13 +++++++++++++
> 1 file changed, 13 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,disp.txt b/Documentation/devicetree/bindings/display/mediatek/mediatek,disp.txt
> index 681502e..34bef44 100644
> --- a/Documentation/devicetree/bindings/display/mediatek/mediatek,disp.txt
> +++ b/Documentation/devicetree/bindings/display/mediatek/mediatek,disp.txt
> @@ -70,6 +70,10 @@ Required properties (DMA function blocks):
> argument, see Documentation/devicetree/bindings/iommu/mediatek,iommu.txt
> for details.
>
> +Required properties (DMA function blocks):
> +- mediatek,rdma_fifo_size: rdma fifo size may be different even in same SOC, add this
> + property to the corresponding rdma
s/_/-/
Valid values? Max value?
> +
> Examples:
>
> mmsys: clock-controller@14000000 {
> @@ -211,3 +215,12 @@ od@14023000 {
> power-domains = <&scpsys MT8173_POWER_DOMAIN_MM>;
> clocks = <&mmsys CLK_MM_DISP_OD>;
> };
> +
> +rdma1: rdma@1400c000 {
> + compatible = "mediatek,mt8183-disp-rdma";
> + reg = <0 0x1400c000 0 0x1000>;
> + interrupts = <GIC_SPI 229 IRQ_TYPE_LEVEL_LOW>;
> + power-domains = <&scpsys MT8183_POWER_DOMAIN_DISP>;
> + clocks = <&mmsys CLK_MM_DISP_RDMA1>;
> + mediatek,rdma_fifo_size = <2048>;
> +};
A new property doesn't really warrant a whole new example.
> \ No newline at end of file
^^^
> --
> 1.8.1.1.dirty
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Yongqiang Niu <yongqiang.niu@mediatek.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org,
Philipp Zabel <p.zabel@pengutronix.de>,
David Airlie <airlied@linux.ie>,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
Matthias Brugger <matthias.bgg@gmail.com>,
linux-mediatek@lists.infradead.org,
Daniel Vetter <daniel@ffwll.ch>, CK Hu <ck.hu@mediatek.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [RESEND PATCH v6 01/17] dt-bindings: mediatek: add rdma_fifo_size description for mt8183 display
Date: Fri, 3 Jan 2020 15:26:45 -0700 [thread overview]
Message-ID: <20200103222645.GA24430@bogus> (raw)
In-Reply-To: <1578021148-32413-2-git-send-email-yongqiang.niu@mediatek.com>
On Fri, Jan 03, 2020 at 11:12:12AM +0800, Yongqiang Niu wrote:
> Update device tree binding documention for rdma_fifo_size
Typo. And write complete sentences.
>
> Signed-off-by: Yongqiang Niu <yongqiang.niu@mediatek.com>
> ---
> .../devicetree/bindings/display/mediatek/mediatek,disp.txt | 13 +++++++++++++
> 1 file changed, 13 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,disp.txt b/Documentation/devicetree/bindings/display/mediatek/mediatek,disp.txt
> index 681502e..34bef44 100644
> --- a/Documentation/devicetree/bindings/display/mediatek/mediatek,disp.txt
> +++ b/Documentation/devicetree/bindings/display/mediatek/mediatek,disp.txt
> @@ -70,6 +70,10 @@ Required properties (DMA function blocks):
> argument, see Documentation/devicetree/bindings/iommu/mediatek,iommu.txt
> for details.
>
> +Required properties (DMA function blocks):
> +- mediatek,rdma_fifo_size: rdma fifo size may be different even in same SOC, add this
> + property to the corresponding rdma
s/_/-/
Valid values? Max value?
> +
> Examples:
>
> mmsys: clock-controller@14000000 {
> @@ -211,3 +215,12 @@ od@14023000 {
> power-domains = <&scpsys MT8173_POWER_DOMAIN_MM>;
> clocks = <&mmsys CLK_MM_DISP_OD>;
> };
> +
> +rdma1: rdma@1400c000 {
> + compatible = "mediatek,mt8183-disp-rdma";
> + reg = <0 0x1400c000 0 0x1000>;
> + interrupts = <GIC_SPI 229 IRQ_TYPE_LEVEL_LOW>;
> + power-domains = <&scpsys MT8183_POWER_DOMAIN_DISP>;
> + clocks = <&mmsys CLK_MM_DISP_RDMA1>;
> + mediatek,rdma_fifo_size = <2048>;
> +};
A new property doesn't really warrant a whole new example.
> \ No newline at end of file
^^^
> --
> 1.8.1.1.dirty
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Yongqiang Niu <yongqiang.niu@mediatek.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org, David Airlie <airlied@linux.ie>,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
Matthias Brugger <matthias.bgg@gmail.com>,
linux-mediatek@lists.infradead.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [RESEND PATCH v6 01/17] dt-bindings: mediatek: add rdma_fifo_size description for mt8183 display
Date: Fri, 3 Jan 2020 15:26:45 -0700 [thread overview]
Message-ID: <20200103222645.GA24430@bogus> (raw)
In-Reply-To: <1578021148-32413-2-git-send-email-yongqiang.niu@mediatek.com>
On Fri, Jan 03, 2020 at 11:12:12AM +0800, Yongqiang Niu wrote:
> Update device tree binding documention for rdma_fifo_size
Typo. And write complete sentences.
>
> Signed-off-by: Yongqiang Niu <yongqiang.niu@mediatek.com>
> ---
> .../devicetree/bindings/display/mediatek/mediatek,disp.txt | 13 +++++++++++++
> 1 file changed, 13 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,disp.txt b/Documentation/devicetree/bindings/display/mediatek/mediatek,disp.txt
> index 681502e..34bef44 100644
> --- a/Documentation/devicetree/bindings/display/mediatek/mediatek,disp.txt
> +++ b/Documentation/devicetree/bindings/display/mediatek/mediatek,disp.txt
> @@ -70,6 +70,10 @@ Required properties (DMA function blocks):
> argument, see Documentation/devicetree/bindings/iommu/mediatek,iommu.txt
> for details.
>
> +Required properties (DMA function blocks):
> +- mediatek,rdma_fifo_size: rdma fifo size may be different even in same SOC, add this
> + property to the corresponding rdma
s/_/-/
Valid values? Max value?
> +
> Examples:
>
> mmsys: clock-controller@14000000 {
> @@ -211,3 +215,12 @@ od@14023000 {
> power-domains = <&scpsys MT8173_POWER_DOMAIN_MM>;
> clocks = <&mmsys CLK_MM_DISP_OD>;
> };
> +
> +rdma1: rdma@1400c000 {
> + compatible = "mediatek,mt8183-disp-rdma";
> + reg = <0 0x1400c000 0 0x1000>;
> + interrupts = <GIC_SPI 229 IRQ_TYPE_LEVEL_LOW>;
> + power-domains = <&scpsys MT8183_POWER_DOMAIN_DISP>;
> + clocks = <&mmsys CLK_MM_DISP_RDMA1>;
> + mediatek,rdma_fifo_size = <2048>;
> +};
A new property doesn't really warrant a whole new example.
> \ No newline at end of file
^^^
> --
> 1.8.1.1.dirty
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2020-01-03 22:26 UTC|newest]
Thread overview: 96+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-03 3:12 [RESEND PATCH v6 00/17] add drm support for MT8183 Yongqiang Niu
2020-01-03 3:12 ` Yongqiang Niu
2020-01-03 3:12 ` Yongqiang Niu
2020-01-03 3:12 ` Yongqiang Niu
2020-01-03 3:12 ` [RESEND PATCH v6 01/17] dt-bindings: mediatek: add rdma_fifo_size description for mt8183 display Yongqiang Niu
2020-01-03 3:12 ` Yongqiang Niu
2020-01-03 3:12 ` Yongqiang Niu
2020-01-03 3:12 ` Yongqiang Niu
2020-01-03 5:10 ` CK Hu
2020-01-03 5:10 ` CK Hu
2020-01-03 5:10 ` CK Hu
2020-01-03 5:10 ` CK Hu
2020-01-03 22:26 ` Rob Herring [this message]
2020-01-03 22:26 ` Rob Herring
2020-01-03 22:26 ` Rob Herring
2020-01-03 22:26 ` Rob Herring
2020-01-03 3:12 ` [RESEND PATCH v6 02/17] arm64: dts: add display nodes for mt8183 Yongqiang Niu
2020-01-03 3:12 ` Yongqiang Niu
2020-01-03 3:12 ` Yongqiang Niu
2020-01-03 3:12 ` Yongqiang Niu
2020-01-03 3:12 ` [RESEND PATCH v6 03/17] drm/mediatek: move dsi/dpi select input into mtk_ddp_sel_in Yongqiang Niu
2020-01-03 3:12 ` Yongqiang Niu
2020-01-03 3:12 ` Yongqiang Niu
2020-01-03 3:12 ` Yongqiang Niu
2020-01-03 5:36 ` CK Hu
2020-01-03 5:36 ` CK Hu
2020-01-03 5:36 ` CK Hu
2020-01-03 5:36 ` CK Hu
2020-01-03 3:12 ` [RESEND PATCH v6 04/17] drm/mediatek: make sout select function format same with select input Yongqiang Niu
2020-01-03 3:12 ` Yongqiang Niu
2020-01-03 3:12 ` Yongqiang Niu
2020-01-03 3:12 ` Yongqiang Niu
2020-01-03 5:44 ` CK Hu
2020-01-03 5:44 ` CK Hu
2020-01-03 5:44 ` CK Hu
2020-01-03 5:44 ` CK Hu
2020-01-03 3:12 ` [RESEND PATCH v6 05/17] drm/mediatek: add mmsys private data for ddp path config Yongqiang Niu
2020-01-03 3:12 ` Yongqiang Niu
2020-01-03 3:12 ` Yongqiang Niu
2020-01-03 3:12 ` Yongqiang Niu
2020-01-03 3:12 ` [RESEND PATCH v6 06/17] drm/mediatek: add private data for rdma1 to dpi0 connection Yongqiang Niu
2020-01-03 3:12 ` Yongqiang Niu
2020-01-03 3:12 ` Yongqiang Niu
2020-01-03 3:12 ` Yongqiang Niu
2020-01-03 3:12 ` [RESEND PATCH v6 07/17] drm/mediatek: add private data for rdma1 to dsi0 connection Yongqiang Niu
2020-01-03 3:12 ` Yongqiang Niu
2020-01-03 3:12 ` Yongqiang Niu
2020-01-03 3:12 ` Yongqiang Niu
2020-01-03 3:12 ` [RESEND PATCH v6 08/17] drm/mediatek: move rdma sout from mtk_ddp_mout_en into mtk_ddp_sout_sel Yongqiang Niu
2020-01-03 3:12 ` Yongqiang Niu
2020-01-03 3:12 ` Yongqiang Niu
2020-01-03 3:12 ` Yongqiang Niu
2020-01-03 3:12 ` [RESEND PATCH v6 09/17] drm/mediatek: add connection from OVL0 to OVL_2L0 Yongqiang Niu
2020-01-03 3:12 ` Yongqiang Niu
2020-01-03 3:12 ` Yongqiang Niu
2020-01-03 3:12 ` Yongqiang Niu
2020-01-03 3:12 ` [RESEND PATCH v6 10/17] drm/mediatek: add connection from RDMA0 to COLOR0 Yongqiang Niu
2020-01-03 3:12 ` Yongqiang Niu
2020-01-03 3:12 ` Yongqiang Niu
2020-01-03 3:12 ` Yongqiang Niu
2020-01-03 3:12 ` [RESEND PATCH v6 11/17] drm/mediatek: add connection from RDMA1 to DSI0 Yongqiang Niu
2020-01-03 3:12 ` Yongqiang Niu
2020-01-03 3:12 ` Yongqiang Niu
2020-01-03 3:12 ` Yongqiang Niu
2020-01-03 3:12 ` [RESEND PATCH v6 12/17] drm/mediatek: add connection from OVL_2L0 to RDMA0 Yongqiang Niu
2020-01-03 3:12 ` Yongqiang Niu
2020-01-03 3:12 ` Yongqiang Niu
2020-01-03 3:12 ` Yongqiang Niu
2020-01-03 3:12 ` [RESEND PATCH v6 13/17] drm/mediatek: add connection from OVL_2L1 to RDMA1 Yongqiang Niu
2020-01-03 3:12 ` Yongqiang Niu
2020-01-03 3:12 ` Yongqiang Niu
2020-01-03 3:12 ` Yongqiang Niu
2020-01-03 3:12 ` [RESEND PATCH v6 14/17] drm/mediatek: add connection from DITHER0 to DSI0 Yongqiang Niu
2020-01-03 3:12 ` Yongqiang Niu
2020-01-03 3:12 ` Yongqiang Niu
2020-01-03 3:12 ` Yongqiang Niu
2020-01-03 3:12 ` [RESEND PATCH v6 15/17] drm/mediatek: add connection from RDMA0 " Yongqiang Niu
2020-01-03 3:12 ` Yongqiang Niu
2020-01-03 3:12 ` Yongqiang Niu
2020-01-03 3:12 ` Yongqiang Niu
2020-01-03 3:12 ` [RESEND PATCH v6 16/17] drm/mediatek: add fifo_size into rdma private data Yongqiang Niu
2020-01-03 3:12 ` Yongqiang Niu
2020-01-03 3:12 ` Yongqiang Niu
2020-01-03 3:12 ` Yongqiang Niu
2020-01-03 3:12 ` [RESEND PATCH v6 17/17] drm/mediatek: add support for mediatek SOC MT8183 Yongqiang Niu
2020-01-03 3:12 ` Yongqiang Niu
2020-01-03 3:12 ` Yongqiang Niu
2020-01-03 3:12 ` Yongqiang Niu
2020-01-03 4:58 ` [RESEND PATCH v6 00/17] add drm support for MT8183 CK Hu
2020-01-03 4:58 ` CK Hu
2020-01-03 4:58 ` CK Hu
2020-01-03 4:58 ` CK Hu
2020-03-26 14:57 ` CK Hu
2020-03-26 14:57 ` CK Hu
2020-03-26 14:57 ` CK Hu
2020-03-26 14:57 ` CK Hu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200103222645.GA24430@bogus \
--to=robh@kernel.org \
--cc=airlied@linux.ie \
--cc=ck.hu@mediatek.com \
--cc=daniel@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=matthias.bgg@gmail.com \
--cc=p.zabel@pengutronix.de \
--cc=yongqiang.niu@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.