From: Sam Ravnborg <sam@ravnborg.org>
To: Jitao Shi <jitao.shi@mediatek.com>
Cc: David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
srv_heupstream@mediatek.com, yingjoe.chen@mediatek.com,
eddie.huang@mediatek.com, cawa.cheng@mediatek.com,
bibby.hsieh@mediatek.com, linux-mediatek@lists.infradead.org,
ck.hu@mediatek.com, stonea168@163.com
Subject: Re: [PATCH v7 0/8] add driver for "boe, tv101wum-nl6", "boe, tv101wum-n53", "auo, kd101n80-45na" and "auo, b101uan08.3" panels
Date: Sun, 5 Jan 2020 12:06:07 +0100 [thread overview]
Message-ID: <20200105110607.GA3309@ravnborg.org> (raw)
In-Reply-To: <20191012030720.27127-1-jitao.shi@mediatek.com>
Hi Jitao.
On Sat, Oct 12, 2019 at 11:07:12AM +0800, Jitao Shi wrote:
> Changes since v6:
> - fix boe_panel_init err uninit.
> - adjust the delay of backlight on.
>
> Changes since v5:
> - covert the documents to yaml
> - fine tune boe, tv101wum-n53 panel video timine
I finally found some time to looks at this.
The bindings does unfortunately not pass a dt_binding_check
I had to locally do the following to make on of the bindings pass:
diff --git a/Documentation/devicetree/bindings/display/panel/auo,b101uan08.3.yaml b/Documentation/devicetree/bindings/display/panel/auo
,b101uan08.3.yaml
index c0939f8c7274..cafa870120fb 100644
--- a/Documentation/devicetree/bindings/display/panel/auo,b101uan08.3.yaml
+++ b/Documentation/devicetree/bindings/display/panel/auo,b101uan08.3.yaml
@@ -11,6 +11,9 @@ maintainers:
- Sam Ravnborg <sam@ravnborg.org>
- Rob Herring <robh+dt@kernel.org>
+allOf:
+ - $ref: panel-common.yaml#
+
properties:
compatible:
const: auo,b101uan08.3
@@ -33,6 +36,8 @@ properties:
backlight:
description: phandle of the backlight device attached to the panel
+ port: true
+
required:
- compatible
- reg
@@ -46,7 +51,9 @@ additionalProperties: false
examples:
- |
- &dsi {
+ dsi {
+ #address-cells = <1>;
+ #size-cells = <0>;
panel@0 {
compatible = "auo,b101uan08.3";
reg = <0>;
I will follow-up with review feedback on the drivers later as time
permits.
Sam
WARNING: multiple messages have this Message-ID (diff)
From: Sam Ravnborg <sam@ravnborg.org>
To: Jitao Shi <jitao.shi@mediatek.com>
Cc: bibby.hsieh@mediatek.com, srv_heupstream@mediatek.com,
David Airlie <airlied@linux.ie>,
stonea168@163.com, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org, cawa.cheng@mediatek.com,
linux-mediatek@lists.infradead.org,
Daniel Vetter <daniel@ffwll.ch>,
ck.hu@mediatek.com, yingjoe.chen@mediatek.com,
eddie.huang@mediatek.com
Subject: Re: [PATCH v7 0/8] add driver for "boe, tv101wum-nl6", "boe, tv101wum-n53", "auo, kd101n80-45na" and "auo, b101uan08.3" panels
Date: Sun, 5 Jan 2020 12:06:07 +0100 [thread overview]
Message-ID: <20200105110607.GA3309@ravnborg.org> (raw)
In-Reply-To: <20191012030720.27127-1-jitao.shi@mediatek.com>
Hi Jitao.
On Sat, Oct 12, 2019 at 11:07:12AM +0800, Jitao Shi wrote:
> Changes since v6:
> - fix boe_panel_init err uninit.
> - adjust the delay of backlight on.
>
> Changes since v5:
> - covert the documents to yaml
> - fine tune boe, tv101wum-n53 panel video timine
I finally found some time to looks at this.
The bindings does unfortunately not pass a dt_binding_check
I had to locally do the following to make on of the bindings pass:
diff --git a/Documentation/devicetree/bindings/display/panel/auo,b101uan08.3.yaml b/Documentation/devicetree/bindings/display/panel/auo
,b101uan08.3.yaml
index c0939f8c7274..cafa870120fb 100644
--- a/Documentation/devicetree/bindings/display/panel/auo,b101uan08.3.yaml
+++ b/Documentation/devicetree/bindings/display/panel/auo,b101uan08.3.yaml
@@ -11,6 +11,9 @@ maintainers:
- Sam Ravnborg <sam@ravnborg.org>
- Rob Herring <robh+dt@kernel.org>
+allOf:
+ - $ref: panel-common.yaml#
+
properties:
compatible:
const: auo,b101uan08.3
@@ -33,6 +36,8 @@ properties:
backlight:
description: phandle of the backlight device attached to the panel
+ port: true
+
required:
- compatible
- reg
@@ -46,7 +51,9 @@ additionalProperties: false
examples:
- |
- &dsi {
+ dsi {
+ #address-cells = <1>;
+ #size-cells = <0>;
panel@0 {
compatible = "auo,b101uan08.3";
reg = <0>;
I will follow-up with review feedback on the drivers later as time
permits.
Sam
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
WARNING: multiple messages have this Message-ID (diff)
From: Sam Ravnborg <sam@ravnborg.org>
To: Jitao Shi <jitao.shi@mediatek.com>
Cc: srv_heupstream@mediatek.com, David Airlie <airlied@linux.ie>,
stonea168@163.com, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org, cawa.cheng@mediatek.com,
linux-mediatek@lists.infradead.org, yingjoe.chen@mediatek.com,
eddie.huang@mediatek.com
Subject: Re: [PATCH v7 0/8] add driver for "boe, tv101wum-nl6", "boe, tv101wum-n53", "auo, kd101n80-45na" and "auo, b101uan08.3" panels
Date: Sun, 5 Jan 2020 12:06:07 +0100 [thread overview]
Message-ID: <20200105110607.GA3309@ravnborg.org> (raw)
In-Reply-To: <20191012030720.27127-1-jitao.shi@mediatek.com>
Hi Jitao.
On Sat, Oct 12, 2019 at 11:07:12AM +0800, Jitao Shi wrote:
> Changes since v6:
> - fix boe_panel_init err uninit.
> - adjust the delay of backlight on.
>
> Changes since v5:
> - covert the documents to yaml
> - fine tune boe, tv101wum-n53 panel video timine
I finally found some time to looks at this.
The bindings does unfortunately not pass a dt_binding_check
I had to locally do the following to make on of the bindings pass:
diff --git a/Documentation/devicetree/bindings/display/panel/auo,b101uan08.3.yaml b/Documentation/devicetree/bindings/display/panel/auo
,b101uan08.3.yaml
index c0939f8c7274..cafa870120fb 100644
--- a/Documentation/devicetree/bindings/display/panel/auo,b101uan08.3.yaml
+++ b/Documentation/devicetree/bindings/display/panel/auo,b101uan08.3.yaml
@@ -11,6 +11,9 @@ maintainers:
- Sam Ravnborg <sam@ravnborg.org>
- Rob Herring <robh+dt@kernel.org>
+allOf:
+ - $ref: panel-common.yaml#
+
properties:
compatible:
const: auo,b101uan08.3
@@ -33,6 +36,8 @@ properties:
backlight:
description: phandle of the backlight device attached to the panel
+ port: true
+
required:
- compatible
- reg
@@ -46,7 +51,9 @@ additionalProperties: false
examples:
- |
- &dsi {
+ dsi {
+ #address-cells = <1>;
+ #size-cells = <0>;
panel@0 {
compatible = "auo,b101uan08.3";
reg = <0>;
I will follow-up with review feedback on the drivers later as time
permits.
Sam
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2020-01-05 11:06 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-12 3:07 [PATCH v7 0/8] add driver for "boe, tv101wum-nl6", "boe, tv101wum-n53", "auo, kd101n80-45na" and "auo, b101uan08.3" panels Jitao Shi
2019-10-12 3:07 ` Jitao Shi
2019-10-12 3:07 ` [PATCH v7 1/8] dt-bindings: display: panel: Add BOE tv101wum-n16 panel bindings Jitao Shi
2019-10-12 3:07 ` Jitao Shi
2019-10-12 3:07 ` [PATCH v7 2/8] drm/panel: support for BOE tv101wum-nl6 wuxga dsi video mode panel Jitao Shi
2019-10-12 3:07 ` Jitao Shi
2020-01-05 11:23 ` Sam Ravnborg
2020-01-05 11:23 ` Sam Ravnborg
2020-01-05 11:23 ` Sam Ravnborg
2019-10-12 3:07 ` [PATCH v7 3/8] dt-bindings: display: panel: add auo kd101n80-45na panel bindings Jitao Shi
2019-10-12 3:07 ` Jitao Shi
2019-10-12 3:07 ` [PATCH v7 4/8] drm/panel: support for auo,kd101n80-45na wuxga dsi video mode panel Jitao Shi
2019-10-12 3:07 ` [PATCH v7 4/8] drm/panel: support for auo, kd101n80-45na " Jitao Shi
2020-01-05 11:31 ` [PATCH v7 4/8] drm/panel: support for auo,kd101n80-45na " Sam Ravnborg
2020-01-05 11:31 ` Sam Ravnborg
2020-01-05 11:31 ` Sam Ravnborg
2019-10-12 3:07 ` [PATCH v7 5/8] dt-bindings: display: panel: add boe tv101wum-n53 panel documentation Jitao Shi
2019-10-12 3:07 ` Jitao Shi
2019-10-12 3:07 ` [PATCH v7 6/8] drm/panel: support for boe,tv101wum-n53 wuxga dsi video mode panel Jitao Shi
2019-10-12 3:07 ` [PATCH v7 6/8] drm/panel: support for boe, tv101wum-n53 " Jitao Shi
2020-01-05 11:31 ` [PATCH v7 6/8] drm/panel: support for boe,tv101wum-n53 " Sam Ravnborg
2020-01-05 11:31 ` [PATCH v7 6/8] drm/panel: support for boe, tv101wum-n53 " Sam Ravnborg
2020-01-05 11:31 ` Sam Ravnborg
2019-10-12 3:07 ` [PATCH v7 7/8] dt-bindings: display: panel: add AUO auo,b101uan08.3 panel documentation Jitao Shi
2019-10-12 3:07 ` [PATCH v7 7/8] dt-bindings: display: panel: add AUO auo, b101uan08.3 " Jitao Shi
2019-10-12 3:07 ` [PATCH v7 8/8] drm/panel: support for auo,b101uan08.3 wuxga dsi video mode panel Jitao Shi
2019-10-12 3:07 ` [PATCH v7 8/8] drm/panel: support for auo, b101uan08.3 " Jitao Shi
2020-01-05 11:32 ` [PATCH v7 8/8] drm/panel: support for auo,b101uan08.3 " Sam Ravnborg
2020-01-05 11:32 ` Sam Ravnborg
2020-01-05 11:32 ` Sam Ravnborg
2020-01-05 11:06 ` Sam Ravnborg [this message]
2020-01-05 11:06 ` [PATCH v7 0/8] add driver for "boe, tv101wum-nl6", "boe, tv101wum-n53", "auo, kd101n80-45na" and "auo, b101uan08.3" panels Sam Ravnborg
2020-01-05 11:06 ` Sam Ravnborg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200105110607.GA3309@ravnborg.org \
--to=sam@ravnborg.org \
--cc=airlied@linux.ie \
--cc=bibby.hsieh@mediatek.com \
--cc=cawa.cheng@mediatek.com \
--cc=ck.hu@mediatek.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=eddie.huang@mediatek.com \
--cc=jitao.shi@mediatek.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=srv_heupstream@mediatek.com \
--cc=stonea168@163.com \
--cc=yingjoe.chen@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.