From: Miquel Raynal <miquel.raynal@bootlin.com> To: Rob Herring <robh@kernel.org> Cc: Thierry Reding <thierry.reding@gmail.com>, Sam Ravnborg <sam@ravnborg.org>, David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>, Mark Rutland <mark.rutland@arm.com>, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Paul Kocialkowski <paul.kocialkowski@bootlin.com>, Maxime Chevallier <maxime.chevallier@bootlin.com>, Thomas Petazzoni <thomas.petazzoni@bootlin.com> Subject: Re: [PATCH v3 2/3] dt-bindings: display: Add Satoz panel Date: Mon, 6 Jan 2020 10:54:32 +0100 [thread overview] Message-ID: <20200106105432.0621bc86@xps13> (raw) In-Reply-To: <20200104000957.GA17750@bogus> Hi Rob, Rob Herring <robh@kernel.org> wrote on Fri, 3 Jan 2020 17:09:57 -0700: > On Tue, Dec 24, 2019 at 03:19:04PM +0100, Miquel Raynal wrote: > > Satoz is a Chinese TFT manufacturer. > > Website: http://www.sat-sz.com/English/index.html > > > > Add (simple) bindings for its SAT050AT40H12R2 5.0 inch LCD panel. > > > > Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com> > > --- > > > > Changes since v2: > > * None. > > > > Changes since v1: > > * New patch > > > > .../display/panel/satoz,sat050at40h12r2.yaml | 27 +++++++++++++++++++ > > 1 file changed, 27 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/display/panel/satoz,sat050at40h12r2.yaml > > Note that this may become obsolete if we move all simple panels to a > single schema. Absolutely. > > > > > diff --git a/Documentation/devicetree/bindings/display/panel/satoz,sat050at40h12r2.yaml b/Documentation/devicetree/bindings/display/panel/satoz,sat050at40h12r2.yaml > > new file mode 100644 > > index 000000000000..567b32a544f3 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/display/panel/satoz,sat050at40h12r2.yaml > > @@ -0,0 +1,27 @@ > > +# SPDX-License-Identifier: GPL-2.0 > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/display/panel/satoz,sat050at40h12r2# > > Missing '.yaml' > > Run 'make dt_binding_check' which will check this and other things. Right, corrected. > > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: Satoz SAT050AT40H12R2 panel > > + > > +maintainers: > > + - Thierry Reding <thierry.reding@gmail.com> > > + > > +description: |+ > > + LCD 5.0 inch 800x480 RGB panel. > > Any public spec for this panel? Unfortunately, no. I mentioned it in the v3. > > > + > > + This binding is compatible with the simple-panel binding, which is specified > > + in simple-panel.txt in this directory. > > + > > +allOf: > > + - $ref: panel-common.yaml# > > + > > +properties: > > + compatible: > > + contains: > > Drop 'contains'. It must be exactly the below string, not the below > string and *any* other strings. Ok. > > > + const: satoz,sat050at40h12r2 > > + > > +required: > > + - compatible > > -- > > 2.20.1 > > Thanks, Miquèl
WARNING: multiple messages have this Message-ID (diff)
From: Miquel Raynal <miquel.raynal@bootlin.com> To: Rob Herring <robh@kernel.org> Cc: Mark Rutland <mark.rutland@arm.com>, devicetree@vger.kernel.org, Thomas Petazzoni <thomas.petazzoni@bootlin.com>, David Airlie <airlied@linux.ie>, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Maxime Chevallier <maxime.chevallier@bootlin.com>, Paul Kocialkowski <paul.kocialkowski@bootlin.com>, Thierry Reding <thierry.reding@gmail.com>, Sam Ravnborg <sam@ravnborg.org> Subject: Re: [PATCH v3 2/3] dt-bindings: display: Add Satoz panel Date: Mon, 6 Jan 2020 10:54:32 +0100 [thread overview] Message-ID: <20200106105432.0621bc86@xps13> (raw) In-Reply-To: <20200104000957.GA17750@bogus> Hi Rob, Rob Herring <robh@kernel.org> wrote on Fri, 3 Jan 2020 17:09:57 -0700: > On Tue, Dec 24, 2019 at 03:19:04PM +0100, Miquel Raynal wrote: > > Satoz is a Chinese TFT manufacturer. > > Website: http://www.sat-sz.com/English/index.html > > > > Add (simple) bindings for its SAT050AT40H12R2 5.0 inch LCD panel. > > > > Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com> > > --- > > > > Changes since v2: > > * None. > > > > Changes since v1: > > * New patch > > > > .../display/panel/satoz,sat050at40h12r2.yaml | 27 +++++++++++++++++++ > > 1 file changed, 27 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/display/panel/satoz,sat050at40h12r2.yaml > > Note that this may become obsolete if we move all simple panels to a > single schema. Absolutely. > > > > > diff --git a/Documentation/devicetree/bindings/display/panel/satoz,sat050at40h12r2.yaml b/Documentation/devicetree/bindings/display/panel/satoz,sat050at40h12r2.yaml > > new file mode 100644 > > index 000000000000..567b32a544f3 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/display/panel/satoz,sat050at40h12r2.yaml > > @@ -0,0 +1,27 @@ > > +# SPDX-License-Identifier: GPL-2.0 > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/display/panel/satoz,sat050at40h12r2# > > Missing '.yaml' > > Run 'make dt_binding_check' which will check this and other things. Right, corrected. > > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: Satoz SAT050AT40H12R2 panel > > + > > +maintainers: > > + - Thierry Reding <thierry.reding@gmail.com> > > + > > +description: |+ > > + LCD 5.0 inch 800x480 RGB panel. > > Any public spec for this panel? Unfortunately, no. I mentioned it in the v3. > > > + > > + This binding is compatible with the simple-panel binding, which is specified > > + in simple-panel.txt in this directory. > > + > > +allOf: > > + - $ref: panel-common.yaml# > > + > > +properties: > > + compatible: > > + contains: > > Drop 'contains'. It must be exactly the below string, not the below > string and *any* other strings. Ok. > > > + const: satoz,sat050at40h12r2 > > + > > +required: > > + - compatible > > -- > > 2.20.1 > > Thanks, Miquèl _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2020-01-06 9:54 UTC|newest] Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-12-24 14:19 [PATCH v3 1/3] dt-bindings: Add vendor prefix for Satoz Miquel Raynal 2019-12-24 14:19 ` Miquel Raynal 2019-12-24 14:19 ` [PATCH v3 2/3] dt-bindings: display: Add Satoz panel Miquel Raynal 2019-12-24 14:19 ` Miquel Raynal 2020-01-04 0:09 ` Rob Herring 2020-01-04 0:09 ` Rob Herring 2020-01-06 9:54 ` Miquel Raynal [this message] 2020-01-06 9:54 ` Miquel Raynal 2019-12-24 14:19 ` [PATCH v3 3/3] drm/panel: simple: Add Satoz SAT050AT40H12R2 panel support Miquel Raynal 2019-12-24 14:19 ` Miquel Raynal 2020-01-04 15:18 ` Sam Ravnborg 2020-01-04 15:18 ` Sam Ravnborg
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200106105432.0621bc86@xps13 \ --to=miquel.raynal@bootlin.com \ --cc=airlied@linux.ie \ --cc=daniel@ffwll.ch \ --cc=devicetree@vger.kernel.org \ --cc=dri-devel@lists.freedesktop.org \ --cc=linux-kernel@vger.kernel.org \ --cc=mark.rutland@arm.com \ --cc=maxime.chevallier@bootlin.com \ --cc=paul.kocialkowski@bootlin.com \ --cc=robh@kernel.org \ --cc=sam@ravnborg.org \ --cc=thierry.reding@gmail.com \ --cc=thomas.petazzoni@bootlin.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.