All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Brown <broonie@kernel.org>
To: Marek Szyprowski <m.szyprowski@samsung.com>
Cc: alsa-devel@alsa-project.org,
	Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
	Dylan Reid <dgreid@google.com>,
	Jimmy Cheng-Yi Chiang <cychiang@google.com>,
	Krzysztof Kozlowski <krzk@kernel.org>,
	linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
	Sylwester Nawrocki <s.nawrocki@samsung.com>,
	Tzung-Bi Shih <tzungbi@google.com>
Subject: Re: Applied "ASoC: max98090: fix incorrect helper in max98090_dapm_put_enum_double()" to the asoc tree
Date: Fri, 10 Jan 2020 13:25:01 +0000	[thread overview]
Message-ID: <20200110132501.GA5889@sirena.org.uk> (raw)
In-Reply-To: <77e524c5-f0a4-1996-2bf5-cbb7395f7c25@samsung.com>

[-- Attachment #1: Type: text/plain, Size: 503 bytes --]

On Fri, Jan 10, 2020 at 10:02:05AM +0100, Marek Szyprowski wrote:

> This patch has been applied twice. First time for the 
> max98090_dapm_put_enum_double() function (as it has been designed), 
> second time for max98090_put_enum_double(), what is completely wrong 
> thing (it does exactly the opposite thing).

> Mark, please revert/drop 4e93c1294f4b051d574d6bc59755d2863286990e commit.

OK.  For things like this it's generally easiest to just send a revert
that can be directly applied.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@kernel.org>
To: Marek Szyprowski <m.szyprowski@samsung.com>
Cc: alsa-devel@alsa-project.org, linux-samsung-soc@vger.kernel.org,
	Jimmy Cheng-Yi Chiang <cychiang@google.com>,
	Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
	linux-kernel@vger.kernel.org,
	Krzysztof Kozlowski <krzk@kernel.org>,
	Tzung-Bi Shih <tzungbi@google.com>,
	Sylwester Nawrocki <s.nawrocki@samsung.com>,
	Dylan Reid <dgreid@google.com>
Subject: Re: [alsa-devel] Applied "ASoC: max98090: fix incorrect helper in max98090_dapm_put_enum_double()" to the asoc tree
Date: Fri, 10 Jan 2020 13:25:01 +0000	[thread overview]
Message-ID: <20200110132501.GA5889@sirena.org.uk> (raw)
In-Reply-To: <77e524c5-f0a4-1996-2bf5-cbb7395f7c25@samsung.com>


[-- Attachment #1.1: Type: text/plain, Size: 503 bytes --]

On Fri, Jan 10, 2020 at 10:02:05AM +0100, Marek Szyprowski wrote:

> This patch has been applied twice. First time for the 
> max98090_dapm_put_enum_double() function (as it has been designed), 
> second time for max98090_put_enum_double(), what is completely wrong 
> thing (it does exactly the opposite thing).

> Mark, please revert/drop 4e93c1294f4b051d574d6bc59755d2863286990e commit.

OK.  For things like this it's generally easiest to just send a revert
that can be directly applied.

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

[-- Attachment #2: Type: text/plain, Size: 161 bytes --]

_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel

  reply	other threads:[~2020-01-10 13:25 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20200108115027eucas1p2abcd40e359e993e5b471229b02b69fc3@eucas1p2.samsung.com>
2020-01-08 11:50 ` [PATCH 1/2] ASoC: max98090: fix incorrect helper in max98090_dapm_put_enum_double() Marek Szyprowski
2020-01-08 11:50   ` [alsa-devel] " Marek Szyprowski
     [not found]   ` <CGME20200108115027eucas1p1d3645ba53703780679c662921efbca78@eucas1p1.samsung.com>
2020-01-08 11:50     ` [PATCH 2/2] ASoC: max98090: fix lockdep warning Marek Szyprowski
2020-01-08 11:50       ` [alsa-devel] " Marek Szyprowski
2020-01-09  5:36       ` Tzung-Bi Shih
2020-01-09  5:36         ` [alsa-devel] " Tzung-Bi Shih
2020-01-09 10:59         ` Tzung-Bi Shih
2020-01-09 10:59           ` [alsa-devel] " Tzung-Bi Shih
2020-01-09 11:09         ` Marek Szyprowski
2020-01-09 11:09           ` [alsa-devel] " Marek Szyprowski
2020-01-10  1:05           ` Tzung-Bi Shih
2020-01-10  1:05             ` [alsa-devel] " Tzung-Bi Shih
2020-01-09 21:29       ` Applied "ASoC: max98090: fix lockdep warning" to the asoc tree Mark Brown
2020-01-09 21:29         ` [alsa-devel] " Mark Brown
2020-01-09  5:11   ` [PATCH 1/2] ASoC: max98090: fix incorrect helper in max98090_dapm_put_enum_double() Tzung-Bi Shih
2020-01-09  5:11     ` [alsa-devel] " Tzung-Bi Shih
2020-01-09 21:29   ` Applied "ASoC: max98090: fix incorrect helper in max98090_dapm_put_enum_double()" to the asoc tree Mark Brown
2020-01-09 21:29     ` [alsa-devel] " Mark Brown
2020-01-09 21:29     ` Mark Brown
2020-01-09 21:29     ` [alsa-devel] " Mark Brown
2020-01-10  9:02     ` Marek Szyprowski
2020-01-10  9:02       ` [alsa-devel] " Marek Szyprowski
2020-01-10 13:25       ` Mark Brown [this message]
2020-01-10 13:25         ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200110132501.GA5889@sirena.org.uk \
    --to=broonie@kernel.org \
    --cc=alsa-devel@alsa-project.org \
    --cc=b.zolnierkie@samsung.com \
    --cc=cychiang@google.com \
    --cc=dgreid@google.com \
    --cc=krzk@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=m.szyprowski@samsung.com \
    --cc=s.nawrocki@samsung.com \
    --cc=tzungbi@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.