From: kbuild test robot <lkp@intel.com>
To: Sandeep Singh <Sandeep.Singh@amd.com>
Cc: kbuild-all@lists.01.org, jikos@kernel.org,
benjamin.tissoires@redhat.com, linux-kernel@vger.kernel.org,
linux-input@vger.kernel.org, srinivas.pandruvada@linux.intel.com,
jic23@kernel.org, linux-iio@vger.kernel.org,
Shyam-sundar.S-k@amd.com, Sandeep Singh <sandeep.singh@amd.com>,
Nehal Shah <Nehal-bakulchandra.Shah@amd.com>
Subject: Re: [PATCH 2/4] SFH: PCI driver to add support of AMD sensor fusion Hub using HID framework
Date: Sat, 11 Jan 2020 08:37:21 +0800 [thread overview]
Message-ID: <202001110817.Pksgd5O9%lkp@intel.com> (raw)
In-Reply-To: <1578558484-10066-1-git-send-email-Sandeep.Singh@amd.com>
[-- Attachment #1: Type: text/plain, Size: 5612 bytes --]
Hi Sandeep,
I love your patch! Perhaps something to improve:
[auto build test WARNING on linus/master]
[also build test WARNING on v5.5-rc5 next-20200110]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url: https://github.com/0day-ci/linux/commits/Sandeep-Singh/SFH-Add-Support-for-AMD-Sensor-Fusion-Hub/20200110-084435
base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git b07f636fca1c8fbba124b0082487c0b3890a0e0c
config: arm-allmodconfig (attached as .config)
compiler: arm-linux-gnueabi-gcc (GCC) 7.5.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
GCC_VERSION=7.5.0 make.cross ARCH=arm
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
In file included from include/linux/printk.h:331:0,
from include/linux/kernel.h:15,
from include/linux/list.h:9,
from include/linux/pci.h:32,
from drivers/hid/amd-sfh-hid/amd_mp2_pcie.h:12,
from drivers/hid/amd-sfh-hid/amd_mp2_pcie.c:9:
drivers/hid/amd-sfh-hid/amd_mp2_pcie.c: In function 'amd_mp2_pci_init':
>> drivers/hid/amd-sfh-hid/amd_mp2_pcie.c:155:30: warning: format '%llx' expects argument of type 'long long unsigned int', but argument 4 has type 'resource_size_t {aka unsigned int}' [-Wformat=]
dev_dbg(ndev_dev(privdata), "Base addr:%llx size:%llx\n", base, size);
^
include/linux/dynamic_debug.h:125:15: note: in definition of macro '__dynamic_func_call'
func(&id, ##__VA_ARGS__); \
^~~~~~~~~~~
include/linux/dynamic_debug.h:157:2: note: in expansion of macro '_dynamic_func_call'
_dynamic_func_call(fmt,__dynamic_dev_dbg, \
^~~~~~~~~~~~~~~~~~
include/linux/device.h:1784:2: note: in expansion of macro 'dynamic_dev_dbg'
dynamic_dev_dbg(dev, dev_fmt(fmt), ##__VA_ARGS__)
^~~~~~~~~~~~~~~
include/linux/device.h:1784:23: note: in expansion of macro 'dev_fmt'
dynamic_dev_dbg(dev, dev_fmt(fmt), ##__VA_ARGS__)
^~~~~~~
>> drivers/hid/amd-sfh-hid/amd_mp2_pcie.c:155:2: note: in expansion of macro 'dev_dbg'
dev_dbg(ndev_dev(privdata), "Base addr:%llx size:%llx\n", base, size);
^~~~~~~
drivers/hid/amd-sfh-hid/amd_mp2_pcie.c:155:30: warning: format '%llx' expects argument of type 'long long unsigned int', but argument 5 has type 'resource_size_t {aka unsigned int}' [-Wformat=]
dev_dbg(ndev_dev(privdata), "Base addr:%llx size:%llx\n", base, size);
^
include/linux/dynamic_debug.h:125:15: note: in definition of macro '__dynamic_func_call'
func(&id, ##__VA_ARGS__); \
^~~~~~~~~~~
include/linux/dynamic_debug.h:157:2: note: in expansion of macro '_dynamic_func_call'
_dynamic_func_call(fmt,__dynamic_dev_dbg, \
^~~~~~~~~~~~~~~~~~
include/linux/device.h:1784:2: note: in expansion of macro 'dynamic_dev_dbg'
dynamic_dev_dbg(dev, dev_fmt(fmt), ##__VA_ARGS__)
^~~~~~~~~~~~~~~
include/linux/device.h:1784:23: note: in expansion of macro 'dev_fmt'
dynamic_dev_dbg(dev, dev_fmt(fmt), ##__VA_ARGS__)
^~~~~~~
>> drivers/hid/amd-sfh-hid/amd_mp2_pcie.c:155:2: note: in expansion of macro 'dev_dbg'
dev_dbg(ndev_dev(privdata), "Base addr:%llx size:%llx\n", base, size);
^~~~~~~
vim +155 drivers/hid/amd-sfh-hid/amd_mp2_pcie.c
118
119 static int amd_mp2_pci_init(struct amd_mp2_dev *privdata, struct pci_dev *pdev)
120 {
121 int rc;
122 int bar_index = 2;
123 resource_size_t size, base;
124
125 pci_set_drvdata(pdev, privdata);
126
127 rc = pci_enable_device(pdev);
128 if (rc)
129 goto err_pci_enable;
130
131 rc = pci_request_regions(pdev, DRIVER_NAME);
132 if (rc)
133 goto err_pci_regions;
134
135 pci_set_master(pdev);
136
137 rc = pci_set_dma_mask(pdev, DMA_BIT_MASK(64));
138 if (rc) {
139 rc = pci_set_dma_mask(pdev, DMA_BIT_MASK(32));
140 if (rc)
141 goto err_dma_mask;
142 dev_warn(ndev_dev(privdata), "Cannot DMA highmem\n");
143 }
144
145 rc = pci_set_consistent_dma_mask(pdev, DMA_BIT_MASK(64));
146 if (rc) {
147 rc = pci_set_consistent_dma_mask(pdev, DMA_BIT_MASK(32));
148 if (rc)
149 goto err_dma_mask;
150 dev_warn(ndev_dev(privdata), "Cannot DMA consistent highmem\n");
151 }
152
153 base = pci_resource_start(pdev, bar_index);
154 size = pci_resource_len(pdev, bar_index);
> 155 dev_dbg(ndev_dev(privdata), "Base addr:%llx size:%llx\n", base, size);
156
157 privdata->mmio = ioremap(base, size);
158 if (!privdata->mmio) {
159 rc = -EIO;
160 goto err_dma_mask;
161 }
162
163 return 0;
164
165 err_dma_mask:
166 pci_clear_master(pdev);
167 pci_release_regions(pdev);
168 err_pci_regions:
169 pci_disable_device(pdev);
170 err_pci_enable:
171 pci_set_drvdata(pdev, NULL);
172 return rc;
173 }
174
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org Intel Corporation
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 72693 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: kbuild test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: Re: [PATCH 2/4] SFH: PCI driver to add support of AMD sensor fusion Hub using HID framework
Date: Sat, 11 Jan 2020 08:37:21 +0800 [thread overview]
Message-ID: <202001110817.Pksgd5O9%lkp@intel.com> (raw)
In-Reply-To: <1578558484-10066-1-git-send-email-Sandeep.Singh@amd.com>
[-- Attachment #1: Type: text/plain, Size: 5746 bytes --]
Hi Sandeep,
I love your patch! Perhaps something to improve:
[auto build test WARNING on linus/master]
[also build test WARNING on v5.5-rc5 next-20200110]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url: https://github.com/0day-ci/linux/commits/Sandeep-Singh/SFH-Add-Support-for-AMD-Sensor-Fusion-Hub/20200110-084435
base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git b07f636fca1c8fbba124b0082487c0b3890a0e0c
config: arm-allmodconfig (attached as .config)
compiler: arm-linux-gnueabi-gcc (GCC) 7.5.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
GCC_VERSION=7.5.0 make.cross ARCH=arm
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
In file included from include/linux/printk.h:331:0,
from include/linux/kernel.h:15,
from include/linux/list.h:9,
from include/linux/pci.h:32,
from drivers/hid/amd-sfh-hid/amd_mp2_pcie.h:12,
from drivers/hid/amd-sfh-hid/amd_mp2_pcie.c:9:
drivers/hid/amd-sfh-hid/amd_mp2_pcie.c: In function 'amd_mp2_pci_init':
>> drivers/hid/amd-sfh-hid/amd_mp2_pcie.c:155:30: warning: format '%llx' expects argument of type 'long long unsigned int', but argument 4 has type 'resource_size_t {aka unsigned int}' [-Wformat=]
dev_dbg(ndev_dev(privdata), "Base addr:%llx size:%llx\n", base, size);
^
include/linux/dynamic_debug.h:125:15: note: in definition of macro '__dynamic_func_call'
func(&id, ##__VA_ARGS__); \
^~~~~~~~~~~
include/linux/dynamic_debug.h:157:2: note: in expansion of macro '_dynamic_func_call'
_dynamic_func_call(fmt,__dynamic_dev_dbg, \
^~~~~~~~~~~~~~~~~~
include/linux/device.h:1784:2: note: in expansion of macro 'dynamic_dev_dbg'
dynamic_dev_dbg(dev, dev_fmt(fmt), ##__VA_ARGS__)
^~~~~~~~~~~~~~~
include/linux/device.h:1784:23: note: in expansion of macro 'dev_fmt'
dynamic_dev_dbg(dev, dev_fmt(fmt), ##__VA_ARGS__)
^~~~~~~
>> drivers/hid/amd-sfh-hid/amd_mp2_pcie.c:155:2: note: in expansion of macro 'dev_dbg'
dev_dbg(ndev_dev(privdata), "Base addr:%llx size:%llx\n", base, size);
^~~~~~~
drivers/hid/amd-sfh-hid/amd_mp2_pcie.c:155:30: warning: format '%llx' expects argument of type 'long long unsigned int', but argument 5 has type 'resource_size_t {aka unsigned int}' [-Wformat=]
dev_dbg(ndev_dev(privdata), "Base addr:%llx size:%llx\n", base, size);
^
include/linux/dynamic_debug.h:125:15: note: in definition of macro '__dynamic_func_call'
func(&id, ##__VA_ARGS__); \
^~~~~~~~~~~
include/linux/dynamic_debug.h:157:2: note: in expansion of macro '_dynamic_func_call'
_dynamic_func_call(fmt,__dynamic_dev_dbg, \
^~~~~~~~~~~~~~~~~~
include/linux/device.h:1784:2: note: in expansion of macro 'dynamic_dev_dbg'
dynamic_dev_dbg(dev, dev_fmt(fmt), ##__VA_ARGS__)
^~~~~~~~~~~~~~~
include/linux/device.h:1784:23: note: in expansion of macro 'dev_fmt'
dynamic_dev_dbg(dev, dev_fmt(fmt), ##__VA_ARGS__)
^~~~~~~
>> drivers/hid/amd-sfh-hid/amd_mp2_pcie.c:155:2: note: in expansion of macro 'dev_dbg'
dev_dbg(ndev_dev(privdata), "Base addr:%llx size:%llx\n", base, size);
^~~~~~~
vim +155 drivers/hid/amd-sfh-hid/amd_mp2_pcie.c
118
119 static int amd_mp2_pci_init(struct amd_mp2_dev *privdata, struct pci_dev *pdev)
120 {
121 int rc;
122 int bar_index = 2;
123 resource_size_t size, base;
124
125 pci_set_drvdata(pdev, privdata);
126
127 rc = pci_enable_device(pdev);
128 if (rc)
129 goto err_pci_enable;
130
131 rc = pci_request_regions(pdev, DRIVER_NAME);
132 if (rc)
133 goto err_pci_regions;
134
135 pci_set_master(pdev);
136
137 rc = pci_set_dma_mask(pdev, DMA_BIT_MASK(64));
138 if (rc) {
139 rc = pci_set_dma_mask(pdev, DMA_BIT_MASK(32));
140 if (rc)
141 goto err_dma_mask;
142 dev_warn(ndev_dev(privdata), "Cannot DMA highmem\n");
143 }
144
145 rc = pci_set_consistent_dma_mask(pdev, DMA_BIT_MASK(64));
146 if (rc) {
147 rc = pci_set_consistent_dma_mask(pdev, DMA_BIT_MASK(32));
148 if (rc)
149 goto err_dma_mask;
150 dev_warn(ndev_dev(privdata), "Cannot DMA consistent highmem\n");
151 }
152
153 base = pci_resource_start(pdev, bar_index);
154 size = pci_resource_len(pdev, bar_index);
> 155 dev_dbg(ndev_dev(privdata), "Base addr:%llx size:%llx\n", base, size);
156
157 privdata->mmio = ioremap(base, size);
158 if (!privdata->mmio) {
159 rc = -EIO;
160 goto err_dma_mask;
161 }
162
163 return 0;
164
165 err_dma_mask:
166 pci_clear_master(pdev);
167 pci_release_regions(pdev);
168 err_pci_regions:
169 pci_disable_device(pdev);
170 err_pci_enable:
171 pci_set_drvdata(pdev, NULL);
172 return rc;
173 }
174
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org Intel Corporation
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 72693 bytes --]
next prev parent reply other threads:[~2020-01-11 0:37 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-09 8:21 [PATCH 0/4] SFH: Add Support for AMD Sensor Fusion Hub Sandeep Singh
2020-01-09 8:27 ` [PATCH 1/4] SFH: Add maintainer list and documentation for AMD SFH based on HID framework Sandeep Singh
2020-01-09 8:28 ` [PATCH 2/4] SFH: PCI driver to add support of AMD sensor fusion Hub using " Sandeep Singh
2020-01-11 0:37 ` kbuild test robot [this message]
2020-01-11 0:37 ` kbuild test robot
2020-01-09 8:28 ` [PATCH 3/4] SFH: Transport Driver to add support of AMD sensor fusion Hub (SFH) Sandeep Singh
2020-01-13 10:45 ` Dan Carpenter
2020-01-13 10:45 ` Dan Carpenter
2020-01-13 10:45 ` Dan Carpenter
2020-01-09 8:29 ` [PATCH 4/4] SFH: Create HID report to Enable " Sandeep Singh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202001110817.Pksgd5O9%lkp@intel.com \
--to=lkp@intel.com \
--cc=Nehal-bakulchandra.Shah@amd.com \
--cc=Sandeep.Singh@amd.com \
--cc=Shyam-sundar.S-k@amd.com \
--cc=benjamin.tissoires@redhat.com \
--cc=jic23@kernel.org \
--cc=jikos@kernel.org \
--cc=kbuild-all@lists.01.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=srinivas.pandruvada@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.