From: Jordan Crouse <jcrouse@codeaurora.org>
To: Douglas Anderson <dianders@chromium.org>
Cc: Rob Clark <robdclark@chromium.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Sean Paul <sean@poorly.run>,
linux-arm-msm@vger.kernel.org, David Airlie <airlied@linux.ie>,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
Brian Masney <masneyb@onstation.org>,
Thomas Gleixner <tglx@linutronix.de>,
freedreno@lists.freedesktop.org, Daniel Vetter <daniel@ffwll.ch>
Subject: Re: [PATCH] drm/msm: Fix error about comments within a comment block
Date: Tue, 14 Jan 2020 08:59:55 -0700 [thread overview]
Message-ID: <20200114155955.GA31665@jcrouse1-lnx.qualcomm.com> (raw)
In-Reply-To: <20200113140427.1.I5e35e29bebe575e091177c4f82606c15370b71d7@changeid>
On Mon, Jan 13, 2020 at 02:04:46PM -0800, Douglas Anderson wrote:
> My compiler yells:
> .../drivers/gpu/drm/msm/adreno/adreno_gpu.c:69:27:
> error: '/*' within block comment [-Werror,-Wcomment]
>
> Let's fix.
grumble something about the road being paved with good intentions....
Reviewed-by: Jordan Crouse <jcrouse@codeaurora.org>
> Fixes: 6a0dea02c2c4 ("drm/msm: support firmware-name for zap fw (v2)")
> Signed-off-by: Douglas Anderson <dianders@chromium.org>
> ---
>
> drivers/gpu/drm/msm/adreno/adreno_gpu.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/msm/adreno/adreno_gpu.c b/drivers/gpu/drm/msm/adreno/adreno_gpu.c
> index c146c3b8f52b..7fd29829b2fa 100644
> --- a/drivers/gpu/drm/msm/adreno/adreno_gpu.c
> +++ b/drivers/gpu/drm/msm/adreno/adreno_gpu.c
> @@ -67,7 +67,7 @@ static int zap_shader_load_mdt(struct msm_gpu *gpu, const char *fwname,
> *
> * If the firmware-name property is found, we bypass the
> * adreno_request_fw() mechanism, because we don't need to handle
> - * the /lib/firmware/qcom/* vs /lib/firmware/* case.
> + * the /lib/firmware/qcom/... vs /lib/firmware/... case.
> *
> * If the firmware-name property is not found, for backwards
> * compatibility we fall back to the fwname from the gpulist
> --
> 2.25.0.rc1.283.g88dfdc4193-goog
>
--
The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
WARNING: multiple messages have this Message-ID (diff)
From: Jordan Crouse <jcrouse@codeaurora.org>
To: Douglas Anderson <dianders@chromium.org>
Cc: Rob Clark <robdclark@chromium.org>,
freedreno@lists.freedesktop.org, David Airlie <airlied@linux.ie>,
linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Thomas Gleixner <tglx@linutronix.de>, Sean Paul <sean@poorly.run>,
Brian Masney <masneyb@onstation.org>
Subject: Re: [PATCH] drm/msm: Fix error about comments within a comment block
Date: Tue, 14 Jan 2020 08:59:55 -0700 [thread overview]
Message-ID: <20200114155955.GA31665@jcrouse1-lnx.qualcomm.com> (raw)
In-Reply-To: <20200113140427.1.I5e35e29bebe575e091177c4f82606c15370b71d7@changeid>
On Mon, Jan 13, 2020 at 02:04:46PM -0800, Douglas Anderson wrote:
> My compiler yells:
> .../drivers/gpu/drm/msm/adreno/adreno_gpu.c:69:27:
> error: '/*' within block comment [-Werror,-Wcomment]
>
> Let's fix.
grumble something about the road being paved with good intentions....
Reviewed-by: Jordan Crouse <jcrouse@codeaurora.org>
> Fixes: 6a0dea02c2c4 ("drm/msm: support firmware-name for zap fw (v2)")
> Signed-off-by: Douglas Anderson <dianders@chromium.org>
> ---
>
> drivers/gpu/drm/msm/adreno/adreno_gpu.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/msm/adreno/adreno_gpu.c b/drivers/gpu/drm/msm/adreno/adreno_gpu.c
> index c146c3b8f52b..7fd29829b2fa 100644
> --- a/drivers/gpu/drm/msm/adreno/adreno_gpu.c
> +++ b/drivers/gpu/drm/msm/adreno/adreno_gpu.c
> @@ -67,7 +67,7 @@ static int zap_shader_load_mdt(struct msm_gpu *gpu, const char *fwname,
> *
> * If the firmware-name property is found, we bypass the
> * adreno_request_fw() mechanism, because we don't need to handle
> - * the /lib/firmware/qcom/* vs /lib/firmware/* case.
> + * the /lib/firmware/qcom/... vs /lib/firmware/... case.
> *
> * If the firmware-name property is not found, for backwards
> * compatibility we fall back to the fwname from the gpulist
> --
> 2.25.0.rc1.283.g88dfdc4193-goog
>
--
The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2020-01-14 16:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-13 22:04 [PATCH] drm/msm: Fix error about comments within a comment block Douglas Anderson
2020-01-13 22:04 ` Douglas Anderson
2020-01-14 15:59 ` Jordan Crouse [this message]
2020-01-14 15:59 ` Jordan Crouse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200114155955.GA31665@jcrouse1-lnx.qualcomm.com \
--to=jcrouse@codeaurora.org \
--cc=airlied@linux.ie \
--cc=bjorn.andersson@linaro.org \
--cc=daniel@ffwll.ch \
--cc=dianders@chromium.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masneyb@onstation.org \
--cc=robdclark@chromium.org \
--cc=sean@poorly.run \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.