From: Christoph Hellwig <hch@infradead.org>
To: Satya Tangirala <satyat@google.com>
Cc: linux-block@vger.kernel.org, linux-scsi@vger.kernel.org,
linux-fscrypt@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net,
Barani Muthukumaran <bmuthuku@qti.qualcomm.com>,
Kuohong Wang <kuohong.wang@mediatek.com>,
Kim Boojin <boojin.kim@samsung.com>
Subject: Re: [PATCH v6 6/9] scsi: ufs: Add inline encryption support to UFS
Date: Fri, 17 Jan 2020 05:58:08 -0800 [thread overview]
Message-ID: <20200117135808.GB5670@infradead.org> (raw)
In-Reply-To: <20191218145136.172774-7-satyat@google.com>
On Wed, Dec 18, 2019 at 06:51:33AM -0800, Satya Tangirala wrote:
> Wire up ufshcd.c with the UFS Crypto API, the block layer inline
> encryption additions and the keyslot manager.
I think this patch should be merged into the previous patch, as the
previous one isn't useful without wiring it up.
> +int ufshcd_prepare_lrbp_crypto(struct ufs_hba *hba,
> + struct scsi_cmnd *cmd,
> + struct ufshcd_lrb *lrbp)
> +{
> + struct bio_crypt_ctx *bc;
> +
> + if (!bio_crypt_should_process(cmd->request)) {
> + lrbp->crypto_enable = false;
> + return 0;
> + }
I think this check belongs into the caller so that there is no function
call overhead for the !inline crypto case. If you extend the
conditional
to
if (!IS_ENABLED(CONFIG_SCSI_UFS_CRYPTO) ||
!bio_crypt_should_process(cmd->request))
you also don't need the stub for ufshcd_prepare_lrbp_crypto.
> +EXPORT_SYMBOL_GPL(ufshcd_prepare_lrbp_crypto);
No need to export this function.
> + if (ufshcd_lrbp_crypto_enabled(lrbp)) {
> +#if IS_ENABLED(CONFIG_SCSI_UFS_CRYPTO)
> + dword_0 |= UTP_REQ_DESC_CRYPTO_ENABLE_CMD;
> + dword_0 |= lrbp->crypto_key_slot;
> + req_desc->header.dword_1 =
> + cpu_to_le32(lower_32_bits(lrbp->data_unit_num));
> + req_desc->header.dword_3 =
> + cpu_to_le32(upper_32_bits(lrbp->data_unit_num));
> +#endif /* CONFIG_SCSI_UFS_CRYPTO */
This can be a plain old ifdef without the IS_ENABLED obsfucation.
> +#if IS_ENABLED(CONFIG_SCSI_UFS_CRYPTO)
> + lrbp->crypto_enable = false; /* No crypto operations */
> +#endif
Same here.
> +#if IS_ENABLED(CONFIG_SCSI_UFS_CRYPTO)
> + bool crypto_enable;
> + u8 crypto_key_slot;
> + u64 data_unit_num;
> +#endif /* CONFIG_SCSI_UFS_CRYPTO */
.. and here.
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@infradead.org>
To: Satya Tangirala <satyat@google.com>
Cc: linux-scsi@vger.kernel.org, Kim Boojin <boojin.kim@samsung.com>,
Kuohong Wang <kuohong.wang@mediatek.com>,
Barani Muthukumaran <bmuthuku@qti.qualcomm.com>,
linux-f2fs-devel@lists.sourceforge.net,
linux-block@vger.kernel.org, linux-fscrypt@vger.kernel.org,
linux-fsdevel@vger.kernel.org
Subject: Re: [f2fs-dev] [PATCH v6 6/9] scsi: ufs: Add inline encryption support to UFS
Date: Fri, 17 Jan 2020 05:58:08 -0800 [thread overview]
Message-ID: <20200117135808.GB5670@infradead.org> (raw)
In-Reply-To: <20191218145136.172774-7-satyat@google.com>
On Wed, Dec 18, 2019 at 06:51:33AM -0800, Satya Tangirala wrote:
> Wire up ufshcd.c with the UFS Crypto API, the block layer inline
> encryption additions and the keyslot manager.
I think this patch should be merged into the previous patch, as the
previous one isn't useful without wiring it up.
> +int ufshcd_prepare_lrbp_crypto(struct ufs_hba *hba,
> + struct scsi_cmnd *cmd,
> + struct ufshcd_lrb *lrbp)
> +{
> + struct bio_crypt_ctx *bc;
> +
> + if (!bio_crypt_should_process(cmd->request)) {
> + lrbp->crypto_enable = false;
> + return 0;
> + }
I think this check belongs into the caller so that there is no function
call overhead for the !inline crypto case. If you extend the
conditional
to
if (!IS_ENABLED(CONFIG_SCSI_UFS_CRYPTO) ||
!bio_crypt_should_process(cmd->request))
you also don't need the stub for ufshcd_prepare_lrbp_crypto.
> +EXPORT_SYMBOL_GPL(ufshcd_prepare_lrbp_crypto);
No need to export this function.
> + if (ufshcd_lrbp_crypto_enabled(lrbp)) {
> +#if IS_ENABLED(CONFIG_SCSI_UFS_CRYPTO)
> + dword_0 |= UTP_REQ_DESC_CRYPTO_ENABLE_CMD;
> + dword_0 |= lrbp->crypto_key_slot;
> + req_desc->header.dword_1 =
> + cpu_to_le32(lower_32_bits(lrbp->data_unit_num));
> + req_desc->header.dword_3 =
> + cpu_to_le32(upper_32_bits(lrbp->data_unit_num));
> +#endif /* CONFIG_SCSI_UFS_CRYPTO */
This can be a plain old ifdef without the IS_ENABLED obsfucation.
> +#if IS_ENABLED(CONFIG_SCSI_UFS_CRYPTO)
> + lrbp->crypto_enable = false; /* No crypto operations */
> +#endif
Same here.
> +#if IS_ENABLED(CONFIG_SCSI_UFS_CRYPTO)
> + bool crypto_enable;
> + u8 crypto_key_slot;
> + u64 data_unit_num;
> +#endif /* CONFIG_SCSI_UFS_CRYPTO */
.. and here.
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
next prev parent reply other threads:[~2020-01-17 13:58 UTC|newest]
Thread overview: 112+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-18 14:51 [PATCH v6 0/9] Inline Encryption Support Satya Tangirala
2019-12-18 14:51 ` [f2fs-dev] " Satya Tangirala via Linux-f2fs-devel
2019-12-18 14:51 ` [PATCH v6 1/9] block: Keyslot Manager for Inline Encryption Satya Tangirala
2019-12-18 14:51 ` [f2fs-dev] " Satya Tangirala via Linux-f2fs-devel
2019-12-18 20:13 ` Eric Biggers
2019-12-18 20:13 ` [f2fs-dev] " Eric Biggers
2020-01-17 9:10 ` Christoph Hellwig
2020-01-17 9:10 ` [f2fs-dev] " Christoph Hellwig
2019-12-18 14:51 ` [PATCH v6 2/9] block: Add encryption context to struct bio Satya Tangirala
2019-12-18 14:51 ` [f2fs-dev] " Satya Tangirala via Linux-f2fs-devel
2019-12-18 21:10 ` Eric Biggers
2019-12-18 21:10 ` [f2fs-dev] " Eric Biggers
2019-12-18 21:21 ` Darrick J. Wong
2019-12-18 21:21 ` [f2fs-dev] " Darrick J. Wong
2019-12-18 21:25 ` Martin K. Petersen
2019-12-18 21:25 ` [f2fs-dev] " Martin K. Petersen
2019-12-18 22:27 ` Eric Biggers
2019-12-18 22:27 ` [f2fs-dev] " Eric Biggers
2019-12-19 0:47 ` Martin K. Petersen
2019-12-19 0:47 ` [f2fs-dev] " Martin K. Petersen
2019-12-20 3:52 ` Eric Biggers
2019-12-20 3:52 ` [f2fs-dev] " Eric Biggers
2020-01-07 4:35 ` Martin K. Petersen
2020-01-07 4:35 ` [f2fs-dev] " Martin K. Petersen
2020-01-08 14:07 ` Christoph Hellwig
2020-01-08 14:07 ` [f2fs-dev] " Christoph Hellwig
2020-01-08 17:26 ` Eric Biggers
2020-01-08 17:26 ` [f2fs-dev] " Eric Biggers
2020-01-17 8:32 ` Christoph Hellwig
2020-01-17 8:32 ` [f2fs-dev] " Christoph Hellwig
2020-01-18 5:11 ` Eric Biggers
2020-01-18 5:11 ` [f2fs-dev] " Eric Biggers
2020-01-21 22:05 ` Satya Tangirala
2020-01-21 22:05 ` [f2fs-dev] " Satya Tangirala via Linux-f2fs-devel
2020-01-09 3:40 ` Martin K. Petersen
2020-01-09 3:40 ` [f2fs-dev] " Martin K. Petersen
2020-01-14 21:24 ` Eric Biggers
2020-01-14 21:24 ` [f2fs-dev] " Eric Biggers
2019-12-18 14:51 ` [PATCH v6 3/9] block: blk-crypto for Inline Encryption Satya Tangirala
2019-12-18 14:51 ` [f2fs-dev] " Satya Tangirala via Linux-f2fs-devel
2019-12-20 3:14 ` Eric Biggers
2019-12-20 3:14 ` [f2fs-dev] " Eric Biggers
2019-12-20 5:10 ` Eric Biggers
2019-12-20 5:10 ` [f2fs-dev] " Eric Biggers
2020-01-14 21:22 ` Eric Biggers
2020-01-14 21:22 ` [f2fs-dev] " Eric Biggers
2019-12-18 14:51 ` [PATCH v6 4/9] scsi: ufs: UFS driver v2.1 spec crypto additions Satya Tangirala
2019-12-18 14:51 ` [f2fs-dev] " Satya Tangirala via Linux-f2fs-devel
2020-01-17 12:31 ` Christoph Hellwig
2020-01-17 12:31 ` [f2fs-dev] " Christoph Hellwig
2019-12-18 14:51 ` [PATCH v6 5/9] scsi: ufs: UFS crypto API Satya Tangirala
2019-12-18 14:51 ` [f2fs-dev] " Satya Tangirala via Linux-f2fs-devel
2019-12-20 4:48 ` Eric Biggers
2019-12-20 4:48 ` [f2fs-dev] " Eric Biggers
2020-01-14 21:16 ` Eric Biggers
2020-01-14 21:16 ` [f2fs-dev] " Eric Biggers
2020-01-17 13:51 ` Christoph Hellwig
2020-01-17 13:51 ` [f2fs-dev] " Christoph Hellwig
2019-12-18 14:51 ` [PATCH v6 6/9] scsi: ufs: Add inline encryption support to UFS Satya Tangirala
2019-12-18 14:51 ` [f2fs-dev] " Satya Tangirala via Linux-f2fs-devel
2019-12-20 5:44 ` Eric Biggers
2019-12-20 5:44 ` [f2fs-dev] " Eric Biggers
2020-01-17 13:58 ` Christoph Hellwig [this message]
2020-01-17 13:58 ` Christoph Hellwig
2020-01-18 5:27 ` Eric Biggers
2020-01-18 5:27 ` [f2fs-dev] " Eric Biggers
2020-02-05 18:07 ` Christoph Hellwig
2020-02-05 18:07 ` [f2fs-dev] " Christoph Hellwig
2020-01-18 3:58 ` Eric Biggers
2020-01-18 3:58 ` [f2fs-dev] " Eric Biggers
2020-02-05 20:47 ` Eric Biggers
2020-02-05 20:47 ` [f2fs-dev] " Eric Biggers
2019-12-18 14:51 ` [PATCH v6 7/9] fscrypt: add inline encryption support Satya Tangirala
2019-12-18 14:51 ` [f2fs-dev] " Satya Tangirala via Linux-f2fs-devel
2020-01-14 21:12 ` Eric Biggers
2020-01-14 21:12 ` [f2fs-dev] " Eric Biggers
2019-12-18 14:51 ` [PATCH v6 8/9] f2fs: " Satya Tangirala
2019-12-18 14:51 ` [f2fs-dev] " Satya Tangirala via Linux-f2fs-devel
2019-12-20 4:23 ` Eric Biggers
2019-12-20 4:23 ` [f2fs-dev] " Eric Biggers
2019-12-18 14:51 ` [PATCH v6 9/9] ext4: " Satya Tangirala
2019-12-18 14:51 ` [f2fs-dev] " Satya Tangirala via Linux-f2fs-devel
2019-12-19 0:12 ` Eric Biggers
2019-12-19 0:12 ` [f2fs-dev] " Eric Biggers
2019-12-19 0:31 ` Satya Tangirala
2019-12-19 0:31 ` [f2fs-dev] " Satya Tangirala via Linux-f2fs-devel
2019-12-22 0:16 ` Eric Biggers
2019-12-22 0:16 ` [f2fs-dev] " Eric Biggers
2020-01-08 14:05 ` [PATCH v6 0/9] Inline Encryption Support Christoph Hellwig
2020-01-08 14:05 ` [f2fs-dev] " Christoph Hellwig
2020-01-08 18:43 ` Satya Tangirala
2020-01-08 18:43 ` [f2fs-dev] " Satya Tangirala via Linux-f2fs-devel
2020-01-17 8:52 ` Christoph Hellwig
2020-01-17 8:52 ` [f2fs-dev] " Christoph Hellwig
2020-02-01 0:53 ` Satya Tangirala
2020-02-01 0:53 ` [f2fs-dev] " Satya Tangirala via Linux-f2fs-devel
2020-02-03 9:15 ` Christoph Hellwig
2020-02-03 9:15 ` [f2fs-dev] " Christoph Hellwig
2020-02-04 3:39 ` Satya Tangirala
2020-02-04 3:39 ` [f2fs-dev] " Satya Tangirala via Linux-f2fs-devel
2020-02-04 14:58 ` Christoph Hellwig
2020-02-04 14:58 ` [f2fs-dev] " Christoph Hellwig
2020-02-04 21:21 ` Eric Biggers
2020-02-04 21:21 ` [f2fs-dev] " Eric Biggers
2020-02-05 7:36 ` Eric Biggers
2020-02-05 7:36 ` [f2fs-dev] " Eric Biggers
2020-02-05 18:05 ` Christoph Hellwig
2020-02-05 18:05 ` [f2fs-dev] " Christoph Hellwig
2020-02-21 12:30 ` Satya Tangirala
2020-02-21 12:30 ` [f2fs-dev] " Satya Tangirala via Linux-f2fs-devel
2020-02-21 14:20 ` Christoph Hellwig
2020-02-21 14:20 ` [f2fs-dev] " Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200117135808.GB5670@infradead.org \
--to=hch@infradead.org \
--cc=bmuthuku@qti.qualcomm.com \
--cc=boojin.kim@samsung.com \
--cc=kuohong.wang@mediatek.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-fscrypt@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=satyat@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.