From: Lee Jones <lee.jones@linaro.org>
To: Wen Su <Wen.Su@mediatek.com>
Cc: Rob Herring <robh+dt@kernel.org>, Mark Brown <broonie@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org,
devicetree@vger.kernel.org, Liam Girdwood <lgirdwood@gmail.com>,
Mark Rutland <mark.rutland@arm.com>,
linux-arm-kernel@lists.infradead.org, wsd_upstream@mediatek.com
Subject: Re: [RESEND 1/4] dt-bindings: regulator: Add document for MT6359 regulator
Date: Mon, 20 Jan 2020 08:43:55 +0000 [thread overview]
Message-ID: <20200120084355.GW15507@dell> (raw)
In-Reply-To: <1579506450-21830-2-git-send-email-Wen.Su@mediatek.com>
On Mon, 20 Jan 2020, Wen Su wrote:
> From: Wen Su <wen.su@mediatek.com>
>
> add dt-binding document for MediaTek MT6359 PMIC
>
> Reviewed-by: Rob Herring <robh@kernel.org>
> Signed-off-by: Wen Su <wen.su@mediatek.com>
These are in the wrong order. Tags should describe history, thus
should be in chronological order. For instance, the ordering you used
describes Rob reviewing the patch *before* you sent it, which is not
possible.
> ---
> .../bindings/regulator/mt6359-regulator.txt | 59 ++++++++++++++++++++++
> 1 file changed, 59 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/regulator/mt6359-regulator.txt
--
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
WARNING: multiple messages have this Message-ID (diff)
From: Lee Jones <lee.jones@linaro.org>
To: Wen Su <Wen.Su@mediatek.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org, wsd_upstream@mediatek.com,
linux-kernel@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
linux-mediatek@lists.infradead.org,
Matthias Brugger <matthias.bgg@gmail.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [RESEND 1/4] dt-bindings: regulator: Add document for MT6359 regulator
Date: Mon, 20 Jan 2020 08:43:55 +0000 [thread overview]
Message-ID: <20200120084355.GW15507@dell> (raw)
In-Reply-To: <1579506450-21830-2-git-send-email-Wen.Su@mediatek.com>
On Mon, 20 Jan 2020, Wen Su wrote:
> From: Wen Su <wen.su@mediatek.com>
>
> add dt-binding document for MediaTek MT6359 PMIC
>
> Reviewed-by: Rob Herring <robh@kernel.org>
> Signed-off-by: Wen Su <wen.su@mediatek.com>
These are in the wrong order. Tags should describe history, thus
should be in chronological order. For instance, the ordering you used
describes Rob reviewing the patch *before* you sent it, which is not
possible.
> ---
> .../bindings/regulator/mt6359-regulator.txt | 59 ++++++++++++++++++++++
> 1 file changed, 59 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/regulator/mt6359-regulator.txt
--
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
WARNING: multiple messages have this Message-ID (diff)
From: Lee Jones <lee.jones@linaro.org>
To: Wen Su <Wen.Su@mediatek.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org, wsd_upstream@mediatek.com,
linux-kernel@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
linux-mediatek@lists.infradead.org,
Matthias Brugger <matthias.bgg@gmail.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [RESEND 1/4] dt-bindings: regulator: Add document for MT6359 regulator
Date: Mon, 20 Jan 2020 08:43:55 +0000 [thread overview]
Message-ID: <20200120084355.GW15507@dell> (raw)
In-Reply-To: <1579506450-21830-2-git-send-email-Wen.Su@mediatek.com>
On Mon, 20 Jan 2020, Wen Su wrote:
> From: Wen Su <wen.su@mediatek.com>
>
> add dt-binding document for MediaTek MT6359 PMIC
>
> Reviewed-by: Rob Herring <robh@kernel.org>
> Signed-off-by: Wen Su <wen.su@mediatek.com>
These are in the wrong order. Tags should describe history, thus
should be in chronological order. For instance, the ordering you used
describes Rob reviewing the patch *before* you sent it, which is not
possible.
> ---
> .../bindings/regulator/mt6359-regulator.txt | 59 ++++++++++++++++++++++
> 1 file changed, 59 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/regulator/mt6359-regulator.txt
--
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-01-20 8:43 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-20 7:47 [RESEND 0/4] Add Support for MediaTek PMIC MT6359 Regulator Wen Su
2020-01-20 7:47 ` Wen Su
2020-01-20 7:47 ` Wen Su
2020-01-20 7:47 ` [RESEND 1/4] dt-bindings: regulator: Add document for MT6359 regulator Wen Su
2020-01-20 7:47 ` Wen Su
2020-01-20 7:47 ` Wen Su
2020-01-20 8:43 ` Lee Jones [this message]
2020-01-20 8:43 ` Lee Jones
2020-01-20 8:43 ` Lee Jones
2020-01-22 2:05 ` Wen Su
2020-01-22 2:05 ` Wen Su
2020-01-22 2:05 ` Wen Su
2020-01-20 18:43 ` Mark Brown
2020-01-20 18:43 ` Mark Brown
2020-01-20 18:43 ` Mark Brown
2020-01-20 7:47 ` [RESEND 2/4] mfd: Add for PMIC MT6359 registers definition Wen Su
2020-01-20 7:47 ` Wen Su
2020-01-20 7:47 ` Wen Su
2020-01-20 8:44 ` Lee Jones
2020-01-20 8:44 ` Lee Jones
2020-01-20 8:44 ` Lee Jones
2020-01-20 7:47 ` [RESEND 3/4] regulator: mt6359: Add support for MT6359 regulator Wen Su
2020-01-20 7:47 ` Wen Su
2020-01-20 7:47 ` Wen Su
2020-01-20 19:04 ` Mark Brown
2020-01-20 19:04 ` Mark Brown
2020-01-20 19:04 ` Mark Brown
2020-01-22 2:23 ` Wen Su
2020-01-22 2:23 ` Wen Su
2020-01-22 2:23 ` Wen Su
2020-01-22 12:34 ` Mark Brown
2020-01-22 12:34 ` Mark Brown
2020-01-22 12:34 ` Mark Brown
2020-01-20 7:47 ` [RESEND 4/4] arm64: dts: mt6359: add PMIC MT6359 related nodes Wen Su
2020-01-20 7:47 ` Wen Su
2020-01-20 7:47 ` Wen Su
2020-01-20 8:41 ` [RESEND 0/4] Add Support for MediaTek PMIC MT6359 Regulator Lee Jones
2020-01-20 8:41 ` Lee Jones
2020-01-20 8:41 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200120084355.GW15507@dell \
--to=lee.jones@linaro.org \
--cc=Wen.Su@mediatek.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=matthias.bgg@gmail.com \
--cc=robh+dt@kernel.org \
--cc=wsd_upstream@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.