From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Jeff LaBundy <jeff@labundy.com>
Cc: "lee.jones@linaro.org" <lee.jones@linaro.org>,
"dmitry.torokhov@gmail.com" <dmitry.torokhov@gmail.com>,
"thierry.reding@gmail.com" <thierry.reding@gmail.com>,
"jic23@kernel.org" <jic23@kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-input@vger.kernel.org" <linux-input@vger.kernel.org>,
"linux-pwm@vger.kernel.org" <linux-pwm@vger.kernel.org>,
"knaack.h@gmx.de" <knaack.h@gmx.de>,
"lars@metafoo.de" <lars@metafoo.de>,
"pmeerw@pmeerw.net" <pmeerw@pmeerw.net>,
"linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"mark.rutland@arm.com" <mark.rutland@arm.com>,
"kernel@pengutronix.de" <kernel@pengutronix.de>
Subject: Re: [PATCH v4 4/7] pwm: Add support for Azoteq IQS620A PWM generator
Date: Wed, 22 Jan 2020 08:02:21 +0100 [thread overview]
Message-ID: <20200122070221.mq6a5lejsepnajgf@pengutronix.de> (raw)
In-Reply-To: <20200122035608.GA1455@labundy.com>
Hello Jeff,
On Wed, Jan 22, 2020 at 03:56:14AM +0000, Jeff LaBundy wrote:
> > > The only problem is that leds-pwm disables the pwm at start-up, so the end
> > > result is the same anyway. Regardless of the behavior of any one consumer,
> > > however, I'm slightly inclined to go with the second option as it seems to
> > > be less restrictive and more maintainable. Let me know if you disagree.
> >
> > With
> >
> > default-state = "keep";
> >
> > in your dt the LED shouldn't get disabled.
>
> I see default-state defined as a common LED property, but leds-pwm doesn't
> seem to use it unfortunately. Looking through its code, brightness is just
> initialized to zero unconditionally.
Sounds like a bug.
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | https://www.pengutronix.de/ |
WARNING: multiple messages have this Message-ID (diff)
From: "Uwe Kleine-König" <u.kleine-koenig-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
To: Jeff LaBundy <jeff-Sk+WRT7NHmFBDgjK7y7TUQ@public.gmane.org>
Cc: "lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org"
<lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
"dmitry.torokhov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org"
<dmitry.torokhov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
"thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org"
<thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
"jic23-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org"
<jic23-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
"devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"linux-input-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-input-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"linux-pwm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-pwm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"knaack.h-Mmb7MZpHnFY@public.gmane.org"
<knaack.h-Mmb7MZpHnFY@public.gmane.org>,
"lars-Qo5EllUWu/uELgA04lAiVw@public.gmane.org"
<lars-Qo5EllUWu/uELgA04lAiVw@public.gmane.org>,
"pmeerw-jW+XmwGofnusTnJN9+BGXg@public.gmane.org"
<pmeerw-jW+XmwGofnusTnJN9+BGXg@public.gmane.org>,
"linux-iio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-iio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org"
<robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
"mark.rutland-5wv7dgnIgG8@public.gmane.org"
<mark.rutland-5wv7dgnIgG8@public.gmane.org>,
"kernel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org"
<kernel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
Subject: Re: [PATCH v4 4/7] pwm: Add support for Azoteq IQS620A PWM generator
Date: Wed, 22 Jan 2020 08:02:21 +0100 [thread overview]
Message-ID: <20200122070221.mq6a5lejsepnajgf@pengutronix.de> (raw)
In-Reply-To: <20200122035608.GA1455-Sk+WRT7NHmFBDgjK7y7TUQ@public.gmane.org>
Hello Jeff,
On Wed, Jan 22, 2020 at 03:56:14AM +0000, Jeff LaBundy wrote:
> > > The only problem is that leds-pwm disables the pwm at start-up, so the end
> > > result is the same anyway. Regardless of the behavior of any one consumer,
> > > however, I'm slightly inclined to go with the second option as it seems to
> > > be less restrictive and more maintainable. Let me know if you disagree.
> >
> > With
> >
> > default-state = "keep";
> >
> > in your dt the LED shouldn't get disabled.
>
> I see default-state defined as a common LED property, but leds-pwm doesn't
> seem to use it unfortunately. Looking through its code, brightness is just
> initialized to zero unconditionally.
Sounds like a bug.
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | https://www.pengutronix.de/ |
next prev parent reply other threads:[~2020-01-22 7:02 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-17 2:35 [PATCH v4 0/7] Add support for Azoteq IQS620A/621/622/624/625 Jeff LaBundy
2020-01-17 2:35 ` Jeff LaBundy
2020-01-17 2:35 ` [PATCH v4 1/7] dt-bindings: Add bindings " Jeff LaBundy
2020-01-17 2:35 ` Jeff LaBundy
2020-01-17 2:35 ` [PATCH v4 2/7] mfd: Add support " Jeff LaBundy
2020-01-17 2:35 ` Jeff LaBundy
2020-01-17 13:21 ` Lee Jones
2020-01-20 4:23 ` Jeff LaBundy
2020-01-20 8:00 ` Lee Jones
2020-01-20 8:00 ` Lee Jones
2020-01-22 4:00 ` Jeff LaBundy
2020-01-17 2:35 ` [PATCH v4 3/7] input: keyboard: " Jeff LaBundy
2020-01-17 2:35 ` Jeff LaBundy
2020-01-17 21:33 ` dmitry.torokhov
2020-01-19 22:40 ` Jeff LaBundy
2020-01-19 22:40 ` Jeff LaBundy
2020-01-21 6:55 ` dmitry.torokhov
2020-01-17 2:35 ` [PATCH v4 4/7] pwm: Add support for Azoteq IQS620A PWM generator Jeff LaBundy
2020-01-17 7:34 ` Uwe Kleine-König
2020-01-17 7:34 ` Uwe Kleine-König
2020-01-19 23:32 ` Jeff LaBundy
2020-01-19 23:32 ` Jeff LaBundy
2020-01-20 7:27 ` Uwe Kleine-König
2020-01-20 7:27 ` Uwe Kleine-König
2020-01-22 3:56 ` Jeff LaBundy
2020-01-22 7:02 ` Uwe Kleine-König [this message]
2020-01-22 7:02 ` Uwe Kleine-König
2020-01-17 2:36 ` [PATCH v4 5/7] iio: temperature: Add support for Azoteq IQS620AT temperature sensor Jeff LaBundy
2020-01-17 2:36 ` Jeff LaBundy
2020-01-22 3:28 ` Jeff LaBundy
2020-01-28 9:10 ` Jonathan Cameron
2020-01-28 9:10 ` Jonathan Cameron
2020-01-17 2:36 ` [PATCH v4 6/7] iio: light: Add support for Azoteq IQS621/622 ambient light sensors Jeff LaBundy
2020-01-17 2:36 ` Jeff LaBundy
2020-01-17 2:36 ` [PATCH v4 7/7] iio: position: Add support for Azoteq IQS624/625 angle sensors Jeff LaBundy
2020-01-17 2:36 ` Jeff LaBundy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200122070221.mq6a5lejsepnajgf@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=jeff@labundy.com \
--cc=jic23@kernel.org \
--cc=kernel@pengutronix.de \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=lee.jones@linaro.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pmeerw@pmeerw.net \
--cc=robh+dt@kernel.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.