From: Bjorn Andersson <bjorn.andersson@linaro.org> To: rishabhb@codeaurora.org Cc: Rob Herring <robh+dt@kernel.org>, Mark Rutland <mark.rutland@arm.com>, Ohad Ben-Cohen <ohad@wizery.com>, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-remoteproc@vger.kernel.org, Sibi Sankar <sibis@codeaurora.org> Subject: Re: [PATCH v2 2/8] remoteproc: qcom: Introduce driver to store pil info in IMEM Date: Wed, 22 Jan 2020 15:08:52 -0800 [thread overview] Message-ID: <20200122230849.GC3261042@ripper> (raw) In-Reply-To: <60c10082ba90fbba0f056df8575d205f@codeaurora.org> On Wed 22 Jan 14:56 PST 2020, rishabhb@codeaurora.org wrote: > On 2019-12-26 21:32, Bjorn Andersson wrote: > > diff --git a/drivers/remoteproc/qcom_pil_info.c [..] > > +static int pil_reloc_probe(struct platform_device *pdev) > > +{ > > + struct pil_reloc *reloc; > > + > > + reloc = devm_kzalloc(&pdev->dev, sizeof(*reloc), GFP_KERNEL); > > + if (!reloc) > > + return -ENOMEM; > > + > > + reloc->dev = &pdev->dev; > > + reloc->map = syscon_node_to_regmap(pdev->dev.parent->of_node); > If there are multiple entries like "pil-reloc" in the imem node > mapping the entire imem multiple times may not work. Is there a way > we can somehow just iomap the required region for pil? With the entire imem being represented as a syscon this will be ioremapped once and all callers of syscon_node_to_regmap() (or one of the other syscon getters) will get a regmap back that reference this one mapping. So doing it this way allow us to "map" sections of imem that is smaller than PAGE_SIZE. That said, it means that all imem users/clients should access imem through this syscon regmap. Regards, Bjorn
WARNING: multiple messages have this Message-ID (diff)
From: Bjorn Andersson <bjorn.andersson@linaro.org> To: rishabhb@codeaurora.org Cc: Rob Herring <robh+dt@kernel.org>, Mark Rutland <mark.rutland@arm.com>, Ohad Ben-Cohen <ohad@wizery.com>, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-remoteproc@vger.kernel.org, Sibi Sankar <sibis@codeaurora.org> Subject: Re: [PATCH v2 2/8] remoteproc: qcom: Introduce driver to store pil info in IMEM Date: Wed, 22 Jan 2020 15:08:49 -0800 [thread overview] Message-ID: <20200122230849.GC3261042@ripper> (raw) In-Reply-To: <60c10082ba90fbba0f056df8575d205f@codeaurora.org> On Wed 22 Jan 14:56 PST 2020, rishabhb@codeaurora.org wrote: > On 2019-12-26 21:32, Bjorn Andersson wrote: > > diff --git a/drivers/remoteproc/qcom_pil_info.c [..] > > +static int pil_reloc_probe(struct platform_device *pdev) > > +{ > > + struct pil_reloc *reloc; > > + > > + reloc = devm_kzalloc(&pdev->dev, sizeof(*reloc), GFP_KERNEL); > > + if (!reloc) > > + return -ENOMEM; > > + > > + reloc->dev = &pdev->dev; > > + reloc->map = syscon_node_to_regmap(pdev->dev.parent->of_node); > If there are multiple entries like "pil-reloc" in the imem node > mapping the entire imem multiple times may not work. Is there a way > we can somehow just iomap the required region for pil? With the entire imem being represented as a syscon this will be ioremapped once and all callers of syscon_node_to_regmap() (or one of the other syscon getters) will get a regmap back that reference this one mapping. So doing it this way allow us to "map" sections of imem that is smaller than PAGE_SIZE. That said, it means that all imem users/clients should access imem through this syscon regmap. Regards, Bjorn
next prev parent reply other threads:[~2020-01-22 23:08 UTC|newest] Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-12-27 5:32 [PATCH v2 0/8] remoteproc: qcom: post mortem debug support Bjorn Andersson 2019-12-27 5:32 ` [PATCH v2 1/8] dt-bindings: remoteproc: Add Qualcomm PIL info binding Bjorn Andersson 2020-01-04 21:38 ` Rob Herring 2020-01-04 22:17 ` Bjorn Andersson 2020-01-04 22:17 ` Bjorn Andersson 2020-01-23 22:07 ` Rob Herring 2020-01-23 22:07 ` Rob Herring 2019-12-27 5:32 ` [PATCH v2 2/8] remoteproc: qcom: Introduce driver to store pil info in IMEM Bjorn Andersson 2020-01-10 21:18 ` Mathieu Poirier 2020-01-22 2:02 ` Bjorn Andersson 2020-01-22 2:02 ` Bjorn Andersson 2020-01-22 19:04 ` Mathieu Poirier 2020-01-22 19:19 ` Bjorn Andersson 2020-01-22 19:19 ` Bjorn Andersson 2020-01-22 22:56 ` rishabhb 2020-01-22 23:08 ` Bjorn Andersson [this message] 2020-01-22 23:08 ` Bjorn Andersson 2020-01-22 23:58 ` rishabhb 2020-01-23 5:38 ` Bjorn Andersson 2020-01-23 5:38 ` Bjorn Andersson 2019-12-27 5:32 ` [PATCH v2 3/8] remoteproc: qcom: Update IMEM PIL info on load Bjorn Andersson 2020-01-10 21:19 ` Mathieu Poirier 2019-12-27 5:32 ` [PATCH v2 4/8] arm64: dts: qcom: qcs404: Add IMEM and PIL info region Bjorn Andersson 2019-12-27 5:32 ` [PATCH v2 5/8] arm64: dts: qcom: sdm845: " Bjorn Andersson 2019-12-27 5:32 ` [PATCH v2 6/8] remoteproc: Introduce "panic" callback in ops Bjorn Andersson 2020-01-10 21:23 ` Mathieu Poirier 2020-01-30 10:07 ` Arnaud POULIQUEN 2020-01-30 10:07 ` Arnaud POULIQUEN 2019-12-27 5:32 ` [PATCH v2 7/8] remoteproc: qcom: q6v5: Add common panic handler Bjorn Andersson 2020-01-10 21:28 ` Mathieu Poirier 2020-01-22 19:39 ` Bjorn Andersson 2020-01-22 19:39 ` Bjorn Andersson 2020-01-23 17:01 ` Mathieu Poirier 2020-01-23 17:15 ` Bjorn Andersson 2020-01-23 17:15 ` Bjorn Andersson 2020-01-23 17:49 ` Arnaud POULIQUEN 2020-01-23 17:49 ` Arnaud POULIQUEN 2020-01-24 18:44 ` Mathieu Poirier 2020-01-27 9:46 ` Arnaud POULIQUEN 2020-01-27 9:46 ` Arnaud POULIQUEN 2020-01-29 20:15 ` Mathieu Poirier 2020-01-29 20:15 ` Mathieu Poirier 2020-01-30 10:00 ` Arnaud POULIQUEN 2020-01-30 10:00 ` Arnaud POULIQUEN 2019-12-27 5:32 ` [PATCH v2 8/8] remoteproc: qcom: Introduce panic handler for PAS and ADSP Bjorn Andersson
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200122230849.GC3261042@ripper \ --to=bjorn.andersson@linaro.org \ --cc=devicetree@vger.kernel.org \ --cc=linux-arm-msm@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-remoteproc@vger.kernel.org \ --cc=mark.rutland@arm.com \ --cc=ohad@wizery.com \ --cc=rishabhb@codeaurora.org \ --cc=robh+dt@kernel.org \ --cc=sibis@codeaurora.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.