From: Dmitry Osipenko <digetx@gmail.com> To: "Laxman Dewangan" <ldewangan@nvidia.com>, "Vinod Koul" <vkoul@kernel.org>, "Dan Williams" <dan.j.williams@intel.com>, "Thierry Reding" <thierry.reding@gmail.com>, "Jonathan Hunter" <jonathanh@nvidia.com>, "Michał Mirosław" <mirq-linux@rere.qmqm.pl> Cc: dmaengine@vger.kernel.org, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v5 00/14] NVIDIA Tegra APB DMA driver fixes and improvements Date: Fri, 24 Jan 2020 02:03:11 +0300 [thread overview] Message-ID: <20200123230325.3037-1-digetx@gmail.com> (raw) Hello, This series fixes some problems that I spotted recently, secondly the driver's code gets a cleanup. Please review and apply, thanks in advance! Changelog: v5: - Fixed touching hardware registers after RPM-suspending in the patch "Keep clock enabled only during of DMA transfer", now RPM is kept resumed in the tegra_dma_terminate_all() while needed. Thanks to Jon Hunter for pointing at this problem in a review comment to v4. - The "Clean up runtime PM teardown" patch is replaced with the "Remove assumptions about unavailable runtime PM" patch because I recalled that now RPM is always available on all Tegra SoCs. - The "Clean up suspend-resume" patch got a minor improvement, now tasklet_kill() is invoked before checking of the busy state in tegra_dma_dev_suspend(), this should allow us to catch problems if DMA callback issues a new DMA transfer. - Added Jon's acks to the reviewed patches. v4: - Addressed Jon's request to *not* remove the runtime PM usage, instead there is now new patch that makes RPM more practical: dmaengine: tegra-apb: Keep clock enabled only during of DMA transfer - Added new minor patch to clean up RPM's teardown: dmaengine: tegra-apb: Clean up runtime PM teardown v3: - In the review comment to v1 Michał Mirosław suggested that "Prevent race conditions on channel's freeing" does changes that deserve to be separated into two patches. I factored out and improved tasklet releasing into this new patch: dmaengine: tegra-apb: Clean up tasklet releasing - The "Fix use-after-free" patch got an improved commit message. v2: - I took another look at the driver and spotted few more things that could be improved, which resulted in these new patches: dmaengine: tegra-apb: Remove runtime PM usage dmaengine: tegra-apb: Clean up suspend-resume dmaengine: tegra-apb: Add missing of_dma_controller_free dmaengine: tegra-apb: Allow to compile as a loadable kernel module dmaengine: tegra-apb: Remove MODULE_ALIAS Dmitry Osipenko (14): dmaengine: tegra-apb: Fix use-after-free dmaengine: tegra-apb: Implement synchronization hook dmaengine: tegra-apb: Prevent race conditions on channel's freeing dmaengine: tegra-apb: Clean up tasklet releasing dmaengine: tegra-apb: Prevent race conditions of tasklet vs free list dmaengine: tegra-apb: Use devm_platform_ioremap_resource dmaengine: tegra-apb: Use devm_request_irq dmaengine: tegra-apb: Fix coding style problems dmaengine: tegra-apb: Remove assumptions about unavailable runtime PM dmaengine: tegra-apb: Keep clock enabled only during of DMA transfer dmaengine: tegra-apb: Clean up suspend-resume dmaengine: tegra-apb: Add missing of_dma_controller_free dmaengine: tegra-apb: Allow to compile as a loadable kernel module dmaengine: tegra-apb: Remove MODULE_ALIAS drivers/dma/Kconfig | 2 +- drivers/dma/tegra20-apb-dma.c | 507 +++++++++++++++++----------------- 2 files changed, 260 insertions(+), 249 deletions(-) -- 2.24.0
WARNING: multiple messages have this Message-ID (diff)
From: Dmitry Osipenko <digetx-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> To: "Laxman Dewangan" <ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>, "Vinod Koul" <vkoul-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>, "Dan Williams" <dan.j.williams-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>, "Thierry Reding" <thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>, "Jonathan Hunter" <jonathanh-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>, "Michał Mirosław" <mirq-linux-CoA6ZxLDdyEEUmgCuDUIdw@public.gmane.org> Cc: dmaengine-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org Subject: [PATCH v5 00/14] NVIDIA Tegra APB DMA driver fixes and improvements Date: Fri, 24 Jan 2020 02:03:11 +0300 [thread overview] Message-ID: <20200123230325.3037-1-digetx@gmail.com> (raw) Hello, This series fixes some problems that I spotted recently, secondly the driver's code gets a cleanup. Please review and apply, thanks in advance! Changelog: v5: - Fixed touching hardware registers after RPM-suspending in the patch "Keep clock enabled only during of DMA transfer", now RPM is kept resumed in the tegra_dma_terminate_all() while needed. Thanks to Jon Hunter for pointing at this problem in a review comment to v4. - The "Clean up runtime PM teardown" patch is replaced with the "Remove assumptions about unavailable runtime PM" patch because I recalled that now RPM is always available on all Tegra SoCs. - The "Clean up suspend-resume" patch got a minor improvement, now tasklet_kill() is invoked before checking of the busy state in tegra_dma_dev_suspend(), this should allow us to catch problems if DMA callback issues a new DMA transfer. - Added Jon's acks to the reviewed patches. v4: - Addressed Jon's request to *not* remove the runtime PM usage, instead there is now new patch that makes RPM more practical: dmaengine: tegra-apb: Keep clock enabled only during of DMA transfer - Added new minor patch to clean up RPM's teardown: dmaengine: tegra-apb: Clean up runtime PM teardown v3: - In the review comment to v1 Michał Mirosław suggested that "Prevent race conditions on channel's freeing" does changes that deserve to be separated into two patches. I factored out and improved tasklet releasing into this new patch: dmaengine: tegra-apb: Clean up tasklet releasing - The "Fix use-after-free" patch got an improved commit message. v2: - I took another look at the driver and spotted few more things that could be improved, which resulted in these new patches: dmaengine: tegra-apb: Remove runtime PM usage dmaengine: tegra-apb: Clean up suspend-resume dmaengine: tegra-apb: Add missing of_dma_controller_free dmaengine: tegra-apb: Allow to compile as a loadable kernel module dmaengine: tegra-apb: Remove MODULE_ALIAS Dmitry Osipenko (14): dmaengine: tegra-apb: Fix use-after-free dmaengine: tegra-apb: Implement synchronization hook dmaengine: tegra-apb: Prevent race conditions on channel's freeing dmaengine: tegra-apb: Clean up tasklet releasing dmaengine: tegra-apb: Prevent race conditions of tasklet vs free list dmaengine: tegra-apb: Use devm_platform_ioremap_resource dmaengine: tegra-apb: Use devm_request_irq dmaengine: tegra-apb: Fix coding style problems dmaengine: tegra-apb: Remove assumptions about unavailable runtime PM dmaengine: tegra-apb: Keep clock enabled only during of DMA transfer dmaengine: tegra-apb: Clean up suspend-resume dmaengine: tegra-apb: Add missing of_dma_controller_free dmaengine: tegra-apb: Allow to compile as a loadable kernel module dmaengine: tegra-apb: Remove MODULE_ALIAS drivers/dma/Kconfig | 2 +- drivers/dma/tegra20-apb-dma.c | 507 +++++++++++++++++----------------- 2 files changed, 260 insertions(+), 249 deletions(-) -- 2.24.0
next reply other threads:[~2020-01-23 23:11 UTC|newest] Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-01-23 23:03 Dmitry Osipenko [this message] 2020-01-23 23:03 ` [PATCH v5 00/14] NVIDIA Tegra APB DMA driver fixes and improvements Dmitry Osipenko 2020-01-23 23:03 ` [PATCH v5 01/14] dmaengine: tegra-apb: Fix use-after-free Dmitry Osipenko 2020-01-29 10:56 ` Jon Hunter 2020-01-29 10:56 ` Jon Hunter 2020-01-29 14:38 ` Dmitry Osipenko 2020-01-29 14:38 ` Dmitry Osipenko 2020-01-23 23:03 ` [PATCH v5 02/14] dmaengine: tegra-apb: Implement synchronization hook Dmitry Osipenko 2020-01-23 23:03 ` Dmitry Osipenko 2020-01-23 23:03 ` [PATCH v5 03/14] dmaengine: tegra-apb: Prevent race conditions on channel's freeing Dmitry Osipenko 2020-01-23 23:03 ` Dmitry Osipenko 2020-01-23 23:03 ` [PATCH v5 04/14] dmaengine: tegra-apb: Clean up tasklet releasing Dmitry Osipenko 2020-01-23 23:03 ` Dmitry Osipenko 2020-01-23 23:03 ` [PATCH v5 05/14] dmaengine: tegra-apb: Prevent race conditions of tasklet vs free list Dmitry Osipenko 2020-01-29 11:01 ` Jon Hunter 2020-01-29 11:01 ` Jon Hunter 2020-01-29 14:39 ` Dmitry Osipenko 2020-01-29 14:39 ` Dmitry Osipenko 2020-01-23 23:03 ` [PATCH v5 06/14] dmaengine: tegra-apb: Use devm_platform_ioremap_resource Dmitry Osipenko 2020-01-23 23:03 ` [PATCH v5 07/14] dmaengine: tegra-apb: Use devm_request_irq Dmitry Osipenko 2020-01-23 23:03 ` Dmitry Osipenko 2020-01-23 23:03 ` [PATCH v5 08/14] dmaengine: tegra-apb: Fix coding style problems Dmitry Osipenko 2020-01-29 11:03 ` Jon Hunter 2020-01-29 11:03 ` Jon Hunter 2020-01-29 14:31 ` Dmitry Osipenko 2020-01-23 23:03 ` [PATCH v5 09/14] dmaengine: tegra-apb: Remove assumptions about unavailable runtime PM Dmitry Osipenko 2020-01-23 23:03 ` [PATCH v5 10/14] dmaengine: tegra-apb: Keep clock enabled only during of DMA transfer Dmitry Osipenko 2020-01-23 23:03 ` Dmitry Osipenko 2020-01-23 23:03 ` [PATCH v5 11/14] dmaengine: tegra-apb: Clean up suspend-resume Dmitry Osipenko 2020-01-23 23:03 ` Dmitry Osipenko 2020-01-23 23:03 ` [PATCH v5 12/14] dmaengine: tegra-apb: Add missing of_dma_controller_free Dmitry Osipenko 2020-01-23 23:03 ` [PATCH v5 13/14] dmaengine: tegra-apb: Allow to compile as a loadable kernel module Dmitry Osipenko 2020-01-23 23:03 ` Dmitry Osipenko 2020-01-23 23:03 ` [PATCH v5 14/14] dmaengine: tegra-apb: Remove MODULE_ALIAS Dmitry Osipenko 2020-01-23 23:03 ` Dmitry Osipenko
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200123230325.3037-1-digetx@gmail.com \ --to=digetx@gmail.com \ --cc=dan.j.williams@intel.com \ --cc=dmaengine@vger.kernel.org \ --cc=jonathanh@nvidia.com \ --cc=ldewangan@nvidia.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-tegra@vger.kernel.org \ --cc=mirq-linux@rere.qmqm.pl \ --cc=thierry.reding@gmail.com \ --cc=vkoul@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.