From: Matthew Wilcox <willy@infradead.org>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: linux-fsdevel@vger.kernel.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, linux-btrfs@vger.kernel.org,
linux-erofs@lists.ozlabs.org, linux-ext4@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net,
linux-xfs@vger.kernel.org, cluster-devel@redhat.com,
ocfs2-devel@oss.oracle.com
Subject: Re: [PATCH 04/12] mm: Add readahead address space operation
Date: Fri, 31 Jan 2020 16:25:42 -0800 [thread overview]
Message-ID: <20200201002542.GA20648@bombadil.infradead.org> (raw)
In-Reply-To: <4e28eb80-d602-47e6-51ec-63bb39e1a296@infradead.org>
On Fri, Jan 24, 2020 at 07:57:40PM -0800, Randy Dunlap wrote:
> > +``readahead``
> > + called by the VM to read pages associated with the address_space
> > + object. The pages are consecutive in the page cache and are
> > + locked. The implementation should decrement the page refcount after
> > + attempting I/O on each page. Usually the page will be unlocked by
> > + the I/O completion handler. If the function does not attempt I/O on
> > + some pages, return the number of pages which were not read so the
> > + common code can unlock the pages for you.
> > +
>
> Please use consistent indentation (tabs).
This turned out to be not my fault. The vim rst ... mode? plugin?
Whatever it is, it's converting tabs to spaces! To fix it, I had to
rename the file to .txt, make the edits, then rename it back. This is
very poor behaviour.
WARNING: multiple messages have this Message-ID (diff)
From: Matthew Wilcox <willy@infradead.org>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: cluster-devel@redhat.com, linux-kernel@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net,
linux-xfs@vger.kernel.org, linux-mm@kvack.org,
ocfs2-devel@oss.oracle.com, linux-fsdevel@vger.kernel.org,
linux-ext4@vger.kernel.org, linux-erofs@lists.ozlabs.org,
linux-btrfs@vger.kernel.org
Subject: Re: [f2fs-dev] [PATCH 04/12] mm: Add readahead address space operation
Date: Fri, 31 Jan 2020 16:25:42 -0800 [thread overview]
Message-ID: <20200201002542.GA20648@bombadil.infradead.org> (raw)
In-Reply-To: <4e28eb80-d602-47e6-51ec-63bb39e1a296@infradead.org>
On Fri, Jan 24, 2020 at 07:57:40PM -0800, Randy Dunlap wrote:
> > +``readahead``
> > + called by the VM to read pages associated with the address_space
> > + object. The pages are consecutive in the page cache and are
> > + locked. The implementation should decrement the page refcount after
> > + attempting I/O on each page. Usually the page will be unlocked by
> > + the I/O completion handler. If the function does not attempt I/O on
> > + some pages, return the number of pages which were not read so the
> > + common code can unlock the pages for you.
> > +
>
> Please use consistent indentation (tabs).
This turned out to be not my fault. The vim rst ... mode? plugin?
Whatever it is, it's converting tabs to spaces! To fix it, I had to
rename the file to .txt, make the edits, then rename it back. This is
very poor behaviour.
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
WARNING: multiple messages have this Message-ID (diff)
From: Matthew Wilcox <willy@infradead.org>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: cluster-devel@redhat.com, linux-kernel@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net,
linux-xfs@vger.kernel.org, linux-mm@kvack.org,
ocfs2-devel@oss.oracle.com, linux-fsdevel@vger.kernel.org,
linux-ext4@vger.kernel.org, linux-erofs@lists.ozlabs.org,
linux-btrfs@vger.kernel.org
Subject: Re: [PATCH 04/12] mm: Add readahead address space operation
Date: Fri, 31 Jan 2020 16:25:42 -0800 [thread overview]
Message-ID: <20200201002542.GA20648@bombadil.infradead.org> (raw)
In-Reply-To: <4e28eb80-d602-47e6-51ec-63bb39e1a296@infradead.org>
On Fri, Jan 24, 2020 at 07:57:40PM -0800, Randy Dunlap wrote:
> > +``readahead``
> > + called by the VM to read pages associated with the address_space
> > + object. The pages are consecutive in the page cache and are
> > + locked. The implementation should decrement the page refcount after
> > + attempting I/O on each page. Usually the page will be unlocked by
> > + the I/O completion handler. If the function does not attempt I/O on
> > + some pages, return the number of pages which were not read so the
> > + common code can unlock the pages for you.
> > +
>
> Please use consistent indentation (tabs).
This turned out to be not my fault. The vim rst ... mode? plugin?
Whatever it is, it's converting tabs to spaces! To fix it, I had to
rename the file to .txt, make the edits, then rename it back. This is
very poor behaviour.
WARNING: multiple messages have this Message-ID (diff)
From: Matthew Wilcox <willy@infradead.org>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [PATCH 04/12] mm: Add readahead address space operation
Date: Fri, 31 Jan 2020 16:25:42 -0800 [thread overview]
Message-ID: <20200201002542.GA20648@bombadil.infradead.org> (raw)
In-Reply-To: <4e28eb80-d602-47e6-51ec-63bb39e1a296@infradead.org>
On Fri, Jan 24, 2020 at 07:57:40PM -0800, Randy Dunlap wrote:
> > +``readahead``
> > + called by the VM to read pages associated with the address_space
> > + object. The pages are consecutive in the page cache and are
> > + locked. The implementation should decrement the page refcount after
> > + attempting I/O on each page. Usually the page will be unlocked by
> > + the I/O completion handler. If the function does not attempt I/O on
> > + some pages, return the number of pages which were not read so the
> > + common code can unlock the pages for you.
> > +
>
> Please use consistent indentation (tabs).
This turned out to be not my fault. The vim rst ... mode? plugin?
Whatever it is, it's converting tabs to spaces! To fix it, I had to
rename the file to .txt, make the edits, then rename it back. This is
very poor behaviour.
next prev parent reply other threads:[~2020-02-01 0:25 UTC|newest]
Thread overview: 74+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-25 1:35 [PATCH 00/12] Change readahead API Matthew Wilcox
2020-01-25 1:35 ` [Cluster-devel] " Matthew Wilcox
2020-01-25 1:35 ` Matthew Wilcox
2020-01-25 1:35 ` [f2fs-dev] " Matthew Wilcox
2020-01-25 1:35 ` [PATCH 01/12] mm: Fix the return type of __do_page_cache_readahead Matthew Wilcox
2020-01-25 1:35 ` [PATCH 02/12] readahead: Ignore return value of ->readpages Matthew Wilcox
2020-01-25 1:35 ` [PATCH 03/12] readahead: Put pages in cache earlier Matthew Wilcox
2020-01-25 1:35 ` [Cluster-devel] " Matthew Wilcox
2020-01-25 1:35 ` Matthew Wilcox
2020-01-25 1:35 ` [f2fs-dev] " Matthew Wilcox
2020-01-25 19:44 ` Matthew Wilcox
2020-01-25 19:44 ` [Cluster-devel] " Matthew Wilcox
2020-01-25 19:44 ` Matthew Wilcox
2020-01-25 19:44 ` [f2fs-dev] " Matthew Wilcox
2020-01-25 1:35 ` [PATCH 04/12] mm: Add readahead address space operation Matthew Wilcox
2020-01-25 1:35 ` [Cluster-devel] " Matthew Wilcox
2020-01-25 1:35 ` Matthew Wilcox
2020-01-25 1:35 ` [f2fs-dev] " Matthew Wilcox
2020-01-25 3:57 ` Randy Dunlap
2020-01-25 3:57 ` [Cluster-devel] " Randy Dunlap
2020-01-25 3:57 ` Randy Dunlap
2020-01-25 3:57 ` [f2fs-dev] " Randy Dunlap
2020-02-01 0:25 ` Matthew Wilcox [this message]
2020-02-01 0:25 ` [Cluster-devel] " Matthew Wilcox
2020-02-01 0:25 ` Matthew Wilcox
2020-02-01 0:25 ` [f2fs-dev] " Matthew Wilcox
2020-01-29 0:24 ` Dave Chinner
2020-01-29 0:24 ` [Cluster-devel] " Dave Chinner
2020-01-29 0:24 ` Dave Chinner
2020-01-29 0:24 ` [f2fs-dev] " Dave Chinner
2020-01-29 0:24 ` [Ocfs2-devel] " Dave Chinner
2020-01-30 8:00 ` Matthew Wilcox
2020-01-30 8:00 ` [Cluster-devel] " Matthew Wilcox
2020-01-30 8:00 ` Matthew Wilcox
2020-01-30 8:00 ` [f2fs-dev] " Matthew Wilcox
2020-01-25 1:35 ` [PATCH 05/12] fs: Convert mpage_readpages to mpage_readahead Matthew Wilcox
2020-01-25 1:35 ` [Cluster-devel] " Matthew Wilcox
2020-01-25 1:35 ` [PATCH 06/12] btrfs: Convert from readpages to readahead Matthew Wilcox
2020-01-29 0:46 ` Dave Chinner
2020-01-30 8:09 ` Matthew Wilcox
2020-01-31 2:17 ` Dave Chinner
2020-01-25 1:35 ` [PATCH 07/12] erofs: Convert uncompressed files " Matthew Wilcox
2020-01-25 1:35 ` Matthew Wilcox
2020-01-25 1:53 ` Gao Xiang
2020-01-25 1:53 ` Gao Xiang via Linux-erofs
2020-01-25 19:09 ` Matthew Wilcox
2020-01-29 0:57 ` Dave Chinner
2020-01-29 0:57 ` Dave Chinner
2020-01-30 8:10 ` Matthew Wilcox
2020-01-30 8:10 ` Matthew Wilcox
2020-01-25 1:35 ` [PATCH 08/12] erofs: Convert compressed " Matthew Wilcox
2020-01-25 1:35 ` Matthew Wilcox
2020-01-25 1:35 ` [PATCH 09/12] ext4: Convert " Matthew Wilcox
2020-01-25 1:35 ` [PATCH 10/12] f2fs: " Matthew Wilcox
2020-01-25 1:35 ` [f2fs-dev] " Matthew Wilcox
2020-01-25 1:35 ` [PATCH 11/12] fuse: " Matthew Wilcox
2020-01-29 1:08 ` Dave Chinner
2020-01-30 21:35 ` Matthew Wilcox
2020-01-31 2:19 ` Dave Chinner
2020-01-29 10:50 ` Miklos Szeredi
2020-01-29 10:50 ` Miklos Szeredi
2020-01-30 7:26 ` Matthew Wilcox
2020-01-25 1:35 ` [PATCH 12/12] iomap: " Matthew Wilcox
2020-01-29 1:38 ` Dave Chinner
2020-01-31 9:44 ` Matthew Wilcox
2020-02-13 4:38 ` [PATCH 00/12] Change readahead API Andrew Morton
2020-02-13 4:38 ` [Cluster-devel] " Andrew Morton
2020-02-13 4:38 ` Andrew Morton
2020-02-13 4:38 ` [f2fs-dev] " Andrew Morton
2020-02-13 4:38 ` [Ocfs2-devel] " Andrew Morton
2020-02-13 13:43 ` Matthew Wilcox
2020-02-13 13:43 ` [Cluster-devel] " Matthew Wilcox
2020-02-13 13:43 ` Matthew Wilcox
2020-02-13 13:43 ` [f2fs-dev] " Matthew Wilcox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200201002542.GA20648@bombadil.infradead.org \
--to=willy@infradead.org \
--cc=cluster-devel@redhat.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-erofs@lists.ozlabs.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-xfs@vger.kernel.org \
--cc=ocfs2-devel@oss.oracle.com \
--cc=rdunlap@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.