[PATCH v3 12/17] media: imx: csi: Add missing notifier unregister/cleanup

All of lore.kernel.org
 help / color / mirror / Atom feed

From: Steve Longerbeam <slongerbeam@gmail.com>
To: linux-media@vger.kernel.org, Rui Miguel Silva <rmfrfs@gmail.com>,
	Philipp Zabel <p.zabel@pengutronix.de>
Cc: Steve Longerbeam <slongerbeam@gmail.com>,
	Mauro Carvalho Chehab <mchehab+samsung@kernel.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Shawn Guo <shawnguo@kernel.org>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	Pengutronix Kernel Team <kernel@pengutronix.de>,
	Fabio Estevam <festevam@gmail.com>,
	NXP Linux Team <linux-imx@nxp.com>,
	Sakari Ailus <sakari.ailus@linux.intel.com>,
	devel@driverdev.osuosl.org (open list:STAGING SUBSYSTEM),
	linux-arm-kernel@lists.infradead.org (moderated
	list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE),
	linux-kernel@vger.kernel.org (open list)
Subject: [PATCH v3 12/17] media: imx: csi: Add missing notifier unregister/cleanup
Date: Tue,  4 Feb 2020 15:49:13 -0800	[thread overview]
Message-ID: <20200204234918.20425-13-slongerbeam@gmail.com> (raw)
In-Reply-To: <20200204234918.20425-1-slongerbeam@gmail.com>

Add the missing calls to unregister and cleanup the subdev notifier in
imx_csi_remove().

Fixes: c893500a16baf ("media: imx: csi: Register a subdev notifier")
Signed-off-by: Steve Longerbeam <slongerbeam@gmail.com>
---
 drivers/staging/media/imx/imx-media-csi.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/staging/media/imx/imx-media-csi.c b/drivers/staging/media/imx/imx-media-csi.c
index 3e2afdd59276..bea6a70cc353 100644
--- a/drivers/staging/media/imx/imx-media-csi.c
+++ b/drivers/staging/media/imx/imx-media-csi.c
@@ -2030,6 +2030,8 @@ static int imx_csi_remove(struct platform_device *pdev)
 
 	v4l2_ctrl_handler_free(&priv->ctrl_hdlr);
 	mutex_destroy(&priv->lock);
+	v4l2_async_notifier_unregister(&priv->notifier);
+	v4l2_async_notifier_cleanup(&priv->notifier);
 	v4l2_async_unregister_subdev(sd);
 	media_entity_cleanup(&sd->entity);
 
-- 
2.17.1

WARNING: multiple messages have this Message-ID (diff)

From: Steve Longerbeam <slongerbeam@gmail.com>
To: linux-media@vger.kernel.org, Rui Miguel Silva <rmfrfs@gmail.com>,
	Philipp Zabel <p.zabel@pengutronix.de>
Cc: "open list:STAGING SUBSYSTEM" <devel@driverdev.osuosl.org>,
	Sakari Ailus <sakari.ailus@linux.intel.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	open list <linux-kernel@vger.kernel.org>,
	NXP Linux Team <linux-imx@nxp.com>,
	Pengutronix Kernel Team <kernel@pengutronix.de>,
	Steve Longerbeam <slongerbeam@gmail.com>,
	Mauro Carvalho Chehab <mchehab+samsung@kernel.org>,
	Shawn Guo <shawnguo@kernel.org>,
	"moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE"
	<linux-arm-kernel@lists.infradead.org>
Subject: [PATCH v3 12/17] media: imx: csi: Add missing notifier unregister/cleanup
Date: Tue,  4 Feb 2020 15:49:13 -0800	[thread overview]
Message-ID: <20200204234918.20425-13-slongerbeam@gmail.com> (raw)
In-Reply-To: <20200204234918.20425-1-slongerbeam@gmail.com>

Add the missing calls to unregister and cleanup the subdev notifier in
imx_csi_remove().

Fixes: c893500a16baf ("media: imx: csi: Register a subdev notifier")
Signed-off-by: Steve Longerbeam <slongerbeam@gmail.com>
---
 drivers/staging/media/imx/imx-media-csi.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/staging/media/imx/imx-media-csi.c b/drivers/staging/media/imx/imx-media-csi.c
index 3e2afdd59276..bea6a70cc353 100644
--- a/drivers/staging/media/imx/imx-media-csi.c
+++ b/drivers/staging/media/imx/imx-media-csi.c
@@ -2030,6 +2030,8 @@ static int imx_csi_remove(struct platform_device *pdev)
 
 	v4l2_ctrl_handler_free(&priv->ctrl_hdlr);
 	mutex_destroy(&priv->lock);
+	v4l2_async_notifier_unregister(&priv->notifier);
+	v4l2_async_notifier_cleanup(&priv->notifier);
 	v4l2_async_unregister_subdev(sd);
 	media_entity_cleanup(&sd->entity);
 
-- 
2.17.1

_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

WARNING: multiple messages have this Message-ID (diff)

From: Steve Longerbeam <slongerbeam@gmail.com>
To: linux-media@vger.kernel.org, Rui Miguel Silva <rmfrfs@gmail.com>,
	Philipp Zabel <p.zabel@pengutronix.de>
Cc: "open list:STAGING SUBSYSTEM" <devel@driverdev.osuosl.org>,
	Fabio Estevam <festevam@gmail.com>,
	Sakari Ailus <sakari.ailus@linux.intel.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	open list <linux-kernel@vger.kernel.org>,
	NXP Linux Team <linux-imx@nxp.com>,
	Pengutronix Kernel Team <kernel@pengutronix.de>,
	Steve Longerbeam <slongerbeam@gmail.com>,
	Mauro Carvalho Chehab <mchehab+samsung@kernel.org>,
	Shawn Guo <shawnguo@kernel.org>,
	"moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE"
	<linux-arm-kernel@lists.infradead.org>
Subject: [PATCH v3 12/17] media: imx: csi: Add missing notifier unregister/cleanup
Date: Tue,  4 Feb 2020 15:49:13 -0800	[thread overview]
Message-ID: <20200204234918.20425-13-slongerbeam@gmail.com> (raw)
In-Reply-To: <20200204234918.20425-1-slongerbeam@gmail.com>

Add the missing calls to unregister and cleanup the subdev notifier in
imx_csi_remove().

Fixes: c893500a16baf ("media: imx: csi: Register a subdev notifier")
Signed-off-by: Steve Longerbeam <slongerbeam@gmail.com>
---
 drivers/staging/media/imx/imx-media-csi.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/staging/media/imx/imx-media-csi.c b/drivers/staging/media/imx/imx-media-csi.c
index 3e2afdd59276..bea6a70cc353 100644
--- a/drivers/staging/media/imx/imx-media-csi.c
+++ b/drivers/staging/media/imx/imx-media-csi.c
@@ -2030,6 +2030,8 @@ static int imx_csi_remove(struct platform_device *pdev)
 
 	v4l2_ctrl_handler_free(&priv->ctrl_hdlr);
 	mutex_destroy(&priv->lock);
+	v4l2_async_notifier_unregister(&priv->notifier);
+	v4l2_async_notifier_cleanup(&priv->notifier);
 	v4l2_async_unregister_subdev(sd);
 	media_entity_cleanup(&sd->entity);
 
-- 
2.17.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

next prev parent reply	other threads:[~2020-02-04 23:50 UTC|newest]

Thread overview: 49+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-04 23:49 [PATCH v3 00/17] media: imx: Create media links in bound notifiers Steve Longerbeam
2020-02-04 23:49 ` [PATCH v3 01/17] media: entity: Pass entity to get_fwnode_pad operation Steve Longerbeam
2020-02-04 23:49 ` [PATCH v3 02/17] media: v4l2-fwnode: Pass notifier to v4l2_async_register_fwnode_subdev() Steve Longerbeam
2020-02-04 23:49   ` Steve Longerbeam
2020-02-04 23:49   ` Steve Longerbeam
2020-02-05  9:02   ` Andy Shevchenko
2020-02-05  9:02     ` Andy Shevchenko
2020-02-05  9:02     ` Andy Shevchenko
2020-02-04 23:49 ` [PATCH v3 03/17] media: imx: csi: Implement get_fwnode_pad op Steve Longerbeam
2020-02-04 23:49   ` Steve Longerbeam
2020-02-04 23:49   ` Steve Longerbeam
2020-02-04 23:49 ` [PATCH v3 04/17] media: imx: mipi csi-2: " Steve Longerbeam
2020-02-04 23:49   ` Steve Longerbeam
2020-02-04 23:49   ` Steve Longerbeam
2020-02-04 23:49 ` [PATCH v3 05/17] media: video-mux: " Steve Longerbeam
2020-02-04 23:49 ` [PATCH v3 06/17] media: imx: Add imx_media_create_fwnode_pad_link() Steve Longerbeam
2020-02-04 23:49   ` Steve Longerbeam
2020-02-04 23:49   ` Steve Longerbeam
2020-02-04 23:49 ` [PATCH v3 07/17] media: video-mux: Create media links in bound notifier Steve Longerbeam
2020-02-04 23:49 ` [PATCH v3 08/17] media: imx: mipi csi-2: " Steve Longerbeam
2020-02-04 23:49   ` Steve Longerbeam
2020-02-04 23:49   ` Steve Longerbeam
2020-02-04 23:49 ` [PATCH v3 09/17] media: imx7-mipi-csis: " Steve Longerbeam
2020-02-04 23:49   ` Steve Longerbeam
2020-02-04 23:49   ` Steve Longerbeam
2020-02-04 23:49 ` [PATCH v3 10/17] media: imx7-media-csi: " Steve Longerbeam
2020-02-04 23:49   ` Steve Longerbeam
2020-02-04 23:49   ` Steve Longerbeam
2020-02-04 23:49 ` [PATCH v3 11/17] media: imx: csi: Embed notifier in struct csi_priv Steve Longerbeam
2020-02-04 23:49   ` Steve Longerbeam
2020-02-04 23:49   ` Steve Longerbeam
2020-02-04 23:49 ` Steve Longerbeam [this message]
2020-02-04 23:49   ` [PATCH v3 12/17] media: imx: csi: Add missing notifier unregister/cleanup Steve Longerbeam
2020-02-04 23:49   ` Steve Longerbeam
2020-02-04 23:49 ` [PATCH v3 13/17] media: imx: csi: Create media links in bound notifier Steve Longerbeam
2020-02-04 23:49   ` Steve Longerbeam
2020-02-04 23:49   ` Steve Longerbeam
2020-02-04 23:49 ` [PATCH v3 14/17] media: imx: csi: Lookup upstream endpoint with imx_media_get_pad_fwnode Steve Longerbeam
2020-02-04 23:49   ` Steve Longerbeam
2020-02-04 23:49   ` Steve Longerbeam
2020-02-04 23:49 ` [PATCH v3 15/17] media: imx: Create missing links from CSI-2 receiver Steve Longerbeam
2020-02-04 23:49   ` Steve Longerbeam
2020-02-04 23:49   ` Steve Longerbeam
2020-02-04 23:49 ` [PATCH v3 16/17] media: imx: silence a couple debug messages Steve Longerbeam
2020-02-04 23:49   ` Steve Longerbeam
2020-02-04 23:49   ` Steve Longerbeam
2020-02-04 23:49 ` [PATCH v3 17/17] media: imx: TODO: Remove media link creation todos Steve Longerbeam
2020-02-04 23:49   ` Steve Longerbeam
2020-02-04 23:49   ` Steve Longerbeam

find likely ancestor, descendant, or conflicting patches for this message:
dfblob:3e2afdd5927 dfblob:3e2afdd5927 dfblob:3e2afdd5927
dfblob:bea6a70cc35 dfblob:bea6a70cc35 dfblob:bea6a70cc35
	(help)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200204234918.20425-13-slongerbeam@gmail.com \
    --to=slongerbeam@gmail.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=festevam@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=kernel@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-imx@nxp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab+samsung@kernel.org \
    --cc=p.zabel@pengutronix.de \
    --cc=rmfrfs@gmail.com \
    --cc=s.hauer@pengutronix.de \
    --cc=sakari.ailus@linux.intel.com \
    --cc=shawnguo@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Be sure your reply has a Subject: header at the top and a blank line before the message body.

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.