From: Stephen Rothwell <sfr@canb.auug.org.au> To: Geert Uytterhoeven <geert@linux-m68k.org> Cc: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>, Mark Brown <broonie@kernel.org>, ALSA Development Mailing List <alsa-devel@alsa-project.org>, Lee Jones <lee.jones@linaro.org>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org> Subject: Re: [PATCH v2] ASoC: wcd934x: Add missing COMMON_CLK dependency Date: Wed, 5 Feb 2020 11:37:55 +1100 [thread overview] Message-ID: <20200205113755.7daca1f1@canb.auug.org.au> (raw) In-Reply-To: <CAMuHMdVw0crXH+=7e9GGLUR-c-SxZDz9kQdeWxkZyZ9Jx7CVig@mail.gmail.com> [-- Attachment #1: Type: text/plain, Size: 1313 bytes --] Hi Geert, On Tue, 4 Feb 2020 14:21:01 +0100 Geert Uytterhoeven <geert@linux-m68k.org> wrote: > > On Tue, Feb 4, 2020 at 12:14 PM Srinivas Kandagatla > <srinivas.kandagatla@linaro.org> wrote: > > Looks like some platforms are not yet using COMMON CLK. > > > > PowerPC allyesconfig failed with below error in next > > > > ld: sound/soc/codecs/wcd934x.o:(.toc+0x0): > > undefined reference to `of_clk_src_simple_get' > > ld: sound/soc/codecs/wcd934x.o: in function `.wcd934x_codec_probe': > > wcd934x.c:(.text.wcd934x_codec_probe+0x3d4): > > undefined reference to `.__clk_get_name' > > ld: wcd934x.c:(.text.wcd934x_codec_probe+0x438): > > undefined reference to `.clk_hw_register' > > ld: wcd934x.c:(.text.wcd934x_codec_probe+0x474): > > undefined reference to `.of_clk_add_provider' > > > > Add the missing COMMON_CLK dependency to fix this errors. > > > > Reported-by: Stephen Rothwell <sfr@canb.auug.org.au> > > Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org> > > Thanks for your patch! > > But did this change really fix your PowerPC allyesconfig build? It does not :-( > SND_SOC_ALL_CODECS will still select it... > > Fix sent. I have applied that patch to linux-next today. -- Cheers, Stephen Rothwell [-- Attachment #2: OpenPGP digital signature --] [-- Type: application/pgp-signature, Size: 488 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Stephen Rothwell <sfr@canb.auug.org.au> To: Geert Uytterhoeven <geert@linux-m68k.org> Cc: Lee Jones <lee.jones@linaro.org>, ALSA Development Mailing List <alsa-devel@alsa-project.org>, Mark Brown <broonie@kernel.org>, Srinivas Kandagatla <srinivas.kandagatla@linaro.org>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org> Subject: Re: [alsa-devel] [PATCH v2] ASoC: wcd934x: Add missing COMMON_CLK dependency Date: Wed, 5 Feb 2020 11:37:55 +1100 [thread overview] Message-ID: <20200205113755.7daca1f1@canb.auug.org.au> (raw) In-Reply-To: <CAMuHMdVw0crXH+=7e9GGLUR-c-SxZDz9kQdeWxkZyZ9Jx7CVig@mail.gmail.com> [-- Attachment #1.1: Type: text/plain, Size: 1313 bytes --] Hi Geert, On Tue, 4 Feb 2020 14:21:01 +0100 Geert Uytterhoeven <geert@linux-m68k.org> wrote: > > On Tue, Feb 4, 2020 at 12:14 PM Srinivas Kandagatla > <srinivas.kandagatla@linaro.org> wrote: > > Looks like some platforms are not yet using COMMON CLK. > > > > PowerPC allyesconfig failed with below error in next > > > > ld: sound/soc/codecs/wcd934x.o:(.toc+0x0): > > undefined reference to `of_clk_src_simple_get' > > ld: sound/soc/codecs/wcd934x.o: in function `.wcd934x_codec_probe': > > wcd934x.c:(.text.wcd934x_codec_probe+0x3d4): > > undefined reference to `.__clk_get_name' > > ld: wcd934x.c:(.text.wcd934x_codec_probe+0x438): > > undefined reference to `.clk_hw_register' > > ld: wcd934x.c:(.text.wcd934x_codec_probe+0x474): > > undefined reference to `.of_clk_add_provider' > > > > Add the missing COMMON_CLK dependency to fix this errors. > > > > Reported-by: Stephen Rothwell <sfr@canb.auug.org.au> > > Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org> > > Thanks for your patch! > > But did this change really fix your PowerPC allyesconfig build? It does not :-( > SND_SOC_ALL_CODECS will still select it... > > Fix sent. I have applied that patch to linux-next today. -- Cheers, Stephen Rothwell [-- Attachment #1.2: OpenPGP digital signature --] [-- Type: application/pgp-signature, Size: 488 bytes --] [-- Attachment #2: Type: text/plain, Size: 161 bytes --] _______________________________________________ Alsa-devel mailing list Alsa-devel@alsa-project.org https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
next prev parent reply other threads:[~2020-02-05 0:38 UTC|newest] Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-02-04 11:12 [PATCH v2] ASoC: wcd934x: Add missing COMMON_CLK dependency Srinivas Kandagatla 2020-02-04 11:12 ` [alsa-devel] " Srinivas Kandagatla 2020-02-04 11:23 ` Applied "ASoC: wcd934x: Add missing COMMON_CLK dependency" to the asoc tree Mark Brown 2020-02-04 11:23 ` [alsa-devel] " Mark Brown 2020-02-04 13:21 ` [PATCH v2] ASoC: wcd934x: Add missing COMMON_CLK dependency Geert Uytterhoeven 2020-02-04 13:21 ` [alsa-devel] " Geert Uytterhoeven 2020-02-05 0:37 ` Stephen Rothwell [this message] 2020-02-05 0:37 ` Stephen Rothwell
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200205113755.7daca1f1@canb.auug.org.au \ --to=sfr@canb.auug.org.au \ --cc=alsa-devel@alsa-project.org \ --cc=broonie@kernel.org \ --cc=geert@linux-m68k.org \ --cc=lee.jones@linaro.org \ --cc=linux-kernel@vger.kernel.org \ --cc=srinivas.kandagatla@linaro.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.