Re: [RFC PATCH 10/11] module: Reorder functions

From: kbuild test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: Re: [RFC PATCH 10/11] module: Reorder functions
Date: Fri, 07 Feb 2020 06:15:49 +0800	[thread overview]
Message-ID: <202002070625.QnRvE6jG%lkp@intel.com> (raw)
In-Reply-To: <20200205223950.1212394-11-kristen@linux.intel.com>

[-- Attachment #1: Type: text/plain, Size: 3431 bytes --]

Hi Kristen,

[FYI, it's a private test report for your RFC patch.]
[auto build test ERROR on tip/x86/core]
[also build test ERROR on kbuild/for-next tip/x86/mm v5.5]
[cannot apply to linus/master next-20200206]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url:    https://github.com/0day-ci/linux/commits/Kristen-Carlson-Accardi/Finer-grained-kernel-address-space-randomization/20200207-030617
base:   https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git 248ed51048c40d36728e70914e38bffd7821da57
config: arc-defconfig (attached as .config)
compiler: arc-elf-gcc (GCC) 9.2.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        GCC_VERSION=9.2.0 make.cross ARCH=arc 

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   kernel/module.c: In function 'randomize_text':
>> kernel/module.c:3292:39: error: implicit declaration of function 'kaslr_enabled' [-Werror=implicit-function-declaration]
    3292 |  if (!IS_ENABLED(CONFIG_FG_KASLR) || !kaslr_enabled())
         |                                       ^~~~~~~~~~~~~
   cc1: some warnings being treated as errors

vim +/kaslr_enabled +3292 kernel/module.c

  3276	
  3277	/*
  3278	 * randomize_text()
  3279	 * Look through the core section looking for executable code sections.
  3280	 * Store sections in an array and then shuffle the sections
  3281	 * to reorder the functions.
  3282	 */
  3283	static void randomize_text(struct module *mod, struct load_info *info)
  3284	{
  3285		int i;
  3286		int num_text_sections = 0;
  3287		Elf_Shdr **text_list;
  3288		int size = 0;
  3289		int max_sections = info->hdr->e_shnum;
  3290		unsigned int sec = find_sec(info, ".text");
  3291	
> 3292		if (!IS_ENABLED(CONFIG_FG_KASLR) || !kaslr_enabled())
  3293			return;
  3294	
  3295		if (sec == 0)
  3296			return;
  3297	
  3298		text_list = kmalloc_array(max_sections, sizeof(*text_list), GFP_KERNEL);
  3299		if (text_list == NULL)
  3300			return;
  3301	
  3302		for (i = 0; i < max_sections; i++) {
  3303			Elf_Shdr *shdr = &info->sechdrs[i];
  3304			const char *sname = info->secstrings + shdr->sh_name;
  3305	
  3306			if (!(shdr->sh_flags & SHF_ALLOC) ||
  3307			    !(shdr->sh_flags & SHF_EXECINSTR) ||
  3308			    strstarts(sname, ".init"))
  3309				continue;
  3310	
  3311			text_list[num_text_sections] = shdr;
  3312			num_text_sections++;
  3313		}
  3314	
  3315		shuffle_text_list(text_list, num_text_sections);
  3316	
  3317		for (i = 0; i < num_text_sections; i++) {
  3318			Elf_Shdr *shdr = text_list[i];
  3319			unsigned int infosec;
  3320			const char *sname;
  3321	
  3322			sname = info->secstrings + shdr->sh_name;
  3323			infosec	= shdr->sh_info;
  3324	
  3325			shdr->sh_entsize = get_offset(mod, &size, shdr, infosec);
  3326		}
  3327	
  3328		kfree(text_list);
  3329	}
  3330	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 9124 bytes --]