Re: [Intel-gfx] [PATCH v2] drm/i915/gt: make a gt sysfs group and move power management files

From: kbuild test robot <lkp@intel.com>
To: Andi Shyti <andi@etezian.org>
Cc: Intel GFX <intel-gfx@lists.freedesktop.org>, kbuild-all@lists.01.org
Subject: Re: [Intel-gfx] [PATCH v2] drm/i915/gt: make a gt sysfs group and move power management files
Date: Fri, 14 Feb 2020 21:21:50 +0800	[thread overview]
Message-ID: <202002142144.KAio98ZN%lkp@intel.com> (raw)
In-Reply-To: <20200211181027.5329-1-andi@etezian.org>

[-- Attachment #1: Type: text/plain, Size: 2306 bytes --]

Hi Andi,

I love your patch! Yet something to improve:

[auto build test ERROR on drm-tip/drm-tip]
[cannot apply to drm-intel/for-linux-next v5.6-rc1 next-20200214]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url:    https://github.com/0day-ci/linux/commits/Andi-Shyti/drm-i915-gt-make-a-gt-sysfs-group-and-move-power-management-files/20200214-142110
base:   git://anongit.freedesktop.org/drm/drm-tip drm-tip
config: i386-randconfig-h003-20200213 (attached as .config)
compiler: gcc-7 (Debian 7.5.0-4) 7.5.0
reproduce:
        # save the attached .config to linux build tree
        make ARCH=i386 

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   drivers/gpu/drm/i915/gt/sysfs_gt_pm.c: In function 'intel_gt_sysfs_get_drvdata':
>> drivers/gpu/drm/i915/gt/sysfs_gt_pm.c:26:49: error: "/*" within comment [-Werror=comment]
      * has been called, whether it's called from gt/* or from

   cc1: all warnings being treated as errors

vim +26 drivers/gpu/drm/i915/gt/sysfs_gt_pm.c

    18	
    19	struct intel_gt *intel_gt_sysfs_get_drvdata(struct device *dev)
    20	{
    21		struct kobject *kobj = &dev->kobj;
    22		struct drm_i915_private *i915;
    23	
    24		/*
    25		 * We are interested at knowing from where the interface
  > 26		 * has been called, whether it's called from gt/* or from
    27		 * the parent directory.
    28		 * From the interface position it depends also the value of
    29		 * the private data.
    30		 * If the interface is called from gt/ then private data is
    31		 * of the "struct intel_gt *" type, otherwise it's * a
    32		 * "struct drm_i915_private *" type.
    33		 */
    34		if (strcmp(kobj->name, "gt")) {
    35			pr_warn("the interface is obsolete, use gt/\n");
    36			i915 = kdev_minor_to_i915(dev);
    37			return &i915->gt;
    38		}
    39	
    40		return dev_get_drvdata(dev);
    41	}
    42	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 33140 bytes --]

[-- Attachment #3: Type: text/plain, Size: 160 bytes --]

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx