All of lore.kernel.org
 help / color / mirror / Atom feed
From: Schrempf Frieder <frieder.schrempf@kontron.de>
To: Boris Brezillon <bbrezillon@kernel.org>,
	Schrempf Frieder <frieder.schrempf@kontron.de>,
	Jeff Kletsky <git-commits@allycomm.com>,
	liaoweixiong <liaoweixiong@allwinnertech.com>,
	Miquel Raynal <miquel.raynal@bootlin.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>,
	"Richard Weinberger" <richard@nod.at>
Subject: [PATCH v3 0/3] mtd: spinand: Fix reading and writing of bad block markers
Date: Tue, 18 Feb 2020 10:05:05 +0000	[thread overview]
Message-ID: <20200218100432.32433-1-frieder.schrempf@kontron.de> (raw)

From: Frieder Schrempf <frieder.schrempf@kontron.de>

We were pointed to the issue of bad block markers not being saved to flash on
one of our boards with SPI NAND flash. After a bit of investigation it seems
like there are two overlapping bugs in the original framework that cause silent
failure when writing a bad block marker.

This set contains fixes for both of these issues and one more fix (patch 2) that
should not affect the actual behavior of the driver.

Changes in v3:
 * Patch 1: Correct "SPI MEM" to "SPI NAND" in commit message
 * Patch 3: Fix the subject line and the commit message
 * Patch 3: Add Boris' R-b tag

Changes in v2:
 * Patch 1: Incorporate small improvements proposed by Boris
 * Patch 1: Add Boris' R-b tag
 * Patch 2: Add Boris' R-b tag
 * Patch 3: Instead of waiting for the erase operation to finish,
            just don't do an erase at all, as it is not needed.

Frieder Schrempf (3):
  mtd: spinand: Stop using spinand->oobbuf for buffering bad block
    markers
  mtd: spinand: Explicitly use MTD_OPS_RAW to write the bad block marker
    to OOB
  mtd: spinand: Do not erase the block before writing a bad block marker

 drivers/mtd/nand/spi/core.c | 18 ++++++++----------
 1 file changed, 8 insertions(+), 10 deletions(-)

-- 
2.17.1

WARNING: multiple messages have this Message-ID (diff)
From: Schrempf Frieder <frieder.schrempf@kontron.de>
To: Boris Brezillon <bbrezillon@kernel.org>,
	Schrempf Frieder <frieder.schrempf@kontron.de>,
	Jeff Kletsky <git-commits@allycomm.com>,
	liaoweixiong <liaoweixiong@allwinnertech.com>,
	Miquel Raynal <miquel.raynal@bootlin.com>
Cc: Richard Weinberger <richard@nod.at>,
	"linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: [PATCH v3 0/3] mtd: spinand: Fix reading and writing of bad block markers
Date: Tue, 18 Feb 2020 10:05:05 +0000	[thread overview]
Message-ID: <20200218100432.32433-1-frieder.schrempf@kontron.de> (raw)

From: Frieder Schrempf <frieder.schrempf@kontron.de>

We were pointed to the issue of bad block markers not being saved to flash on
one of our boards with SPI NAND flash. After a bit of investigation it seems
like there are two overlapping bugs in the original framework that cause silent
failure when writing a bad block marker.

This set contains fixes for both of these issues and one more fix (patch 2) that
should not affect the actual behavior of the driver.

Changes in v3:
 * Patch 1: Correct "SPI MEM" to "SPI NAND" in commit message
 * Patch 3: Fix the subject line and the commit message
 * Patch 3: Add Boris' R-b tag

Changes in v2:
 * Patch 1: Incorporate small improvements proposed by Boris
 * Patch 1: Add Boris' R-b tag
 * Patch 2: Add Boris' R-b tag
 * Patch 3: Instead of waiting for the erase operation to finish,
            just don't do an erase at all, as it is not needed.

Frieder Schrempf (3):
  mtd: spinand: Stop using spinand->oobbuf for buffering bad block
    markers
  mtd: spinand: Explicitly use MTD_OPS_RAW to write the bad block marker
    to OOB
  mtd: spinand: Do not erase the block before writing a bad block marker

 drivers/mtd/nand/spi/core.c | 18 ++++++++----------
 1 file changed, 8 insertions(+), 10 deletions(-)

-- 
2.17.1

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

             reply	other threads:[~2020-02-18 10:05 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-18 10:05 Schrempf Frieder [this message]
2020-02-18 10:05 ` [PATCH v3 0/3] mtd: spinand: Fix reading and writing of bad block markers Schrempf Frieder
2020-02-18 10:05 ` [PATCH v3 1/3] mtd: spinand: Stop using spinand->oobbuf for buffering " Schrempf Frieder
2020-02-18 10:05   ` Schrempf Frieder
2020-03-10 18:31   ` Miquel Raynal
2020-03-10 18:31     ` Miquel Raynal
2020-02-18 10:05 ` [PATCH v3 2/3] mtd: spinand: Explicitly use MTD_OPS_RAW to write the bad block marker to OOB Schrempf Frieder
2020-02-18 10:05   ` Schrempf Frieder
2020-03-10 18:31   ` Miquel Raynal
2020-03-10 18:31     ` Miquel Raynal
2020-02-18 10:05 ` [PATCH v3 3/3] mtd: spinand: Do not erase the block before writing a bad block marker Schrempf Frieder
2020-02-18 10:05   ` Schrempf Frieder
2020-03-10 18:31   ` Miquel Raynal
2020-03-10 18:31     ` Miquel Raynal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200218100432.32433-1-frieder.schrempf@kontron.de \
    --to=frieder.schrempf@kontron.de \
    --cc=bbrezillon@kernel.org \
    --cc=git-commits@allycomm.com \
    --cc=liaoweixiong@allwinnertech.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=miquel.raynal@bootlin.com \
    --cc=richard@nod.at \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.