From: Jason Gunthorpe <jgg@mellanox.com>
To: Jason Wang <jasowang@redhat.com>
Cc: "mst@redhat.com" <mst@redhat.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
"virtualization@lists.linux-foundation.org"
<virtualization@lists.linux-foundation.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"tiwei.bie@intel.com" <tiwei.bie@intel.com>,
"maxime.coquelin@redhat.com" <maxime.coquelin@redhat.com>,
"cunming.liang@intel.com" <cunming.liang@intel.com>,
"zhihong.wang@intel.com" <zhihong.wang@intel.com>,
"rob.miller@broadcom.com" <rob.miller@broadcom.com>,
"xiao.w.wang@intel.com" <xiao.w.wang@intel.com>,
"haotian.wang@sifive.com" <haotian.wang@sifive.com>,
"lingshan.zhu@intel.com" <lingshan.zhu@intel.com>,
"eperezma@redhat.com" <eperezma@redhat.com>,
"lulu@redhat.com" <lulu@redhat.com>,
Parav Pandit <parav@mellanox.com>,
"kevin.tian@intel.com" <kevin.tian@intel.com>,
"stefanha@redhat.com" <stefanha@redhat.com>,
"rdunlap@infradead.org" <rdunlap@infradead.org>,
"hch@infradead.org" <hch@infradead.org>,
"aadam@redhat.com" <aadam@redhat.com>,
Jiri Pirko <jiri@mellanox.com>,
Shahaf Shuler <shahafs@mellanox.com>,
"hanand@xilinx.com" <hanand@xilinx.com>,
"mhabets@solarflare.com" <mhabets@solarflare.com>
Subject: Re: [PATCH V2 3/5] vDPA: introduce vDPA bus
Date: Tue, 18 Feb 2020 13:56:12 +0000 [thread overview]
Message-ID: <20200218135608.GS4271@mellanox.com> (raw)
In-Reply-To: <01c86ebb-cf4b-691f-e682-2d6f93ddbcf7@redhat.com>
On Mon, Feb 17, 2020 at 02:08:03PM +0800, Jason Wang wrote:
> I thought you were copied in the patch [1], maybe we can move vhost related
> discussion there to avoid confusion.
>
> [1] https://lwn.net/Articles/811210/
Wow, that is .. confusing.
So this is supposed to duplicate the uAPI of vhost-user? But it is
open coded and duplicated because .. vdpa?
> So it's cheaper and simpler to introduce a new bus instead of refactoring a
> well known bus and API where brunches of drivers and devices had been
> implemented for years.
If you reason for this approach is to ease the implementation then you
should talk about it in the cover letters/etc
Maybe it is reasonable to do this because the rework is too great, I
don't know, but to me this whole thing looks rather messy.
Remember this stuff is all uAPI as it shows up in sysfs, so you can
easilly get stuck with it forever.
Jason
WARNING: multiple messages have this Message-ID (diff)
From: Jason Gunthorpe <jgg@mellanox.com>
To: Jason Wang <jasowang@redhat.com>
Cc: "mst@redhat.com" <mst@redhat.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
"virtualization@lists.linux-foundation.org"
<virtualization@lists.linux-foundation.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"tiwei.bie@intel.com" <tiwei.bie@intel.com>,
"maxime.coquelin@redhat.com" <maxime.coquelin@redhat.com>,
"cunming.liang@intel.com" <cunming.liang@intel.com>,
"zhihong.wang@intel.com" <zhihong.wang@intel.com>,
"rob.miller@broadcom.com" <rob.miller@broadcom.com>,
"xiao.w.wang@intel.com" <xiao.w.wang@intel.com>,
"haotian.wang@sifive.com" <haotian.wang@sifive.com>,
"lingshan.zhu@intel.com" <lingshan.zhu@intel.com>,
"eperezma@redhat.com" <eperezma@redhat.com>,
"lulu@redhat.com" <lulu@redhat.co>
Subject: Re: [PATCH V2 3/5] vDPA: introduce vDPA bus
Date: Tue, 18 Feb 2020 13:56:12 +0000 [thread overview]
Message-ID: <20200218135608.GS4271@mellanox.com> (raw)
In-Reply-To: <01c86ebb-cf4b-691f-e682-2d6f93ddbcf7@redhat.com>
On Mon, Feb 17, 2020 at 02:08:03PM +0800, Jason Wang wrote:
> I thought you were copied in the patch [1], maybe we can move vhost related
> discussion there to avoid confusion.
>
> [1] https://lwn.net/Articles/811210/
Wow, that is .. confusing.
So this is supposed to duplicate the uAPI of vhost-user? But it is
open coded and duplicated because .. vdpa?
> So it's cheaper and simpler to introduce a new bus instead of refactoring a
> well known bus and API where brunches of drivers and devices had been
> implemented for years.
If you reason for this approach is to ease the implementation then you
should talk about it in the cover letters/etc
Maybe it is reasonable to do this because the rework is too great, I
don't know, but to me this whole thing looks rather messy.
Remember this stuff is all uAPI as it shows up in sysfs, so you can
easilly get stuck with it forever.
Jason
next prev parent reply other threads:[~2020-02-18 13:56 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-10 3:56 [PATCH V2 0/5] vDPA support Jason Wang
2020-02-10 3:56 ` [PATCH V2 1/5] vhost: factor out IOTLB Jason Wang
2020-02-10 3:56 ` [PATCH V2 2/5] vringh: IOTLB support Jason Wang
2020-02-10 3:56 ` [PATCH V2 3/5] vDPA: introduce vDPA bus Jason Wang
2020-02-11 13:47 ` Jason Gunthorpe
2020-02-12 7:55 ` Jason Wang
2020-02-12 12:51 ` Jason Gunthorpe
2020-02-13 3:34 ` Jason Wang
2020-02-13 13:41 ` Jason Gunthorpe
2020-02-13 14:58 ` Jason Wang
2020-02-13 15:05 ` Jason Gunthorpe
2020-02-13 15:05 ` Jason Gunthorpe
2020-02-13 15:41 ` Michael S. Tsirkin
2020-02-13 15:51 ` Jason Gunthorpe
2020-02-13 15:56 ` Michael S. Tsirkin
2020-02-13 15:56 ` Michael S. Tsirkin
2020-02-13 16:24 ` Jason Gunthorpe
2020-02-14 4:05 ` Jason Wang
2020-02-14 14:04 ` Jason Gunthorpe
2020-02-17 6:07 ` Jason Wang
2020-02-17 6:07 ` Jason Wang
2020-02-13 15:59 ` Michael S. Tsirkin
2020-02-13 16:13 ` Jason Gunthorpe
2020-02-14 4:39 ` Jason Wang
2020-02-14 3:23 ` Jason Wang
2020-02-14 3:23 ` Jason Wang
2020-02-14 13:52 ` Jason Gunthorpe
2020-02-17 6:08 ` Jason Wang
2020-02-17 6:08 ` Jason Wang
2020-02-18 13:56 ` Jason Gunthorpe [this message]
2020-02-18 13:56 ` Jason Gunthorpe
2020-02-19 2:59 ` Tiwei Bie
2020-02-19 2:59 ` Tiwei Bie
2020-02-19 5:35 ` Jason Wang
2020-02-19 5:35 ` Jason Wang
2020-02-19 12:53 ` Jason Gunthorpe
2020-02-19 12:53 ` Jason Gunthorpe
2020-02-10 3:56 ` [PATCH V2 4/5] virtio: introduce a vDPA based transport Jason Wang
2020-02-10 13:34 ` Jason Gunthorpe
2020-02-10 13:34 ` Jason Gunthorpe
2020-02-11 3:04 ` Jason Wang
2020-02-11 3:04 ` Jason Wang
2020-02-10 3:56 ` [PATCH V2 5/5] vdpasim: vDPA device simulator Jason Wang
2020-02-10 11:23 ` Michael S. Tsirkin
2020-02-11 3:12 ` Jason Wang
2020-02-11 13:52 ` Jason Gunthorpe
2020-02-12 8:27 ` Jason Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200218135608.GS4271@mellanox.com \
--to=jgg@mellanox.com \
--cc=aadam@redhat.com \
--cc=cunming.liang@intel.com \
--cc=eperezma@redhat.com \
--cc=hanand@xilinx.com \
--cc=haotian.wang@sifive.com \
--cc=hch@infradead.org \
--cc=jasowang@redhat.com \
--cc=jiri@mellanox.com \
--cc=kevin.tian@intel.com \
--cc=kvm@vger.kernel.org \
--cc=lingshan.zhu@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lulu@redhat.com \
--cc=maxime.coquelin@redhat.com \
--cc=mhabets@solarflare.com \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=parav@mellanox.com \
--cc=rdunlap@infradead.org \
--cc=rob.miller@broadcom.com \
--cc=shahafs@mellanox.com \
--cc=stefanha@redhat.com \
--cc=tiwei.bie@intel.com \
--cc=virtualization@lists.linux-foundation.org \
--cc=xiao.w.wang@intel.com \
--cc=zhihong.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.