All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: Jon Hunter <jonathanh-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
Cc: Sameer Pujar <spujar-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>,
	perex-/Fr2/VpizcU@public.gmane.org,
	tiwai-IBi9RG/b67k@public.gmane.org,
	robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
	lgirdwood-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
	thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
	digetx-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
	alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw@public.gmane.org,
	devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	sharadg-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org,
	mkumard-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org,
	viswanathl-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org,
	rlokhande-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org,
	dramesh-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org,
	atalambedu-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org
Subject: Re: [PATCH v3 03/10] ASoC: tegra: add Tegra210 based DMIC driver
Date: Mon, 24 Feb 2020 11:44:06 +0000	[thread overview]
Message-ID: <20200224114406.GB6215@sirena.org.uk> (raw)
In-Reply-To: <47f94534-e997-d56c-5793-ae832fb2add4-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>

[-- Attachment #1: Type: text/plain, Size: 1485 bytes --]

On Mon, Feb 24, 2020 at 11:28:57AM +0000, Jon Hunter wrote:
> On 21/02/2020 16:55, Mark Brown wrote:

> > The ideal thing in a component model would be to represent those sample
> > rate convertors directly to usrspace so the routing and rewriting is
> > explicit.

> I assume that it would be OK for the sample rate converter itself to
> expose mixer controls to configure its input and output rates so the
> user could configure as needed?

I don't think so, I'd not expect the individual drivers to be doing
anything user visible here - if we know what a digital transformation
looks like the framework should be offering anything that's needed to
users (and hiding controls that don't have any practical control in a
given system).

> > Is there any *need* for these to be user configurable?  What's normally
> > happening at the minute is that either the external DAIs are fixed
> > configuration and the DSP just converts everything or there's no format
> > conversion done and things get passed through.

> I can see that in most cases there are a finite set of configurations
> that the end user may use. However, we would like to make the
> configuration flexible as possible and this also allow us to test lots
> of different configurations for verification purposes as well.

Internal testing often requires things that can't be exposed to users,
the extreme examples are things like battery chargers with health and
safety issues if the full range of control is available.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@kernel.org>
To: Jon Hunter <jonathanh@nvidia.com>
Cc: Sameer Pujar <spujar@nvidia.com>,
	perex@perex.cz, tiwai@suse.com, robh+dt@kernel.org,
	lgirdwood@gmail.com, thierry.reding@gmail.com, digetx@gmail.com,
	alsa-devel@alsa-project.org, devicetree@vger.kernel.org,
	linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org,
	sharadg@nvidia.com, mkumard@nvidia.com, viswanathl@nvidia.com,
	rlokhande@nvidia.com, dramesh@nvidia.com, atalambedu@nvidia.com
Subject: Re: [PATCH v3 03/10] ASoC: tegra: add Tegra210 based DMIC driver
Date: Mon, 24 Feb 2020 11:44:06 +0000	[thread overview]
Message-ID: <20200224114406.GB6215@sirena.org.uk> (raw)
In-Reply-To: <47f94534-e997-d56c-5793-ae832fb2add4@nvidia.com>

[-- Attachment #1: Type: text/plain, Size: 1485 bytes --]

On Mon, Feb 24, 2020 at 11:28:57AM +0000, Jon Hunter wrote:
> On 21/02/2020 16:55, Mark Brown wrote:

> > The ideal thing in a component model would be to represent those sample
> > rate convertors directly to usrspace so the routing and rewriting is
> > explicit.

> I assume that it would be OK for the sample rate converter itself to
> expose mixer controls to configure its input and output rates so the
> user could configure as needed?

I don't think so, I'd not expect the individual drivers to be doing
anything user visible here - if we know what a digital transformation
looks like the framework should be offering anything that's needed to
users (and hiding controls that don't have any practical control in a
given system).

> > Is there any *need* for these to be user configurable?  What's normally
> > happening at the minute is that either the external DAIs are fixed
> > configuration and the DSP just converts everything or there's no format
> > conversion done and things get passed through.

> I can see that in most cases there are a finite set of configurations
> that the end user may use. However, we would like to make the
> configuration flexible as possible and this also allow us to test lots
> of different configurations for verification purposes as well.

Internal testing often requires things that can't be exposed to users,
the extreme examples are things like battery chargers with health and
safety issues if the full range of control is available.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@kernel.org>
To: Jon Hunter <jonathanh@nvidia.com>
Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org,
	atalambedu@nvidia.com, linux-kernel@vger.kernel.org,
	Sameer Pujar <spujar@nvidia.com>,
	lgirdwood@gmail.com, tiwai@suse.com, viswanathl@nvidia.com,
	sharadg@nvidia.com, robh+dt@kernel.org, thierry.reding@gmail.com,
	linux-tegra@vger.kernel.org, digetx@gmail.com,
	rlokhande@nvidia.com, mkumard@nvidia.com, dramesh@nvidia.com
Subject: Re: [PATCH v3 03/10] ASoC: tegra: add Tegra210 based DMIC driver
Date: Mon, 24 Feb 2020 11:44:06 +0000	[thread overview]
Message-ID: <20200224114406.GB6215@sirena.org.uk> (raw)
In-Reply-To: <47f94534-e997-d56c-5793-ae832fb2add4@nvidia.com>

[-- Attachment #1: Type: text/plain, Size: 1485 bytes --]

On Mon, Feb 24, 2020 at 11:28:57AM +0000, Jon Hunter wrote:
> On 21/02/2020 16:55, Mark Brown wrote:

> > The ideal thing in a component model would be to represent those sample
> > rate convertors directly to usrspace so the routing and rewriting is
> > explicit.

> I assume that it would be OK for the sample rate converter itself to
> expose mixer controls to configure its input and output rates so the
> user could configure as needed?

I don't think so, I'd not expect the individual drivers to be doing
anything user visible here - if we know what a digital transformation
looks like the framework should be offering anything that's needed to
users (and hiding controls that don't have any practical control in a
given system).

> > Is there any *need* for these to be user configurable?  What's normally
> > happening at the minute is that either the external DAIs are fixed
> > configuration and the DSP just converts everything or there's no format
> > conversion done and things get passed through.

> I can see that in most cases there are a finite set of configurations
> that the end user may use. However, we would like to make the
> configuration flexible as possible and this also allow us to test lots
> of different configurations for verification purposes as well.

Internal testing often requires things that can't be exposed to users,
the extreme examples are things like battery chargers with health and
safety issues if the full range of control is available.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

  parent reply	other threads:[~2020-02-24 11:44 UTC|newest]

Thread overview: 115+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-20  6:34 [PATCH v3 00/10] add ASoC components for AHUB Sameer Pujar
2020-02-20  6:34 ` Sameer Pujar
2020-02-20  6:34 ` Sameer Pujar
     [not found] ` <1582180492-25297-1-git-send-email-spujar-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2020-02-20  6:34   ` [PATCH v3 01/10] dt-bindings: sound: tegra: add DT binding " Sameer Pujar
2020-02-20  6:34     ` Sameer Pujar
2020-02-20  6:34     ` Sameer Pujar
2020-02-21 12:39     ` Mark Brown
2020-02-21 12:39       ` Mark Brown
     [not found]     ` <1582180492-25297-2-git-send-email-spujar-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2020-02-26 16:02       ` Rob Herring
2020-02-26 16:02         ` Rob Herring
2020-02-26 16:02         ` Rob Herring
2020-02-20  6:34   ` [PATCH v3 02/10] ASoC: tegra: add support for CIF programming Sameer Pujar
2020-02-20  6:34     ` Sameer Pujar
2020-02-20  6:34     ` Sameer Pujar
     [not found]     ` <1582180492-25297-3-git-send-email-spujar-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2020-02-20 14:30       ` Jon Hunter
2020-02-20 14:30         ` Jon Hunter
2020-02-20 14:30         ` Jon Hunter
2020-02-21  5:27       ` Dmitry Osipenko
2020-02-21  5:27         ` Dmitry Osipenko
2020-02-21  5:27         ` Dmitry Osipenko
2020-02-20  6:34   ` [PATCH v3 03/10] ASoC: tegra: add Tegra210 based DMIC driver Sameer Pujar
2020-02-20  6:34     ` Sameer Pujar
2020-02-20  6:34     ` Sameer Pujar
     [not found]     ` <1582180492-25297-4-git-send-email-spujar-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2020-02-20 14:36       ` Jon Hunter
2020-02-20 14:36         ` Jon Hunter
2020-02-20 14:36         ` Jon Hunter
2020-02-21  5:53       ` Dmitry Osipenko
2020-02-21  5:53         ` Dmitry Osipenko
2020-02-21  5:53         ` Dmitry Osipenko
2020-02-21 13:00       ` Mark Brown
2020-02-21 13:00         ` Mark Brown
2020-02-21 13:00         ` Mark Brown
     [not found]         ` <20200221130005.GD5546-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2020-02-21 14:31           ` Jon Hunter
2020-02-21 14:31             ` Jon Hunter
2020-02-21 14:31             ` Jon Hunter
     [not found]             ` <316ce0d5-318d-0533-ef06-bd7e8672f893-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2020-02-21 16:55               ` Mark Brown
2020-02-21 16:55                 ` Mark Brown
2020-02-21 16:55                 ` Mark Brown
2020-02-24 11:28                 ` Jon Hunter
2020-02-24 11:28                   ` Jon Hunter
2020-02-24 11:28                   ` Jon Hunter
     [not found]                   ` <47f94534-e997-d56c-5793-ae832fb2add4-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2020-02-24 11:44                     ` Mark Brown [this message]
2020-02-24 11:44                       ` Mark Brown
2020-02-24 11:44                       ` Mark Brown
     [not found]                       ` <20200224114406.GB6215-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2020-02-24 12:29                         ` Sameer Pujar
2020-02-24 12:29                           ` Sameer Pujar
2020-02-24 12:29                           ` Sameer Pujar
     [not found]                           ` <f70c7c12-dbc0-a725-f06a-86fab868e7dc-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2020-02-24 13:18                             ` Mark Brown
2020-02-24 13:18                               ` Mark Brown
2020-02-24 13:18                               ` Mark Brown
2020-02-28  7:30           ` Viswanath L
2020-02-28  7:30             ` Viswanath L
2020-02-28  7:30             ` Viswanath L
2020-02-20  6:34   ` [PATCH v3 04/10] ASoC: tegra: add Tegra210 based I2S driver Sameer Pujar
2020-02-20  6:34     ` Sameer Pujar
2020-02-20  6:34     ` Sameer Pujar
     [not found]     ` <1582180492-25297-5-git-send-email-spujar-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2020-02-20 14:45       ` Jon Hunter
2020-02-20 14:45         ` Jon Hunter
2020-02-20 14:45         ` Jon Hunter
2020-02-21 13:21     ` Mark Brown
2020-02-21 13:21       ` Mark Brown
2020-02-20  6:34   ` [PATCH v3 05/10] ASoC: tegra: add Tegra210 based AHUB driver Sameer Pujar
2020-02-20  6:34     ` Sameer Pujar
2020-02-20  6:34     ` Sameer Pujar
     [not found]     ` <1582180492-25297-6-git-send-email-spujar-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2020-02-20  6:51       ` Randy Dunlap
2020-02-20  6:51         ` Randy Dunlap
2020-02-20  6:51         ` Randy Dunlap
2020-02-20 15:08       ` Jon Hunter
2020-02-20 15:08         ` Jon Hunter
2020-02-20 15:08         ` Jon Hunter
2020-02-21 13:38       ` Mark Brown
2020-02-21 13:38         ` Mark Brown
2020-02-21 13:38         ` Mark Brown
2020-02-20  6:34   ` [PATCH v3 06/10] ASoC: tegra: add Tegra186 based DSPK driver Sameer Pujar
2020-02-20  6:34     ` Sameer Pujar
2020-02-20  6:34     ` Sameer Pujar
     [not found]     ` <1582180492-25297-7-git-send-email-spujar-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2020-02-20  6:53       ` Randy Dunlap
2020-02-20  6:53         ` Randy Dunlap
2020-02-20  6:53         ` Randy Dunlap
2020-02-20 15:10       ` Jon Hunter
2020-02-20 15:10         ` Jon Hunter
2020-02-20 15:10         ` Jon Hunter
2020-02-20  6:34   ` [PATCH v3 07/10] ASoC: tegra: add Tegra210 based ADMAIF driver Sameer Pujar
2020-02-20  6:34     ` Sameer Pujar
2020-02-20  6:34     ` Sameer Pujar
     [not found]     ` <1582180492-25297-8-git-send-email-spujar-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2020-02-20  6:55       ` Randy Dunlap
2020-02-20  6:55         ` Randy Dunlap
2020-02-20  6:55         ` Randy Dunlap
2020-02-20 15:16       ` Jon Hunter
2020-02-20 15:16         ` Jon Hunter
2020-02-20 15:16         ` Jon Hunter
2020-02-21  6:08       ` Dmitry Osipenko
2020-02-21  6:08         ` Dmitry Osipenko
2020-02-21  6:08         ` Dmitry Osipenko
2020-02-20  6:34   ` [PATCH v3 08/10] arm64: tegra: add AHUB components for few Tegra chips Sameer Pujar
2020-02-20  6:34     ` Sameer Pujar
2020-02-20  6:34     ` Sameer Pujar
     [not found]     ` <1582180492-25297-9-git-send-email-spujar-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2020-02-20 14:49       ` Jon Hunter
2020-02-20 14:49         ` Jon Hunter
2020-02-20 14:49         ` Jon Hunter
2020-02-20  6:34   ` [PATCH v3 09/10] arm64: tegra: enable AHUB modules " Sameer Pujar
2020-02-20  6:34     ` Sameer Pujar
2020-02-20  6:34     ` Sameer Pujar
     [not found]     ` <1582180492-25297-10-git-send-email-spujar-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2020-02-20 14:52       ` Jon Hunter
2020-02-20 14:52         ` Jon Hunter
2020-02-20 14:52         ` Jon Hunter
2020-02-20  6:34   ` [PATCH v3 10/10] arm64: defconfig: enable AHUB components for Tegra210 and later Sameer Pujar
2020-02-20  6:34     ` Sameer Pujar
2020-02-20  6:34     ` Sameer Pujar
     [not found]     ` <1582180492-25297-11-git-send-email-spujar-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2020-02-20 14:52       ` Jon Hunter
2020-02-20 14:52         ` Jon Hunter
2020-02-20 14:52         ` Jon Hunter
2020-02-21  5:44       ` Dmitry Osipenko
2020-02-21  5:44         ` Dmitry Osipenko
2020-02-21  5:44         ` Dmitry Osipenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200224114406.GB6215@sirena.org.uk \
    --to=broonie-dgejt+ai2ygdnm+yrofe0a@public.gmane.org \
    --cc=alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw@public.gmane.org \
    --cc=atalambedu-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
    --cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=digetx-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=dramesh-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
    --cc=jonathanh-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
    --cc=lgirdwood-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=mkumard-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
    --cc=perex-/Fr2/VpizcU@public.gmane.org \
    --cc=rlokhande-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
    --cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    --cc=sharadg-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
    --cc=spujar-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
    --cc=thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=tiwai-IBi9RG/b67k@public.gmane.org \
    --cc=viswanathl-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.