From: Krzysztof Kozlowski <krzk@kernel.org>
To: Jiri Slaby <jirislaby@gmail.com>
Cc: Rich Felker <dalias@libc.org>,
Geert Uytterhoeven <geert+renesas@glider.be>,
"Michael S. Tsirkin" <mst@redhat.com>,
David Airlie <airlied@linux.ie>, Jason Wang <jasowang@redhat.com>,
dri-devel@lists.freedesktop.org,
virtualization@lists.linux-foundation.org,
"James E.J. Bottomley" <James.Bottomley@hansenpartnership.com>,
netdev@vger.kernel.org, Paul Mackerras <paulus@samba.org>,
linux-arch@vger.kernel.org, Dave Jiang <dave.jiang@intel.com>,
Yoshinori Sato <ysato@users.sourceforge.jp>,
Michael Ellerman <mpe@ellerman.id.au>,
Helge Deller <deller@gmx.de>,
linux-sh@vger.kernel.org, Alexey Brodkin <abrodkin@synopsys.com>,
Ben Skeggs <bskeggs@redhat.com>,
nouveau@lists.freedesktop.org, Dave Airlie <airlied@redhat.com>,
Matt Turner <mattst88@gmail.com>,
linux-snps-arc@lists.infradead.org,
Nick Kossifidis <mickflemm@gmail.com>,
Allen Hubbe <allenbh@gmail.com>, Arnd Bergmann <arnd@arndb.de>,
linux-alpha@vger.kernel.org,
Ivan Kokshaysky <ink@jurassic.park.msu.ru>,
Thomas Gleixner <tglx@linutronix.de>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Kalle Valo <kvalo@codeaurora.org>,
Richard Henderson <rth@twiddle.net>,
linux-parisc@vger.kernel.org, Vineet Gupta <vgupta@synopsys.com>,
linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org,
Luis Chamberlain <mcgrof@kernel.org>,
Jon Mason <jdmason@kudzu.us>,
linux-ntb@googlegroups.com,
Andrew Morton <akpm@linux-foundation.org>,
linux-media@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [RESEND PATCH v2 9/9] ath5k: Constify ioreadX() iomem argument (as in generic implementation)
Date: Mon, 24 Feb 2020 12:47:44 +0000 [thread overview]
Message-ID: <20200224124744.GA1949@pi3> (raw)
In-Reply-To: <518a9023-f802-17b3-fca5-582400bc34ae@gmail.com>
On Thu, Feb 20, 2020 at 10:48:33AM +0100, Jiri Slaby wrote:
> On 19. 02. 20, 18:50, Krzysztof Kozlowski wrote:
> > The ioreadX() helpers have inconsistent interface. On some architectures
> > void *__iomem address argument is a pointer to const, on some not.
> >
> > Implementations of ioreadX() do not modify the memory under the address
> > so they can be converted to a "const" version for const-safety and
> > consistency among architectures.
> >
> > Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> > Acked-by: Kalle Valo <kvalo@codeaurora.org>
> > ---
> > drivers/net/wireless/ath/ath5k/ahb.c | 10 +++++-----
> > 1 file changed, 5 insertions(+), 5 deletions(-)
> >
> > diff --git a/drivers/net/wireless/ath/ath5k/ahb.c b/drivers/net/wireless/ath/ath5k/ahb.c
> > index 2c9cec8b53d9..8bd01df369fb 100644
> > --- a/drivers/net/wireless/ath/ath5k/ahb.c
> > +++ b/drivers/net/wireless/ath/ath5k/ahb.c
> > @@ -138,18 +138,18 @@ static int ath_ahb_probe(struct platform_device *pdev)
> >
> > if (bcfg->devid >= AR5K_SREV_AR2315_R6) {
> > /* Enable WMAC AHB arbitration */
> > - reg = ioread32((void __iomem *) AR5K_AR2315_AHB_ARB_CTL);
> > + reg = ioread32((const void __iomem *) AR5K_AR2315_AHB_ARB_CTL);
>
> While I understand why the parameter of ioread32 should be const, I
> don't see a reason for these casts on the users' side. What does it
> bring except longer code to read?
Because the argument is an int:
drivers/net/wireless/ath/ath5k/ahb.c: In function ‘ath_ahb_probe’:
drivers/net/wireless/ath/ath5k/ahb.c:141:18: warning: passing argument 1 of ‘ioread32’ makes pointer from integer without a cast [-Wint-conversion]
reg = ioread32(AR5K_AR2315_AHB_ARB_CTL);
Best regards,
Krzysztof
WARNING: multiple messages have this Message-ID (diff)
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Jiri Slaby <jirislaby@gmail.com>
Cc: Richard Henderson <rth@twiddle.net>,
Ivan Kokshaysky <ink@jurassic.park.msu.ru>,
Matt Turner <mattst88@gmail.com>,
Alexey Brodkin <abrodkin@synopsys.com>,
Vineet Gupta <vgupta@synopsys.com>,
"James E.J. Bottomley" <James.Bottomley@hansenpartnership.com>,
Helge Deller <deller@gmx.de>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Paul Mackerras <paulus@samba.org>,
Michael Ellerman <mpe@ellerman.id.au>,
Yoshinori Sato <ysato@users.sourceforge.jp>,
Rich Felker <dalias@libc.org>, Dave Airlie <airlied@redhat.com>,
David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
Ben Skeggs <bskeggs@redhat.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Nick Kossifidis <mickflemm@gmail.com>,
Luis Chamberlain <mcgrof@kernel.org>,
Kalle Valo <kvalo@codeaurora.org>,
"David S. Miller" <davem@davemloft.net>,
Dave Jiang <dave.jiang@intel.com>, Jon Mason <jdmason@kudzu.us>,
Allen Hubbe <allenbh@gmail.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
Jason Wang <jasowang@redhat.com>, Arnd Bergmann <arnd@arndb.de>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Andrew Morton <akpm@linux-foundation.org>,
Thomas Gleixner <tglx@linutronix.de>,
linux-alpha@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-snps-arc@lists.infradead.org, linux-parisc@vger.kernel.org,
linuxppc-dev@lists.ozlabs.org, linux-sh@vger.kernel.org,
dri-devel@lists.freedesktop.org, nouveau@lists.freedesktop.org,
linux-media@vger.kernel.org, linux-wireless@vger.kernel.org,
netdev@vger.kernel.org, linux-ntb@googlegroups.com,
virtualization@lists.linux-foundation.org,
linux-arch@vger.kernel.org
Subject: Re: [RESEND PATCH v2 9/9] ath5k: Constify ioreadX() iomem argument (as in generic implementation)
Date: Mon, 24 Feb 2020 13:47:44 +0100 [thread overview]
Message-ID: <20200224124744.GA1949@pi3> (raw)
In-Reply-To: <518a9023-f802-17b3-fca5-582400bc34ae@gmail.com>
On Thu, Feb 20, 2020 at 10:48:33AM +0100, Jiri Slaby wrote:
> On 19. 02. 20, 18:50, Krzysztof Kozlowski wrote:
> > The ioreadX() helpers have inconsistent interface. On some architectures
> > void *__iomem address argument is a pointer to const, on some not.
> >
> > Implementations of ioreadX() do not modify the memory under the address
> > so they can be converted to a "const" version for const-safety and
> > consistency among architectures.
> >
> > Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> > Acked-by: Kalle Valo <kvalo@codeaurora.org>
> > ---
> > drivers/net/wireless/ath/ath5k/ahb.c | 10 +++++-----
> > 1 file changed, 5 insertions(+), 5 deletions(-)
> >
> > diff --git a/drivers/net/wireless/ath/ath5k/ahb.c b/drivers/net/wireless/ath/ath5k/ahb.c
> > index 2c9cec8b53d9..8bd01df369fb 100644
> > --- a/drivers/net/wireless/ath/ath5k/ahb.c
> > +++ b/drivers/net/wireless/ath/ath5k/ahb.c
> > @@ -138,18 +138,18 @@ static int ath_ahb_probe(struct platform_device *pdev)
> >
> > if (bcfg->devid >= AR5K_SREV_AR2315_R6) {
> > /* Enable WMAC AHB arbitration */
> > - reg = ioread32((void __iomem *) AR5K_AR2315_AHB_ARB_CTL);
> > + reg = ioread32((const void __iomem *) AR5K_AR2315_AHB_ARB_CTL);
>
> While I understand why the parameter of ioread32 should be const, I
> don't see a reason for these casts on the users' side. What does it
> bring except longer code to read?
Because the argument is an int:
drivers/net/wireless/ath/ath5k/ahb.c: In function ‘ath_ahb_probe’:
drivers/net/wireless/ath/ath5k/ahb.c:141:18: warning: passing argument 1 of ‘ioread32’ makes pointer from integer without a cast [-Wint-conversion]
reg = ioread32(AR5K_AR2315_AHB_ARB_CTL);
Best regards,
Krzysztof
WARNING: multiple messages have this Message-ID (diff)
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Jiri Slaby <jirislaby@gmail.com>
Cc: Richard Henderson <rth@twiddle.net>,
Ivan Kokshaysky <ink@jurassic.park.msu.ru>,
Matt Turner <mattst88@gmail.com>,
Alexey Brodkin <abrodkin@synopsys.com>,
Vineet Gupta <vgupta@synopsys.com>,
"James E.J. Bottomley" <James.Bottomley@hansenpartnership.com>,
Helge Deller <deller@gmx.de>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Paul Mackerras <paulus@samba.org>,
Michael Ellerman <mpe@ellerman.id.au>,
Yoshinori Sato <ysato@users.sourceforge.jp>,
Rich Felker <dalias@libc.org>, Dave Airlie <airlied@redhat.com>,
David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
Ben Skeggs <bskeggs@redhat.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Nick Kossifidis <mickflemm@gmail.com>,
Luis Chamberlain <mcgrof@kernel.org>,
Kall
Subject: Re: [RESEND PATCH v2 9/9] ath5k: Constify ioreadX() iomem argument (as in generic implementation)
Date: Mon, 24 Feb 2020 13:47:44 +0100 [thread overview]
Message-ID: <20200224124744.GA1949@pi3> (raw)
In-Reply-To: <518a9023-f802-17b3-fca5-582400bc34ae@gmail.com>
On Thu, Feb 20, 2020 at 10:48:33AM +0100, Jiri Slaby wrote:
> On 19. 02. 20, 18:50, Krzysztof Kozlowski wrote:
> > The ioreadX() helpers have inconsistent interface. On some architectures
> > void *__iomem address argument is a pointer to const, on some not.
> >
> > Implementations of ioreadX() do not modify the memory under the address
> > so they can be converted to a "const" version for const-safety and
> > consistency among architectures.
> >
> > Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> > Acked-by: Kalle Valo <kvalo@codeaurora.org>
> > ---
> > drivers/net/wireless/ath/ath5k/ahb.c | 10 +++++-----
> > 1 file changed, 5 insertions(+), 5 deletions(-)
> >
> > diff --git a/drivers/net/wireless/ath/ath5k/ahb.c b/drivers/net/wireless/ath/ath5k/ahb.c
> > index 2c9cec8b53d9..8bd01df369fb 100644
> > --- a/drivers/net/wireless/ath/ath5k/ahb.c
> > +++ b/drivers/net/wireless/ath/ath5k/ahb.c
> > @@ -138,18 +138,18 @@ static int ath_ahb_probe(struct platform_device *pdev)
> >
> > if (bcfg->devid >= AR5K_SREV_AR2315_R6) {
> > /* Enable WMAC AHB arbitration */
> > - reg = ioread32((void __iomem *) AR5K_AR2315_AHB_ARB_CTL);
> > + reg = ioread32((const void __iomem *) AR5K_AR2315_AHB_ARB_CTL);
>
> While I understand why the parameter of ioread32 should be const, I
> don't see a reason for these casts on the users' side. What does it
> bring except longer code to read?
Because the argument is an int:
drivers/net/wireless/ath/ath5k/ahb.c: In function ‘ath_ahb_probe’:
drivers/net/wireless/ath/ath5k/ahb.c:141:18: warning: passing argument 1 of ‘ioread32’ makes pointer from integer without a cast [-Wint-conversion]
reg = ioread32(AR5K_AR2315_AHB_ARB_CTL);
Best regards,
Krzysztof
WARNING: multiple messages have this Message-ID (diff)
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Jiri Slaby <jirislaby@gmail.com>
Cc: Rich Felker <dalias@libc.org>,
Geert Uytterhoeven <geert+renesas@glider.be>,
"Michael S. Tsirkin" <mst@redhat.com>,
David Airlie <airlied@linux.ie>, Jason Wang <jasowang@redhat.com>,
dri-devel@lists.freedesktop.org,
virtualization@lists.linux-foundation.org,
"James E.J. Bottomley" <James.Bottomley@hansenpartnership.com>,
netdev@vger.kernel.org, Paul Mackerras <paulus@samba.org>,
linux-arch@vger.kernel.org, Dave Jiang <dave.jiang@intel.com>,
Yoshinori Sato <ysato@users.sourceforge.jp>,
Helge Deller <deller@gmx.de>,
linux-sh@vger.kernel.org, Alexey Brodkin <abrodkin@synopsys.com>,
Ben Skeggs <bskeggs@redhat.com>,
nouveau@lists.freedesktop.org, Dave Airlie <airlied@redhat.com>,
Matt Turner <mattst88@gmail.com>,
linux-snps-arc@lists.infradead.org,
Nick Kossifidis <mickflemm@gmail.com>,
Allen Hubbe <allenbh@gmail.com>, Arnd Bergmann <arnd@arndb.de>,
linux-alpha@vger.kernel.org,
Ivan Kokshaysky <ink@jurassic.park.msu.ru>,
Thomas Gleixner <tglx@linutronix.de>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Kalle Valo <kvalo@codeaurora.org>,
Richard Henderson <rth@twiddle.net>,
linux-parisc@vger.kernel.org, Vineet Gupta <vgupta@synopsys.com>,
linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org,
Luis Chamberlain <mcgrof@kernel.org>,
Daniel Vetter <daniel@ffwll.ch>, Jon Mason <jdmason@kudzu.us>,
linux-ntb@googlegroups.com,
Andrew Morton <akpm@linux-foundation.org>,
linux-media@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [RESEND PATCH v2 9/9] ath5k: Constify ioreadX() iomem argument (as in generic implementation)
Date: Mon, 24 Feb 2020 13:47:44 +0100 [thread overview]
Message-ID: <20200224124744.GA1949@pi3> (raw)
In-Reply-To: <518a9023-f802-17b3-fca5-582400bc34ae@gmail.com>
On Thu, Feb 20, 2020 at 10:48:33AM +0100, Jiri Slaby wrote:
> On 19. 02. 20, 18:50, Krzysztof Kozlowski wrote:
> > The ioreadX() helpers have inconsistent interface. On some architectures
> > void *__iomem address argument is a pointer to const, on some not.
> >
> > Implementations of ioreadX() do not modify the memory under the address
> > so they can be converted to a "const" version for const-safety and
> > consistency among architectures.
> >
> > Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> > Acked-by: Kalle Valo <kvalo@codeaurora.org>
> > ---
> > drivers/net/wireless/ath/ath5k/ahb.c | 10 +++++-----
> > 1 file changed, 5 insertions(+), 5 deletions(-)
> >
> > diff --git a/drivers/net/wireless/ath/ath5k/ahb.c b/drivers/net/wireless/ath/ath5k/ahb.c
> > index 2c9cec8b53d9..8bd01df369fb 100644
> > --- a/drivers/net/wireless/ath/ath5k/ahb.c
> > +++ b/drivers/net/wireless/ath/ath5k/ahb.c
> > @@ -138,18 +138,18 @@ static int ath_ahb_probe(struct platform_device *pdev)
> >
> > if (bcfg->devid >= AR5K_SREV_AR2315_R6) {
> > /* Enable WMAC AHB arbitration */
> > - reg = ioread32((void __iomem *) AR5K_AR2315_AHB_ARB_CTL);
> > + reg = ioread32((const void __iomem *) AR5K_AR2315_AHB_ARB_CTL);
>
> While I understand why the parameter of ioread32 should be const, I
> don't see a reason for these casts on the users' side. What does it
> bring except longer code to read?
Because the argument is an int:
drivers/net/wireless/ath/ath5k/ahb.c: In function ‘ath_ahb_probe’:
drivers/net/wireless/ath/ath5k/ahb.c:141:18: warning: passing argument 1 of ‘ioread32’ makes pointer from integer without a cast [-Wint-conversion]
reg = ioread32(AR5K_AR2315_AHB_ARB_CTL);
Best regards,
Krzysztof
WARNING: multiple messages have this Message-ID (diff)
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Jiri Slaby <jirislaby@gmail.com>
Cc: Rich Felker <dalias@libc.org>,
Geert Uytterhoeven <geert+renesas@glider.be>,
"Michael S. Tsirkin" <mst@redhat.com>,
David Airlie <airlied@linux.ie>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Jason Wang <jasowang@redhat.com>,
dri-devel@lists.freedesktop.org,
virtualization@lists.linux-foundation.org,
"James E.J. Bottomley" <James.Bottomley@hansenpartnership.com>,
netdev@vger.kernel.org, Paul Mackerras <paulus@samba.org>,
linux-arch@vger.kernel.org, Dave Jiang <dave.jiang@intel.com>,
Yoshinori Sato <ysato@users.sourceforge.jp>,
Michael Ellerman <mpe@ellerman.id.au>,
Helge Deller <deller@gmx.de>,
linux-sh@vger.kernel.org, Alexey Brodkin <abrodkin@synopsys.com>,
Ben Skeggs <bskeggs@redhat.com>,
nouveau@lists.freedesktop.org, Dave Airlie <airlied@redhat.com>,
Matt Turner <mattst88@gmail.com>,
linux-snps-arc@lists.infradead.org,
Nick Kossifidis <mickflemm@gmail.com>,
Allen Hubbe <allenbh@gmail.com>, Arnd Bergmann <arnd@arndb.de>,
linux-alpha@vger.kernel.org,
Ivan Kokshaysky <ink@jurassic.park.msu.ru>,
Thomas Gleixner <tglx@linutronix.de>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Kalle Valo <kvalo@codeaurora.org>,
Richard Henderson <rth@twiddle.net>,
linux-parisc@vger.kernel.org, Vineet Gupta <vgupta@synopsys.com>,
linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org,
Luis Chamberlain <mcgrof@kernel.org>,
Daniel Vetter <daniel@ffwll.ch>, Jon Mason <jdmason@kudzu.us>,
linux-ntb@googlegroups.com,
Andrew Morton <akpm@linux-foundation.org>,
linux-media@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [RESEND PATCH v2 9/9] ath5k: Constify ioreadX() iomem argument (as in generic implementation)
Date: Mon, 24 Feb 2020 13:47:44 +0100 [thread overview]
Message-ID: <20200224124744.GA1949@pi3> (raw)
In-Reply-To: <518a9023-f802-17b3-fca5-582400bc34ae@gmail.com>
On Thu, Feb 20, 2020 at 10:48:33AM +0100, Jiri Slaby wrote:
> On 19. 02. 20, 18:50, Krzysztof Kozlowski wrote:
> > The ioreadX() helpers have inconsistent interface. On some architectures
> > void *__iomem address argument is a pointer to const, on some not.
> >
> > Implementations of ioreadX() do not modify the memory under the address
> > so they can be converted to a "const" version for const-safety and
> > consistency among architectures.
> >
> > Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> > Acked-by: Kalle Valo <kvalo@codeaurora.org>
> > ---
> > drivers/net/wireless/ath/ath5k/ahb.c | 10 +++++-----
> > 1 file changed, 5 insertions(+), 5 deletions(-)
> >
> > diff --git a/drivers/net/wireless/ath/ath5k/ahb.c b/drivers/net/wireless/ath/ath5k/ahb.c
> > index 2c9cec8b53d9..8bd01df369fb 100644
> > --- a/drivers/net/wireless/ath/ath5k/ahb.c
> > +++ b/drivers/net/wireless/ath/ath5k/ahb.c
> > @@ -138,18 +138,18 @@ static int ath_ahb_probe(struct platform_device *pdev)
> >
> > if (bcfg->devid >= AR5K_SREV_AR2315_R6) {
> > /* Enable WMAC AHB arbitration */
> > - reg = ioread32((void __iomem *) AR5K_AR2315_AHB_ARB_CTL);
> > + reg = ioread32((const void __iomem *) AR5K_AR2315_AHB_ARB_CTL);
>
> While I understand why the parameter of ioread32 should be const, I
> don't see a reason for these casts on the users' side. What does it
> bring except longer code to read?
Because the argument is an int:
drivers/net/wireless/ath/ath5k/ahb.c: In function ‘ath_ahb_probe’:
drivers/net/wireless/ath/ath5k/ahb.c:141:18: warning: passing argument 1 of ‘ioread32’ makes pointer from integer without a cast [-Wint-conversion]
reg = ioread32(AR5K_AR2315_AHB_ARB_CTL);
Best regards,
Krzysztof
_______________________________________________
linux-snps-arc mailing list
linux-snps-arc@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-snps-arc
WARNING: multiple messages have this Message-ID (diff)
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Jiri Slaby <jirislaby@gmail.com>
Cc: Rich Felker <dalias@libc.org>,
Geert Uytterhoeven <geert+renesas@glider.be>,
"Michael S. Tsirkin" <mst@redhat.com>,
David Airlie <airlied@linux.ie>, Jason Wang <jasowang@redhat.com>,
dri-devel@lists.freedesktop.org,
virtualization@lists.linux-foundation.org,
"James E.J. Bottomley" <James.Bottomley@hansenpartnership.com>,
netdev@vger.kernel.org, Paul Mackerras <paulus@samba.org>,
linux-arch@vger.kernel.org, Dave Jiang <dave.jiang@intel.com>,
Yoshinori Sato <ysato@users.sourceforge.jp>,
Michael Ellerman <mpe@ellerman.id.au>,
Helge Deller <deller@gmx.de>,
linux-sh@vger.kernel.org, Alexey Brodkin <abrodkin@synopsys.com>,
Ben Skeggs <bskeggs@redhat.com>,
nouveau@lists.freedesktop.org, Dave Airlie <airlied@redhat.com>,
Matt Turner <mattst88@gmail.com>,
linux-snps-arc@lists.infradead.org,
Nick Kossifidis <mickflemm@gmail.com>,
Allen Hubbe <allenbh@gmail.com>, Arnd Bergmann <arnd@arndb.de>,
linux-alpha@vger.kernel.org,
Ivan Kokshaysky <ink@jurassic.park.msu.ru>,
Thomas Gleixner <tglx@linutronix.de>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Kalle Valo <kvalo@codeaurora.org>,
Richard Henderson <rth@twiddle.net>,
linux-parisc@vger.kernel.org, Vineet Gupta <vgupta@synopsys.com>,
linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org,
Luis Chamberlain <mcgrof@kernel.org>,
Jon Mason <jdmason@kudzu.us>,
linux-ntb@googlegroups.com,
Andrew Morton <akpm@linux-foundation.org>,
linux-media@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [RESEND PATCH v2 9/9] ath5k: Constify ioreadX() iomem argument (as in generic implementation)
Date: Mon, 24 Feb 2020 13:47:44 +0100 [thread overview]
Message-ID: <20200224124744.GA1949@pi3> (raw)
In-Reply-To: <518a9023-f802-17b3-fca5-582400bc34ae@gmail.com>
On Thu, Feb 20, 2020 at 10:48:33AM +0100, Jiri Slaby wrote:
> On 19. 02. 20, 18:50, Krzysztof Kozlowski wrote:
> > The ioreadX() helpers have inconsistent interface. On some architectures
> > void *__iomem address argument is a pointer to const, on some not.
> >
> > Implementations of ioreadX() do not modify the memory under the address
> > so they can be converted to a "const" version for const-safety and
> > consistency among architectures.
> >
> > Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> > Acked-by: Kalle Valo <kvalo@codeaurora.org>
> > ---
> > drivers/net/wireless/ath/ath5k/ahb.c | 10 +++++-----
> > 1 file changed, 5 insertions(+), 5 deletions(-)
> >
> > diff --git a/drivers/net/wireless/ath/ath5k/ahb.c b/drivers/net/wireless/ath/ath5k/ahb.c
> > index 2c9cec8b53d9..8bd01df369fb 100644
> > --- a/drivers/net/wireless/ath/ath5k/ahb.c
> > +++ b/drivers/net/wireless/ath/ath5k/ahb.c
> > @@ -138,18 +138,18 @@ static int ath_ahb_probe(struct platform_device *pdev)
> >
> > if (bcfg->devid >= AR5K_SREV_AR2315_R6) {
> > /* Enable WMAC AHB arbitration */
> > - reg = ioread32((void __iomem *) AR5K_AR2315_AHB_ARB_CTL);
> > + reg = ioread32((const void __iomem *) AR5K_AR2315_AHB_ARB_CTL);
>
> While I understand why the parameter of ioread32 should be const, I
> don't see a reason for these casts on the users' side. What does it
> bring except longer code to read?
Because the argument is an int:
drivers/net/wireless/ath/ath5k/ahb.c: In function ‘ath_ahb_probe’:
drivers/net/wireless/ath/ath5k/ahb.c:141:18: warning: passing argument 1 of ‘ioread32’ makes pointer from integer without a cast [-Wint-conversion]
reg = ioread32(AR5K_AR2315_AHB_ARB_CTL);
Best regards,
Krzysztof
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2020-02-24 12:47 UTC|newest]
Thread overview: 148+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-19 17:49 [RESEND PATCH v2 0/9] iomap: Constify ioreadX() iomem argument Krzysztof Kozlowski
2020-02-19 17:49 ` Krzysztof Kozlowski
2020-02-19 17:49 ` Krzysztof Kozlowski
2020-02-19 17:49 ` Krzysztof Kozlowski
2020-02-19 17:49 ` Krzysztof Kozlowski
2020-02-19 17:49 ` [RESEND PATCH v2 1/9] iomap: Constify ioreadX() iomem argument (as in generic implementation) Krzysztof Kozlowski
2020-02-19 17:49 ` Krzysztof Kozlowski
2020-02-19 17:49 ` Krzysztof Kozlowski
2020-02-19 17:49 ` Krzysztof Kozlowski
[not found] ` <20200219175007.13627-2-krzk-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2020-03-12 10:55 ` Michael Ellerman
2020-03-12 10:55 ` Michael Ellerman
2020-03-12 10:55 ` Michael Ellerman
2020-03-12 10:55 ` Michael Ellerman
2020-03-12 10:55 ` Michael Ellerman
2020-03-12 10:55 ` Michael Ellerman
2020-03-12 10:55 ` Michael Ellerman
2020-03-12 10:55 ` Michael Ellerman
2020-03-12 10:55 ` Michael Ellerman
2020-03-14 11:02 ` Krzysztof Kozlowski
2020-03-14 11:02 ` Krzysztof Kozlowski
2020-03-14 11:02 ` Krzysztof Kozlowski
2020-03-14 11:02 ` Krzysztof Kozlowski
2020-03-14 11:02 ` Krzysztof Kozlowski
2020-03-14 11:02 ` Krzysztof Kozlowski
2020-02-19 17:49 ` Krzysztof Kozlowski
2020-02-19 17:49 ` Krzysztof Kozlowski
2020-02-19 17:49 ` Krzysztof Kozlowski
2020-02-19 17:50 ` [RESEND PATCH v2 2/9] rtl818x: " Krzysztof Kozlowski
2020-02-19 17:50 ` Krzysztof Kozlowski
2020-02-19 17:50 ` Krzysztof Kozlowski
2020-02-19 17:50 ` Krzysztof Kozlowski
2020-02-19 17:50 ` Krzysztof Kozlowski
2020-02-19 17:50 ` Krzysztof Kozlowski
2020-02-19 17:50 ` Krzysztof Kozlowski
2020-02-19 17:50 ` [RESEND PATCH v2 3/9] ntb: intel: " Krzysztof Kozlowski
2020-02-19 17:50 ` Krzysztof Kozlowski
2020-02-19 17:50 ` Krzysztof Kozlowski
2020-02-19 17:50 ` Krzysztof Kozlowski
2020-02-19 17:50 ` Krzysztof Kozlowski
2020-02-19 17:50 ` Krzysztof Kozlowski
2020-02-19 17:50 ` Krzysztof Kozlowski
2020-02-19 17:50 ` [RESEND PATCH v2 4/9] virtio: pci: " Krzysztof Kozlowski
2020-02-19 17:50 ` Krzysztof Kozlowski
2020-02-19 17:50 ` Krzysztof Kozlowski
2020-02-19 17:50 ` Krzysztof Kozlowski
2020-02-19 17:50 ` Krzysztof Kozlowski
2020-02-19 17:50 ` Krzysztof Kozlowski
2020-02-19 17:50 ` Krzysztof Kozlowski
2020-02-19 17:50 ` [RESEND PATCH v2 5/9] arc: " Krzysztof Kozlowski
2020-02-19 17:50 ` Krzysztof Kozlowski
2020-02-19 17:50 ` Krzysztof Kozlowski
2020-02-19 17:50 ` Krzysztof Kozlowski
2020-02-19 17:50 ` Krzysztof Kozlowski
2020-02-19 17:50 ` Krzysztof Kozlowski
2020-02-19 17:50 ` Krzysztof Kozlowski
2020-02-19 17:50 ` [RESEND PATCH v2 6/9] drm/mgag200: " Krzysztof Kozlowski
2020-02-19 17:50 ` Krzysztof Kozlowski
2020-02-19 17:50 ` Krzysztof Kozlowski
2020-02-19 17:50 ` Krzysztof Kozlowski
2020-02-19 17:50 ` Krzysztof Kozlowski
2020-02-19 17:50 ` Krzysztof Kozlowski
2020-02-19 17:50 ` Krzysztof Kozlowski
2020-03-12 10:49 ` [RESEND PATCH v2 6/9] drm/mgag200: Constify ioreadX() iomem argument (as in generic implementati Thomas Zimmermann
2020-03-12 10:49 ` [RESEND PATCH v2 6/9] drm/mgag200: Constify ioreadX() iomem argument (as in generic implementation) Thomas Zimmermann
2020-03-12 10:49 ` Thomas Zimmermann
2020-03-12 10:49 ` Thomas Zimmermann
2020-03-12 10:49 ` Thomas Zimmermann
2020-03-14 10:59 ` [RESEND PATCH v2 6/9] drm/mgag200: Constify ioreadX() iomem argument (as in generic implementati Krzysztof Kozlowski
2020-03-14 10:59 ` [RESEND PATCH v2 6/9] drm/mgag200: Constify ioreadX() iomem argument (as in generic implementation) Krzysztof Kozlowski
2020-03-14 10:59 ` Krzysztof Kozlowski
2020-03-14 10:59 ` Krzysztof Kozlowski
2020-03-14 10:59 ` Krzysztof Kozlowski
2020-03-14 10:59 ` Krzysztof Kozlowski
2020-03-24 8:39 ` [RESEND PATCH v2 6/9] drm/mgag200: Constify ioreadX() iomem argument (as in generic implementati Thomas Zimmermann
2020-03-24 8:39 ` [RESEND PATCH v2 6/9] drm/mgag200: Constify ioreadX() iomem argument (as in generic implementation) Thomas Zimmermann
2020-03-24 8:39 ` Thomas Zimmermann
2020-03-24 8:39 ` Thomas Zimmermann
2020-03-24 8:39 ` Thomas Zimmermann
2020-03-24 8:39 ` Thomas Zimmermann
[not found] ` <20200219175007.13627-7-krzk-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2020-03-12 10:49 ` Thomas Zimmermann
2020-03-12 10:49 ` Thomas Zimmermann
2020-03-12 10:49 ` Thomas Zimmermann
2020-02-19 17:50 ` [RESEND PATCH v2 7/9] drm/nouveau: " Krzysztof Kozlowski
2020-02-19 17:50 ` Krzysztof Kozlowski
2020-02-19 17:50 ` Krzysztof Kozlowski
2020-02-19 17:50 ` Krzysztof Kozlowski
2020-02-19 17:50 ` Krzysztof Kozlowski
2020-02-19 17:50 ` Krzysztof Kozlowski
2020-02-19 17:50 ` Krzysztof Kozlowski
2020-02-19 17:50 ` [RESEND PATCH v2 8/9] media: fsl-viu: " Krzysztof Kozlowski
2020-02-19 17:50 ` [RESEND PATCH v2 8/9] media: fsl-viu: Constify ioreadX() iomem argument (as in generic implementatio Krzysztof Kozlowski
2020-02-19 17:50 ` [RESEND PATCH v2 8/9] media: fsl-viu: Constify ioreadX() iomem argument (as in generic implementation) Krzysztof Kozlowski
2020-02-19 17:50 ` Krzysztof Kozlowski
2020-02-19 17:50 ` Krzysztof Kozlowski
2020-03-12 8:01 ` [RESEND PATCH v2 8/9] media: fsl-viu: Constify ioreadX() iomem argument (as in generic implement Hans Verkuil
2020-03-12 8:01 ` [RESEND PATCH v2 8/9] media: fsl-viu: Constify ioreadX() iomem argument (as in generic implementation) Hans Verkuil
2020-03-12 8:01 ` Hans Verkuil
2020-03-12 8:01 ` Hans Verkuil
2020-03-12 8:01 ` Hans Verkuil
2020-03-12 8:01 ` Hans Verkuil
[not found] ` <20200219175007.13627-9-krzk-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2020-03-12 8:01 ` Hans Verkuil
2020-02-19 17:50 ` Krzysztof Kozlowski
2020-02-19 17:50 ` Krzysztof Kozlowski
2020-02-19 17:50 ` [RESEND PATCH v2 9/9] ath5k: " Krzysztof Kozlowski
2020-02-19 17:50 ` Krzysztof Kozlowski
2020-02-19 17:50 ` Krzysztof Kozlowski
2020-02-19 17:50 ` Krzysztof Kozlowski
2020-02-19 17:50 ` Krzysztof Kozlowski
2020-02-20 9:48 ` Jiri Slaby
2020-02-20 9:48 ` Jiri Slaby
2020-02-20 9:48 ` Jiri Slaby
2020-02-20 9:48 ` Jiri Slaby
2020-02-20 9:48 ` Jiri Slaby
2020-02-20 9:48 ` Jiri Slaby
2020-02-24 12:47 ` Krzysztof Kozlowski [this message]
2020-02-24 12:47 ` Krzysztof Kozlowski
2020-02-24 12:47 ` Krzysztof Kozlowski
2020-02-24 12:47 ` Krzysztof Kozlowski
2020-02-24 12:47 ` Krzysztof Kozlowski
2020-02-24 12:47 ` Krzysztof Kozlowski
2020-02-24 12:54 ` Geert Uytterhoeven
2020-02-24 12:54 ` Geert Uytterhoeven
2020-02-24 12:54 ` Geert Uytterhoeven
2020-02-24 12:54 ` Geert Uytterhoeven
2020-02-24 12:54 ` Geert Uytterhoeven
2020-02-24 14:00 ` David Laight
2020-02-24 14:00 ` David Laight
2020-02-24 14:00 ` David Laight
2020-02-24 14:00 ` David Laight
2020-02-24 14:00 ` David Laight
2020-02-24 14:44 ` Krzysztof Kozlowski
2020-02-24 14:44 ` Krzysztof Kozlowski
2020-02-24 14:44 ` Krzysztof Kozlowski
2020-02-24 14:44 ` Krzysztof Kozlowski
2020-02-24 14:44 ` Krzysztof Kozlowski
2020-02-20 9:48 ` Jiri Slaby
[not found] ` <20200219175007.13627-10-krzk-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2020-02-20 9:48 ` Jiri Slaby
2020-02-19 17:50 ` Krzysztof Kozlowski
[not found] ` <20200219175007.13627-1-krzk-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2020-02-19 17:49 ` [RESEND PATCH v2 1/9] iomap: " Krzysztof Kozlowski
2020-02-19 17:50 ` [RESEND PATCH v2 2/9] rtl818x: " Krzysztof Kozlowski
2020-02-19 17:50 ` [RESEND PATCH v2 3/9] ntb: intel: " Krzysztof Kozlowski
2020-02-19 17:50 ` [RESEND PATCH v2 4/9] virtio: pci: " Krzysztof Kozlowski
2020-02-19 17:50 ` [RESEND PATCH v2 5/9] arc: " Krzysztof Kozlowski
2020-02-19 17:50 ` [RESEND PATCH v2 6/9] drm/mgag200: " Krzysztof Kozlowski
2020-02-19 17:50 ` [RESEND PATCH v2 7/9] drm/nouveau: " Krzysztof Kozlowski
2020-02-19 17:50 ` [RESEND PATCH v2 8/9] media: fsl-viu: " Krzysztof Kozlowski
2020-02-19 17:50 ` [RESEND PATCH v2 9/9] ath5k: " Krzysztof Kozlowski
2020-02-19 17:50 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200224124744.GA1949@pi3 \
--to=krzk@kernel.org \
--cc=James.Bottomley@hansenpartnership.com \
--cc=abrodkin@synopsys.com \
--cc=airlied@linux.ie \
--cc=airlied@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=allenbh@gmail.com \
--cc=arnd@arndb.de \
--cc=bskeggs@redhat.com \
--cc=dalias@libc.org \
--cc=dave.jiang@intel.com \
--cc=davem@davemloft.net \
--cc=deller@gmx.de \
--cc=dri-devel@lists.freedesktop.org \
--cc=geert+renesas@glider.be \
--cc=ink@jurassic.park.msu.ru \
--cc=jasowang@redhat.com \
--cc=jdmason@kudzu.us \
--cc=jirislaby@gmail.com \
--cc=kvalo@codeaurora.org \
--cc=linux-alpha@vger.kernel.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-ntb@googlegroups.com \
--cc=linux-parisc@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=linux-snps-arc@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mattst88@gmail.com \
--cc=mcgrof@kernel.org \
--cc=mchehab@kernel.org \
--cc=mickflemm@gmail.com \
--cc=mpe@ellerman.id.au \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=nouveau@lists.freedesktop.org \
--cc=paulus@samba.org \
--cc=rth@twiddle.net \
--cc=tglx@linutronix.de \
--cc=vgupta@synopsys.com \
--cc=virtualization@lists.linux-foundation.org \
--cc=ysato@users.sourceforge.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.