From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: Matthew Wilcox <willy@infradead.org>
Cc: Christoph Hellwig <hch@infradead.org>,
linux-fsdevel@vger.kernel.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, linux-btrfs@vger.kernel.org,
linux-erofs@lists.ozlabs.org, linux-ext4@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net, cluster-devel@redhat.com,
ocfs2-devel@oss.oracle.com, linux-xfs@vger.kernel.org
Subject: Re: [PATCH v7 22/24] iomap: Convert from readpages to readahead
Date: Mon, 24 Feb 2020 08:52:44 -0800 [thread overview]
Message-ID: <20200224165244.GA6731@magnolia> (raw)
In-Reply-To: <20200224043355.GL24185@bombadil.infradead.org>
On Sun, Feb 23, 2020 at 08:33:55PM -0800, Matthew Wilcox wrote:
> On Fri, Feb 21, 2020 at 05:00:13PM -0800, Darrick J. Wong wrote:
> > On Thu, Feb 20, 2020 at 08:57:34AM -0800, Matthew Wilcox wrote:
> > > On Thu, Feb 20, 2020 at 07:49:12AM -0800, Christoph Hellwig wrote:
> > > +/**
> > > + * iomap_readahead - Attempt to read pages from a file.
> > > + * @rac: Describes the pages to be read.
> > > + * @ops: The operations vector for the filesystem.
> > > + *
> > > + * This function is for filesystems to call to implement their readahead
> > > + * address_space operation.
> > > + *
> > > + * Context: The file is pinned by the caller, and the pages to be read are
> > > + * all locked and have an elevated refcount. This function will unlock
> > > + * the pages (once I/O has completed on them, or I/O has been determined to
> > > + * not be necessary). It will also decrease the refcount once the pages
> > > + * have been submitted for I/O. After this point, the page may be removed
> > > + * from the page cache, and should not be referenced.
> > > + */
> > >
> > > > Isn't the context documentation something that belongs into the aop
> > > > documentation? I've never really seen the value of duplicating this
> > > > information in method instances, as it is just bound to be out of date
> > > > rather sooner than later.
> > >
> > > I'm in two minds about it as well. There's definitely no value in
> > > providing kernel-doc for implementations of a common interface ... so
> > > rather than fixing the nilfs2 kernel-doc, I just deleted it. But this
> > > isn't just the implementation, like nilfs2_readahead() is, it's a library
> > > function for filesystems to call, so it deserves documentation. On the
> > > other hand, there's no real thought to this on the part of the filesystem;
> > > the implementation just calls this with the appropriate ops pointer.
> > >
> > > Then again, I kind of feel like we need more documentation of iomap to
> > > help filesystems convert to using it. But maybe kernel-doc isn't the
> > > mechanism to provide that.
> >
> > I think we need more documentation of the parts of iomap where it can
> > call back into the filesystem (looking at you, iomap_dio_ops).
> >
> > I'm not opposed to letting this comment stay, though I don't see it as
> > all that necessary since iomap_readahead implements a callout that's
> > documented in vfs.rst and is thus subject to all the constraints listed
> > in the (*readahead) documentation.
>
> Right. And that's not currently in kernel-doc format, but should be.
> Something for a different patchset, IMO.
>
> What we need documenting _here_ is the conditions under which the
> iomap_ops are called so the filesystem author doesn't need to piece them
> together from three different places. Here's what I currently have:
>
> * Context: The @ops callbacks may submit I/O (eg to read the addresses of
> * blocks from disc), and may wait for it. The caller may be trying to
> * access a different page, and so sleeping excessively should be avoided.
> * It may allocate memory, but should avoid large allocations. This
> * function is called with memalloc_nofs set, so allocations will not cause
> * the filesystem to be reentered.
How large? :)
--D
WARNING: multiple messages have this Message-ID (diff)
From: Darrick J. Wong <darrick.wong@oracle.com>
To: Matthew Wilcox <willy@infradead.org>
Cc: Christoph Hellwig <hch@infradead.org>,
linux-fsdevel@vger.kernel.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, linux-btrfs@vger.kernel.org,
linux-erofs@lists.ozlabs.org, linux-ext4@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net, cluster-devel@redhat.com,
ocfs2-devel@oss.oracle.com, linux-xfs@vger.kernel.org
Subject: [Ocfs2-devel] [PATCH v7 22/24] iomap: Convert from readpages to readahead
Date: Mon, 24 Feb 2020 08:52:44 -0800 [thread overview]
Message-ID: <20200224165244.GA6731@magnolia> (raw)
In-Reply-To: <20200224043355.GL24185@bombadil.infradead.org>
On Sun, Feb 23, 2020 at 08:33:55PM -0800, Matthew Wilcox wrote:
> On Fri, Feb 21, 2020 at 05:00:13PM -0800, Darrick J. Wong wrote:
> > On Thu, Feb 20, 2020 at 08:57:34AM -0800, Matthew Wilcox wrote:
> > > On Thu, Feb 20, 2020 at 07:49:12AM -0800, Christoph Hellwig wrote:
> > > +/**
> > > + * iomap_readahead - Attempt to read pages from a file.
> > > + * @rac: Describes the pages to be read.
> > > + * @ops: The operations vector for the filesystem.
> > > + *
> > > + * This function is for filesystems to call to implement their readahead
> > > + * address_space operation.
> > > + *
> > > + * Context: The file is pinned by the caller, and the pages to be read are
> > > + * all locked and have an elevated refcount. This function will unlock
> > > + * the pages (once I/O has completed on them, or I/O has been determined to
> > > + * not be necessary). It will also decrease the refcount once the pages
> > > + * have been submitted for I/O. After this point, the page may be removed
> > > + * from the page cache, and should not be referenced.
> > > + */
> > >
> > > > Isn't the context documentation something that belongs into the aop
> > > > documentation? I've never really seen the value of duplicating this
> > > > information in method instances, as it is just bound to be out of date
> > > > rather sooner than later.
> > >
> > > I'm in two minds about it as well. There's definitely no value in
> > > providing kernel-doc for implementations of a common interface ... so
> > > rather than fixing the nilfs2 kernel-doc, I just deleted it. But this
> > > isn't just the implementation, like nilfs2_readahead() is, it's a library
> > > function for filesystems to call, so it deserves documentation. On the
> > > other hand, there's no real thought to this on the part of the filesystem;
> > > the implementation just calls this with the appropriate ops pointer.
> > >
> > > Then again, I kind of feel like we need more documentation of iomap to
> > > help filesystems convert to using it. But maybe kernel-doc isn't the
> > > mechanism to provide that.
> >
> > I think we need more documentation of the parts of iomap where it can
> > call back into the filesystem (looking at you, iomap_dio_ops).
> >
> > I'm not opposed to letting this comment stay, though I don't see it as
> > all that necessary since iomap_readahead implements a callout that's
> > documented in vfs.rst and is thus subject to all the constraints listed
> > in the (*readahead) documentation.
>
> Right. And that's not currently in kernel-doc format, but should be.
> Something for a different patchset, IMO.
>
> What we need documenting _here_ is the conditions under which the
> iomap_ops are called so the filesystem author doesn't need to piece them
> together from three different places. Here's what I currently have:
>
> * Context: The @ops callbacks may submit I/O (eg to read the addresses of
> * blocks from disc), and may wait for it. The caller may be trying to
> * access a different page, and so sleeping excessively should be avoided.
> * It may allocate memory, but should avoid large allocations. This
> * function is called with memalloc_nofs set, so allocations will not cause
> * the filesystem to be reentered.
How large? :)
--D
WARNING: multiple messages have this Message-ID (diff)
From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: Matthew Wilcox <willy@infradead.org>
Cc: cluster-devel@redhat.com, linux-kernel@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net,
Christoph Hellwig <hch@infradead.org>,
linux-mm@kvack.org, ocfs2-devel@oss.oracle.com,
linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org,
linux-erofs@lists.ozlabs.org, linux-xfs@vger.kernel.org,
linux-btrfs@vger.kernel.org
Subject: Re: [f2fs-dev] [PATCH v7 22/24] iomap: Convert from readpages to readahead
Date: Mon, 24 Feb 2020 08:52:44 -0800 [thread overview]
Message-ID: <20200224165244.GA6731@magnolia> (raw)
In-Reply-To: <20200224043355.GL24185@bombadil.infradead.org>
On Sun, Feb 23, 2020 at 08:33:55PM -0800, Matthew Wilcox wrote:
> On Fri, Feb 21, 2020 at 05:00:13PM -0800, Darrick J. Wong wrote:
> > On Thu, Feb 20, 2020 at 08:57:34AM -0800, Matthew Wilcox wrote:
> > > On Thu, Feb 20, 2020 at 07:49:12AM -0800, Christoph Hellwig wrote:
> > > +/**
> > > + * iomap_readahead - Attempt to read pages from a file.
> > > + * @rac: Describes the pages to be read.
> > > + * @ops: The operations vector for the filesystem.
> > > + *
> > > + * This function is for filesystems to call to implement their readahead
> > > + * address_space operation.
> > > + *
> > > + * Context: The file is pinned by the caller, and the pages to be read are
> > > + * all locked and have an elevated refcount. This function will unlock
> > > + * the pages (once I/O has completed on them, or I/O has been determined to
> > > + * not be necessary). It will also decrease the refcount once the pages
> > > + * have been submitted for I/O. After this point, the page may be removed
> > > + * from the page cache, and should not be referenced.
> > > + */
> > >
> > > > Isn't the context documentation something that belongs into the aop
> > > > documentation? I've never really seen the value of duplicating this
> > > > information in method instances, as it is just bound to be out of date
> > > > rather sooner than later.
> > >
> > > I'm in two minds about it as well. There's definitely no value in
> > > providing kernel-doc for implementations of a common interface ... so
> > > rather than fixing the nilfs2 kernel-doc, I just deleted it. But this
> > > isn't just the implementation, like nilfs2_readahead() is, it's a library
> > > function for filesystems to call, so it deserves documentation. On the
> > > other hand, there's no real thought to this on the part of the filesystem;
> > > the implementation just calls this with the appropriate ops pointer.
> > >
> > > Then again, I kind of feel like we need more documentation of iomap to
> > > help filesystems convert to using it. But maybe kernel-doc isn't the
> > > mechanism to provide that.
> >
> > I think we need more documentation of the parts of iomap where it can
> > call back into the filesystem (looking at you, iomap_dio_ops).
> >
> > I'm not opposed to letting this comment stay, though I don't see it as
> > all that necessary since iomap_readahead implements a callout that's
> > documented in vfs.rst and is thus subject to all the constraints listed
> > in the (*readahead) documentation.
>
> Right. And that's not currently in kernel-doc format, but should be.
> Something for a different patchset, IMO.
>
> What we need documenting _here_ is the conditions under which the
> iomap_ops are called so the filesystem author doesn't need to piece them
> together from three different places. Here's what I currently have:
>
> * Context: The @ops callbacks may submit I/O (eg to read the addresses of
> * blocks from disc), and may wait for it. The caller may be trying to
> * access a different page, and so sleeping excessively should be avoided.
> * It may allocate memory, but should avoid large allocations. This
> * function is called with memalloc_nofs set, so allocations will not cause
> * the filesystem to be reentered.
How large? :)
--D
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
WARNING: multiple messages have this Message-ID (diff)
From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: Matthew Wilcox <willy@infradead.org>
Cc: cluster-devel@redhat.com, linux-kernel@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net,
Christoph Hellwig <hch@infradead.org>,
linux-mm@kvack.org, ocfs2-devel@oss.oracle.com,
linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org,
linux-erofs@lists.ozlabs.org, linux-xfs@vger.kernel.org,
linux-btrfs@vger.kernel.org
Subject: Re: [PATCH v7 22/24] iomap: Convert from readpages to readahead
Date: Mon, 24 Feb 2020 08:52:44 -0800 [thread overview]
Message-ID: <20200224165244.GA6731@magnolia> (raw)
In-Reply-To: <20200224043355.GL24185@bombadil.infradead.org>
On Sun, Feb 23, 2020 at 08:33:55PM -0800, Matthew Wilcox wrote:
> On Fri, Feb 21, 2020 at 05:00:13PM -0800, Darrick J. Wong wrote:
> > On Thu, Feb 20, 2020 at 08:57:34AM -0800, Matthew Wilcox wrote:
> > > On Thu, Feb 20, 2020 at 07:49:12AM -0800, Christoph Hellwig wrote:
> > > +/**
> > > + * iomap_readahead - Attempt to read pages from a file.
> > > + * @rac: Describes the pages to be read.
> > > + * @ops: The operations vector for the filesystem.
> > > + *
> > > + * This function is for filesystems to call to implement their readahead
> > > + * address_space operation.
> > > + *
> > > + * Context: The file is pinned by the caller, and the pages to be read are
> > > + * all locked and have an elevated refcount. This function will unlock
> > > + * the pages (once I/O has completed on them, or I/O has been determined to
> > > + * not be necessary). It will also decrease the refcount once the pages
> > > + * have been submitted for I/O. After this point, the page may be removed
> > > + * from the page cache, and should not be referenced.
> > > + */
> > >
> > > > Isn't the context documentation something that belongs into the aop
> > > > documentation? I've never really seen the value of duplicating this
> > > > information in method instances, as it is just bound to be out of date
> > > > rather sooner than later.
> > >
> > > I'm in two minds about it as well. There's definitely no value in
> > > providing kernel-doc for implementations of a common interface ... so
> > > rather than fixing the nilfs2 kernel-doc, I just deleted it. But this
> > > isn't just the implementation, like nilfs2_readahead() is, it's a library
> > > function for filesystems to call, so it deserves documentation. On the
> > > other hand, there's no real thought to this on the part of the filesystem;
> > > the implementation just calls this with the appropriate ops pointer.
> > >
> > > Then again, I kind of feel like we need more documentation of iomap to
> > > help filesystems convert to using it. But maybe kernel-doc isn't the
> > > mechanism to provide that.
> >
> > I think we need more documentation of the parts of iomap where it can
> > call back into the filesystem (looking at you, iomap_dio_ops).
> >
> > I'm not opposed to letting this comment stay, though I don't see it as
> > all that necessary since iomap_readahead implements a callout that's
> > documented in vfs.rst and is thus subject to all the constraints listed
> > in the (*readahead) documentation.
>
> Right. And that's not currently in kernel-doc format, but should be.
> Something for a different patchset, IMO.
>
> What we need documenting _here_ is the conditions under which the
> iomap_ops are called so the filesystem author doesn't need to piece them
> together from three different places. Here's what I currently have:
>
> * Context: The @ops callbacks may submit I/O (eg to read the addresses of
> * blocks from disc), and may wait for it. The caller may be trying to
> * access a different page, and so sleeping excessively should be avoided.
> * It may allocate memory, but should avoid large allocations. This
> * function is called with memalloc_nofs set, so allocations will not cause
> * the filesystem to be reentered.
How large? :)
--D
WARNING: multiple messages have this Message-ID (diff)
From: Darrick J. Wong <darrick.wong@oracle.com>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [PATCH v7 22/24] iomap: Convert from readpages to readahead
Date: Mon, 24 Feb 2020 08:52:44 -0800 [thread overview]
Message-ID: <20200224165244.GA6731@magnolia> (raw)
In-Reply-To: <20200224043355.GL24185@bombadil.infradead.org>
On Sun, Feb 23, 2020 at 08:33:55PM -0800, Matthew Wilcox wrote:
> On Fri, Feb 21, 2020 at 05:00:13PM -0800, Darrick J. Wong wrote:
> > On Thu, Feb 20, 2020 at 08:57:34AM -0800, Matthew Wilcox wrote:
> > > On Thu, Feb 20, 2020 at 07:49:12AM -0800, Christoph Hellwig wrote:
> > > +/**
> > > + * iomap_readahead - Attempt to read pages from a file.
> > > + * @rac: Describes the pages to be read.
> > > + * @ops: The operations vector for the filesystem.
> > > + *
> > > + * This function is for filesystems to call to implement their readahead
> > > + * address_space operation.
> > > + *
> > > + * Context: The file is pinned by the caller, and the pages to be read are
> > > + * all locked and have an elevated refcount. This function will unlock
> > > + * the pages (once I/O has completed on them, or I/O has been determined to
> > > + * not be necessary). It will also decrease the refcount once the pages
> > > + * have been submitted for I/O. After this point, the page may be removed
> > > + * from the page cache, and should not be referenced.
> > > + */
> > >
> > > > Isn't the context documentation something that belongs into the aop
> > > > documentation? I've never really seen the value of duplicating this
> > > > information in method instances, as it is just bound to be out of date
> > > > rather sooner than later.
> > >
> > > I'm in two minds about it as well. There's definitely no value in
> > > providing kernel-doc for implementations of a common interface ... so
> > > rather than fixing the nilfs2 kernel-doc, I just deleted it. But this
> > > isn't just the implementation, like nilfs2_readahead() is, it's a library
> > > function for filesystems to call, so it deserves documentation. On the
> > > other hand, there's no real thought to this on the part of the filesystem;
> > > the implementation just calls this with the appropriate ops pointer.
> > >
> > > Then again, I kind of feel like we need more documentation of iomap to
> > > help filesystems convert to using it. But maybe kernel-doc isn't the
> > > mechanism to provide that.
> >
> > I think we need more documentation of the parts of iomap where it can
> > call back into the filesystem (looking at you, iomap_dio_ops).
> >
> > I'm not opposed to letting this comment stay, though I don't see it as
> > all that necessary since iomap_readahead implements a callout that's
> > documented in vfs.rst and is thus subject to all the constraints listed
> > in the (*readahead) documentation.
>
> Right. And that's not currently in kernel-doc format, but should be.
> Something for a different patchset, IMO.
>
> What we need documenting _here_ is the conditions under which the
> iomap_ops are called so the filesystem author doesn't need to piece them
> together from three different places. Here's what I currently have:
>
> * Context: The @ops callbacks may submit I/O (eg to read the addresses of
> * blocks from disc), and may wait for it. The caller may be trying to
> * access a different page, and so sleeping excessively should be avoided.
> * It may allocate memory, but should avoid large allocations. This
> * function is called with memalloc_nofs set, so allocations will not cause
> * the filesystem to be reentered.
How large? :)
--D
next prev parent reply other threads:[~2020-02-24 16:53 UTC|newest]
Thread overview: 385+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-19 21:00 [PATCH v7 00/23] Change readahead API Matthew Wilcox
2020-02-19 21:00 ` [Cluster-devel] " Matthew Wilcox
2020-02-19 21:00 ` Matthew Wilcox
2020-02-19 21:00 ` [f2fs-dev] " Matthew Wilcox
2020-02-19 21:00 ` [Ocfs2-devel] " Matthew Wilcox
2020-02-19 21:00 ` [PATCH v7 01/24] mm: Move readahead prototypes from mm.h Matthew Wilcox
2020-02-19 21:00 ` [Cluster-devel] " Matthew Wilcox
2020-02-19 21:00 ` Matthew Wilcox
2020-02-19 21:00 ` [f2fs-dev] " Matthew Wilcox
2020-02-19 21:00 ` [Ocfs2-devel] " Matthew Wilcox
2020-02-21 2:43 ` John Hubbard
2020-02-21 2:43 ` [Cluster-devel] " John Hubbard
2020-02-21 2:43 ` John Hubbard
2020-02-21 2:43 ` [f2fs-dev] " John Hubbard
2020-02-21 2:43 ` [Ocfs2-devel] " John Hubbard
2020-02-21 21:48 ` Matthew Wilcox
2020-02-21 21:48 ` [Cluster-devel] " Matthew Wilcox
2020-02-21 21:48 ` Matthew Wilcox
2020-02-21 21:48 ` [f2fs-dev] " Matthew Wilcox
2020-02-21 21:48 ` [Ocfs2-devel] " Matthew Wilcox
2020-02-22 0:15 ` John Hubbard
2020-02-22 0:15 ` [Cluster-devel] " John Hubbard
2020-02-22 0:15 ` John Hubbard
2020-02-22 0:15 ` [f2fs-dev] " John Hubbard
2020-02-22 0:15 ` [Ocfs2-devel] " John Hubbard
2020-02-24 21:32 ` Christoph Hellwig
2020-02-24 21:32 ` [Cluster-devel] " Christoph Hellwig
2020-02-24 21:32 ` Christoph Hellwig
2020-02-24 21:32 ` [f2fs-dev] " Christoph Hellwig
2020-02-24 21:32 ` [Ocfs2-devel] " Christoph Hellwig
2020-02-19 21:00 ` [PATCH v7 02/24] mm: Return void from various readahead functions Matthew Wilcox
2020-02-19 21:00 ` [Cluster-devel] " Matthew Wilcox
2020-02-19 21:00 ` Matthew Wilcox
2020-02-19 21:00 ` [f2fs-dev] " Matthew Wilcox
2020-02-19 21:00 ` [Ocfs2-devel] " Matthew Wilcox
2020-02-24 21:33 ` Christoph Hellwig
2020-02-24 21:33 ` [Cluster-devel] " Christoph Hellwig
2020-02-24 21:33 ` Christoph Hellwig
2020-02-24 21:33 ` [f2fs-dev] " Christoph Hellwig
2020-02-24 21:33 ` [Ocfs2-devel] " Christoph Hellwig
2020-02-19 21:00 ` [PATCH v7 03/24] mm: Ignore return value of ->readpages Matthew Wilcox
2020-02-19 21:00 ` [Cluster-devel] " Matthew Wilcox
2020-02-19 21:00 ` Matthew Wilcox
2020-02-19 21:00 ` [f2fs-dev] " Matthew Wilcox
2020-02-19 21:00 ` [Ocfs2-devel] " Matthew Wilcox
2020-02-19 21:00 ` [PATCH v7 04/24] mm: Move readahead nr_pages check into read_pages Matthew Wilcox
2020-02-19 21:00 ` [Cluster-devel] " Matthew Wilcox
2020-02-19 21:00 ` Matthew Wilcox
2020-02-19 21:00 ` [f2fs-dev] " Matthew Wilcox
2020-02-19 21:00 ` [Ocfs2-devel] " Matthew Wilcox
2020-02-20 14:36 ` Zi Yan
2020-02-20 14:36 ` [Cluster-devel] " Zi Yan
2020-02-20 14:36 ` Zi Yan
2020-02-20 14:36 ` [Ocfs2-devel] " Zi Yan
2020-02-21 4:24 ` John Hubbard
2020-02-21 4:24 ` [Cluster-devel] " John Hubbard
2020-02-21 4:24 ` John Hubbard
2020-02-21 4:24 ` [f2fs-dev] " John Hubbard
2020-02-21 4:24 ` [Ocfs2-devel] " John Hubbard
2020-02-24 21:34 ` Christoph Hellwig
2020-02-24 21:34 ` [Cluster-devel] " Christoph Hellwig
2020-02-24 21:34 ` Christoph Hellwig
2020-02-24 21:34 ` [f2fs-dev] " Christoph Hellwig
2020-02-24 21:34 ` [Ocfs2-devel] " Christoph Hellwig
2020-02-19 21:00 ` [PATCH v7 05/24] mm: Use readahead_control to pass arguments Matthew Wilcox
2020-02-19 21:00 ` [Cluster-devel] " Matthew Wilcox
2020-02-19 21:00 ` Matthew Wilcox
2020-02-19 21:00 ` [f2fs-dev] " Matthew Wilcox
2020-02-19 21:00 ` [Ocfs2-devel] " Matthew Wilcox
2020-02-24 21:36 ` Christoph Hellwig
2020-02-24 21:36 ` [Cluster-devel] " Christoph Hellwig
2020-02-24 21:36 ` Christoph Hellwig
2020-02-24 21:36 ` [f2fs-dev] " Christoph Hellwig
2020-02-24 21:36 ` [Ocfs2-devel] " Christoph Hellwig
2020-02-19 21:00 ` [PATCH v7 06/24] mm: Rename various 'offset' parameters to 'index' Matthew Wilcox
2020-02-19 21:00 ` [Cluster-devel] " Matthew Wilcox
2020-02-19 21:00 ` Matthew Wilcox
2020-02-19 21:00 ` [f2fs-dev] " Matthew Wilcox
2020-02-19 21:00 ` [Ocfs2-devel] " Matthew Wilcox
2020-02-21 2:21 ` John Hubbard
2020-02-21 2:21 ` [Cluster-devel] " John Hubbard
2020-02-21 2:21 ` John Hubbard
2020-02-21 2:21 ` [f2fs-dev] " John Hubbard
2020-02-21 2:21 ` [Ocfs2-devel] " John Hubbard
2020-02-21 3:27 ` John Hubbard
2020-02-21 3:27 ` [Cluster-devel] " John Hubbard
2020-02-21 3:27 ` John Hubbard
2020-02-21 3:27 ` [f2fs-dev] " John Hubbard
2020-02-21 3:27 ` [Ocfs2-devel] " John Hubbard
2020-02-19 21:00 ` [PATCH v7 07/24] mm: rename readahead loop variable to 'i' Matthew Wilcox
2020-02-19 21:00 ` [Cluster-devel] " Matthew Wilcox
2020-02-19 21:00 ` Matthew Wilcox
2020-02-19 21:00 ` [f2fs-dev] " Matthew Wilcox
2020-02-19 21:00 ` [Ocfs2-devel] " Matthew Wilcox
2020-02-19 21:00 ` [PATCH v7 08/24] mm: Remove 'page_offset' from readahead loop Matthew Wilcox
2020-02-19 21:00 ` [Cluster-devel] " Matthew Wilcox
2020-02-19 21:00 ` Matthew Wilcox
2020-02-19 21:00 ` [f2fs-dev] " Matthew Wilcox
2020-02-19 21:00 ` [Ocfs2-devel] " Matthew Wilcox
2020-02-21 2:48 ` John Hubbard
2020-02-21 2:48 ` [Cluster-devel] " John Hubbard
2020-02-21 2:48 ` John Hubbard
2020-02-21 2:48 ` [f2fs-dev] " John Hubbard
2020-02-21 2:48 ` [Ocfs2-devel] " John Hubbard
2020-02-24 21:37 ` Christoph Hellwig
2020-02-24 21:37 ` [Cluster-devel] " Christoph Hellwig
2020-02-24 21:37 ` Christoph Hellwig
2020-02-24 21:37 ` [f2fs-dev] " Christoph Hellwig
2020-02-24 21:37 ` [Ocfs2-devel] " Christoph Hellwig
2020-02-19 21:00 ` [PATCH v7 09/24] mm: Put readahead pages in cache earlier Matthew Wilcox
2020-02-19 21:00 ` [Cluster-devel] " Matthew Wilcox
2020-02-19 21:00 ` Matthew Wilcox
2020-02-19 21:00 ` [f2fs-dev] " Matthew Wilcox
2020-02-19 21:00 ` [Ocfs2-devel] " Matthew Wilcox
2020-02-21 3:19 ` John Hubbard
2020-02-21 3:19 ` [Cluster-devel] " John Hubbard
2020-02-21 3:19 ` John Hubbard
2020-02-21 3:19 ` [f2fs-dev] " John Hubbard
2020-02-21 3:19 ` [Ocfs2-devel] " John Hubbard
2020-02-21 3:43 ` Matthew Wilcox
2020-02-21 3:43 ` [Cluster-devel] " Matthew Wilcox
2020-02-21 3:43 ` Matthew Wilcox
2020-02-21 3:43 ` [f2fs-dev] " Matthew Wilcox
2020-02-21 3:43 ` [Ocfs2-devel] " Matthew Wilcox
2020-02-21 4:19 ` John Hubbard
2020-02-21 4:19 ` [Cluster-devel] " John Hubbard
2020-02-21 4:19 ` John Hubbard
2020-02-21 4:19 ` [f2fs-dev] " John Hubbard
2020-02-21 4:19 ` [Ocfs2-devel] " John Hubbard
2020-02-24 21:40 ` Christoph Hellwig
2020-02-24 21:40 ` [Cluster-devel] " Christoph Hellwig
2020-02-24 21:40 ` Christoph Hellwig
2020-02-24 21:40 ` [f2fs-dev] " Christoph Hellwig
2020-02-24 21:40 ` [Ocfs2-devel] " Christoph Hellwig
2020-02-19 21:00 ` [PATCH v7 10/24] mm: Add readahead address space operation Matthew Wilcox
2020-02-19 21:00 ` [Cluster-devel] " Matthew Wilcox
2020-02-19 21:00 ` Matthew Wilcox
2020-02-19 21:00 ` [f2fs-dev] " Matthew Wilcox
2020-02-19 21:00 ` [Ocfs2-devel] " Matthew Wilcox
2020-02-20 15:00 ` Zi Yan
2020-02-20 15:00 ` [Cluster-devel] " Zi Yan
2020-02-20 15:00 ` Zi Yan
2020-02-20 15:00 ` [Ocfs2-devel] " Zi Yan
2020-02-20 15:10 ` Matthew Wilcox
2020-02-20 15:10 ` [Cluster-devel] " Matthew Wilcox
2020-02-20 15:10 ` Matthew Wilcox
2020-02-20 15:10 ` [f2fs-dev] " Matthew Wilcox
2020-02-20 15:10 ` [Ocfs2-devel] " Matthew Wilcox
2020-02-21 4:30 ` John Hubbard
2020-02-21 4:30 ` [Cluster-devel] " John Hubbard
2020-02-21 4:30 ` John Hubbard
2020-02-21 4:30 ` [f2fs-dev] " John Hubbard
2020-02-21 4:30 ` [Ocfs2-devel] " John Hubbard
2020-02-24 21:41 ` Christoph Hellwig
2020-02-24 21:41 ` [Cluster-devel] " Christoph Hellwig
2020-02-24 21:41 ` Christoph Hellwig
2020-02-24 21:41 ` [f2fs-dev] " Christoph Hellwig
2020-02-24 21:41 ` [Ocfs2-devel] " Christoph Hellwig
2020-02-19 21:00 ` [PATCH v7 11/24] mm: Move end_index check out of readahead loop Matthew Wilcox
2020-02-19 21:00 ` [Cluster-devel] " Matthew Wilcox
2020-02-19 21:00 ` Matthew Wilcox
2020-02-19 21:00 ` [f2fs-dev] " Matthew Wilcox
2020-02-19 21:00 ` [Ocfs2-devel] " Matthew Wilcox
2020-02-21 3:50 ` John Hubbard
2020-02-21 3:50 ` [Cluster-devel] " John Hubbard
2020-02-21 3:50 ` John Hubbard
2020-02-21 3:50 ` [f2fs-dev] " John Hubbard
2020-02-21 3:50 ` [Ocfs2-devel] " John Hubbard
2020-02-21 15:35 ` Matthew Wilcox
2020-02-21 15:35 ` [Cluster-devel] " Matthew Wilcox
2020-02-21 15:35 ` Matthew Wilcox
2020-02-21 15:35 ` [f2fs-dev] " Matthew Wilcox
2020-02-21 15:35 ` [Ocfs2-devel] " Matthew Wilcox
2020-02-21 19:41 ` John Hubbard
2020-02-21 19:41 ` [Cluster-devel] " John Hubbard
2020-02-21 19:41 ` John Hubbard
2020-02-21 19:41 ` [f2fs-dev] " John Hubbard
2020-02-21 19:41 ` [Ocfs2-devel] " John Hubbard
2020-02-19 21:00 ` [PATCH v7 12/24] mm: Add page_cache_readahead_unbounded Matthew Wilcox
2020-02-19 21:00 ` [Cluster-devel] " Matthew Wilcox
2020-02-19 21:00 ` Matthew Wilcox
2020-02-19 21:00 ` [f2fs-dev] " Matthew Wilcox
2020-02-19 21:00 ` [Ocfs2-devel] " Matthew Wilcox
2020-02-24 21:53 ` [Cluster-devel] " Christoph Hellwig
2020-02-24 21:53 ` Christoph Hellwig
2020-02-24 21:53 ` Christoph Hellwig
2020-02-24 21:53 ` [f2fs-dev] " Christoph Hellwig
2020-02-24 21:53 ` [Ocfs2-devel] " Christoph Hellwig
2020-02-19 21:00 ` [PATCH v7 13/24] fs: Convert mpage_readpages to mpage_readahead Matthew Wilcox
2020-02-19 21:00 ` [Cluster-devel] " Matthew Wilcox
2020-02-19 21:00 ` Matthew Wilcox
2020-02-19 21:00 ` [f2fs-dev] " Matthew Wilcox
2020-02-19 21:00 ` [Ocfs2-devel] " Matthew Wilcox
2020-02-24 21:54 ` [Cluster-devel] " Christoph Hellwig
2020-02-24 21:54 ` Christoph Hellwig
2020-02-24 21:54 ` Christoph Hellwig
2020-02-24 21:54 ` [f2fs-dev] " Christoph Hellwig
2020-02-24 21:54 ` [Ocfs2-devel] " Christoph Hellwig
2020-02-19 21:00 ` [PATCH v7 14/24] btrfs: Convert from readpages to readahead Matthew Wilcox
2020-02-19 21:00 ` [Cluster-devel] " Matthew Wilcox
2020-02-19 21:00 ` Matthew Wilcox
2020-02-19 21:00 ` [f2fs-dev] " Matthew Wilcox
2020-02-19 21:00 ` [Ocfs2-devel] " Matthew Wilcox
2020-02-20 9:42 ` Johannes Thumshirn
2020-02-20 9:42 ` [Cluster-devel] " Johannes Thumshirn
2020-02-20 9:42 ` Johannes Thumshirn
2020-02-20 9:42 ` [f2fs-dev] " Johannes Thumshirn
2020-02-20 9:42 ` Johannes Thumshirn
2020-02-20 9:42 ` [Ocfs2-devel] " Johannes Thumshirn
2020-02-20 13:48 ` Matthew Wilcox
2020-02-20 13:48 ` [Cluster-devel] " Matthew Wilcox
2020-02-20 13:48 ` Matthew Wilcox
2020-02-20 13:48 ` [f2fs-dev] " Matthew Wilcox
2020-02-20 13:48 ` Matthew Wilcox
2020-02-20 13:48 ` [Ocfs2-devel] " Matthew Wilcox
2020-02-20 15:46 ` Christoph Hellwig
2020-02-20 15:46 ` [Cluster-devel] " Christoph Hellwig
2020-02-20 15:46 ` Christoph Hellwig
2020-02-20 15:46 ` [f2fs-dev] " Christoph Hellwig
2020-02-20 15:46 ` Christoph Hellwig
2020-02-20 15:46 ` [Ocfs2-devel] " Christoph Hellwig
2020-02-20 15:54 ` Matthew Wilcox
2020-02-20 15:54 ` [Cluster-devel] " Matthew Wilcox
2020-02-20 15:54 ` Matthew Wilcox
2020-02-20 15:54 ` [f2fs-dev] " Matthew Wilcox
2020-02-20 15:54 ` Matthew Wilcox
2020-02-20 15:54 ` [Ocfs2-devel] " Matthew Wilcox
2020-02-20 15:57 ` Christoph Hellwig
2020-02-20 15:57 ` [Cluster-devel] " Christoph Hellwig
2020-02-20 15:57 ` Christoph Hellwig
2020-02-20 15:57 ` [f2fs-dev] " Christoph Hellwig
2020-02-20 15:57 ` Christoph Hellwig
2020-02-20 15:57 ` [Ocfs2-devel] " Christoph Hellwig
2020-02-24 21:43 ` Christoph Hellwig
2020-02-24 21:43 ` [Cluster-devel] " Christoph Hellwig
2020-02-24 21:43 ` Christoph Hellwig
2020-02-24 21:43 ` [f2fs-dev] " Christoph Hellwig
2020-02-24 21:43 ` Christoph Hellwig
2020-02-24 21:43 ` [Ocfs2-devel] " Christoph Hellwig
2020-02-24 21:54 ` Matthew Wilcox
2020-02-24 21:54 ` [Cluster-devel] " Matthew Wilcox
2020-02-24 21:54 ` Matthew Wilcox
2020-02-24 21:54 ` [f2fs-dev] " Matthew Wilcox
2020-02-24 21:54 ` Matthew Wilcox
2020-02-24 21:54 ` [Ocfs2-devel] " Matthew Wilcox
2020-02-24 21:57 ` Christoph Hellwig
2020-02-24 21:57 ` [Cluster-devel] " Christoph Hellwig
2020-02-24 21:57 ` Christoph Hellwig
2020-02-24 21:57 ` [f2fs-dev] " Christoph Hellwig
2020-02-24 21:57 ` Christoph Hellwig
2020-02-24 21:57 ` [Ocfs2-devel] " Christoph Hellwig
2020-02-19 21:00 ` [PATCH v7 15/24] erofs: Convert uncompressed files " Matthew Wilcox
2020-02-19 21:00 ` [Cluster-devel] " Matthew Wilcox
2020-02-19 21:00 ` Matthew Wilcox
2020-02-19 21:00 ` [f2fs-dev] " Matthew Wilcox
2020-02-19 21:00 ` [Ocfs2-devel] " Matthew Wilcox
2020-02-19 21:00 ` [PATCH v7 16/24] erofs: Convert compressed " Matthew Wilcox
2020-02-19 21:00 ` [Cluster-devel] " Matthew Wilcox
2020-02-19 21:00 ` Matthew Wilcox
2020-02-19 21:00 ` [f2fs-dev] " Matthew Wilcox
2020-02-19 21:00 ` [Ocfs2-devel] " Matthew Wilcox
2020-02-19 21:00 ` [PATCH v7 17/24] ext4: Convert " Matthew Wilcox
2020-02-19 21:00 ` [Cluster-devel] " Matthew Wilcox
2020-02-19 21:00 ` Matthew Wilcox
2020-02-19 21:00 ` [f2fs-dev] " Matthew Wilcox
2020-02-19 21:00 ` [Ocfs2-devel] " Matthew Wilcox
2020-02-19 21:00 ` [PATCH v7 18/24] ext4: Pass the inode to ext4_mpage_readpages Matthew Wilcox
2020-02-19 21:00 ` [Cluster-devel] " Matthew Wilcox
2020-02-19 21:00 ` Matthew Wilcox
2020-02-19 21:00 ` [f2fs-dev] " Matthew Wilcox
2020-02-19 21:00 ` [Ocfs2-devel] " Matthew Wilcox
2020-02-19 21:00 ` [PATCH v7 19/24] f2fs: Convert from readpages to readahead Matthew Wilcox
2020-02-19 21:00 ` [Cluster-devel] " Matthew Wilcox
2020-02-19 21:00 ` Matthew Wilcox
2020-02-19 21:00 ` [f2fs-dev] " Matthew Wilcox
2020-02-19 21:00 ` [Ocfs2-devel] " Matthew Wilcox
2020-02-19 21:00 ` [PATCH v7 20/24] fuse: " Matthew Wilcox
2020-02-19 21:00 ` [Cluster-devel] " Matthew Wilcox
2020-02-19 21:00 ` Matthew Wilcox
2020-02-19 21:00 ` [f2fs-dev] " Matthew Wilcox
2020-02-19 21:00 ` [Ocfs2-devel] " Matthew Wilcox
2020-02-19 21:01 ` [PATCH v7 21/24] iomap: Restructure iomap_readpages_actor Matthew Wilcox
2020-02-19 21:01 ` [Cluster-devel] " Matthew Wilcox
2020-02-19 21:01 ` Matthew Wilcox
2020-02-19 21:01 ` [f2fs-dev] " Matthew Wilcox
2020-02-19 21:01 ` [Ocfs2-devel] " Matthew Wilcox
2020-02-20 15:47 ` Christoph Hellwig
2020-02-20 15:47 ` [Cluster-devel] " Christoph Hellwig
2020-02-20 15:47 ` Christoph Hellwig
2020-02-20 15:47 ` [f2fs-dev] " Christoph Hellwig
2020-02-20 15:47 ` [Ocfs2-devel] " Christoph Hellwig
2020-02-20 16:24 ` Matthew Wilcox
2020-02-20 16:24 ` [Cluster-devel] " Matthew Wilcox
2020-02-20 16:24 ` Matthew Wilcox
2020-02-20 16:24 ` [f2fs-dev] " Matthew Wilcox
2020-02-20 16:24 ` [Ocfs2-devel] " Matthew Wilcox
2020-02-24 22:17 ` Christoph Hellwig
2020-02-24 22:17 ` [Cluster-devel] " Christoph Hellwig
2020-02-24 22:17 ` Christoph Hellwig
2020-02-24 22:17 ` [f2fs-dev] " Christoph Hellwig
2020-02-24 22:17 ` [Ocfs2-devel] " Christoph Hellwig
2020-02-25 1:49 ` Matthew Wilcox
2020-02-25 1:49 ` [Cluster-devel] " Matthew Wilcox
2020-02-25 1:49 ` Matthew Wilcox
2020-02-25 1:49 ` [f2fs-dev] " Matthew Wilcox
2020-02-25 1:49 ` [Ocfs2-devel] " Matthew Wilcox
2020-02-22 0:44 ` Darrick J. Wong
2020-02-22 0:44 ` [Cluster-devel] " Darrick J. Wong
2020-02-22 0:44 ` Darrick J. Wong
2020-02-22 0:44 ` [f2fs-dev] " Darrick J. Wong
2020-02-22 0:44 ` [Ocfs2-devel] " Darrick J. Wong
2020-02-22 1:54 ` Matthew Wilcox
2020-02-22 1:54 ` [Cluster-devel] " Matthew Wilcox
2020-02-22 1:54 ` Matthew Wilcox
2020-02-22 1:54 ` [f2fs-dev] " Matthew Wilcox
2020-02-22 1:54 ` [Ocfs2-devel] " Matthew Wilcox
2020-02-23 17:55 ` Darrick J. Wong
2020-02-23 17:55 ` [Cluster-devel] " Darrick J. Wong
2020-02-23 17:55 ` Darrick J. Wong
2020-02-23 17:55 ` [f2fs-dev] " Darrick J. Wong
2020-02-23 17:55 ` [Ocfs2-devel] " Darrick J. Wong
2020-02-19 21:01 ` [PATCH v7 22/24] iomap: Convert from readpages to readahead Matthew Wilcox
2020-02-19 21:01 ` [Cluster-devel] " Matthew Wilcox
2020-02-19 21:01 ` Matthew Wilcox
2020-02-19 21:01 ` [f2fs-dev] " Matthew Wilcox
2020-02-19 21:01 ` [Ocfs2-devel] " Matthew Wilcox
2020-02-20 15:49 ` Christoph Hellwig
2020-02-20 15:49 ` [Cluster-devel] " Christoph Hellwig
2020-02-20 15:49 ` Christoph Hellwig
2020-02-20 15:49 ` [f2fs-dev] " Christoph Hellwig
2020-02-20 15:49 ` [Ocfs2-devel] " Christoph Hellwig
2020-02-20 16:57 ` Matthew Wilcox
2020-02-20 16:57 ` [Cluster-devel] " Matthew Wilcox
2020-02-20 16:57 ` Matthew Wilcox
2020-02-20 16:57 ` [f2fs-dev] " Matthew Wilcox
2020-02-20 16:57 ` [Ocfs2-devel] " Matthew Wilcox
2020-02-22 1:00 ` Darrick J. Wong
2020-02-22 1:00 ` [Cluster-devel] " Darrick J. Wong
2020-02-22 1:00 ` Darrick J. Wong
2020-02-22 1:00 ` [f2fs-dev] " Darrick J. Wong
2020-02-22 1:00 ` [Ocfs2-devel] " Darrick J. Wong
2020-02-24 4:33 ` Matthew Wilcox
2020-02-24 4:33 ` [Cluster-devel] " Matthew Wilcox
2020-02-24 4:33 ` Matthew Wilcox
2020-02-24 4:33 ` [f2fs-dev] " Matthew Wilcox
2020-02-24 4:33 ` [Ocfs2-devel] " Matthew Wilcox
2020-02-24 16:52 ` Darrick J. Wong [this message]
2020-02-24 16:52 ` [Cluster-devel] " Darrick J. Wong
2020-02-24 16:52 ` Darrick J. Wong
2020-02-24 16:52 ` [f2fs-dev] " Darrick J. Wong
2020-02-24 16:52 ` [Ocfs2-devel] " Darrick J. Wong
2020-02-22 1:03 ` Darrick J. Wong
2020-02-22 1:03 ` [Cluster-devel] " Darrick J. Wong
2020-02-22 1:03 ` Darrick J. Wong
2020-02-22 1:03 ` [f2fs-dev] " Darrick J. Wong
2020-02-22 1:03 ` [Ocfs2-devel] " Darrick J. Wong
2020-02-22 1:09 ` Matthew Wilcox
2020-02-22 1:09 ` [Cluster-devel] " Matthew Wilcox
2020-02-22 1:09 ` Matthew Wilcox
2020-02-22 1:09 ` [f2fs-dev] " Matthew Wilcox
2020-02-22 1:09 ` [Ocfs2-devel] " Matthew Wilcox
2020-02-19 21:01 ` [PATCH v7 23/24] mm: Document why we don't set PageReadahead Matthew Wilcox
2020-02-19 21:01 ` [Cluster-devel] " Matthew Wilcox
2020-02-19 21:01 ` Matthew Wilcox
2020-02-19 21:01 ` [f2fs-dev] " Matthew Wilcox
2020-02-19 21:01 ` [Ocfs2-devel] " Matthew Wilcox
2020-02-19 21:01 ` [PATCH v7 24/24] mm: Use memalloc_nofs_save in readahead path Matthew Wilcox
2020-02-19 21:01 ` [Cluster-devel] " Matthew Wilcox
2020-02-19 21:01 ` Matthew Wilcox
2020-02-19 21:01 ` [f2fs-dev] " Matthew Wilcox
2020-02-19 21:01 ` [Ocfs2-devel] " Matthew Wilcox
2020-02-20 17:54 ` [PATCH v7 00/23] Change readahead API David Sterba
2020-02-20 17:54 ` [Cluster-devel] " David Sterba
2020-02-20 17:54 ` David Sterba
2020-02-20 17:54 ` [f2fs-dev] " David Sterba
2020-02-20 17:54 ` [Ocfs2-devel] " David Sterba
2020-02-20 22:39 ` Matthew Wilcox
2020-02-20 22:39 ` [Cluster-devel] " Matthew Wilcox
2020-02-20 22:39 ` [f2fs-dev] " Matthew Wilcox
2020-02-20 22:39 ` [Ocfs2-devel] " Matthew Wilcox
2020-02-21 11:59 ` David Sterba
2020-02-21 11:59 ` [Cluster-devel] " David Sterba
2020-02-21 11:59 ` David Sterba
2020-02-21 11:59 ` [f2fs-dev] " David Sterba
2020-02-21 11:59 ` [Ocfs2-devel] " David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200224165244.GA6731@magnolia \
--to=darrick.wong@oracle.com \
--cc=cluster-devel@redhat.com \
--cc=hch@infradead.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-erofs@lists.ozlabs.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-xfs@vger.kernel.org \
--cc=ocfs2-devel@oss.oracle.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.