From: Russell King - ARM Linux admin <linux@armlinux.org.uk>
To: Fabio Estevam <festevam@gmail.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Rob Herring <robh+dt@kernel.org>,
NXP Linux Team <linux-imx@nxp.com>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Shawn Guo <shawnguo@kernel.org>,
"moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] ARM: dts: imx6qdl-sr-som-ti: indicate powering off wifi is safe
Date: Thu, 27 Feb 2020 13:45:39 +0000 [thread overview]
Message-ID: <20200227134538.GK25745@shell.armlinux.org.uk> (raw)
In-Reply-To: <CAOMZO5A6os4myE41ZLBvW639bjRudg8Tax4yBa5JOyY5+oJW+g@mail.gmail.com>
On Thu, Feb 27, 2020 at 09:57:40AM -0300, Fabio Estevam wrote:
> Hi Russell,
>
> On Thu, Feb 27, 2020 at 9:19 AM Russell King <rmk+kernel@armlinux.org.uk> wrote:
> >
> > We need to indicate that powering off the TI WiFi is safe, to avoid:
> >
> > wl18xx_driver wl18xx.2.auto: Unbalanced pm_runtime_enable!
> > wl1271_sdio mmc0:0001:2: wl12xx_sdio_power_on: failed to get_sync(-13)
> >
> > which prevents the WiFi being functional.
> >
> > Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>
>
> Shouldn't this have a Fixes tag so that it can be backported to stable kernels?
If I knew where the breakage happened and what commit was responsible
for it, then yes - but it used to work with earlier kernels (I don't
know which) and at some point it broke.
The suggestion for how to fix it came from Jon Nettleton.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up
According to speedtest.net: 11.9Mbps down 500kbps up
WARNING: multiple messages have this Message-ID (diff)
From: Russell King - ARM Linux admin <linux@armlinux.org.uk>
To: Fabio Estevam <festevam@gmail.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Rob Herring <robh+dt@kernel.org>,
NXP Linux Team <linux-imx@nxp.com>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Shawn Guo <shawnguo@kernel.org>,
"moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] ARM: dts: imx6qdl-sr-som-ti: indicate powering off wifi is safe
Date: Thu, 27 Feb 2020 13:45:39 +0000 [thread overview]
Message-ID: <20200227134538.GK25745@shell.armlinux.org.uk> (raw)
In-Reply-To: <CAOMZO5A6os4myE41ZLBvW639bjRudg8Tax4yBa5JOyY5+oJW+g@mail.gmail.com>
On Thu, Feb 27, 2020 at 09:57:40AM -0300, Fabio Estevam wrote:
> Hi Russell,
>
> On Thu, Feb 27, 2020 at 9:19 AM Russell King <rmk+kernel@armlinux.org.uk> wrote:
> >
> > We need to indicate that powering off the TI WiFi is safe, to avoid:
> >
> > wl18xx_driver wl18xx.2.auto: Unbalanced pm_runtime_enable!
> > wl1271_sdio mmc0:0001:2: wl12xx_sdio_power_on: failed to get_sync(-13)
> >
> > which prevents the WiFi being functional.
> >
> > Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>
>
> Shouldn't this have a Fixes tag so that it can be backported to stable kernels?
If I knew where the breakage happened and what commit was responsible
for it, then yes - but it used to work with earlier kernels (I don't
know which) and at some point it broke.
The suggestion for how to fix it came from Jon Nettleton.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up
According to speedtest.net: 11.9Mbps down 500kbps up
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-02-27 13:45 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-27 12:18 [PATCH] ARM: dts: imx6qdl-sr-som-ti: indicate powering off wifi is safe Russell King
2020-02-27 12:18 ` Russell King
2020-02-27 12:57 ` Fabio Estevam
2020-02-27 12:57 ` Fabio Estevam
2020-02-27 13:45 ` Russell King - ARM Linux admin [this message]
2020-02-27 13:45 ` Russell King - ARM Linux admin
2020-02-27 15:17 ` Russell King - ARM Linux admin
2020-02-27 15:17 ` Russell King - ARM Linux admin
2020-02-27 15:28 ` Fabio Estevam
2020-02-27 15:28 ` Fabio Estevam
2020-03-11 7:46 ` Shawn Guo
2020-03-11 7:46 ` Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200227134538.GK25745@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.