From: "J. Bruce Fields" <bfields@fieldses.org>
To: madhuparnabhowmik10@gmail.com
Cc: chuck.lever@oracle.com, linux-nfs@vger.kernel.org,
linux-kernel@vger.kernel.org, joel@joelfernandes.org,
frextrite@gmail.com,
linux-kernel-mentees@lists.linuxfoundation.org,
paulmck@kernel.org
Subject: Re: [PATCH] fs: nfsd: fileache.c: Use built-in RCU list checking
Date: Tue, 3 Mar 2020 11:54:50 -0500 [thread overview]
Message-ID: <20200303165450.GD19140@fieldses.org> (raw)
In-Reply-To: <20200213150359.5819-1-madhuparnabhowmik10@gmail.com>
Applying for 5.7, thanks.--b.
On Thu, Feb 13, 2020 at 08:33:59PM +0530, madhuparnabhowmik10@gmail.com wrote:
> From: Madhuparna Bhowmik <madhuparnabhowmik10@gmail.com>
>
> list_for_each_entry_rcu() has built-in RCU and lock checking.
>
> Pass cond argument to list_for_each_entry_rcu() to silence
> false lockdep warning when CONFIG_PROVE_RCU_LIST is enabled
> by default.
>
> Signed-off-by: Madhuparna Bhowmik <madhuparnabhowmik10@gmail.com>
> ---
> fs/nfsd/filecache.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/nfsd/filecache.c b/fs/nfsd/filecache.c
> index 32a9bf22ac08..547d2d8bde62 100644
> --- a/fs/nfsd/filecache.c
> +++ b/fs/nfsd/filecache.c
> @@ -736,7 +736,7 @@ nfsd_file_find_locked(struct inode *inode, unsigned int may_flags,
> unsigned char need = may_flags & NFSD_FILE_MAY_MASK;
>
> hlist_for_each_entry_rcu(nf, &nfsd_file_hashtbl[hashval].nfb_head,
> - nf_node) {
> + nf_node, lockdep_is_held(&nfsd_file_hashtbl[hashval].nfb_lock)) {
> if ((need & nf->nf_may) != need)
> continue;
> if (nf->nf_inode != inode)
> --
> 2.17.1
WARNING: multiple messages have this Message-ID (diff)
From: "J. Bruce Fields" <bfields@fieldses.org>
To: madhuparnabhowmik10@gmail.com
Cc: linux-nfs@vger.kernel.org, paulmck@kernel.org,
linux-kernel@vger.kernel.org, chuck.lever@oracle.com,
joel@joelfernandes.org,
linux-kernel-mentees@lists.linuxfoundation.org
Subject: Re: [Linux-kernel-mentees] [PATCH] fs: nfsd: fileache.c: Use built-in RCU list checking
Date: Tue, 3 Mar 2020 11:54:50 -0500 [thread overview]
Message-ID: <20200303165450.GD19140@fieldses.org> (raw)
In-Reply-To: <20200213150359.5819-1-madhuparnabhowmik10@gmail.com>
Applying for 5.7, thanks.--b.
On Thu, Feb 13, 2020 at 08:33:59PM +0530, madhuparnabhowmik10@gmail.com wrote:
> From: Madhuparna Bhowmik <madhuparnabhowmik10@gmail.com>
>
> list_for_each_entry_rcu() has built-in RCU and lock checking.
>
> Pass cond argument to list_for_each_entry_rcu() to silence
> false lockdep warning when CONFIG_PROVE_RCU_LIST is enabled
> by default.
>
> Signed-off-by: Madhuparna Bhowmik <madhuparnabhowmik10@gmail.com>
> ---
> fs/nfsd/filecache.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/nfsd/filecache.c b/fs/nfsd/filecache.c
> index 32a9bf22ac08..547d2d8bde62 100644
> --- a/fs/nfsd/filecache.c
> +++ b/fs/nfsd/filecache.c
> @@ -736,7 +736,7 @@ nfsd_file_find_locked(struct inode *inode, unsigned int may_flags,
> unsigned char need = may_flags & NFSD_FILE_MAY_MASK;
>
> hlist_for_each_entry_rcu(nf, &nfsd_file_hashtbl[hashval].nfb_head,
> - nf_node) {
> + nf_node, lockdep_is_held(&nfsd_file_hashtbl[hashval].nfb_lock)) {
> if ((need & nf->nf_may) != need)
> continue;
> if (nf->nf_inode != inode)
> --
> 2.17.1
_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees
next prev parent reply other threads:[~2020-03-03 16:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-13 15:03 [PATCH] fs: nfsd: fileache.c: Use built-in RCU list checking madhuparnabhowmik10
2020-02-13 15:03 ` [Linux-kernel-mentees] " madhuparnabhowmik10
2020-03-03 16:54 ` J. Bruce Fields [this message]
2020-03-03 16:54 ` J. Bruce Fields
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200303165450.GD19140@fieldses.org \
--to=bfields@fieldses.org \
--cc=chuck.lever@oracle.com \
--cc=frextrite@gmail.com \
--cc=joel@joelfernandes.org \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=madhuparnabhowmik10@gmail.com \
--cc=paulmck@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.