From: Rob Herring <robh@kernel.org> To: Ulf Hansson <ulf.hansson@linaro.org> Cc: Sudeep Holla <sudeep.holla@arm.com>, Lorenzo Pieralisi <Lorenzo.Pieralisi@arm.com>, devicetree@vger.kernel.org, "Rafael J . Wysocki" <rjw@rjwysocki.net>, Daniel Lezcano <daniel.lezcano@linaro.org>, Lina Iyer <ilina@codeaurora.org>, Stephen Boyd <sboyd@kernel.org>, Bjorn Andersson <bjorn.andersson@linaro.org>, Benjamin Gaignard <benjamin.gaignard@st.com>, linux-arm-kernel@lists.infradead.org, linux-pm@vger.kernel.org Subject: Re: [PATCH 5/7] dt-bindings: arm: Fixup the DT bindings for hierarchical PSCI states Date: Tue, 3 Mar 2020 11:06:41 -0600 [thread overview] Message-ID: <20200303170641.GC26191@bogus> (raw) In-Reply-To: <20200303150749.30566-6-ulf.hansson@linaro.org> On Tue, Mar 03, 2020 at 04:07:47PM +0100, Ulf Hansson wrote: > The hierarchical topology with power-domain should be described through > child nodes, rather than as currently described in the PSCI root node. Fix > this by adding a patternProperties with a corresponding reference to the > power-domain DT binding. > > Additionally, update the example to conform to the new pattern, but also to > the adjusted domain-idle-state DT binding. > > Fixes: a3f048b5424e ("dt: psci: Update DT bindings to support hierarchical PSCI states") > Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org> > --- > .../devicetree/bindings/arm/psci.yaml | 33 +++++++++---------- > 1 file changed, 15 insertions(+), 18 deletions(-) > > diff --git a/Documentation/devicetree/bindings/arm/psci.yaml b/Documentation/devicetree/bindings/arm/psci.yaml > index 0bc3c43a525a..cae668b61265 100644 > --- a/Documentation/devicetree/bindings/arm/psci.yaml > +++ b/Documentation/devicetree/bindings/arm/psci.yaml > @@ -102,11 +102,15 @@ properties: > [1] Kernel documentation - ARM idle states bindings > Documentation/devicetree/bindings/arm/idle-states.yaml > > - "#power-domain-cells": > - description: > - The number of cells in a PM domain specifier as per binding in [3]. > - Must be 0 as to represent a single PM domain. > +required: > + - compatible > + - method No need to move this. > > +patternProperties: > + "^(power-controller|power-domain)([@-].*)?$": > + $ref: "../power/power-domain.yaml#" This has to be under an 'allOf' or the rest of the properties are ignored. > + type: object > + description: | > ARM systems can have multiple cores, sometimes in an hierarchical > arrangement. This often, but not always, maps directly to the processor > power topology of the system. Individual nodes in a topology have their > @@ -122,19 +126,9 @@ properties: > helps to implement support for OSI mode and OS implementations may choose > to mandate it. > > - [3] Documentation/devicetree/bindings/power/power_domain.txt > + [3] Documentation/devicetree/bindings/power/power-domain.yaml > [4] Documentation/devicetree/bindings/power/domain-idle-state.yaml > > - power-domains: > - $ref: '/schemas/types.yaml#/definitions/phandle-array' > - description: > - List of phandles and PM domain specifiers, as defined by bindings of the > - PM domain provider. > - > -required: > - - compatible > - - method > - > allOf: > - if: > properties: > @@ -224,6 +218,9 @@ examples: > exit-latency-us = <10>; > min-residency-us = <100>; > }; > + }; > + > + domain-idle-states { > > CLUSTER_RET: cluster-retention { > compatible = "domain-idle-state"; > @@ -247,19 +244,19 @@ examples: > compatible = "arm,psci-1.0"; > method = "smc"; > > - CPU_PD0: cpu-pd0 { > + CPU_PD0: power-domain-cpu0 { > #power-domain-cells = <0>; > domain-idle-states = <&CPU_PWRDN>; > power-domains = <&CLUSTER_PD>; > }; > > - CPU_PD1: cpu-pd1 { > + CPU_PD1: power-domain-cpu1 { > #power-domain-cells = <0>; > domain-idle-states = <&CPU_PWRDN>; > power-domains = <&CLUSTER_PD>; > }; > > - CLUSTER_PD: cluster-pd { > + CLUSTER_PD: power-domain-cluster { > #power-domain-cells = <0>; > domain-idle-states = <&CLUSTER_RET>, <&CLUSTER_PWRDN>; > }; > -- > 2.20.1 >
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org> To: Ulf Hansson <ulf.hansson@linaro.org> Cc: devicetree@vger.kernel.org, Lorenzo Pieralisi <Lorenzo.Pieralisi@arm.com>, Benjamin Gaignard <benjamin.gaignard@st.com>, linux-pm@vger.kernel.org, Stephen Boyd <sboyd@kernel.org>, Daniel Lezcano <daniel.lezcano@linaro.org>, "Rafael J . Wysocki" <rjw@rjwysocki.net>, Lina Iyer <ilina@codeaurora.org>, Bjorn Andersson <bjorn.andersson@linaro.org>, Sudeep Holla <sudeep.holla@arm.com>, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 5/7] dt-bindings: arm: Fixup the DT bindings for hierarchical PSCI states Date: Tue, 3 Mar 2020 11:06:41 -0600 [thread overview] Message-ID: <20200303170641.GC26191@bogus> (raw) In-Reply-To: <20200303150749.30566-6-ulf.hansson@linaro.org> On Tue, Mar 03, 2020 at 04:07:47PM +0100, Ulf Hansson wrote: > The hierarchical topology with power-domain should be described through > child nodes, rather than as currently described in the PSCI root node. Fix > this by adding a patternProperties with a corresponding reference to the > power-domain DT binding. > > Additionally, update the example to conform to the new pattern, but also to > the adjusted domain-idle-state DT binding. > > Fixes: a3f048b5424e ("dt: psci: Update DT bindings to support hierarchical PSCI states") > Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org> > --- > .../devicetree/bindings/arm/psci.yaml | 33 +++++++++---------- > 1 file changed, 15 insertions(+), 18 deletions(-) > > diff --git a/Documentation/devicetree/bindings/arm/psci.yaml b/Documentation/devicetree/bindings/arm/psci.yaml > index 0bc3c43a525a..cae668b61265 100644 > --- a/Documentation/devicetree/bindings/arm/psci.yaml > +++ b/Documentation/devicetree/bindings/arm/psci.yaml > @@ -102,11 +102,15 @@ properties: > [1] Kernel documentation - ARM idle states bindings > Documentation/devicetree/bindings/arm/idle-states.yaml > > - "#power-domain-cells": > - description: > - The number of cells in a PM domain specifier as per binding in [3]. > - Must be 0 as to represent a single PM domain. > +required: > + - compatible > + - method No need to move this. > > +patternProperties: > + "^(power-controller|power-domain)([@-].*)?$": > + $ref: "../power/power-domain.yaml#" This has to be under an 'allOf' or the rest of the properties are ignored. > + type: object > + description: | > ARM systems can have multiple cores, sometimes in an hierarchical > arrangement. This often, but not always, maps directly to the processor > power topology of the system. Individual nodes in a topology have their > @@ -122,19 +126,9 @@ properties: > helps to implement support for OSI mode and OS implementations may choose > to mandate it. > > - [3] Documentation/devicetree/bindings/power/power_domain.txt > + [3] Documentation/devicetree/bindings/power/power-domain.yaml > [4] Documentation/devicetree/bindings/power/domain-idle-state.yaml > > - power-domains: > - $ref: '/schemas/types.yaml#/definitions/phandle-array' > - description: > - List of phandles and PM domain specifiers, as defined by bindings of the > - PM domain provider. > - > -required: > - - compatible > - - method > - > allOf: > - if: > properties: > @@ -224,6 +218,9 @@ examples: > exit-latency-us = <10>; > min-residency-us = <100>; > }; > + }; > + > + domain-idle-states { > > CLUSTER_RET: cluster-retention { > compatible = "domain-idle-state"; > @@ -247,19 +244,19 @@ examples: > compatible = "arm,psci-1.0"; > method = "smc"; > > - CPU_PD0: cpu-pd0 { > + CPU_PD0: power-domain-cpu0 { > #power-domain-cells = <0>; > domain-idle-states = <&CPU_PWRDN>; > power-domains = <&CLUSTER_PD>; > }; > > - CPU_PD1: cpu-pd1 { > + CPU_PD1: power-domain-cpu1 { > #power-domain-cells = <0>; > domain-idle-states = <&CPU_PWRDN>; > power-domains = <&CLUSTER_PD>; > }; > > - CLUSTER_PD: cluster-pd { > + CLUSTER_PD: power-domain-cluster { > #power-domain-cells = <0>; > domain-idle-states = <&CLUSTER_RET>, <&CLUSTER_PWRDN>; > }; > -- > 2.20.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-03-03 17:06 UTC|newest] Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-03-03 15:07 [PATCH 0/7] dt-bindings: arm: Fix bindings used for hierarchical PSCI states Ulf Hansson 2020-03-03 15:07 ` Ulf Hansson 2020-03-03 15:07 ` [PATCH 1/7] dt-bindings: arm: Correct links to idle states definitions Ulf Hansson 2020-03-03 15:07 ` Ulf Hansson 2020-03-04 14:47 ` Rob Herring 2020-03-04 14:47 ` Rob Herring 2020-03-03 15:07 ` [PATCH 2/7] dt-bindings: arm: Fix cpu compatibles in the hierarchical example for PSCI Ulf Hansson 2020-03-03 15:07 ` Ulf Hansson 2020-03-04 14:47 ` Rob Herring 2020-03-04 14:47 ` Rob Herring 2020-03-03 15:07 ` [PATCH 3/7] dt-bindings: power: Convert domain-idle-states bindings to json-schema Ulf Hansson 2020-03-03 15:07 ` Ulf Hansson 2020-03-03 17:02 ` Rob Herring 2020-03-03 17:02 ` Rob Herring 2020-03-03 20:45 ` Ulf Hansson 2020-03-03 20:45 ` Ulf Hansson 2020-03-03 21:17 ` Rob Herring 2020-03-03 21:17 ` Rob Herring 2020-03-04 14:48 ` Rob Herring 2020-03-04 14:48 ` Rob Herring 2020-03-03 15:07 ` [PATCH 4/7] dt-bindings: power: Extend nodename pattern for power-domain providers Ulf Hansson 2020-03-03 15:07 ` Ulf Hansson 2020-03-03 17:03 ` Rob Herring 2020-03-03 17:03 ` Rob Herring 2020-03-03 20:46 ` Ulf Hansson 2020-03-03 20:46 ` Ulf Hansson 2020-03-03 15:07 ` [PATCH 5/7] dt-bindings: arm: Fixup the DT bindings for hierarchical PSCI states Ulf Hansson 2020-03-03 15:07 ` Ulf Hansson 2020-03-03 17:06 ` Rob Herring [this message] 2020-03-03 17:06 ` Rob Herring 2020-03-03 20:50 ` Ulf Hansson 2020-03-03 20:50 ` Ulf Hansson 2020-03-04 14:53 ` Rob Herring 2020-03-04 14:53 ` Rob Herring 2020-03-06 18:29 ` Rob Herring 2020-03-06 18:29 ` Rob Herring 2020-03-09 7:10 ` Ulf Hansson 2020-03-09 7:10 ` Ulf Hansson 2020-03-03 15:07 ` [PATCH 6/7] arm64: dts: msm8916: Conform to the domain-idle-state DT binding Ulf Hansson 2020-03-03 15:07 ` Ulf Hansson 2020-03-03 15:07 ` [PATCH 7/7] arm64: dts: msm8916: Conform to the nodename pattern for power-domain Ulf Hansson 2020-03-03 15:07 ` Ulf Hansson
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200303170641.GC26191@bogus \ --to=robh@kernel.org \ --cc=Lorenzo.Pieralisi@arm.com \ --cc=benjamin.gaignard@st.com \ --cc=bjorn.andersson@linaro.org \ --cc=daniel.lezcano@linaro.org \ --cc=devicetree@vger.kernel.org \ --cc=ilina@codeaurora.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-pm@vger.kernel.org \ --cc=rjw@rjwysocki.net \ --cc=sboyd@kernel.org \ --cc=sudeep.holla@arm.com \ --cc=ulf.hansson@linaro.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.