From: Nicolas Saenz Julienne <nsaenzjulienne@suse.de> To: adrian.hunter@intel.com, linux-kernel@vger.kernel.org, Ludovic Desroches <ludovic.desroches@microchip.com>, Nicolas Ferre <nicolas.ferre@microchip.com>, Alexandre Belloni <alexandre.belloni@bootlin.com> Cc: phil@raspberrypi.com, linux-mmc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, f.fainelli@gmail.com, stefan.wahren@i2se.com, bcm-kernel-feedback-list@broadcom.com, linux-rpi-kernel@lists.infradead.org, Nicolas Saenz Julienne <nsaenzjulienne@suse.de>, Ulf Hansson <ulf.hansson@linaro.org> Subject: [PATCH v2 04/11] mmc: sdhci: at91: Use sdhci_set_power_and_voltage() Date: Fri, 6 Mar 2020 18:44:06 +0100 [thread overview] Message-ID: <20200306174413.20634-5-nsaenzjulienne@suse.de> (raw) In-Reply-To: <20200306174413.20634-1-nsaenzjulienne@suse.de> The sdhci core provides a helper function with the same functionality as this controller's set_power() callback. Use it instead. Signed-off-by: Nicolas Saenz Julienne <nsaenzjulienne@suse.de> --- drivers/mmc/host/sdhci-of-at91.c | 18 +----------------- 1 file changed, 1 insertion(+), 17 deletions(-) diff --git a/drivers/mmc/host/sdhci-of-at91.c b/drivers/mmc/host/sdhci-of-at91.c index ab2bd314a390..564a606f6729 100644 --- a/drivers/mmc/host/sdhci-of-at91.c +++ b/drivers/mmc/host/sdhci-of-at91.c @@ -101,22 +101,6 @@ static void sdhci_at91_set_clock(struct sdhci_host *host, unsigned int clock) sdhci_writew(host, clk, SDHCI_CLOCK_CONTROL); } -/* - * In this specific implementation of the SDHCI controller, the power register - * needs to have a valid voltage set even when the power supply is managed by - * an external regulator. - */ -static void sdhci_at91_set_power(struct sdhci_host *host, unsigned char mode, - unsigned short vdd) -{ - if (!IS_ERR(host->mmc->supply.vmmc)) { - struct mmc_host *mmc = host->mmc; - - mmc_regulator_set_ocr(mmc, mmc->supply.vmmc, vdd); - } - sdhci_set_power_noreg(host, mode, vdd); -} - static void sdhci_at91_set_uhs_signaling(struct sdhci_host *host, unsigned int timing) { @@ -145,7 +129,7 @@ static const struct sdhci_ops sdhci_at91_sama5d2_ops = { .set_bus_width = sdhci_set_bus_width, .reset = sdhci_at91_reset, .set_uhs_signaling = sdhci_at91_set_uhs_signaling, - .set_power = sdhci_at91_set_power, + .set_power = sdhci_set_power_and_bus_voltage, }; static const struct sdhci_pltfm_data sdhci_sama5d2_pdata = { -- 2.25.1
WARNING: multiple messages have this Message-ID (diff)
From: Nicolas Saenz Julienne <nsaenzjulienne@suse.de> To: adrian.hunter@intel.com, linux-kernel@vger.kernel.org, Ludovic Desroches <ludovic.desroches@microchip.com>, Nicolas Ferre <nicolas.ferre@microchip.com>, Alexandre Belloni <alexandre.belloni@bootlin.com> Cc: stefan.wahren@i2se.com, Ulf Hansson <ulf.hansson@linaro.org>, f.fainelli@gmail.com, linux-mmc@vger.kernel.org, Nicolas Saenz Julienne <nsaenzjulienne@suse.de>, bcm-kernel-feedback-list@broadcom.com, linux-rpi-kernel@lists.infradead.org, phil@raspberrypi.com, linux-arm-kernel@lists.infradead.org Subject: [PATCH v2 04/11] mmc: sdhci: at91: Use sdhci_set_power_and_voltage() Date: Fri, 6 Mar 2020 18:44:06 +0100 [thread overview] Message-ID: <20200306174413.20634-5-nsaenzjulienne@suse.de> (raw) In-Reply-To: <20200306174413.20634-1-nsaenzjulienne@suse.de> The sdhci core provides a helper function with the same functionality as this controller's set_power() callback. Use it instead. Signed-off-by: Nicolas Saenz Julienne <nsaenzjulienne@suse.de> --- drivers/mmc/host/sdhci-of-at91.c | 18 +----------------- 1 file changed, 1 insertion(+), 17 deletions(-) diff --git a/drivers/mmc/host/sdhci-of-at91.c b/drivers/mmc/host/sdhci-of-at91.c index ab2bd314a390..564a606f6729 100644 --- a/drivers/mmc/host/sdhci-of-at91.c +++ b/drivers/mmc/host/sdhci-of-at91.c @@ -101,22 +101,6 @@ static void sdhci_at91_set_clock(struct sdhci_host *host, unsigned int clock) sdhci_writew(host, clk, SDHCI_CLOCK_CONTROL); } -/* - * In this specific implementation of the SDHCI controller, the power register - * needs to have a valid voltage set even when the power supply is managed by - * an external regulator. - */ -static void sdhci_at91_set_power(struct sdhci_host *host, unsigned char mode, - unsigned short vdd) -{ - if (!IS_ERR(host->mmc->supply.vmmc)) { - struct mmc_host *mmc = host->mmc; - - mmc_regulator_set_ocr(mmc, mmc->supply.vmmc, vdd); - } - sdhci_set_power_noreg(host, mode, vdd); -} - static void sdhci_at91_set_uhs_signaling(struct sdhci_host *host, unsigned int timing) { @@ -145,7 +129,7 @@ static const struct sdhci_ops sdhci_at91_sama5d2_ops = { .set_bus_width = sdhci_set_bus_width, .reset = sdhci_at91_reset, .set_uhs_signaling = sdhci_at91_set_uhs_signaling, - .set_power = sdhci_at91_set_power, + .set_power = sdhci_set_power_and_bus_voltage, }; static const struct sdhci_pltfm_data sdhci_sama5d2_pdata = { -- 2.25.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-03-06 17:44 UTC|newest] Thread overview: 60+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-03-06 17:44 [PATCH v2 00/11] Raspbery Pi 4 vmmc regulator support Nicolas Saenz Julienne 2020-03-06 17:44 ` Nicolas Saenz Julienne 2020-03-06 17:44 ` [PATCH v2 01/11] mmc: sdhci: Introduce sdhci_set_power_and_bus_voltage() Nicolas Saenz Julienne 2020-03-06 17:44 ` Nicolas Saenz Julienne 2020-03-09 7:21 ` Adrian Hunter 2020-03-09 7:21 ` Adrian Hunter 2020-03-06 17:44 ` [PATCH v2 02/11] mmc: sdhci: arasan: Use sdhci_set_power_and_voltage() Nicolas Saenz Julienne 2020-03-06 17:44 ` Nicolas Saenz Julienne 2020-03-09 7:22 ` Adrian Hunter 2020-03-09 7:22 ` Adrian Hunter 2020-03-06 17:44 ` [PATCH v2 03/11] mmc: sdhci: milbeaut: " Nicolas Saenz Julienne 2020-03-06 17:44 ` Nicolas Saenz Julienne 2020-03-09 7:25 ` Adrian Hunter 2020-03-09 7:25 ` Adrian Hunter 2020-03-06 17:44 ` Nicolas Saenz Julienne [this message] 2020-03-06 17:44 ` [PATCH v2 04/11] mmc: sdhci: at91: " Nicolas Saenz Julienne 2020-03-09 7:25 ` Adrian Hunter 2020-03-09 7:25 ` Adrian Hunter 2020-03-06 17:44 ` [PATCH v2 05/11] mmc: sdhci: pxav3: " Nicolas Saenz Julienne 2020-03-06 17:44 ` Nicolas Saenz Julienne 2020-03-09 7:20 ` Adrian Hunter 2020-03-09 7:20 ` Adrian Hunter 2020-03-06 17:44 ` [PATCH v2 06/11] mmc: sdhci: xenon: " Nicolas Saenz Julienne 2020-03-06 17:44 ` Nicolas Saenz Julienne 2020-03-09 7:20 ` Adrian Hunter 2020-03-09 7:20 ` Adrian Hunter 2020-03-09 10:53 ` Nicolas Saenz Julienne 2020-03-09 10:53 ` Nicolas Saenz Julienne 2020-03-09 11:55 ` Adrian Hunter 2020-03-09 11:55 ` Adrian Hunter 2020-03-09 11:56 ` Adrian Hunter 2020-03-09 11:56 ` Adrian Hunter 2020-03-06 17:44 ` [PATCH v2 07/11] mmc: sdhci: am654: " Nicolas Saenz Julienne 2020-03-06 17:44 ` Nicolas Saenz Julienne 2020-03-09 7:27 ` Adrian Hunter 2020-03-09 7:27 ` Adrian Hunter 2020-03-06 17:44 ` [PATCH v2 08/11] mmc: sdhci: Unexport sdhci_set_power_noreg() Nicolas Saenz Julienne 2020-03-06 17:44 ` Nicolas Saenz Julienne 2020-03-06 17:44 ` [PATCH v2 09/11] mmc: sdhci: iproc: Add custom set_power() callback for bcm2711 Nicolas Saenz Julienne 2020-03-06 17:44 ` Nicolas Saenz Julienne 2020-03-09 7:29 ` Adrian Hunter 2020-03-09 7:29 ` Adrian Hunter 2020-03-06 17:44 ` [PATCH v2 10/11] ARM: dts: bcm2711: Update expgpio's GPIO labels Nicolas Saenz Julienne 2020-03-06 17:44 ` Nicolas Saenz Julienne 2020-03-27 11:21 ` Nicolas Saenz Julienne 2020-03-27 11:21 ` Nicolas Saenz Julienne 2020-03-06 17:44 ` [PATCH v2 11/11] ARM: dts: bcm2711: Add vmmc regulator in emmc2 Nicolas Saenz Julienne 2020-03-06 17:44 ` Nicolas Saenz Julienne 2020-03-09 20:00 ` Stefan Wahren 2020-03-09 20:00 ` Stefan Wahren 2020-03-09 20:01 ` Nicolas Saenz Julienne 2020-03-09 20:01 ` Nicolas Saenz Julienne 2020-03-27 11:22 ` Nicolas Saenz Julienne 2020-03-27 11:22 ` Nicolas Saenz Julienne 2020-03-12 13:08 ` [PATCH v2 00/11] Raspbery Pi 4 vmmc regulator support Ulf Hansson 2020-03-12 13:08 ` Ulf Hansson 2020-03-12 13:13 ` Nicolas Saenz Julienne 2020-03-12 13:13 ` Nicolas Saenz Julienne 2020-03-12 14:06 ` Ulf Hansson 2020-03-12 14:06 ` Ulf Hansson
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200306174413.20634-5-nsaenzjulienne@suse.de \ --to=nsaenzjulienne@suse.de \ --cc=adrian.hunter@intel.com \ --cc=alexandre.belloni@bootlin.com \ --cc=bcm-kernel-feedback-list@broadcom.com \ --cc=f.fainelli@gmail.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mmc@vger.kernel.org \ --cc=linux-rpi-kernel@lists.infradead.org \ --cc=ludovic.desroches@microchip.com \ --cc=nicolas.ferre@microchip.com \ --cc=phil@raspberrypi.com \ --cc=stefan.wahren@i2se.com \ --cc=ulf.hansson@linaro.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.