From: Takashi Sakamoto <o-takashi@sakamocchi.jp>
To: Jules Irenge <jbi.octave@gmail.com>
Cc: boqun.feng@gmail.com, linux-kernel@vger.kernel.org,
bpf@vger.kernel.org, netdev@vger.kernel.org,
Clemens Ladisch <clemens@ladisch.de>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
Alexios Zavras <alexios.zavras@intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Thomas Gleixner <tglx@linutronix.de>,
Allison Randal <allison@lohutok.net>,
"moderated list:FIREWIRE AUDIO DRIVERS and IEC 61883-1/6
PACKET..." <alsa-devel@alsa-project.org>
Subject: Re: [PATCH 8/8] ALSA: firewire-tascam: Add missing annotation for tscm_hwdep_read_locked()
Date: Wed, 11 Mar 2020 12:18:54 +0900 [thread overview]
Message-ID: <20200311031853.GA8197@workstation> (raw)
In-Reply-To: <20200311010908.42366-9-jbi.octave@gmail.com>
Hi,
On Wed, Mar 11, 2020 at 01:09:08AM +0000, Jules Irenge wrote:
> Sparse reports a warning at tscm_hwdep_read_locked()
>
> warning: context imbalance in tscm_hwdep_read_locked() - unexpected unlock
>
> The root cause is the missing annotation at tscm_hwdep_read_locked()
> Add the missing __releases(&tscm->lock) annotation
>
> Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
> ---
> sound/firewire/tascam/tascam-hwdep.c | 1 +
> 1 file changed, 1 insertion(+)
Thanks for your care of the warning. Although I have found it, I had
no idea to suppress it.
Acked-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
> diff --git a/sound/firewire/tascam/tascam-hwdep.c b/sound/firewire/tascam/tascam-hwdep.c
> index 9801e33e7f2a..6f38335fe10b 100644
> --- a/sound/firewire/tascam/tascam-hwdep.c
> +++ b/sound/firewire/tascam/tascam-hwdep.c
> @@ -17,6 +17,7 @@
>
> static long tscm_hwdep_read_locked(struct snd_tscm *tscm, char __user *buf,
> long count, loff_t *offset)
> + __releases(&tscm->lock)
> {
> struct snd_firewire_event_lock_status event = {
> .type = SNDRV_FIREWIRE_EVENT_LOCK_STATUS,
> --
> 2.24.1
>
WARNING: multiple messages have this Message-ID (diff)
From: Takashi Sakamoto <o-takashi@sakamocchi.jp>
To: Jules Irenge <jbi.octave@gmail.com>
Cc: "moderated list:FIREWIRE AUDIO DRIVERS and IEC 61883-1/6
PACKET..." <alsa-devel@alsa-project.org>,
netdev@vger.kernel.org, boqun.feng@gmail.com,
Takashi Iwai <tiwai@suse.com>,
Clemens Ladisch <clemens@ladisch.de>,
linux-kernel@vger.kernel.org,
Alexios Zavras <alexios.zavras@intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
bpf@vger.kernel.org, Thomas Gleixner <tglx@linutronix.de>,
Allison Randal <allison@lohutok.net>
Subject: Re: [PATCH 8/8] ALSA: firewire-tascam: Add missing annotation for tscm_hwdep_read_locked()
Date: Wed, 11 Mar 2020 12:18:54 +0900 [thread overview]
Message-ID: <20200311031853.GA8197@workstation> (raw)
In-Reply-To: <20200311010908.42366-9-jbi.octave@gmail.com>
Hi,
On Wed, Mar 11, 2020 at 01:09:08AM +0000, Jules Irenge wrote:
> Sparse reports a warning at tscm_hwdep_read_locked()
>
> warning: context imbalance in tscm_hwdep_read_locked() - unexpected unlock
>
> The root cause is the missing annotation at tscm_hwdep_read_locked()
> Add the missing __releases(&tscm->lock) annotation
>
> Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
> ---
> sound/firewire/tascam/tascam-hwdep.c | 1 +
> 1 file changed, 1 insertion(+)
Thanks for your care of the warning. Although I have found it, I had
no idea to suppress it.
Acked-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
> diff --git a/sound/firewire/tascam/tascam-hwdep.c b/sound/firewire/tascam/tascam-hwdep.c
> index 9801e33e7f2a..6f38335fe10b 100644
> --- a/sound/firewire/tascam/tascam-hwdep.c
> +++ b/sound/firewire/tascam/tascam-hwdep.c
> @@ -17,6 +17,7 @@
>
> static long tscm_hwdep_read_locked(struct snd_tscm *tscm, char __user *buf,
> long count, loff_t *offset)
> + __releases(&tscm->lock)
> {
> struct snd_firewire_event_lock_status event = {
> .type = SNDRV_FIREWIRE_EVENT_LOCK_STATUS,
> --
> 2.24.1
>
next prev parent reply other threads:[~2020-03-11 3:26 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <0/8>
2020-03-11 1:09 ` [PATCH 0/8] Lock warning cleanups Jules Irenge
2020-03-11 1:09 ` [PATCH 1/8] bpf: Add missing annotations for __bpf_prog_enter() and __bpf_prog_exit() Jules Irenge
2020-03-13 19:49 ` Daniel Borkmann
2020-03-11 1:09 ` [PATCH 2/8] raw: Add missing annotations to raw_seq_start() and raw_seq_stop() Jules Irenge
2020-03-11 1:15 ` Eric Dumazet
2020-03-11 1:40 ` Jules Irenge
2020-03-12 6:20 ` David Miller
2020-03-11 1:09 ` [PATCH 3/8] tcp: Add missing annotation for tcp_child_process() Jules Irenge
2020-03-11 1:14 ` Eric Dumazet
2020-03-11 1:28 ` Jules Irenge
2020-03-12 6:20 ` David Miller
2020-03-11 1:09 ` [PATCH 4/8] netfilter: Add missing annotation for ctnetlink_parse_nat_setup() Jules Irenge
2020-03-27 17:22 ` Pablo Neira Ayuso
2020-03-11 1:09 ` [PATCH 5/8] netfilter: conntrack: Add missing annotations for nf_conntrack_all_lock() and nf_conntrack_all_unlock() Jules Irenge
2020-03-27 17:22 ` Pablo Neira Ayuso
2020-03-11 1:09 ` [PATCH 6/8] net: Add missing annotation for *netlink_seq_start() Jules Irenge
2020-03-12 6:20 ` David Miller
2020-03-11 1:09 ` [PATCH 7/8] ALSA: firewire-tascam: Add missing annotation for tscm_hwdep_read_queue() Jules Irenge
2020-03-11 1:09 ` Jules Irenge
2020-03-11 3:19 ` Takashi Sakamoto
2020-03-11 3:19 ` Takashi Sakamoto
2020-03-11 3:19 ` Takashi Sakamoto
2020-03-11 6:56 ` Takashi Iwai
2020-03-11 6:56 ` Takashi Iwai
2020-03-11 1:09 ` [PATCH 8/8] ALSA: firewire-tascam: Add missing annotation for tscm_hwdep_read_locked() Jules Irenge
2020-03-11 1:09 ` Jules Irenge
2020-03-11 3:18 ` Takashi Sakamoto [this message]
2020-03-11 3:18 ` Takashi Sakamoto
2020-03-11 3:18 ` Takashi Sakamoto
2020-03-11 6:56 ` Takashi Iwai
2020-03-11 6:56 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200311031853.GA8197@workstation \
--to=o-takashi@sakamocchi.jp \
--cc=alexios.zavras@intel.com \
--cc=allison@lohutok.net \
--cc=alsa-devel@alsa-project.org \
--cc=boqun.feng@gmail.com \
--cc=bpf@vger.kernel.org \
--cc=clemens@ladisch.de \
--cc=gregkh@linuxfoundation.org \
--cc=jbi.octave@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=perex@perex.cz \
--cc=tglx@linutronix.de \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.