From: Mathieu Poirier <mathieu.poirier@linaro.org>
To: bjorn.andersson@linaro.org
Cc: linux-remoteproc@vger.kernel.org, ohad@wizery.com,
loic.pallardy@st.com, s-anna@ti.com, peng.fan@nxp.com,
arnaud.pouliquen@st.com, fabien.dessenne@st.com
Subject: [PATCH 13/18] remoteproc: Introducting new functions to start and stop an MCU
Date: Thu, 12 Mar 2020 16:11:53 -0600 [thread overview]
Message-ID: <20200312221158.3613-14-mathieu.poirier@linaro.org> (raw)
In-Reply-To: <20200312221158.3613-1-mathieu.poirier@linaro.org>
Add new functions to replace direct calling of rproc->ops->start() and
rproc->ops->stop(). That way different behaviour can be played out
when booting an MCU or synchronising with it.
Signed-off-by: Mathieu Poirier <mathieu.poirier@linaro.org>
---
drivers/remoteproc/remoteproc_core.c | 6 +++---
drivers/remoteproc/remoteproc_internal.h | 12 ++++++++++++
2 files changed, 15 insertions(+), 3 deletions(-)
diff --git a/drivers/remoteproc/remoteproc_core.c b/drivers/remoteproc/remoteproc_core.c
index 36c4d0f13ae9..806201af9470 100644
--- a/drivers/remoteproc/remoteproc_core.c
+++ b/drivers/remoteproc/remoteproc_core.c
@@ -1330,7 +1330,7 @@ static int rproc_start(struct rproc *rproc, const struct firmware *fw)
}
/* power up the remote processor */
- ret = rproc->ops->start(rproc);
+ ret = rproc_start_hw(rproc);
if (ret) {
dev_err(dev, "can't start rproc %s: %d\n", rproc->name, ret);
goto unprepare_subdevices;
@@ -1351,7 +1351,7 @@ static int rproc_start(struct rproc *rproc, const struct firmware *fw)
return 0;
stop_rproc:
- rproc->ops->stop(rproc);
+ rproc_stop_hw(rproc);
unprepare_subdevices:
rproc_unprepare_subdevices(rproc);
reset_table_ptr:
@@ -1483,7 +1483,7 @@ static int rproc_stop(struct rproc *rproc, bool crashed)
rproc->table_ptr = rproc->cached_table;
/* power off the remote processor */
- ret = rproc->ops->stop(rproc);
+ ret = rproc_stop_hw(rproc);
if (ret) {
dev_err(dev, "can't stop rproc: %d\n", ret);
return ret;
diff --git a/drivers/remoteproc/remoteproc_internal.h b/drivers/remoteproc/remoteproc_internal.h
index 53d63ee2c8bf..73a71ae12c01 100644
--- a/drivers/remoteproc/remoteproc_internal.h
+++ b/drivers/remoteproc/remoteproc_internal.h
@@ -159,4 +159,16 @@ struct resource_table *rproc_find_loaded_rsc_table(struct rproc *rproc,
return NULL;
}
+static inline int rproc_start_hw(struct rproc *rproc)
+{
+ RPROC_OPS_HELPER(start, rproc);
+ return -EINVAL;
+}
+
+static inline int rproc_stop_hw(struct rproc *rproc)
+{
+ RPROC_OPS_HELPER(stop, rproc);
+ return -EINVAL;
+}
+
#endif /* REMOTEPROC_INTERNAL_H */
--
2.20.1
next prev parent reply other threads:[~2020-03-12 22:12 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-12 22:11 [PATCH 00/18] remoteproc: Add support for synchronisation with MCU Mathieu Poirier
2020-03-12 22:11 ` [PATCH 01/18] remoteproc: Add new operation and state machine for MCU synchronisation Mathieu Poirier
2020-03-13 2:03 ` Xiang Xiao
2020-03-13 15:01 ` Mathieu Poirier
2020-03-30 19:24 ` Suman Anna
2020-03-12 22:11 ` [PATCH 02/18] remoteproc: Introduce function rproc_set_mcu_sync_state() Mathieu Poirier
2020-03-12 22:11 ` [PATCH 03/18] remoteproc: Split firmware name allocation from rproc_alloc() Mathieu Poirier
2020-03-12 22:11 ` [PATCH 04/18] remoteproc: Split rproc_ops " Mathieu Poirier
2020-03-12 22:11 ` [PATCH 05/18] remoteproc: Get rid of tedious error path Mathieu Poirier
2020-03-12 22:11 ` [PATCH 06/18] remoteproc: Introduce function rproc_alloc_internals() Mathieu Poirier
2020-03-12 22:11 ` [PATCH 07/18] remoteproc: Introduce function rproc_alloc_state_machine() Mathieu Poirier
2020-03-12 22:11 ` [PATCH 08/18] remoteproc: Allocate synchronisation state machine Mathieu Poirier
2020-03-12 22:11 ` [PATCH 09/18] remoteproc: Call the right core function based on synchronisation state Mathieu Poirier
2020-03-12 22:11 ` [PATCH 10/18] remoteproc: Decouple firmware load and remoteproc booting Mathieu Poirier
2020-03-12 22:11 ` [PATCH 11/18] remoteproc: Repurpose function rproc_trigger_auto_boot() Mathieu Poirier
2020-03-12 22:11 ` [PATCH 12/18] remoteproc: Rename function rproc_fw_boot() Mathieu Poirier
2020-03-12 22:11 ` Mathieu Poirier [this message]
2020-03-12 22:11 ` [PATCH 14/18] remoteproc: Refactor function rproc_trigger_recovery() Mathieu Poirier
2020-03-12 22:11 ` [PATCH 15/18] remoteproc: Correctly deal with MCU synchronisation when changing FW image Mathieu Poirier
2020-03-12 22:11 ` [PATCH 16/18] remoteproc: Correctly deal with MCU synchronisation when changing state Mathieu Poirier
2020-03-12 22:11 ` [PATCH 17/18] remoteproc: Make MCU synchronisation state changes on stop and crashed Mathieu Poirier
2020-03-12 22:11 ` [PATCH 18/18] remoteproc: stm32: add support for co-processor booted before kernel Mathieu Poirier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200312221158.3613-14-mathieu.poirier@linaro.org \
--to=mathieu.poirier@linaro.org \
--cc=arnaud.pouliquen@st.com \
--cc=bjorn.andersson@linaro.org \
--cc=fabien.dessenne@st.com \
--cc=linux-remoteproc@vger.kernel.org \
--cc=loic.pallardy@st.com \
--cc=ohad@wizery.com \
--cc=peng.fan@nxp.com \
--cc=s-anna@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.