From: Mathieu Poirier <mathieu.poirier@linaro.org>
To: bjorn.andersson@linaro.org
Cc: linux-remoteproc@vger.kernel.org, ohad@wizery.com,
loic.pallardy@st.com, s-anna@ti.com, peng.fan@nxp.com,
arnaud.pouliquen@st.com, fabien.dessenne@st.com
Subject: [PATCH 02/18] remoteproc: Introduce function rproc_set_mcu_sync_state()
Date: Thu, 12 Mar 2020 16:11:42 -0600 [thread overview]
Message-ID: <20200312221158.3613-3-mathieu.poirier@linaro.org> (raw)
In-Reply-To: <20200312221158.3613-1-mathieu.poirier@linaro.org>
Introduce function rproc_set_mcu_sync_state() to set the synchronisation
state of the MCU at various stages of the lifecycle process.
Signed-off-by: Mathieu Poirier <mathieu.poirier@linaro.org>
---
drivers/remoteproc/remoteproc_internal.h | 38 ++++++++++++++++++++++++
1 file changed, 38 insertions(+)
diff --git a/drivers/remoteproc/remoteproc_internal.h b/drivers/remoteproc/remoteproc_internal.h
index 5c93de5e00bb..73ea32df0156 100644
--- a/drivers/remoteproc/remoteproc_internal.h
+++ b/drivers/remoteproc/remoteproc_internal.h
@@ -24,6 +24,26 @@ struct rproc_debug_trace {
struct rproc_mem_entry trace_mem;
};
+/*
+ * enum rproc_sync_states - remote processsor sync states
+ * @RPROC_SYNC_STATE_INIT state to use when the remoteproc core
+ * is initialising.
+ * @RPROC_SYNC_STATE_SHUTDOWN state to use after the remoteproc core
+ * has shutdown (rproc_shutdown()) the MCU.
+ * @RPROC_SYNC_STATE_CRASHED state to use after the MCU has crashed but
+ * has not been recovered by the remoteproc
+ * core yet.
+ *
+ * Keeping these separate from the enum rproc_state in order to avoid
+ * introducing coupling between the state of the MCU and the synchronisation
+ * operation to use.
+ */
+enum rproc_mcu_sync_states {
+ RPROC_SYNC_STATE_INIT,
+ RPROC_SYNC_STATE_SHUTDOWN,
+ RPROC_SYNC_STATE_CRASHED,
+};
+
/* from remoteproc_core.c */
void rproc_release(struct kref *kref);
irqreturn_t rproc_vq_interrupt(struct rproc *rproc, int vq_id);
@@ -68,6 +88,24 @@ static inline bool rproc_sync_with_mcu(struct rproc *rproc)
return rproc->sync_with_mcu;
}
+static inline void rproc_set_mcu_sync_state(struct rproc *rproc,
+ unsigned int state)
+{
+ switch (state) {
+ case RPROC_SYNC_STATE_INIT:
+ rproc->sync_with_mcu = rproc->sync_states->on_init;
+ break;
+ case RPROC_SYNC_STATE_SHUTDOWN:
+ rproc->sync_with_mcu = rproc->sync_states->after_stop;
+ break;
+ case RPROC_SYNC_STATE_CRASHED:
+ rproc->sync_with_mcu = rproc->sync_states->after_crash;
+ break;
+ default:
+ break;
+ }
+}
+
static inline
int rproc_fw_sanity_check(struct rproc *rproc, const struct firmware *fw)
{
--
2.20.1
next prev parent reply other threads:[~2020-03-12 22:11 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-12 22:11 [PATCH 00/18] remoteproc: Add support for synchronisation with MCU Mathieu Poirier
2020-03-12 22:11 ` [PATCH 01/18] remoteproc: Add new operation and state machine for MCU synchronisation Mathieu Poirier
2020-03-13 2:03 ` Xiang Xiao
2020-03-13 15:01 ` Mathieu Poirier
2020-03-30 19:24 ` Suman Anna
2020-03-12 22:11 ` Mathieu Poirier [this message]
2020-03-12 22:11 ` [PATCH 03/18] remoteproc: Split firmware name allocation from rproc_alloc() Mathieu Poirier
2020-03-12 22:11 ` [PATCH 04/18] remoteproc: Split rproc_ops " Mathieu Poirier
2020-03-12 22:11 ` [PATCH 05/18] remoteproc: Get rid of tedious error path Mathieu Poirier
2020-03-12 22:11 ` [PATCH 06/18] remoteproc: Introduce function rproc_alloc_internals() Mathieu Poirier
2020-03-12 22:11 ` [PATCH 07/18] remoteproc: Introduce function rproc_alloc_state_machine() Mathieu Poirier
2020-03-12 22:11 ` [PATCH 08/18] remoteproc: Allocate synchronisation state machine Mathieu Poirier
2020-03-12 22:11 ` [PATCH 09/18] remoteproc: Call the right core function based on synchronisation state Mathieu Poirier
2020-03-12 22:11 ` [PATCH 10/18] remoteproc: Decouple firmware load and remoteproc booting Mathieu Poirier
2020-03-12 22:11 ` [PATCH 11/18] remoteproc: Repurpose function rproc_trigger_auto_boot() Mathieu Poirier
2020-03-12 22:11 ` [PATCH 12/18] remoteproc: Rename function rproc_fw_boot() Mathieu Poirier
2020-03-12 22:11 ` [PATCH 13/18] remoteproc: Introducting new functions to start and stop an MCU Mathieu Poirier
2020-03-12 22:11 ` [PATCH 14/18] remoteproc: Refactor function rproc_trigger_recovery() Mathieu Poirier
2020-03-12 22:11 ` [PATCH 15/18] remoteproc: Correctly deal with MCU synchronisation when changing FW image Mathieu Poirier
2020-03-12 22:11 ` [PATCH 16/18] remoteproc: Correctly deal with MCU synchronisation when changing state Mathieu Poirier
2020-03-12 22:11 ` [PATCH 17/18] remoteproc: Make MCU synchronisation state changes on stop and crashed Mathieu Poirier
2020-03-12 22:11 ` [PATCH 18/18] remoteproc: stm32: add support for co-processor booted before kernel Mathieu Poirier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200312221158.3613-3-mathieu.poirier@linaro.org \
--to=mathieu.poirier@linaro.org \
--cc=arnaud.pouliquen@st.com \
--cc=bjorn.andersson@linaro.org \
--cc=fabien.dessenne@st.com \
--cc=linux-remoteproc@vger.kernel.org \
--cc=loic.pallardy@st.com \
--cc=ohad@wizery.com \
--cc=peng.fan@nxp.com \
--cc=s-anna@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.