From: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
To: Waiman Long <longman@redhat.com>
Cc: David Howells <dhowells@redhat.com>,
James Morris <jmorris@namei.org>,
"Serge E. Hallyn" <serge@hallyn.com>,
Mimi Zohar <zohar@linux.ibm.com>,
keyrings@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-security-module@vger.kernel.org,
linux-integrity@vger.kernel.org,
Sumit Garg <sumit.garg@linaro.org>,
Jerry Snitselaar <jsnitsel@redhat.com>,
Roberto Sassu <roberto.sassu@huawei.com>,
Eric Biggers <ebiggers@google.com>,
Chris von Recklinghausen <crecklin@redhat.com>
Subject: Re: [PATCH v2 1/2] KEYS: Don't write out to userspace while holding key semaphore
Date: Fri, 13 Mar 2020 01:04:25 +0000 [thread overview]
Message-ID: <20200313010425.GA11360@linux.intel.com> (raw)
In-Reply-To: <20200308170410.14166-2-longman@redhat.com>
On Sun, Mar 08, 2020 at 01:04:09PM -0400, Waiman Long wrote:
> + /*
> + * Read methods will just return the required length
> + * without any copying if the provided length isn't big
> + * enough.
> + */
> + if ((ret > 0) && (ret <= buflen) && buffer &&
> + copy_to_user(buffer, tmpbuf, ret))
> + ret = -EFAULT;
Please, reorg and remove redundant parentheses:
/*
* Read methods will just return the required length
* without any copying if the provided length isn't big
* enough.
*/
if (ret > 0 && ret <= buflen) {
if (buffer && copy_to_user(buffer, tmpbuf, ret))
ret = -EFAULT;
}
Now the comment is attached to the exact right thing. The previous
organization is a pain to look at when backtracking commits for
whatever reason in the future.
I'm also wondering, would it be possible to rework the code in a way
that you don't have check whether buffer is valid on a constant basis?
/Jarkko
WARNING: multiple messages have this Message-ID (diff)
From: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
To: Waiman Long <longman@redhat.com>
Cc: David Howells <dhowells@redhat.com>,
James Morris <jmorris@namei.org>,
"Serge E. Hallyn" <serge@hallyn.com>,
Mimi Zohar <zohar@linux.ibm.com>,
keyrings@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-security-module@vger.kernel.org,
linux-integrity@vger.kernel.org,
Sumit Garg <sumit.garg@linaro.org>,
Jerry Snitselaar <jsnitsel@redhat.com>,
Roberto Sassu <roberto.sassu@huawei.com>,
Eric Biggers <ebiggers@google.com>,
Chris von Recklinghausen <crecklin@redhat.com>
Subject: Re: [PATCH v2 1/2] KEYS: Don't write out to userspace while holding key semaphore
Date: Fri, 13 Mar 2020 03:04:25 +0200 [thread overview]
Message-ID: <20200313010425.GA11360@linux.intel.com> (raw)
In-Reply-To: <20200308170410.14166-2-longman@redhat.com>
On Sun, Mar 08, 2020 at 01:04:09PM -0400, Waiman Long wrote:
> + /*
> + * Read methods will just return the required length
> + * without any copying if the provided length isn't big
> + * enough.
> + */
> + if ((ret > 0) && (ret <= buflen) && buffer &&
> + copy_to_user(buffer, tmpbuf, ret))
> + ret = -EFAULT;
Please, reorg and remove redundant parentheses:
/*
* Read methods will just return the required length
* without any copying if the provided length isn't big
* enough.
*/
if (ret > 0 && ret <= buflen) {
if (buffer && copy_to_user(buffer, tmpbuf, ret))
ret = -EFAULT;
}
Now the comment is attached to the exact right thing. The previous
organization is a pain to look at when backtracking commits for
whatever reason in the future.
I'm also wondering, would it be possible to rework the code in a way
that you don't have check whether buffer is valid on a constant basis?
/Jarkko
next prev parent reply other threads:[~2020-03-13 1:04 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-08 17:04 [PATCH v2 0/2] KEYS: Read keys to internal buffer & then copy to userspace Waiman Long
2020-03-08 17:04 ` Waiman Long
2020-03-08 17:04 ` [PATCH v2 1/2] KEYS: Don't write out to userspace while holding key semaphore Waiman Long
2020-03-08 17:04 ` Waiman Long
2020-03-13 1:04 ` Jarkko Sakkinen [this message]
2020-03-13 1:04 ` Jarkko Sakkinen
2020-03-13 13:29 ` Waiman Long
2020-03-13 13:29 ` Waiman Long
2020-03-13 15:28 ` Jarkko Sakkinen
2020-03-13 15:28 ` Jarkko Sakkinen
2020-03-13 16:57 ` Waiman Long
2020-03-13 16:57 ` Waiman Long
2020-03-08 17:04 ` [PATCH v2 2/2] KEYS: Avoid false positive ENOMEM error on key read Waiman Long
2020-03-08 17:04 ` Waiman Long
2020-03-09 16:32 ` David Howells
2020-03-10 15:45 ` Waiman Long
2020-03-10 15:45 ` Waiman Long
2020-03-10 15:58 ` Waiman Long
2020-03-10 15:58 ` Waiman Long
2020-03-10 17:12 ` David Howells
2020-03-11 15:33 ` Waiman Long
2020-03-11 15:33 ` Waiman Long
2020-03-11 15:33 ` Waiman Long
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200313010425.GA11360@linux.intel.com \
--to=jarkko.sakkinen@linux.intel.com \
--cc=crecklin@redhat.com \
--cc=dhowells@redhat.com \
--cc=ebiggers@google.com \
--cc=jmorris@namei.org \
--cc=jsnitsel@redhat.com \
--cc=keyrings@vger.kernel.org \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=longman@redhat.com \
--cc=roberto.sassu@huawei.com \
--cc=serge@hallyn.com \
--cc=sumit.garg@linaro.org \
--cc=zohar@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.