From: Stanley Chu <stanley.chu@mediatek.com>
To: <linux-scsi@vger.kernel.org>, <martin.peter~sen@oracle.com>,
<avri.altman@wdc.com>, <alim.akhtar@samsung.com>,
<jejb@linux.ibm.com>
Cc: <beanhuo@micron.com>, <asutoshd@codeaurora.org>,
<cang@codeaurora.org>, <matthias.bgg@gmail.com>,
<bvanassche@acm.org>, <linux-mediatek@lists.infradead.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>, <kuohong.wang@mediatek.com>,
<peter.wang@mediatek.com>, <chun-hung.wu@mediatek.com>,
<andy.teng@mediatek.com>, Stanley Chu <stanley.chu@mediatek.com>
Subject: [PATCH v5 7/8] scsi: ufs: make HCE polling more compact to improve initialization latency
Date: Mon, 16 Mar 2020 11:42:17 +0800 [thread overview]
Message-ID: <20200316034218.11914-8-stanley.chu@mediatek.com> (raw)
In-Reply-To: <20200316034218.11914-1-stanley.chu@mediatek.com>
Reduce the waiting period between each HCE (Host Controller Enable)
polling from 5 ms to 1 ms. In the same time, increase the maximum polling
times to make "total polling time" unchanged approximately.
This change could make HCE initializatoin faster to improve latency of
ufshcd initialization, error recovery, and resume behaviors.
Signed-off-by: Stanley Chu <stanley.chu@mediatek.com>
Reviewed-by: Avri Altman <avri.altman@wdc.com>
---
drivers/scsi/ufs/ufshcd.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
index dcbf45d547d8..cd33d07c56cf 100644
--- a/drivers/scsi/ufs/ufshcd.c
+++ b/drivers/scsi/ufs/ufshcd.c
@@ -4301,7 +4301,7 @@ int ufshcd_hba_enable(struct ufs_hba *hba)
ufshcd_wait_us(hba->hba_enable_delay_us, 100, true);
/* wait for the host controller to complete initialization */
- retry = 10;
+ retry = 50;
while (ufshcd_is_hba_active(hba)) {
if (retry) {
retry--;
@@ -4310,7 +4310,7 @@ int ufshcd_hba_enable(struct ufs_hba *hba)
"Controller enable failed\n");
return -EIO;
}
- ufshcd_wait_us(5000, 100, true);
+ ufshcd_wait_us(1000, 100, true);
}
/* enable UIC related interrupts */
--
2.18.0
WARNING: multiple messages have this Message-ID (diff)
From: Stanley Chu <stanley.chu@mediatek.com>
To: <linux-scsi@vger.kernel.org>, <martin.peter~sen@oracle.com>,
<avri.altman@wdc.com>, <alim.akhtar@samsung.com>,
<jejb@linux.ibm.com>
Cc: Stanley Chu <stanley.chu@mediatek.com>,
bvanassche@acm.org, andy.teng@mediatek.com,
chun-hung.wu@mediatek.com, kuohong.wang@mediatek.com,
linux-kernel@vger.kernel.org, cang@codeaurora.org,
linux-mediatek@lists.infradead.org, peter.wang@mediatek.com,
matthias.bgg@gmail.com, beanhuo@micron.com,
linux-arm-kernel@lists.infradead.org, asutoshd@codeaurora.org
Subject: [PATCH v5 7/8] scsi: ufs: make HCE polling more compact to improve initialization latency
Date: Mon, 16 Mar 2020 11:42:17 +0800 [thread overview]
Message-ID: <20200316034218.11914-8-stanley.chu@mediatek.com> (raw)
In-Reply-To: <20200316034218.11914-1-stanley.chu@mediatek.com>
Reduce the waiting period between each HCE (Host Controller Enable)
polling from 5 ms to 1 ms. In the same time, increase the maximum polling
times to make "total polling time" unchanged approximately.
This change could make HCE initializatoin faster to improve latency of
ufshcd initialization, error recovery, and resume behaviors.
Signed-off-by: Stanley Chu <stanley.chu@mediatek.com>
Reviewed-by: Avri Altman <avri.altman@wdc.com>
---
drivers/scsi/ufs/ufshcd.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
index dcbf45d547d8..cd33d07c56cf 100644
--- a/drivers/scsi/ufs/ufshcd.c
+++ b/drivers/scsi/ufs/ufshcd.c
@@ -4301,7 +4301,7 @@ int ufshcd_hba_enable(struct ufs_hba *hba)
ufshcd_wait_us(hba->hba_enable_delay_us, 100, true);
/* wait for the host controller to complete initialization */
- retry = 10;
+ retry = 50;
while (ufshcd_is_hba_active(hba)) {
if (retry) {
retry--;
@@ -4310,7 +4310,7 @@ int ufshcd_hba_enable(struct ufs_hba *hba)
"Controller enable failed\n");
return -EIO;
}
- ufshcd_wait_us(5000, 100, true);
+ ufshcd_wait_us(1000, 100, true);
}
/* enable UIC related interrupts */
--
2.18.0
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
WARNING: multiple messages have this Message-ID (diff)
From: Stanley Chu <stanley.chu@mediatek.com>
To: <linux-scsi@vger.kernel.org>, <martin.peter~sen@oracle.com>,
<avri.altman@wdc.com>, <alim.akhtar@samsung.com>,
<jejb@linux.ibm.com>
Cc: Stanley Chu <stanley.chu@mediatek.com>,
bvanassche@acm.org, andy.teng@mediatek.com,
chun-hung.wu@mediatek.com, kuohong.wang@mediatek.com,
linux-kernel@vger.kernel.org, cang@codeaurora.org,
linux-mediatek@lists.infradead.org, peter.wang@mediatek.com,
matthias.bgg@gmail.com, beanhuo@micron.com,
linux-arm-kernel@lists.infradead.org, asutoshd@codeaurora.org
Subject: [PATCH v5 7/8] scsi: ufs: make HCE polling more compact to improve initialization latency
Date: Mon, 16 Mar 2020 11:42:17 +0800 [thread overview]
Message-ID: <20200316034218.11914-8-stanley.chu@mediatek.com> (raw)
In-Reply-To: <20200316034218.11914-1-stanley.chu@mediatek.com>
Reduce the waiting period between each HCE (Host Controller Enable)
polling from 5 ms to 1 ms. In the same time, increase the maximum polling
times to make "total polling time" unchanged approximately.
This change could make HCE initializatoin faster to improve latency of
ufshcd initialization, error recovery, and resume behaviors.
Signed-off-by: Stanley Chu <stanley.chu@mediatek.com>
Reviewed-by: Avri Altman <avri.altman@wdc.com>
---
drivers/scsi/ufs/ufshcd.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
index dcbf45d547d8..cd33d07c56cf 100644
--- a/drivers/scsi/ufs/ufshcd.c
+++ b/drivers/scsi/ufs/ufshcd.c
@@ -4301,7 +4301,7 @@ int ufshcd_hba_enable(struct ufs_hba *hba)
ufshcd_wait_us(hba->hba_enable_delay_us, 100, true);
/* wait for the host controller to complete initialization */
- retry = 10;
+ retry = 50;
while (ufshcd_is_hba_active(hba)) {
if (retry) {
retry--;
@@ -4310,7 +4310,7 @@ int ufshcd_hba_enable(struct ufs_hba *hba)
"Controller enable failed\n");
return -EIO;
}
- ufshcd_wait_us(5000, 100, true);
+ ufshcd_wait_us(1000, 100, true);
}
/* enable UIC related interrupts */
--
2.18.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-03-16 3:42 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-16 3:42 [PATCH v5 0/8] scsi: ufs: some cleanups and make the delay for host enabling customizable Stanley Chu
2020-03-16 3:42 ` Stanley Chu
2020-03-16 3:42 ` Stanley Chu
2020-03-16 3:42 ` [PATCH v5 1/8] scsi: ufs: fix uninitialized tx_lanes in ufshcd_disable_tx_lcc() Stanley Chu
2020-03-16 3:42 ` Stanley Chu
2020-03-16 3:42 ` Stanley Chu
2020-03-16 3:42 ` [PATCH v5 2/8] scsi: ufs: remove init_prefetch_data in struct ufs_hba Stanley Chu
2020-03-16 3:42 ` Stanley Chu
2020-03-16 3:42 ` Stanley Chu
2020-03-16 6:25 ` Can Guo
2020-03-16 6:25 ` Can Guo
2020-03-16 6:25 ` Can Guo
2020-03-16 7:08 ` Stanley Chu
2020-03-16 7:08 ` Stanley Chu
2020-03-16 7:08 ` Stanley Chu
2020-03-16 7:09 ` Can Guo
2020-03-16 7:09 ` Can Guo
2020-03-16 7:09 ` Can Guo
2020-03-16 3:42 ` [PATCH v5 3/8] scsi: ufs: use an enum for host capabilities Stanley Chu
2020-03-16 3:42 ` Stanley Chu
2020-03-16 3:42 ` Stanley Chu
2020-03-16 3:42 ` [PATCH v5 4/8] scsi: ufs: introduce common delay function Stanley Chu
2020-03-16 3:42 ` Stanley Chu
2020-03-16 3:42 ` Stanley Chu
2020-03-16 3:42 ` [PATCH v5 5/8] scsi: ufs-mediatek: replace all delay places by " Stanley Chu
2020-03-16 3:42 ` Stanley Chu
2020-03-16 3:42 ` Stanley Chu
2020-03-16 3:42 ` [PATCH v5 6/8] scsi: ufs: allow customized delay for host enabling Stanley Chu
2020-03-16 3:42 ` Stanley Chu
2020-03-16 3:42 ` Stanley Chu
2020-03-16 3:42 ` Stanley Chu [this message]
2020-03-16 3:42 ` [PATCH v5 7/8] scsi: ufs: make HCE polling more compact to improve initialization latency Stanley Chu
2020-03-16 3:42 ` Stanley Chu
2020-03-16 6:34 ` Can Guo
2020-03-16 6:34 ` Can Guo
2020-03-16 6:34 ` Can Guo
2020-03-16 3:42 ` [PATCH v5 8/8] scsi: ufs-mediatek: customize the delay for host enabling Stanley Chu
2020-03-16 3:42 ` Stanley Chu
2020-03-16 3:42 ` Stanley Chu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200316034218.11914-8-stanley.chu@mediatek.com \
--to=stanley.chu@mediatek.com \
--cc=alim.akhtar@samsung.com \
--cc=andy.teng@mediatek.com \
--cc=asutoshd@codeaurora.org \
--cc=avri.altman@wdc.com \
--cc=beanhuo@micron.com \
--cc=bvanassche@acm.org \
--cc=cang@codeaurora.org \
--cc=chun-hung.wu@mediatek.com \
--cc=jejb@linux.ibm.com \
--cc=kuohong.wang@mediatek.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.peter~sen@oracle.com \
--cc=matthias.bgg@gmail.com \
--cc=peter.wang@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.