From: Stanley Chu <stanley.chu@mediatek.com>
To: <linux-scsi@vger.kernel.org>, <martin.peter~sen@oracle.com>,
<avri.altman@wdc.com>, <alim.akhtar@samsung.com>,
<jejb@linux.ibm.com>
Cc: <beanhuo@micron.com>, <asutoshd@codeaurora.org>,
<cang@codeaurora.org>, <matthias.bgg@gmail.com>,
<bvanassche@acm.org>, <linux-mediatek@lists.infradead.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>, <kuohong.wang@mediatek.com>,
<peter.wang@mediatek.com>, <chun-hung.wu@mediatek.com>,
<andy.teng@mediatek.com>, Stanley Chu <stanley.chu@mediatek.com>
Subject: [PATCH v6 5/7] scsi: ufs: allow customized delay for host enabling
Date: Mon, 16 Mar 2020 16:53:01 +0800 [thread overview]
Message-ID: <20200316085303.20350-6-stanley.chu@mediatek.com> (raw)
In-Reply-To: <20200316085303.20350-1-stanley.chu@mediatek.com>
Currently a 1 ms delay is applied before polling CONTROLLER_ENABLE
bit. This delay may not be required or can be changed in different
controllers. Make the delay as a changeable value in struct ufs_hba to
allow it customized by vendors.
Signed-off-by: Stanley Chu <stanley.chu@mediatek.com>
Reviewed-by: Avri Altman <avri.altman@wdc.com>
Reviewed-by: Can Guo <cang@codeaurora.org>
---
drivers/scsi/ufs/ufshcd.c | 3 ++-
drivers/scsi/ufs/ufshcd.h | 1 +
2 files changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
index 9fea346f7d22..78b6ac6fcc4e 100644
--- a/drivers/scsi/ufs/ufshcd.c
+++ b/drivers/scsi/ufs/ufshcd.c
@@ -4298,7 +4298,7 @@ int ufshcd_hba_enable(struct ufs_hba *hba)
* instruction might be read back.
* This delay can be changed based on the controller.
*/
- ufshcd_wait_us(1000, 100, true);
+ ufshcd_wait_us(hba->hba_enable_delay_us, 100, true);
/* wait for the host controller to complete initialization */
retry = 10;
@@ -8421,6 +8421,7 @@ int ufshcd_init(struct ufs_hba *hba, void __iomem *mmio_base, unsigned int irq)
hba->mmio_base = mmio_base;
hba->irq = irq;
+ hba->hba_enable_delay_us = 1000;
err = ufshcd_hba_init(hba);
if (err)
diff --git a/drivers/scsi/ufs/ufshcd.h b/drivers/scsi/ufs/ufshcd.h
index 842f0223f5e5..b7111925d899 100644
--- a/drivers/scsi/ufs/ufshcd.h
+++ b/drivers/scsi/ufs/ufshcd.h
@@ -663,6 +663,7 @@ struct ufs_hba {
u32 eh_flags;
u32 intr_mask;
u16 ee_ctrl_mask;
+ u16 hba_enable_delay_us;
bool is_powered;
struct ufs_init_prefetch init_prefetch_data;
--
2.18.0
WARNING: multiple messages have this Message-ID (diff)
From: Stanley Chu <stanley.chu@mediatek.com>
To: <linux-scsi@vger.kernel.org>, <martin.peter~sen@oracle.com>,
<avri.altman@wdc.com>, <alim.akhtar@samsung.com>,
<jejb@linux.ibm.com>
Cc: Stanley Chu <stanley.chu@mediatek.com>,
bvanassche@acm.org, andy.teng@mediatek.com,
chun-hung.wu@mediatek.com, kuohong.wang@mediatek.com,
linux-kernel@vger.kernel.org, cang@codeaurora.org,
linux-mediatek@lists.infradead.org, peter.wang@mediatek.com,
matthias.bgg@gmail.com, beanhuo@micron.com,
linux-arm-kernel@lists.infradead.org, asutoshd@codeaurora.org
Subject: [PATCH v6 5/7] scsi: ufs: allow customized delay for host enabling
Date: Mon, 16 Mar 2020 16:53:01 +0800 [thread overview]
Message-ID: <20200316085303.20350-6-stanley.chu@mediatek.com> (raw)
In-Reply-To: <20200316085303.20350-1-stanley.chu@mediatek.com>
Currently a 1 ms delay is applied before polling CONTROLLER_ENABLE
bit. This delay may not be required or can be changed in different
controllers. Make the delay as a changeable value in struct ufs_hba to
allow it customized by vendors.
Signed-off-by: Stanley Chu <stanley.chu@mediatek.com>
Reviewed-by: Avri Altman <avri.altman@wdc.com>
Reviewed-by: Can Guo <cang@codeaurora.org>
---
drivers/scsi/ufs/ufshcd.c | 3 ++-
drivers/scsi/ufs/ufshcd.h | 1 +
2 files changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
index 9fea346f7d22..78b6ac6fcc4e 100644
--- a/drivers/scsi/ufs/ufshcd.c
+++ b/drivers/scsi/ufs/ufshcd.c
@@ -4298,7 +4298,7 @@ int ufshcd_hba_enable(struct ufs_hba *hba)
* instruction might be read back.
* This delay can be changed based on the controller.
*/
- ufshcd_wait_us(1000, 100, true);
+ ufshcd_wait_us(hba->hba_enable_delay_us, 100, true);
/* wait for the host controller to complete initialization */
retry = 10;
@@ -8421,6 +8421,7 @@ int ufshcd_init(struct ufs_hba *hba, void __iomem *mmio_base, unsigned int irq)
hba->mmio_base = mmio_base;
hba->irq = irq;
+ hba->hba_enable_delay_us = 1000;
err = ufshcd_hba_init(hba);
if (err)
diff --git a/drivers/scsi/ufs/ufshcd.h b/drivers/scsi/ufs/ufshcd.h
index 842f0223f5e5..b7111925d899 100644
--- a/drivers/scsi/ufs/ufshcd.h
+++ b/drivers/scsi/ufs/ufshcd.h
@@ -663,6 +663,7 @@ struct ufs_hba {
u32 eh_flags;
u32 intr_mask;
u16 ee_ctrl_mask;
+ u16 hba_enable_delay_us;
bool is_powered;
struct ufs_init_prefetch init_prefetch_data;
--
2.18.0
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
WARNING: multiple messages have this Message-ID (diff)
From: Stanley Chu <stanley.chu@mediatek.com>
To: <linux-scsi@vger.kernel.org>, <martin.peter~sen@oracle.com>,
<avri.altman@wdc.com>, <alim.akhtar@samsung.com>,
<jejb@linux.ibm.com>
Cc: Stanley Chu <stanley.chu@mediatek.com>,
bvanassche@acm.org, andy.teng@mediatek.com,
chun-hung.wu@mediatek.com, kuohong.wang@mediatek.com,
linux-kernel@vger.kernel.org, cang@codeaurora.org,
linux-mediatek@lists.infradead.org, peter.wang@mediatek.com,
matthias.bgg@gmail.com, beanhuo@micron.com,
linux-arm-kernel@lists.infradead.org, asutoshd@codeaurora.org
Subject: [PATCH v6 5/7] scsi: ufs: allow customized delay for host enabling
Date: Mon, 16 Mar 2020 16:53:01 +0800 [thread overview]
Message-ID: <20200316085303.20350-6-stanley.chu@mediatek.com> (raw)
In-Reply-To: <20200316085303.20350-1-stanley.chu@mediatek.com>
Currently a 1 ms delay is applied before polling CONTROLLER_ENABLE
bit. This delay may not be required or can be changed in different
controllers. Make the delay as a changeable value in struct ufs_hba to
allow it customized by vendors.
Signed-off-by: Stanley Chu <stanley.chu@mediatek.com>
Reviewed-by: Avri Altman <avri.altman@wdc.com>
Reviewed-by: Can Guo <cang@codeaurora.org>
---
drivers/scsi/ufs/ufshcd.c | 3 ++-
drivers/scsi/ufs/ufshcd.h | 1 +
2 files changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
index 9fea346f7d22..78b6ac6fcc4e 100644
--- a/drivers/scsi/ufs/ufshcd.c
+++ b/drivers/scsi/ufs/ufshcd.c
@@ -4298,7 +4298,7 @@ int ufshcd_hba_enable(struct ufs_hba *hba)
* instruction might be read back.
* This delay can be changed based on the controller.
*/
- ufshcd_wait_us(1000, 100, true);
+ ufshcd_wait_us(hba->hba_enable_delay_us, 100, true);
/* wait for the host controller to complete initialization */
retry = 10;
@@ -8421,6 +8421,7 @@ int ufshcd_init(struct ufs_hba *hba, void __iomem *mmio_base, unsigned int irq)
hba->mmio_base = mmio_base;
hba->irq = irq;
+ hba->hba_enable_delay_us = 1000;
err = ufshcd_hba_init(hba);
if (err)
diff --git a/drivers/scsi/ufs/ufshcd.h b/drivers/scsi/ufs/ufshcd.h
index 842f0223f5e5..b7111925d899 100644
--- a/drivers/scsi/ufs/ufshcd.h
+++ b/drivers/scsi/ufs/ufshcd.h
@@ -663,6 +663,7 @@ struct ufs_hba {
u32 eh_flags;
u32 intr_mask;
u16 ee_ctrl_mask;
+ u16 hba_enable_delay_us;
bool is_powered;
struct ufs_init_prefetch init_prefetch_data;
--
2.18.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-03-16 8:53 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-16 8:52 [PATCH v6 0/7] scsi: ufs: some cleanups and make the delay for host enabling customizable Stanley Chu
2020-03-16 8:52 ` Stanley Chu
2020-03-16 8:52 ` Stanley Chu
2020-03-16 8:52 ` [PATCH v6 1/7] scsi: ufs: fix uninitialized tx_lanes in ufshcd_disable_tx_lcc() Stanley Chu
2020-03-16 8:52 ` Stanley Chu
2020-03-16 8:52 ` Stanley Chu
2020-03-16 8:52 ` [PATCH v6 2/7] scsi: ufs: use an enum for host capabilities Stanley Chu
2020-03-16 8:52 ` Stanley Chu
2020-03-16 8:52 ` Stanley Chu
2020-03-16 8:52 ` [PATCH v6 3/7] scsi: ufs: introduce common delay function Stanley Chu
2020-03-16 8:52 ` Stanley Chu
2020-03-16 8:52 ` Stanley Chu
2020-03-16 8:56 ` Can Guo
2020-03-16 8:56 ` Can Guo
2020-03-16 8:56 ` Can Guo
2020-03-16 16:23 ` Bart Van Assche
2020-03-16 16:23 ` Bart Van Assche
2020-03-16 16:23 ` Bart Van Assche
2020-03-17 0:13 ` Stanley Chu
2020-03-17 0:13 ` Stanley Chu
2020-03-17 0:13 ` Stanley Chu
2020-03-17 3:59 ` Bart Van Assche
2020-03-17 3:59 ` Bart Van Assche
2020-03-17 3:59 ` Bart Van Assche
2020-03-18 6:02 ` [SPAM]Re: " Stanley Chu
2020-03-18 6:02 ` Stanley Chu
2020-03-18 6:14 ` Stanley Chu
2020-03-18 6:14 ` Stanley Chu
2020-03-18 6:14 ` Stanley Chu
2020-03-16 8:53 ` [PATCH v6 4/7] scsi: ufs-mediatek: replace all delay places by " Stanley Chu
2020-03-16 8:53 ` Stanley Chu
2020-03-16 8:53 ` Stanley Chu
2020-03-16 8:53 ` Stanley Chu [this message]
2020-03-16 8:53 ` [PATCH v6 5/7] scsi: ufs: allow customized delay for host enabling Stanley Chu
2020-03-16 8:53 ` Stanley Chu
2020-03-16 8:53 ` [PATCH v6 6/7] scsi: ufs: make HCE polling more compact to improve initialization latency Stanley Chu
2020-03-16 8:53 ` Stanley Chu
2020-03-16 8:53 ` Stanley Chu
2020-03-16 8:53 ` [PATCH v6 7/7] scsi: ufs-mediatek: customize the delay for host enabling Stanley Chu
2020-03-16 8:53 ` Stanley Chu
2020-03-16 8:53 ` Stanley Chu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200316085303.20350-6-stanley.chu@mediatek.com \
--to=stanley.chu@mediatek.com \
--cc=alim.akhtar@samsung.com \
--cc=andy.teng@mediatek.com \
--cc=asutoshd@codeaurora.org \
--cc=avri.altman@wdc.com \
--cc=beanhuo@micron.com \
--cc=bvanassche@acm.org \
--cc=cang@codeaurora.org \
--cc=chun-hung.wu@mediatek.com \
--cc=jejb@linux.ibm.com \
--cc=kuohong.wang@mediatek.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.peter~sen@oracle.com \
--cc=matthias.bgg@gmail.com \
--cc=peter.wang@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.