From: Stanley Chu <stanley.chu@mediatek.com>
To: <linux-scsi@vger.kernel.org>, <martin.peter~sen@oracle.com>,
<avri.altman@wdc.com>, <alim.akhtar@samsung.com>,
<jejb@linux.ibm.com>, <bvanassche@acm.org>
Cc: <beanhuo@micron.com>, <asutoshd@codeaurora.org>,
<cang@codeaurora.org>, <matthias.bgg@gmail.com>,
<linux-mediatek@lists.infradead.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>, <kuohong.wang@mediatek.com>,
<peter.wang@mediatek.com>, <chun-hung.wu@mediatek.com>,
<andy.teng@mediatek.com>, Stanley Chu <stanley.chu@mediatek.com>
Subject: [PATCH v7 4/7] scsi: ufs-mediatek: use common delay function for required places
Date: Wed, 18 Mar 2020 18:40:13 +0800 [thread overview]
Message-ID: <20200318104016.28049-5-stanley.chu@mediatek.com> (raw)
In-Reply-To: <20200318104016.28049-1-stanley.chu@mediatek.com>
A common delay function is introduced in UFS core driver, thus
ufs-mediatek can use it instead of the private delay function for
required places.
Signed-off-by: Stanley Chu <stanley.chu@mediatek.com>
Reviewed-by: Avri Altman <avri.altman@wdc.com>
---
drivers/scsi/ufs/ufs-mediatek.c | 15 ++-------------
1 file changed, 2 insertions(+), 13 deletions(-)
diff --git a/drivers/scsi/ufs/ufs-mediatek.c b/drivers/scsi/ufs/ufs-mediatek.c
index 3b0e575d7460..73bd4c245f4a 100644
--- a/drivers/scsi/ufs/ufs-mediatek.c
+++ b/drivers/scsi/ufs/ufs-mediatek.c
@@ -100,17 +100,6 @@ static int ufs_mtk_bind_mphy(struct ufs_hba *hba)
return err;
}
-static void ufs_mtk_udelay(unsigned long us)
-{
- if (!us)
- return;
-
- if (us < 10)
- udelay(us);
- else
- usleep_range(us, us + 10);
-}
-
static int ufs_mtk_setup_ref_clk(struct ufs_hba *hba, bool on)
{
struct ufs_mtk_host *host = ufshcd_get_variant(hba);
@@ -123,7 +112,7 @@ static int ufs_mtk_setup_ref_clk(struct ufs_hba *hba, bool on)
if (on) {
ufs_mtk_ref_clk_notify(on, res);
- ufs_mtk_udelay(host->ref_clk_ungating_wait_us);
+ ufshcd_delay_us(host->ref_clk_ungating_wait_us, 10);
ufshcd_writel(hba, REFCLK_REQUEST, REG_UFS_REFCLK_CTRL);
} else {
ufshcd_writel(hba, REFCLK_RELEASE, REG_UFS_REFCLK_CTRL);
@@ -150,7 +139,7 @@ static int ufs_mtk_setup_ref_clk(struct ufs_hba *hba, bool on)
out:
host->ref_clk_enabled = on;
if (!on) {
- ufs_mtk_udelay(host->ref_clk_gating_wait_us);
+ ufshcd_delay_us(host->ref_clk_gating_wait_us, 10);
ufs_mtk_ref_clk_notify(on, res);
}
--
2.18.0
WARNING: multiple messages have this Message-ID (diff)
From: Stanley Chu <stanley.chu@mediatek.com>
To: <linux-scsi@vger.kernel.org>, <martin.peter~sen@oracle.com>,
<avri.altman@wdc.com>, <alim.akhtar@samsung.com>,
<jejb@linux.ibm.com>, <bvanassche@acm.org>
Cc: Stanley Chu <stanley.chu@mediatek.com>,
andy.teng@mediatek.com, chun-hung.wu@mediatek.com,
kuohong.wang@mediatek.com, linux-kernel@vger.kernel.org,
cang@codeaurora.org, linux-mediatek@lists.infradead.org,
peter.wang@mediatek.com, matthias.bgg@gmail.com,
beanhuo@micron.com, linux-arm-kernel@lists.infradead.org,
asutoshd@codeaurora.org
Subject: [PATCH v7 4/7] scsi: ufs-mediatek: use common delay function for required places
Date: Wed, 18 Mar 2020 18:40:13 +0800 [thread overview]
Message-ID: <20200318104016.28049-5-stanley.chu@mediatek.com> (raw)
In-Reply-To: <20200318104016.28049-1-stanley.chu@mediatek.com>
A common delay function is introduced in UFS core driver, thus
ufs-mediatek can use it instead of the private delay function for
required places.
Signed-off-by: Stanley Chu <stanley.chu@mediatek.com>
Reviewed-by: Avri Altman <avri.altman@wdc.com>
---
drivers/scsi/ufs/ufs-mediatek.c | 15 ++-------------
1 file changed, 2 insertions(+), 13 deletions(-)
diff --git a/drivers/scsi/ufs/ufs-mediatek.c b/drivers/scsi/ufs/ufs-mediatek.c
index 3b0e575d7460..73bd4c245f4a 100644
--- a/drivers/scsi/ufs/ufs-mediatek.c
+++ b/drivers/scsi/ufs/ufs-mediatek.c
@@ -100,17 +100,6 @@ static int ufs_mtk_bind_mphy(struct ufs_hba *hba)
return err;
}
-static void ufs_mtk_udelay(unsigned long us)
-{
- if (!us)
- return;
-
- if (us < 10)
- udelay(us);
- else
- usleep_range(us, us + 10);
-}
-
static int ufs_mtk_setup_ref_clk(struct ufs_hba *hba, bool on)
{
struct ufs_mtk_host *host = ufshcd_get_variant(hba);
@@ -123,7 +112,7 @@ static int ufs_mtk_setup_ref_clk(struct ufs_hba *hba, bool on)
if (on) {
ufs_mtk_ref_clk_notify(on, res);
- ufs_mtk_udelay(host->ref_clk_ungating_wait_us);
+ ufshcd_delay_us(host->ref_clk_ungating_wait_us, 10);
ufshcd_writel(hba, REFCLK_REQUEST, REG_UFS_REFCLK_CTRL);
} else {
ufshcd_writel(hba, REFCLK_RELEASE, REG_UFS_REFCLK_CTRL);
@@ -150,7 +139,7 @@ static int ufs_mtk_setup_ref_clk(struct ufs_hba *hba, bool on)
out:
host->ref_clk_enabled = on;
if (!on) {
- ufs_mtk_udelay(host->ref_clk_gating_wait_us);
+ ufshcd_delay_us(host->ref_clk_gating_wait_us, 10);
ufs_mtk_ref_clk_notify(on, res);
}
--
2.18.0
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
WARNING: multiple messages have this Message-ID (diff)
From: Stanley Chu <stanley.chu@mediatek.com>
To: <linux-scsi@vger.kernel.org>, <martin.peter~sen@oracle.com>,
<avri.altman@wdc.com>, <alim.akhtar@samsung.com>,
<jejb@linux.ibm.com>, <bvanassche@acm.org>
Cc: Stanley Chu <stanley.chu@mediatek.com>,
andy.teng@mediatek.com, chun-hung.wu@mediatek.com,
kuohong.wang@mediatek.com, linux-kernel@vger.kernel.org,
cang@codeaurora.org, linux-mediatek@lists.infradead.org,
peter.wang@mediatek.com, matthias.bgg@gmail.com,
beanhuo@micron.com, linux-arm-kernel@lists.infradead.org,
asutoshd@codeaurora.org
Subject: [PATCH v7 4/7] scsi: ufs-mediatek: use common delay function for required places
Date: Wed, 18 Mar 2020 18:40:13 +0800 [thread overview]
Message-ID: <20200318104016.28049-5-stanley.chu@mediatek.com> (raw)
In-Reply-To: <20200318104016.28049-1-stanley.chu@mediatek.com>
A common delay function is introduced in UFS core driver, thus
ufs-mediatek can use it instead of the private delay function for
required places.
Signed-off-by: Stanley Chu <stanley.chu@mediatek.com>
Reviewed-by: Avri Altman <avri.altman@wdc.com>
---
drivers/scsi/ufs/ufs-mediatek.c | 15 ++-------------
1 file changed, 2 insertions(+), 13 deletions(-)
diff --git a/drivers/scsi/ufs/ufs-mediatek.c b/drivers/scsi/ufs/ufs-mediatek.c
index 3b0e575d7460..73bd4c245f4a 100644
--- a/drivers/scsi/ufs/ufs-mediatek.c
+++ b/drivers/scsi/ufs/ufs-mediatek.c
@@ -100,17 +100,6 @@ static int ufs_mtk_bind_mphy(struct ufs_hba *hba)
return err;
}
-static void ufs_mtk_udelay(unsigned long us)
-{
- if (!us)
- return;
-
- if (us < 10)
- udelay(us);
- else
- usleep_range(us, us + 10);
-}
-
static int ufs_mtk_setup_ref_clk(struct ufs_hba *hba, bool on)
{
struct ufs_mtk_host *host = ufshcd_get_variant(hba);
@@ -123,7 +112,7 @@ static int ufs_mtk_setup_ref_clk(struct ufs_hba *hba, bool on)
if (on) {
ufs_mtk_ref_clk_notify(on, res);
- ufs_mtk_udelay(host->ref_clk_ungating_wait_us);
+ ufshcd_delay_us(host->ref_clk_ungating_wait_us, 10);
ufshcd_writel(hba, REFCLK_REQUEST, REG_UFS_REFCLK_CTRL);
} else {
ufshcd_writel(hba, REFCLK_RELEASE, REG_UFS_REFCLK_CTRL);
@@ -150,7 +139,7 @@ static int ufs_mtk_setup_ref_clk(struct ufs_hba *hba, bool on)
out:
host->ref_clk_enabled = on;
if (!on) {
- ufs_mtk_udelay(host->ref_clk_gating_wait_us);
+ ufshcd_delay_us(host->ref_clk_gating_wait_us, 10);
ufs_mtk_ref_clk_notify(on, res);
}
--
2.18.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-03-18 10:40 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-18 10:40 [PATCH v7 0/7] scsi: ufs: some cleanups and make the delay for host enabling customizable Stanley Chu
2020-03-18 10:40 ` Stanley Chu
2020-03-18 10:40 ` Stanley Chu
2020-03-18 10:40 ` [PATCH v7 1/7] scsi: ufs: fix uninitialized tx_lanes in ufshcd_disable_tx_lcc() Stanley Chu
2020-03-18 10:40 ` Stanley Chu
2020-03-18 10:40 ` Stanley Chu
2020-03-18 10:40 ` [PATCH v7 2/7] scsi: ufs: use an enum for host capabilities Stanley Chu
2020-03-18 10:40 ` Stanley Chu
2020-03-18 10:40 ` Stanley Chu
2020-03-18 22:42 ` [EXT] " Bean Huo (beanhuo)
2020-03-18 22:42 ` Bean Huo (beanhuo)
2020-03-18 22:42 ` Bean Huo (beanhuo)
2020-03-18 10:40 ` [PATCH v7 3/7] scsi: ufs: introduce common and flexible delay function Stanley Chu
2020-03-18 10:40 ` Stanley Chu
2020-03-18 10:40 ` Stanley Chu
2020-03-18 22:10 ` [EXT] " Bean Huo (beanhuo)
2020-03-18 22:10 ` Bean Huo (beanhuo)
2020-03-18 22:10 ` Bean Huo (beanhuo)
2020-03-19 0:10 ` Stanley Chu
2020-03-19 0:10 ` Stanley Chu
2020-03-19 0:10 ` Stanley Chu
2020-03-18 10:40 ` Stanley Chu [this message]
2020-03-18 10:40 ` [PATCH v7 4/7] scsi: ufs-mediatek: use common delay function for required places Stanley Chu
2020-03-18 10:40 ` Stanley Chu
2020-03-18 10:40 ` [PATCH v7 5/7] scsi: ufs: allow customized delay for host enabling Stanley Chu
2020-03-18 10:40 ` Stanley Chu
2020-03-18 10:40 ` Stanley Chu
2020-03-18 10:40 ` [PATCH v7 6/7] scsi: ufs: make HCE polling more compact to improve initialization latency Stanley Chu
2020-03-18 10:40 ` Stanley Chu
2020-03-18 10:40 ` Stanley Chu
2020-03-18 10:40 ` [PATCH v7 7/7] scsi: ufs-mediatek: customize the delay for host enabling Stanley Chu
2020-03-18 10:40 ` Stanley Chu
2020-03-18 10:40 ` Stanley Chu
2020-03-27 2:09 ` [PATCH v7 0/7] scsi: ufs: some cleanups and make the delay for host enabling customizable Martin K. Petersen
2020-03-27 2:09 ` Martin K. Petersen
2020-03-27 2:09 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200318104016.28049-5-stanley.chu@mediatek.com \
--to=stanley.chu@mediatek.com \
--cc=alim.akhtar@samsung.com \
--cc=andy.teng@mediatek.com \
--cc=asutoshd@codeaurora.org \
--cc=avri.altman@wdc.com \
--cc=beanhuo@micron.com \
--cc=bvanassche@acm.org \
--cc=cang@codeaurora.org \
--cc=chun-hung.wu@mediatek.com \
--cc=jejb@linux.ibm.com \
--cc=kuohong.wang@mediatek.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.peter~sen@oracle.com \
--cc=matthias.bgg@gmail.com \
--cc=peter.wang@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.