All of lore.kernel.org
 help / color / mirror / Atom feed
From: kbuild test robot <lkp@intel.com>
To: Nishant Malpani <nish.malpani25@gmail.com>
Cc: kbuild-all@lists.01.org, jic23@kernel.org,
	andriy.shevchenko@linux.intel.com, joe@perches.com,
	knaack.h@gmx.de, lars@metafoo.de, pmeerw@pmeerw.net,
	nish.malpani25@gmail.com, linux-iio@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 01/13] iio: accel: kxsd9: Use suitable format specifier
Date: Sun, 22 Mar 2020 11:27:57 +0800	[thread overview]
Message-ID: <202003221112.426bmWm5%lkp@intel.com> (raw)
In-Reply-To: <20200321210204.18106-2-nish.malpani25@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 7003 bytes --]

Hi Nishant,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on v5.6-rc6]
[also build test ERROR on next-20200320]
[cannot apply to iio/togreg]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url:    https://github.com/0day-ci/linux/commits/Nishant-Malpani/iio-Use-suitable-format-specifiers/20200322-050532
base:    fb33c6510d5595144d585aa194d377cf74d31911
config: powerpc-randconfig-a001-20200322 (attached as .config)
compiler: powerpc64-linux-gcc (GCC) 9.2.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        GCC_VERSION=9.2.0 make.cross ARCH=powerpc 

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>

All error/warnings (new ones prefixed by >>):

   drivers/iio/accel/kxsd9-i2c.c: In function 'kxsd9_i2c_probe':
>> drivers/iio/accel/kxsd9-i2c.c:68: error: unterminated argument list invoking macro "dev_err"
      68 | MODULE_DESCRIPTION("KXSD9 accelerometer I2C interface");
         | 
>> drivers/iio/accel/kxsd9-i2c.c:24:3: error: 'dev_err' undeclared (first use in this function); did you mean '_dev_err'?
      24 |   dev_err(&i2c->dev, "Failed to register i2c regmap %pe\n",
         |   ^~~~~~~
         |   _dev_err
   drivers/iio/accel/kxsd9-i2c.c:24:3: note: each undeclared identifier is reported only once for each function it appears in
>> drivers/iio/accel/kxsd9-i2c.c:24:10: error: expected ';' at end of input
      24 |   dev_err(&i2c->dev, "Failed to register i2c regmap %pe\n",
         |          ^
         |          ;
   ......
      68 | MODULE_DESCRIPTION("KXSD9 accelerometer I2C interface");
         |           
>> drivers/iio/accel/kxsd9-i2c.c:24:3: error: expected declaration or statement at end of input
      24 |   dev_err(&i2c->dev, "Failed to register i2c regmap %pe\n",
         |   ^~~~~~~
>> drivers/iio/accel/kxsd9-i2c.c:24:3: error: expected declaration or statement at end of input
>> drivers/iio/accel/kxsd9-i2c.c:24:3: warning: no return statement in function returning non-void [-Wreturn-type]
   At top level:
   drivers/iio/accel/kxsd9-i2c.c:12:12: warning: 'kxsd9_i2c_probe' defined but not used [-Wunused-function]
      12 | static int kxsd9_i2c_probe(struct i2c_client *i2c,
         |            ^~~~~~~~~~~~~~~

vim +/dev_err +68 drivers/iio/accel/kxsd9-i2c.c

a483ab796960c9 Linus Walleij   2016-09-01  11  
a483ab796960c9 Linus Walleij   2016-09-01  12  static int kxsd9_i2c_probe(struct i2c_client *i2c,
a483ab796960c9 Linus Walleij   2016-09-01  13  			   const struct i2c_device_id *id)
a483ab796960c9 Linus Walleij   2016-09-01  14  {
a483ab796960c9 Linus Walleij   2016-09-01  15  	static const struct regmap_config config = {
a483ab796960c9 Linus Walleij   2016-09-01  16  		.reg_bits = 8,
a483ab796960c9 Linus Walleij   2016-09-01  17  		.val_bits = 8,
a483ab796960c9 Linus Walleij   2016-09-01  18  		.max_register = 0x0e,
a483ab796960c9 Linus Walleij   2016-09-01  19  	};
a483ab796960c9 Linus Walleij   2016-09-01  20  	struct regmap *regmap;
a483ab796960c9 Linus Walleij   2016-09-01  21  
a483ab796960c9 Linus Walleij   2016-09-01  22  	regmap = devm_regmap_init_i2c(i2c, &config);
a483ab796960c9 Linus Walleij   2016-09-01  23  	if (IS_ERR(regmap)) {
ee70c8726e6050 Nishant Malpani 2020-03-22 @24  		dev_err(&i2c->dev, "Failed to register i2c regmap %pe\n",
ee70c8726e6050 Nishant Malpani 2020-03-22  25  			regmap;
a483ab796960c9 Linus Walleij   2016-09-01  26  		return PTR_ERR(regmap);
a483ab796960c9 Linus Walleij   2016-09-01  27  	}
a483ab796960c9 Linus Walleij   2016-09-01  28  
a483ab796960c9 Linus Walleij   2016-09-01  29  	return kxsd9_common_probe(&i2c->dev,
a483ab796960c9 Linus Walleij   2016-09-01  30  				  regmap,
a483ab796960c9 Linus Walleij   2016-09-01  31  				  i2c->name);
a483ab796960c9 Linus Walleij   2016-09-01  32  }
a483ab796960c9 Linus Walleij   2016-09-01  33  
a483ab796960c9 Linus Walleij   2016-09-01  34  static int kxsd9_i2c_remove(struct i2c_client *client)
a483ab796960c9 Linus Walleij   2016-09-01  35  {
a483ab796960c9 Linus Walleij   2016-09-01  36  	return kxsd9_common_remove(&client->dev);
a483ab796960c9 Linus Walleij   2016-09-01  37  }
a483ab796960c9 Linus Walleij   2016-09-01  38  
a483ab796960c9 Linus Walleij   2016-09-01  39  #ifdef CONFIG_OF
a483ab796960c9 Linus Walleij   2016-09-01  40  static const struct of_device_id kxsd9_of_match[] = {
a483ab796960c9 Linus Walleij   2016-09-01  41  	{ .compatible = "kionix,kxsd9", },
a483ab796960c9 Linus Walleij   2016-09-01  42  	{ },
a483ab796960c9 Linus Walleij   2016-09-01  43  };
a483ab796960c9 Linus Walleij   2016-09-01  44  MODULE_DEVICE_TABLE(of, kxsd9_of_match);
a483ab796960c9 Linus Walleij   2016-09-01  45  #else
a483ab796960c9 Linus Walleij   2016-09-01  46  #define kxsd9_of_match NULL
a483ab796960c9 Linus Walleij   2016-09-01  47  #endif
a483ab796960c9 Linus Walleij   2016-09-01  48  
a483ab796960c9 Linus Walleij   2016-09-01  49  static const struct i2c_device_id kxsd9_i2c_id[] = {
a483ab796960c9 Linus Walleij   2016-09-01  50  	{"kxsd9", 0},
a483ab796960c9 Linus Walleij   2016-09-01  51  	{ },
a483ab796960c9 Linus Walleij   2016-09-01  52  };
a483ab796960c9 Linus Walleij   2016-09-01  53  MODULE_DEVICE_TABLE(i2c, kxsd9_i2c_id);
a483ab796960c9 Linus Walleij   2016-09-01  54  
a483ab796960c9 Linus Walleij   2016-09-01  55  static struct i2c_driver kxsd9_i2c_driver = {
a483ab796960c9 Linus Walleij   2016-09-01  56  	.driver = {
a483ab796960c9 Linus Walleij   2016-09-01  57  		.name	= "kxsd9",
a483ab796960c9 Linus Walleij   2016-09-01  58  		.of_match_table = of_match_ptr(kxsd9_of_match),
9a9a369d6178dd Linus Walleij   2016-09-01  59  		.pm = &kxsd9_dev_pm_ops,
a483ab796960c9 Linus Walleij   2016-09-01  60  	},
a483ab796960c9 Linus Walleij   2016-09-01  61  	.probe		= kxsd9_i2c_probe,
a483ab796960c9 Linus Walleij   2016-09-01  62  	.remove		= kxsd9_i2c_remove,
a483ab796960c9 Linus Walleij   2016-09-01  63  	.id_table	= kxsd9_i2c_id,
a483ab796960c9 Linus Walleij   2016-09-01  64  };
a483ab796960c9 Linus Walleij   2016-09-01  65  module_i2c_driver(kxsd9_i2c_driver);
9a0ebbc93547d8 Linus Walleij   2017-11-13  66  
9a0ebbc93547d8 Linus Walleij   2017-11-13  67  MODULE_LICENSE("GPL v2");
9a0ebbc93547d8 Linus Walleij   2017-11-13 @68  MODULE_DESCRIPTION("KXSD9 accelerometer I2C interface");

:::::: The code at line 68 was first introduced by commit
:::::: 9a0ebbc93547d88f422905c34dcceebe928f3e9e iio: adc/accel: Fix up module licenses

:::::: TO: Linus Walleij <linus.walleij@linaro.org>
:::::: CC: Jonathan Cameron <Jonathan.Cameron@huawei.com>

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 28125 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: kbuild test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: Re: [PATCH 01/13] iio: accel: kxsd9: Use suitable format specifier
Date: Sun, 22 Mar 2020 11:27:57 +0800	[thread overview]
Message-ID: <202003221112.426bmWm5%lkp@intel.com> (raw)
In-Reply-To: <20200321210204.18106-2-nish.malpani25@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 7127 bytes --]

Hi Nishant,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on v5.6-rc6]
[also build test ERROR on next-20200320]
[cannot apply to iio/togreg]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url:    https://github.com/0day-ci/linux/commits/Nishant-Malpani/iio-Use-suitable-format-specifiers/20200322-050532
base:    fb33c6510d5595144d585aa194d377cf74d31911
config: powerpc-randconfig-a001-20200322 (attached as .config)
compiler: powerpc64-linux-gcc (GCC) 9.2.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        GCC_VERSION=9.2.0 make.cross ARCH=powerpc 

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>

All error/warnings (new ones prefixed by >>):

   drivers/iio/accel/kxsd9-i2c.c: In function 'kxsd9_i2c_probe':
>> drivers/iio/accel/kxsd9-i2c.c:68: error: unterminated argument list invoking macro "dev_err"
      68 | MODULE_DESCRIPTION("KXSD9 accelerometer I2C interface");
         | 
>> drivers/iio/accel/kxsd9-i2c.c:24:3: error: 'dev_err' undeclared (first use in this function); did you mean '_dev_err'?
      24 |   dev_err(&i2c->dev, "Failed to register i2c regmap %pe\n",
         |   ^~~~~~~
         |   _dev_err
   drivers/iio/accel/kxsd9-i2c.c:24:3: note: each undeclared identifier is reported only once for each function it appears in
>> drivers/iio/accel/kxsd9-i2c.c:24:10: error: expected ';' at end of input
      24 |   dev_err(&i2c->dev, "Failed to register i2c regmap %pe\n",
         |          ^
         |          ;
   ......
      68 | MODULE_DESCRIPTION("KXSD9 accelerometer I2C interface");
         |           
>> drivers/iio/accel/kxsd9-i2c.c:24:3: error: expected declaration or statement at end of input
      24 |   dev_err(&i2c->dev, "Failed to register i2c regmap %pe\n",
         |   ^~~~~~~
>> drivers/iio/accel/kxsd9-i2c.c:24:3: error: expected declaration or statement at end of input
>> drivers/iio/accel/kxsd9-i2c.c:24:3: warning: no return statement in function returning non-void [-Wreturn-type]
   At top level:
   drivers/iio/accel/kxsd9-i2c.c:12:12: warning: 'kxsd9_i2c_probe' defined but not used [-Wunused-function]
      12 | static int kxsd9_i2c_probe(struct i2c_client *i2c,
         |            ^~~~~~~~~~~~~~~

vim +/dev_err +68 drivers/iio/accel/kxsd9-i2c.c

a483ab796960c9 Linus Walleij   2016-09-01  11  
a483ab796960c9 Linus Walleij   2016-09-01  12  static int kxsd9_i2c_probe(struct i2c_client *i2c,
a483ab796960c9 Linus Walleij   2016-09-01  13  			   const struct i2c_device_id *id)
a483ab796960c9 Linus Walleij   2016-09-01  14  {
a483ab796960c9 Linus Walleij   2016-09-01  15  	static const struct regmap_config config = {
a483ab796960c9 Linus Walleij   2016-09-01  16  		.reg_bits = 8,
a483ab796960c9 Linus Walleij   2016-09-01  17  		.val_bits = 8,
a483ab796960c9 Linus Walleij   2016-09-01  18  		.max_register = 0x0e,
a483ab796960c9 Linus Walleij   2016-09-01  19  	};
a483ab796960c9 Linus Walleij   2016-09-01  20  	struct regmap *regmap;
a483ab796960c9 Linus Walleij   2016-09-01  21  
a483ab796960c9 Linus Walleij   2016-09-01  22  	regmap = devm_regmap_init_i2c(i2c, &config);
a483ab796960c9 Linus Walleij   2016-09-01  23  	if (IS_ERR(regmap)) {
ee70c8726e6050 Nishant Malpani 2020-03-22 @24  		dev_err(&i2c->dev, "Failed to register i2c regmap %pe\n",
ee70c8726e6050 Nishant Malpani 2020-03-22  25  			regmap;
a483ab796960c9 Linus Walleij   2016-09-01  26  		return PTR_ERR(regmap);
a483ab796960c9 Linus Walleij   2016-09-01  27  	}
a483ab796960c9 Linus Walleij   2016-09-01  28  
a483ab796960c9 Linus Walleij   2016-09-01  29  	return kxsd9_common_probe(&i2c->dev,
a483ab796960c9 Linus Walleij   2016-09-01  30  				  regmap,
a483ab796960c9 Linus Walleij   2016-09-01  31  				  i2c->name);
a483ab796960c9 Linus Walleij   2016-09-01  32  }
a483ab796960c9 Linus Walleij   2016-09-01  33  
a483ab796960c9 Linus Walleij   2016-09-01  34  static int kxsd9_i2c_remove(struct i2c_client *client)
a483ab796960c9 Linus Walleij   2016-09-01  35  {
a483ab796960c9 Linus Walleij   2016-09-01  36  	return kxsd9_common_remove(&client->dev);
a483ab796960c9 Linus Walleij   2016-09-01  37  }
a483ab796960c9 Linus Walleij   2016-09-01  38  
a483ab796960c9 Linus Walleij   2016-09-01  39  #ifdef CONFIG_OF
a483ab796960c9 Linus Walleij   2016-09-01  40  static const struct of_device_id kxsd9_of_match[] = {
a483ab796960c9 Linus Walleij   2016-09-01  41  	{ .compatible = "kionix,kxsd9", },
a483ab796960c9 Linus Walleij   2016-09-01  42  	{ },
a483ab796960c9 Linus Walleij   2016-09-01  43  };
a483ab796960c9 Linus Walleij   2016-09-01  44  MODULE_DEVICE_TABLE(of, kxsd9_of_match);
a483ab796960c9 Linus Walleij   2016-09-01  45  #else
a483ab796960c9 Linus Walleij   2016-09-01  46  #define kxsd9_of_match NULL
a483ab796960c9 Linus Walleij   2016-09-01  47  #endif
a483ab796960c9 Linus Walleij   2016-09-01  48  
a483ab796960c9 Linus Walleij   2016-09-01  49  static const struct i2c_device_id kxsd9_i2c_id[] = {
a483ab796960c9 Linus Walleij   2016-09-01  50  	{"kxsd9", 0},
a483ab796960c9 Linus Walleij   2016-09-01  51  	{ },
a483ab796960c9 Linus Walleij   2016-09-01  52  };
a483ab796960c9 Linus Walleij   2016-09-01  53  MODULE_DEVICE_TABLE(i2c, kxsd9_i2c_id);
a483ab796960c9 Linus Walleij   2016-09-01  54  
a483ab796960c9 Linus Walleij   2016-09-01  55  static struct i2c_driver kxsd9_i2c_driver = {
a483ab796960c9 Linus Walleij   2016-09-01  56  	.driver = {
a483ab796960c9 Linus Walleij   2016-09-01  57  		.name	= "kxsd9",
a483ab796960c9 Linus Walleij   2016-09-01  58  		.of_match_table = of_match_ptr(kxsd9_of_match),
9a9a369d6178dd Linus Walleij   2016-09-01  59  		.pm = &kxsd9_dev_pm_ops,
a483ab796960c9 Linus Walleij   2016-09-01  60  	},
a483ab796960c9 Linus Walleij   2016-09-01  61  	.probe		= kxsd9_i2c_probe,
a483ab796960c9 Linus Walleij   2016-09-01  62  	.remove		= kxsd9_i2c_remove,
a483ab796960c9 Linus Walleij   2016-09-01  63  	.id_table	= kxsd9_i2c_id,
a483ab796960c9 Linus Walleij   2016-09-01  64  };
a483ab796960c9 Linus Walleij   2016-09-01  65  module_i2c_driver(kxsd9_i2c_driver);
9a0ebbc93547d8 Linus Walleij   2017-11-13  66  
9a0ebbc93547d8 Linus Walleij   2017-11-13  67  MODULE_LICENSE("GPL v2");
9a0ebbc93547d8 Linus Walleij   2017-11-13 @68  MODULE_DESCRIPTION("KXSD9 accelerometer I2C interface");

:::::: The code at line 68 was first introduced by commit
:::::: 9a0ebbc93547d88f422905c34dcceebe928f3e9e iio: adc/accel: Fix up module licenses

:::::: TO: Linus Walleij <linus.walleij@linaro.org>
:::::: CC: Jonathan Cameron <Jonathan.Cameron@huawei.com>

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 28125 bytes --]

  parent reply	other threads:[~2020-03-22  3:28 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-21 21:01 [PATCH 00/13] iio: Use suitable format specifiers Nishant Malpani
2020-03-21 21:01 ` [PATCH 01/13] iio: accel: kxsd9: Use suitable format specifier Nishant Malpani
2020-03-21 21:09   ` Joe Perches
2020-03-21 21:23     ` Nishant Malpani
2020-03-22  0:36   ` kbuild test robot
2020-03-22  0:36     ` kbuild test robot
2020-03-22  3:27   ` kbuild test robot [this message]
2020-03-22  3:27     ` kbuild test robot
2020-03-22 15:13   ` Jonathan Cameron
2020-03-21 21:01 ` [PATCH 02/13] iio: gyro: bmg160_i2c: " Nishant Malpani
2020-03-21 21:01 ` [PATCH 03/13] iio: gyro: bmg160_spi: " Nishant Malpani
2020-03-21 21:01 ` [PATCH 04/13] iio: gyro: mpu3050: " Nishant Malpani
2020-03-21 21:01 ` [PATCH 05/13] iio: imu: bmi160_i2c: " Nishant Malpani
2020-03-21 21:01 ` [PATCH 06/13] iio: imu: bmi160_spi: " Nishant Malpani
2020-03-21 21:01 ` [PATCH 07/13] iio: imu: inv_mpu6050_i2c: " Nishant Malpani
2020-03-21 21:01 ` [PATCH 08/13] iio: imu: inv_mpu6050_spi: " Nishant Malpani
2020-03-21 21:02 ` [PATCH 09/13] iio: magn: bmc150: " Nishant Malpani
2020-03-21 21:02 ` [PATCH 10/13] iio: light: st_uvis25_i2c: " Nishant Malpani
2020-03-21 21:02 ` [PATCH 11/13] iio: light: st_uvis25_spi: " Nishant Malpani
2020-03-21 21:02 ` [PATCH 12/13] iio: st_sensors_i2c: " Nishant Malpani
2020-03-21 21:02 ` [PATCH 13/13] iio: st_sensors_spi: " Nishant Malpani

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202003221112.426bmWm5%lkp@intel.com \
    --to=lkp@intel.com \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=jic23@kernel.org \
    --cc=joe@perches.com \
    --cc=kbuild-all@lists.01.org \
    --cc=knaack.h@gmx.de \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nish.malpani25@gmail.com \
    --cc=pmeerw@pmeerw.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.